GNU bug report logs - #9566
sql-mode: sql-comint-postgres can't decide if sql-port is an integer or port

Previous Next

Package: emacs;

Reported by: Andrew Schein <andrew <at> andrewschein.com>

Date: Wed, 21 Sep 2011 01:10:02 UTC

Severity: normal

Fixed in version 24.1

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9566 in the body.
You can then email your comments to 9566 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#9566; Package emacs. (Wed, 21 Sep 2011 01:10:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Andrew Schein <andrew <at> andrewschein.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 21 Sep 2011 01:10:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Schein <andrew <at> andrewschein.com>
To: bug-gnu-emacs <at> gnu.org
Subject: sql-mode: sql-comint-postgres can't decide if sql-port is an integer
	or port
Date: Tue, 20 Sep 2011 18:08:51 -0700

sql-port is initialized as an integer in sql.el, but later treated as
a string when building up the params variable within the function
sql-comint-postgres.  Below is my small patch that fixes this.

Cheers,

Andy

=== modified file 'lisp/progmodes/sql.el'
*** lisp/progmodes/sql.el       2011-07-06 03:51:48 +0000
--- lisp/progmodes/sql.el       2011-09-21 00:56:35 +0000
*************** Try to set `comint-output-filter-functio
*** 4719,4731 ****
    ;; sql-postgres-options.
    (let ((params options))
      (if (not (string= "" sql-database))
!       (setq params (append params (list sql-database))))
      (if (not (string= "" sql-server))
!       (setq params (append (list "-h" sql-server) params)))
      (if (not (string= "" sql-user))
!       (setq params (append (list "-U" sql-user) params)))
      (if (not (= 0 sql-port))
!       (setq params (append (list "-p" sql-port) params)))
      (sql-comint product params)))

  (defun sql-postgres-completion-object (sqlbuf schema)
--- 4719,4731 ----
    ;; sql-postgres-options.
    (let ((params options))
      (if (not (string= "" sql-database))
!     (setq params (append params (list sql-database))))
      (if (not (string= "" sql-server))
!     (setq params (append (list "-h" sql-server) params)))
      (if (not (string= "" sql-user))
!     (setq params (append (list "-U" sql-user) params)))
      (if (not (= 0 sql-port))
!     (setq params (append (list "-p" (number-to-string sql-port)) params)))
      (sql-comint product params)))

  (defun sql-postgres-completion-object (sqlbuf schema)



--
Andrew I. Schein
www.andrewschein.com
Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Thu, 22 Sep 2011 07:08:03 GMT) Full text and rfc822 format available.
Notification sent to Andrew Schein <andrew <at> andrewschein.com>:
bug acknowledged by developer. (Thu, 22 Sep 2011 07:08:03 GMT) Full text and rfc822 format available.

Message #10 received at 9566-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 9566-done <at> debbugs.gnu.org
Subject: Re: bug#9566: sql-mode: sql-comint-postgres can't decide if sql-port
	is an integer or port
Date: Thu, 22 Sep 2011 03:06:43 -0400

Version: 24.1

Thank you; applied. (FYI, your patch had extraneous whitespace changes.)
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 20 Oct 2011 11:24:07 GMT) Full text and rfc822 format available.
This bug report was last modified 13 years and 302 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.