Subject: bug#956 closed by Chong Yidong <[email-masked]> (Re: In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.)

From: [email-masked] (Emacs bug Tracking System)

This is an automatic notification regarding your bug report
which was filed against the emacs package:

#956: In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.

It has been closed by Chong Yidong <[email-masked]>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Chong Yidong <[email-masked]> by
replying to this email.

-- 
956: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=956
Emacs Bug Tracking System
Contact [email-masked] with problems
>From [email-masked] Wed Sep 10 15:17:29 2008
From: Chong Yidong <[email-masked]>
To: Francis Litterio <[email-masked]>
Cc: [email-masked]
Subject: Re: In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.
Date: Wed, 10 Sep 2008 18:20:31 -0400

> In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.

Thanks for spotting this.  I've checked in a fix.

>From [email-masked] Wed Sep 10 09:08:24 2008
From: Francis Litterio <[email-masked]>
To: [email-masked]
Subject: In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.
Date: Wed, 10 Sep 2008 11:44:32 -0400

In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.  To
reproduce, evaluate this form:

   (let ((inhibit-read-only t))
     (with-current-buffer (get-buffer-create "zzz")
       (insert "fooxxxbar")
       (replace-regexp "x+" "z" nil (point-min) (point-max))))

You will see this error: Buffer is read-only: #<buffer zzz>

This may be caused by this code in function perform-replace (in
lisp/replace.el):

   (let ((inhibit-read-only
          query-replace-skip-read-only))

The docstring for query-replace-skip-read-only says:

   *Non-nil means `query-replace' and friends ignore read-only matches.

which does not seem to match how it is used in that let form, especially
since replace-regexp is not interactive like query-replace.
--
Fran