From unknown Tue Aug 19 02:52:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9548: 24.0.50; Add vc-git-stash to keymap Resent-From: Jambunathan K Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Sep 2011 21:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 9548 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 9548@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.131638294826892 (code B ref -1); Sun, 18 Sep 2011 21:56:01 +0000 Received: (at submit) by debbugs.gnu.org; 18 Sep 2011 21:55:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R5PL1-0006zh-Po for submit@debbugs.gnu.org; Sun, 18 Sep 2011 17:55:48 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R5PKz-0006za-EJ for submit@debbugs.gnu.org; Sun, 18 Sep 2011 17:55:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5PGB-0004Sr-0y for submit@debbugs.gnu.org; Sun, 18 Sep 2011 17:50:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:55475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5PGA-0004Sn-Vd for submit@debbugs.gnu.org; Sun, 18 Sep 2011 17:50:46 -0400 Received: from eggs.gnu.org ([140.186.70.92]:49666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5PGA-00068c-2Q for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2011 17:50:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5PG8-0004SS-TM for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2011 17:50:46 -0400 Received: from mail-iy0-f169.google.com ([209.85.210.169]:39571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5PG8-0004SO-Op for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2011 17:50:44 -0400 Received: by iaen33 with SMTP id n33so6460681iae.0 for ; Sun, 18 Sep 2011 14:50:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:mime-version:content-type; bh=Ryv282GPHLL+6gx4ACxYmaDoMMdQRoo8WXvs3RG+w9Y=; b=WuZ/VWTu+499PAbf8Yy0KPgTu+eAV5UcLKOkX9G9zmZb2RWSJFmVFRGaFkUFuxujPv sfTE0kEC8TGdCG7ax8elqaQfukuOKajnP3miWYYJ4m6cuo4F0Yk8AcCx+K1wcLB8agJX xQ1NWsaNgE7n1wwWRX8LGKtIAte9/oAciafCA= Received: by 10.68.24.168 with SMTP id v8mr3214184pbf.23.1316382643969; Sun, 18 Sep 2011 14:50:43 -0700 (PDT) Received: from JAMBU-NETBOOK ([115.241.103.207]) by mx.google.com with ESMTPS id e3sm60102845pbi.7.2011.09.18.14.50.39 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 18 Sep 2011 14:50:43 -0700 (PDT) From: Jambunathan K Date: Mon, 19 Sep 2011 03:20:25 +0530 Message-ID: <81y5xlv7tq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) Please add vc-git-stash to keymap[1]. I suggest the following binding S => vc-git-stash C-u S => vc-git-stash-snapshot 1. I am not sure why the stash command keys are capitalized. Pressing SHIFT seems a needless overhead to me. IMHO, they should all be lowercased. 2. I need a way to create a stash or a snapshot when there are ZERO snapshots. This is currently not possible. May be the "Stash : " header line[2] could be decorated with the needed keymap decorations. My 2 cents follows: Speaking of keymaps, the stash operations seem to be orthogonal to regular vc-dir operations. Elsewhere there were discussions about applying a series of stashes to work area - implying some a potential need for marking and reordering stash lines. What this essentially means is that stash operations are "global"/"set" operations in a *vc-dir* and accordingly they deserve a prefix of their own (in addition to the current "local, this-stash-only" keymap bindings.) In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2011-09-06 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.5) --no-opt' Footnotes: [1] ,----[ C-h v vc-git-stash-map RET ] | vc-git-stash-map is a variable defined in `vc-git.el'. | Its value is shown below. | | This variable is potentially risky when used as a file local variable. | | Documentation: | Not documented as a variable. | | Value: (keymap | (83 . vc-git-stash-snapshot) | (80 . vc-git-stash-pop-at-point) | (65 . vc-git-stash-apply-at-point) | (13 . vc-git-stash-show-at-point) | (61 . vc-git-stash-show-at-point) | (11 . vc-git-stash-delete-at-point) | (down-mouse-3 . vc-git-stash-menu) | (mouse-2 . ignore)) | | [back] `---- [2] #+begin_src emacs-lisp [around line 540 vc-git.el] (propertize "Stash :\n" 'face 'font-lock-type-face 'help-echo stash-help-echo) #+end_src #+begin_src emacs-lisp [around line 550 vc-git.el] (concat (propertize "Stash : " 'face 'font-lock-type-face 'help-echo stash-help-echo) (propertize "Nothing stashed" 'help-echo stash-help-echo 'face 'font-lock-variable-name-face)) #+end_src From unknown Tue Aug 19 02:52:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jambunathan K Subject: bug#9548: closed (Re: bug#9548: 24.0.50; Add vc-git-stash to keymap) Message-ID: References: <87ob5ms319.fsf@gmail.com> <81y5xlv7tq.fsf@gmail.com> X-Gnu-PR-Message: they-closed 9548 X-Gnu-PR-Package: emacs Reply-To: 9548@debbugs.gnu.org Date: Fri, 15 Nov 2013 04:28:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1384489683-2678-1" This is a multi-part message in MIME format... ------------=_1384489683-2678-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #9548: 24.0.50; Add vc-git-stash to keymap which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 9548@debbugs.gnu.org. --=20 9548: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D9548 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1384489683-2678-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 9548-done) by debbugs.gnu.org; 15 Nov 2013 04:27:44 +0000 Received: from localhost ([127.0.0.1]:53175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhB0Q-0000gc-Jw for submit@debbugs.gnu.org; Thu, 14 Nov 2013 23:27:43 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:50292) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhB0O-0000gL-A4 for 9548-done@debbugs.gnu.org; Thu, 14 Nov 2013 23:27:40 -0500 Received: by mail-pa0-f43.google.com with SMTP id fa1so3090320pad.16 for <9548-done@debbugs.gnu.org>; Thu, 14 Nov 2013 20:27:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=34RliMuq46GYZpNAJ9q5wgb5qGmLaLD6QroaM995F1Y=; b=Iyrb7qgDuPIbgWRYlA+YHbLzzFVew4o2WF81s2+PJJPKPT/5HevNkDKKo5gd7JYhfY /Xuq4bl9glN6cDyuCnsvcGJ+OLpPZ6qKvXQkvWcIUZ33UECxUuQVn6n9OdgkWqRaOms0 hKsH968w0EjckZjguQ4QOmZQa8/j9+0OjCpQ3OaFC0K7YYGXE6Ts86xhcvzyppISZ5hH f/MZg+NnZfeAlXZEqnBudtiFDtXEp7UPwHFkCusVvYMDDBN67zCRJpJDIC8ohvgUCIc4 tnrzTGIFdH32g+nWeo83bgptN4nQza5jiFdRI1CAARjb/TZVvVrcSPX3EQw20jMuSVZP VyTw== X-Received: by 10.68.196.227 with SMTP id ip3mr4775342pbc.163.1384489654733; Thu, 14 Nov 2013 20:27:34 -0800 (PST) Received: from debian-6.05 ([115.241.27.214]) by mx.google.com with ESMTPSA id gh3sm1370551pbb.2.2013.11.14.20.27.32 for <9548-done@debbugs.gnu.org> (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Thu, 14 Nov 2013 20:27:34 -0800 (PST) From: Jambunathan K To: 9548-done@debbugs.gnu.org Subject: Re: bug#9548: 24.0.50; Add vc-git-stash to keymap References: <81y5xlv7tq.fsf@gmail.com> Date: Fri, 15 Nov 2013 09:57:14 +0530 In-Reply-To: <81y5xlv7tq.fsf@gmail.com> (Jambunathan K.'s message of "Mon, 19 Sep 2011 03:20:25 +0530") Message-ID: <87ob5ms319.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 9548-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) OP here. Closing it. ------------=_1384489683-2678-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 18 Sep 2011 21:55:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R5PL1-0006zh-Po for submit@debbugs.gnu.org; Sun, 18 Sep 2011 17:55:48 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R5PKz-0006za-EJ for submit@debbugs.gnu.org; Sun, 18 Sep 2011 17:55:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5PGB-0004Sr-0y for submit@debbugs.gnu.org; Sun, 18 Sep 2011 17:50:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:55475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5PGA-0004Sn-Vd for submit@debbugs.gnu.org; Sun, 18 Sep 2011 17:50:46 -0400 Received: from eggs.gnu.org ([140.186.70.92]:49666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5PGA-00068c-2Q for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2011 17:50:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5PG8-0004SS-TM for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2011 17:50:46 -0400 Received: from mail-iy0-f169.google.com ([209.85.210.169]:39571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5PG8-0004SO-Op for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2011 17:50:44 -0400 Received: by iaen33 with SMTP id n33so6460681iae.0 for ; Sun, 18 Sep 2011 14:50:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:mime-version:content-type; bh=Ryv282GPHLL+6gx4ACxYmaDoMMdQRoo8WXvs3RG+w9Y=; b=WuZ/VWTu+499PAbf8Yy0KPgTu+eAV5UcLKOkX9G9zmZb2RWSJFmVFRGaFkUFuxujPv sfTE0kEC8TGdCG7ax8elqaQfukuOKajnP3miWYYJ4m6cuo4F0Yk8AcCx+K1wcLB8agJX xQ1NWsaNgE7n1wwWRX8LGKtIAte9/oAciafCA= Received: by 10.68.24.168 with SMTP id v8mr3214184pbf.23.1316382643969; Sun, 18 Sep 2011 14:50:43 -0700 (PDT) Received: from JAMBU-NETBOOK ([115.241.103.207]) by mx.google.com with ESMTPS id e3sm60102845pbi.7.2011.09.18.14.50.39 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 18 Sep 2011 14:50:43 -0700 (PDT) From: Jambunathan K To: bug-gnu-emacs@gnu.org Subject: 24.0.50; Add vc-git-stash to keymap Date: Mon, 19 Sep 2011 03:20:25 +0530 Message-ID: <81y5xlv7tq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) Please add vc-git-stash to keymap[1]. I suggest the following binding S => vc-git-stash C-u S => vc-git-stash-snapshot 1. I am not sure why the stash command keys are capitalized. Pressing SHIFT seems a needless overhead to me. IMHO, they should all be lowercased. 2. I need a way to create a stash or a snapshot when there are ZERO snapshots. This is currently not possible. May be the "Stash : " header line[2] could be decorated with the needed keymap decorations. My 2 cents follows: Speaking of keymaps, the stash operations seem to be orthogonal to regular vc-dir operations. Elsewhere there were discussions about applying a series of stashes to work area - implying some a potential need for marking and reordering stash lines. What this essentially means is that stash operations are "global"/"set" operations in a *vc-dir* and accordingly they deserve a prefix of their own (in addition to the current "local, this-stash-only" keymap bindings.) In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2011-09-06 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.5) --no-opt' Footnotes: [1] ,----[ C-h v vc-git-stash-map RET ] | vc-git-stash-map is a variable defined in `vc-git.el'. | Its value is shown below. | | This variable is potentially risky when used as a file local variable. | | Documentation: | Not documented as a variable. | | Value: (keymap | (83 . vc-git-stash-snapshot) | (80 . vc-git-stash-pop-at-point) | (65 . vc-git-stash-apply-at-point) | (13 . vc-git-stash-show-at-point) | (61 . vc-git-stash-show-at-point) | (11 . vc-git-stash-delete-at-point) | (down-mouse-3 . vc-git-stash-menu) | (mouse-2 . ignore)) | | [back] `---- [2] #+begin_src emacs-lisp [around line 540 vc-git.el] (propertize "Stash :\n" 'face 'font-lock-type-face 'help-echo stash-help-echo) #+end_src #+begin_src emacs-lisp [around line 550 vc-git.el] (concat (propertize "Stash : " 'face 'font-lock-type-face 'help-echo stash-help-echo) (propertize "Nothing stashed" 'help-echo stash-help-echo 'face 'font-lock-variable-name-face)) #+end_src ------------=_1384489683-2678-1--