GNU bug report logs - #9548
24.0.50; Add vc-git-stash to keymap

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9548 in the body.
You can then email your comments to 9548 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jambunathan K <kjambunathan <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; Add vc-git-stash to keymap
Date: Mon, 19 Sep 2011 03:20:25 +0530

Please add vc-git-stash to keymap[1]. I suggest the following binding

S     => vc-git-stash
C-u S => vc-git-stash-snapshot

1. I am not sure why the stash command keys are capitalized. Pressing
   SHIFT seems a needless overhead to me. IMHO, they should all be
   lowercased.

2. I need a way to create a stash or a snapshot when there are ZERO
   snapshots. This is currently not possible. May be the "Stash : "
   header line[2] could be decorated with the needed keymap decorations.

   My 2 cents follows: Speaking of keymaps, the stash operations seem to
   be orthogonal to regular vc-dir operations. Elsewhere there were
   discussions about applying a series of stashes to work area -
   implying some a potential need for marking and reordering stash
   lines. What this essentially means is that stash operations are
   "global"/"set" operations in a *vc-dir* and accordingly they deserve
   a prefix of their own (in addition to the current "local,
   this-stash-only" keymap bindings.)

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2011-09-06 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt'

Footnotes: 
[1]  

,----[ C-h v vc-git-stash-map RET ]
| vc-git-stash-map is a variable defined in `vc-git.el'.
| Its value is shown below.
| 
|   This variable is potentially risky when used as a file local variable.
| 
| Documentation:
| Not documented as a variable.
| 
| Value: (keymap
|  (83 . vc-git-stash-snapshot)
|  (80 . vc-git-stash-pop-at-point)
|  (65 . vc-git-stash-apply-at-point)
|  (13 . vc-git-stash-show-at-point)
|  (61 . vc-git-stash-show-at-point)
|  (11 . vc-git-stash-delete-at-point)
|  (down-mouse-3 . vc-git-stash-menu)
|  (mouse-2 . ignore))
| 
| [back]
`----

[2]  

#+begin_src emacs-lisp [around line 540 vc-git.el]
	(propertize "Stash      :\n" 'face 'font-lock-type-face
		    'help-echo stash-help-echo)
#+end_src

#+begin_src emacs-lisp [around line 550 vc-git.el]
       (concat
	(propertize "Stash      : " 'face 'font-lock-type-face
		    'help-echo stash-help-echo)
	(propertize "Nothing stashed"
		    'help-echo stash-help-echo
		    'face 'font-lock-variable-name-face))
#+end_src

Message #10 received at 9548-done <at> debbugs.gnu.org (full text, mbox):

From: Jambunathan K <kjambunathan <at> gmail.com>
To: 9548-done <at> debbugs.gnu.org
Subject: Re: bug#9548: 24.0.50; Add vc-git-stash to keymap
Date: Fri, 15 Nov 2013 09:57:14 +0530

OP here. Closing it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.