From unknown Sat Aug 16 11:40:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#9516 <9516@debbugs.gnu.org> To: bug#9516 <9516@debbugs.gnu.org> Subject: Status: imagemagick-register-types and image-file-name-extensions Reply-To: bug#9516 <9516@debbugs.gnu.org> Date: Sat, 16 Aug 2025 18:40:49 +0000 retitle 9516 imagemagick-register-types and image-file-name-extensions reassign 9516 emacs submitter 9516 Juri Linkov severity 9516 normal tag 9516 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 15 14:55:35 2011 Received: (at submit) by debbugs.gnu.org; 15 Sep 2011 18:55:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R4H5y-00041U-Ne for submit@debbugs.gnu.org; Thu, 15 Sep 2011 14:55:35 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R4H5q-000411-3o for submit@debbugs.gnu.org; Thu, 15 Sep 2011 14:55:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R4H1I-00085M-UJ for submit@debbugs.gnu.org; Thu, 15 Sep 2011 14:50:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:56707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4H1I-00085H-St for submit@debbugs.gnu.org; Thu, 15 Sep 2011 14:50:44 -0400 Received: from eggs.gnu.org ([140.186.70.92]:51221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4H1H-0007XK-Pi for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2011 14:50:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R4H1F-00081n-AO for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2011 14:50:43 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]:54900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4H1F-000817-6I for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2011 14:50:41 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id BF6826E804F for ; Thu, 15 Sep 2011 11:50:40 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 1C8EE451C3FB for ; Thu, 15 Sep 2011 11:50:39 -0700 (PDT) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: imagemagick-register-types and image-file-name-extensions Organization: JURTA Date: Thu, 15 Sep 2011 21:34:10 +0300 Message-ID: <87wrda6k5p.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) In Dired typing `C-t C-t' (`image-dired-dired-toggle-marked-thumbs') doesn't show images supported by ImageMagick. It gets file extensions of supported image types by calling the function `image-file-name-regexp' and it gets them from the variable `image-file-name-extensions' that currently misses file extensions supported by ImageMagick. I propose a fix that adds them to `image-file-name-extensions' in `imagemagick-register-types': === modified file 'lisp/image.el' --- lisp/image.el 2011-07-25 08:23:29 +0000 +++ lisp/image.el 2011-09-15 18:32:51 +0000 @@ -699,11 +699,11 @@ (defun imagemagick-register-types () (dolist (im-inhibit imagemagick-types-inhibit) (setq im-types (delq im-inhibit im-types))) (dolist (im-type im-types) - (let ((extension - (concat "\\." (downcase (symbol-name im-type)) - "\\'"))) - (push (cons extension 'image-mode) auto-mode-alist) - (push (cons extension 'imagemagick) + (let* ((extension (downcase (symbol-name im-type))) + (extension-regexp (concat "\\." extension "\\'"))) + (push extension image-file-name-extensions) + (push (cons extension-regexp 'image-mode) auto-mode-alist) + (push (cons extension-regexp 'imagemagick) image-type-file-name-regexps)))))) There are other packages that rely on image file extensions defined in image-file.el: ./iimage.el:61: image-file-name-extensions) ./iimage.el:62: image-file-name-extensions) ./image-dired.el:548: (unless (string-match (image-file-name-regexp) file) ./image-dired.el:656: (when (and image-file (string-match-p (image-file-name-regexp) image-file)) ./image-dired.el:867: (dired-mark-files-regexp (image-file-name-regexp)) ./org/org.el:19319: (if (and (not extensions) (fboundp 'image-file-name-regexp)) ./org/org.el:19320: (image-file-name-regexp) ./org/org.el:19321: (let ((image-file-name-extensions ./org/org.el:19327: image-file-name-extensions) ./org/org.el:19328: image-file-name-extensions) ./thumbs.el:228: (directory-files (thumbs-thumbsdir) t (image-file-name-regexp))) ./thumbs.el:411: (directory-files dir t (or reg (image-file-name-regexp))) I suppose all they will benefit from this fix as well. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 15 22:28:15 2011 Received: (at 9516) by debbugs.gnu.org; 16 Sep 2011 02:28:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R4OA3-0004FY-5w for submit@debbugs.gnu.org; Thu, 15 Sep 2011 22:28:15 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R4OA1-0004FR-GT for 9516@debbugs.gnu.org; Thu, 15 Sep 2011 22:28:14 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AkwJAC6yck5FpYYd/2dsb2JhbABBmEyPDHmBUwEBBVYjEAs0EhQYDSS9KoZ0BKBJhEQ X-IronPort-AV: E=Sophos;i="4.68,391,1312171200"; d="scan'208";a="136659020" Received: from 69-165-134-29.dsl.teksavvy.com (HELO ceviche.home) ([69.165.134.29]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 15 Sep 2011 22:23:30 -0400 Received: by ceviche.home (Postfix, from userid 20848) id B9A7D660B6; Thu, 15 Sep 2011 22:23:29 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#9516: imagemagick-register-types and image-file-name-extensions Message-ID: References: <87wrda6k5p.fsf@mail.jurta.org> Date: Thu, 15 Sep 2011 22:23:29 -0400 In-Reply-To: <87wrda6k5p.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 15 Sep 2011 21:34:10 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 9516 Cc: 9516@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > + (extension-regexp (concat "\\." extension "\\'"))) You forgot a regexp-quote. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 16 09:39:04 2011 Received: (at 9516) by debbugs.gnu.org; 16 Sep 2011 13:39:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R4YdE-0004OU-6a for submit@debbugs.gnu.org; Fri, 16 Sep 2011 09:39:04 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R4YdC-0004OC-Gs for 9516@debbugs.gnu.org; Fri, 16 Sep 2011 09:39:02 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAC5Pc05FpYYd/2dsb2JhbABCp1p4gVMBAQQBViMFCws0EhQYDSSICrQBhngEoE6ERA X-IronPort-AV: E=Sophos;i="4.68,393,1312171200"; d="scan'208";a="136700052" Received: from 69-165-134-29.dsl.teksavvy.com (HELO pastel.home) ([69.165.134.29]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 16 Sep 2011 09:34:17 -0400 Received: by pastel.home (Postfix, from userid 20848) id 779F158F87; Fri, 16 Sep 2011 09:34:17 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#9516: imagemagick-register-types and image-file-name-extensions Message-ID: References: <87wrda6k5p.fsf@mail.jurta.org> Date: Fri, 16 Sep 2011 09:34:17 -0400 In-Reply-To: <87wrda6k5p.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 15 Sep 2011 21:34:10 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 9516 Cc: 9516@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > I propose a fix that adds them to `image-file-name-extensions' > in `imagemagick-register-types': There's something I don't understand: - why do we have both image-file-name-extensions and image-file-name-regexps? - why doesn't image-file.el use image-type-file-name-regexps? Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 16 16:14:01 2011 Received: (at 9516) by debbugs.gnu.org; 16 Sep 2011 20:14:01 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R4enQ-0000KJ-UG for submit@debbugs.gnu.org; Fri, 16 Sep 2011 16:14:01 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R4enL-0000K8-83 for 9516@debbugs.gnu.org; Fri, 16 Sep 2011 16:13:55 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 73A53498205; Fri, 16 Sep 2011 07:14:55 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 07235451C40B; Fri, 16 Sep 2011 07:11:23 -0700 (PDT) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#9516: imagemagick-register-types and image-file-name-extensions Organization: JURTA References: <87wrda6k5p.fsf@mail.jurta.org> Date: Fri, 16 Sep 2011 17:09:49 +0300 In-Reply-To: (Stefan Monnier's message of "Fri, 16 Sep 2011 09:34:17 -0400") Message-ID: <874o0cd1ea.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9516 Cc: 9516@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >> I propose a fix that adds them to `image-file-name-extensions' >> in `imagemagick-register-types': > > There's something I don't understand: > - why do we have both image-file-name-extensions and image-file-name-regexps? I guess for historical reasons. > - why doesn't image-file.el use image-type-file-name-regexps? It seems image-file.el is semi-obsoleted by image-mode.el, so it should use more general settings from image-type-file-name-regexps. And other packages should be fixed to use more general settings from image.el instead of relying on definitions from image-file.el. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 17:34:40 2011 Received: (at 9516) by debbugs.gnu.org; 23 Sep 2011 21:34:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7DOK-0000we-1v for submit@debbugs.gnu.org; Fri, 23 Sep 2011 17:34:40 -0400 Received: from vm-emlprdomr-06.its.yale.edu ([130.132.50.147]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7DOG-0000wW-S6 for 9516@debbugs.gnu.org; Fri, 23 Sep 2011 17:34:37 -0400 Received: from furball (dhcp-128-36-14-81.central.yale.edu [128.36.14.81]) (authenticated bits=0) by vm-emlprdomr-06.its.yale.edu (8.14.4/8.14.4) with ESMTP id p8NLY78H009582 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 23 Sep 2011 17:34:07 -0400 From: Chong Yidong To: Juri Linkov Subject: Re: bug#9516: imagemagick-register-types and image-file-name-extensions References: <87wrda6k5p.fsf@mail.jurta.org> <874o0cd1ea.fsf@mail.jurta.org> Date: Fri, 23 Sep 2011 17:34:07 -0400 In-Reply-To: <874o0cd1ea.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 16 Sep 2011 17:09:49 +0300") Message-ID: <87k48zeyeo.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.147 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 9516 Cc: 9516@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Juri Linkov writes: > It seems image-file.el is semi-obsoleted by image-mode.el, > so it should use more general settings from image-type-file-name-regexps. > And other packages should be fixed to use more general settings > from image.el instead of relying on definitions from image-file.el. Sounds right, though I think that can wait till post-release. Please go ahead and commit your patch (with the regexp-quote). From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 17:41:25 2011 Received: (at 9516) by debbugs.gnu.org; 23 Sep 2011 21:41:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7DUq-00015v-Lr for submit@debbugs.gnu.org; Fri, 23 Sep 2011 17:41:25 -0400 Received: from vm-emlprdomr-06.its.yale.edu ([130.132.50.147]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7DUo-00015o-JE for 9516@debbugs.gnu.org; Fri, 23 Sep 2011 17:41:23 -0400 Received: from furball (dhcp-128-36-14-81.central.yale.edu [128.36.14.81]) (authenticated bits=0) by vm-emlprdomr-06.its.yale.edu (8.14.4/8.14.4) with ESMTP id p8NLerjp012523 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 23 Sep 2011 17:40:53 -0400 From: Chong Yidong To: Juri Linkov Subject: Re: bug#9516: imagemagick-register-types and image-file-name-extensions References: <87wrda6k5p.fsf@mail.jurta.org> <874o0cd1ea.fsf@mail.jurta.org> <87k48zeyeo.fsf@stupidchicken.com> Date: Fri, 23 Sep 2011 17:40:53 -0400 In-Reply-To: <87k48zeyeo.fsf@stupidchicken.com> (Chong Yidong's message of "Fri, 23 Sep 2011 17:34:07 -0400") Message-ID: <87fwjney3e.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.147 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 9516 Cc: 9516@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Chong Yidong writes: > Please go ahead and commit your patch (with the regexp-quote). On second thought, there is a problem---image-file-name-extensions is a defcustom, so your patch would trigger a "changed outside customize" warning if the user tries customizing it after calling imagemagick-register-types. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 25 10:15:20 2011 Received: (at 9516) by debbugs.gnu.org; 25 Sep 2011 14:15:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7pUF-0003yU-Ot for submit@debbugs.gnu.org; Sun, 25 Sep 2011 10:15:20 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7pUD-0003tT-5d for 9516@debbugs.gnu.org; Sun, 25 Sep 2011 10:15:18 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 516496E804D; Sun, 25 Sep 2011 07:14:38 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 62AB7451C330; Sun, 25 Sep 2011 07:14:35 -0700 (PDT) From: Juri Linkov To: Chong Yidong Subject: Re: bug#9516: imagemagick-register-types and image-file-name-extensions Organization: JURTA References: <87wrda6k5p.fsf@mail.jurta.org> <874o0cd1ea.fsf@mail.jurta.org> <87k48zeyeo.fsf@stupidchicken.com> <87fwjney3e.fsf@stupidchicken.com> Date: Sun, 25 Sep 2011 17:03:21 +0300 In-Reply-To: <87fwjney3e.fsf@stupidchicken.com> (Chong Yidong's message of "Fri, 23 Sep 2011 17:40:53 -0400") Message-ID: <874o00d8de.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9516 Cc: 9516@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >> Please go ahead and commit your patch (with the regexp-quote). > > On second thought, there is a problem---image-file-name-extensions is a > defcustom, so your patch would trigger a "changed outside customize" > warning if the user tries customizing it after calling > imagemagick-register-types. Then we could change the function `image-file-name-regexp' that dynamically constructs a composite regexp from `image-file-name-extensions' and `image-file-name-regexps'. What we could do is to add to its return value a regexp added in `imagemagick-register-types' to `image-type-file-name-regexps' with the assoc value `imagemagick': === modified file 'lisp/image-file.el' --- lisp/image-file.el 2011-01-25 04:08:28 +0000 +++ lisp/image-file.el 2011-09-25 14:01:31 +0000 @@ -85,13 +85,12 @@ (defun image-file-name-regexp () image-file-name-extensions) t) "\\'")))) - (if image-file-name-regexps - (mapconcat 'identity - (if exts-regexp - (cons exts-regexp image-file-name-regexps) - image-file-name-regexps) - "\\|") - exts-regexp))) + (mapconcat + 'identity + (delq nil (list exts-regexp + image-file-name-regexps + (car (rassq 'imagemagick image-type-file-name-regexps)))) + "\\|"))) This is a temporary solution for the next release of 24.1 that will allow image-dired.el to display Imagemagick supported images. I think in 24.2, defcustoms in image-file.el should be deprecated and packages should use `image-type-file-name-regexps' instead. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 25 08:31:06 2019 Received: (at 9516) by debbugs.gnu.org; 25 Sep 2019 12:31:06 +0000 Received: from localhost ([127.0.0.1]:40954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iD6Rl-0007cf-SB for submit@debbugs.gnu.org; Wed, 25 Sep 2019 08:31:06 -0400 Received: from quimby.gnus.org ([80.91.231.51]:33526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iD6Rk-0007b8-GT for 9516@debbugs.gnu.org; Wed, 25 Sep 2019 08:31:04 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iD6Rg-0002B9-4O; Wed, 25 Sep 2019 14:31:02 +0200 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#9516: imagemagick-register-types and image-file-name-extensions References: <87wrda6k5p.fsf@mail.jurta.org> <874o0cd1ea.fsf@mail.jurta.org> <87k48zeyeo.fsf@stupidchicken.com> <87fwjney3e.fsf@stupidchicken.com> <874o00d8de.fsf@mail.jurta.org> Date: Wed, 25 Sep 2019 14:30:59 +0200 In-Reply-To: <874o00d8de.fsf@mail.jurta.org> (Juri Linkov's message of "Sun, 25 Sep 2011 17:03:21 +0300") Message-ID: <87ef04woak.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > Then we could change the function `image-file-name-regexp' > that dynamically constructs a composite regexp from > `image-file-name-extensions' and `image-file-name-regexps'. > What we could do is t [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 9516 Cc: 9516@debbugs.gnu.org, Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > Then we could change the function `image-file-name-regexp' > that dynamically constructs a composite regexp from > `image-file-name-extensions' and `image-file-name-regexps'. > What we could do is to add to its return value a regexp added > in `imagemagick-register-types' to `image-type-file-name-regexps' > with the assoc value `imagemagick': [...] > + (mapconcat > + 'identity > + (delq nil (list exts-regexp > + image-file-name-regexps > + (car (rassq 'imagemagick image-type-file-name-regexps)))) > + "\\|"))) > > This is a temporary solution for the next release of 24.1 that > will allow image-dired.el to display Imagemagick supported images. > > I think in 24.2, defcustoms in image-file.el should be deprecated > and packages should use `image-type-file-name-regexps' instead. This was seven years ago, but the patch wasn't applied. I know that ImageMagick is slightly semi-deprecated now, but I think this patch possibly makes sense anyway. I don't use the Dired thumbnail stuff, though. Did anybody have an objection to this that didn't land in the bug tracker? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 25 16:31:31 2019 Received: (at 9516) by debbugs.gnu.org; 25 Sep 2019 20:31:31 +0000 Received: from localhost ([127.0.0.1]:42440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDDwh-00026m-Aa for submit@debbugs.gnu.org; Wed, 25 Sep 2019 16:31:31 -0400 Received: from anteater.elm.relay.mailchannels.net ([23.83.212.3]:35684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDDwc-00026Q-T5 for 9516@debbugs.gnu.org; Wed, 25 Sep 2019 16:31:29 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 07F3A8C1000; Wed, 25 Sep 2019 20:31:19 +0000 (UTC) Received: from pdx1-sub0-mail-a19.g.dreamhost.com (100-96-35-93.trex.outbound.svc.cluster.local [100.96.35.93]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 96EF48C1CD5; Wed, 25 Sep 2019 20:31:18 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a19.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Wed, 25 Sep 2019 20:31:18 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Chief-Absorbed: 530b7e27038a3a3c_1569443478838_1052595944 X-MC-Loop-Signature: 1569443478838:692002737 X-MC-Ingress-Time: 1569443478838 Received: from pdx1-sub0-mail-a19.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a19.g.dreamhost.com (Postfix) with ESMTP id 90412818D2; Wed, 25 Sep 2019 13:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jurta.org; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=jurta.org; bh=rdyepMinb0DZy9btVskAg/Pkrvk=; b=Y WEv/sKE8mjlRdM5n2TuTnt4Ed1fQioxdY3NjYgBa1oJL9eHQ1dxxNnNwiWnk2YAg V2iPXvxVgYkwHqUjD89qZqz2CS/sGceYM+qB3Cy6XxbDCK3u63f4B7XNDK48qRib pDtxuHko93rwAHx4P7elQJqV2+g3yxOjCeHQNHJgKk= Received: from mail.jurta.org (m91-129-105-145.cust.tele2.ee [91.129.105.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a19.g.dreamhost.com (Postfix) with ESMTPSA id 4F153818BA; Wed, 25 Sep 2019 13:31:14 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a19 From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#9516: imagemagick-register-types and image-file-name-extensions Organization: LINKOV.NET References: <87wrda6k5p.fsf@mail.jurta.org> <874o0cd1ea.fsf@mail.jurta.org> <87k48zeyeo.fsf@stupidchicken.com> <87fwjney3e.fsf@stupidchicken.com> <874o00d8de.fsf@mail.jurta.org> <87ef04woak.fsf@gnus.org> Date: Wed, 25 Sep 2019 22:57:07 +0300 In-Reply-To: <87ef04woak.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 25 Sep 2019 14:30:59 +0200") Message-ID: <871rw4qhd8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrfedvgdduheduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhrihesjhhurhhtrgdrohhrgheqnecukfhppeeluddruddvledruddthedrudegheenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdehrddugeehpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehjuhhrthgrrdhorhhgqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehlrghrshhisehgnhhushdrohhrghenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 9516 Cc: 9516@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >> Then we could change the function `image-file-name-regexp' >> that dynamically constructs a composite regexp from >> `image-file-name-extensions' and `image-file-name-regexps'. >> What we could do is to add to its return value a regexp added >> in `imagemagick-register-types' to `image-type-file-name-regexps' >> with the assoc value `imagemagick': > > [...] > >> + (mapconcat >> + 'identity >> + (delq nil (list exts-regexp >> + image-file-name-regexps >> + (car (rassq 'imagemagick image-type-file-name-regexps)))) >> + "\\|"))) >> >> This is a temporary solution for the next release of 24.1 that >> will allow image-dired.el to display Imagemagick supported images. >> >> I think in 24.2, defcustoms in image-file.el should be deprecated >> and packages should use `image-type-file-name-regexps' instead. > > This was seven years ago, but the patch wasn't applied. I know that > ImageMagick is slightly semi-deprecated now, but I think this patch > possibly makes sense anyway. There was no hurry in installing this because all widely used formats are already presented in image-type-file-name-regexps. > I don't use the Dired thumbnail stuff, though. Did anybody have an > objection to this that didn't land in the bug tracker? Sorry, I can't confirm if the patch still works since I don't remember how I tested it long ago, so not sure if this change might break something. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 15:27:22 2019 Received: (at 9516) by debbugs.gnu.org; 26 Sep 2019 19:27:22 +0000 Received: from localhost ([127.0.0.1]:45262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDZQA-0002HK-1A for submit@debbugs.gnu.org; Thu, 26 Sep 2019 15:27:22 -0400 Received: from quimby.gnus.org ([80.91.231.51]:39872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDZQ7-0002H6-BT for 9516@debbugs.gnu.org; Thu, 26 Sep 2019 15:27:19 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iDZQ2-00077b-TS; Thu, 26 Sep 2019 21:27:17 +0200 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#9516: imagemagick-register-types and image-file-name-extensions References: <87wrda6k5p.fsf@mail.jurta.org> <874o0cd1ea.fsf@mail.jurta.org> <87k48zeyeo.fsf@stupidchicken.com> <87fwjney3e.fsf@stupidchicken.com> <874o00d8de.fsf@mail.jurta.org> <87ef04woak.fsf@gnus.org> <871rw4qhd8.fsf@mail.linkov.net> Date: Thu, 26 Sep 2019 21:27:14 +0200 In-Reply-To: <871rw4qhd8.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 25 Sep 2019 22:57:07 +0300") Message-ID: <87lfuaj1t9.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: >> I don't use the Dired thumbnail stuff, though. Did anybody have an >> objection to this that didn't land in the bug tracker? > > Sorry, I can't confirm if the patch still works since I don't rememb [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 9516 Cc: 9516@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: >> I don't use the Dired thumbnail stuff, though. Did anybody have an >> objection to this that didn't land in the bug tracker? > > Sorry, I can't confirm if the patch still works since I don't remember > how I tested it long ago, so not sure if this change might break something. I've now done some light testing in an ImageMagick-enabled Emacs, and it seems to work fine, so I've pushed the patch. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 15:27:24 2019 Received: (at control) by debbugs.gnu.org; 26 Sep 2019 19:27:24 +0000 Received: from localhost ([127.0.0.1]:45265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDZQC-0002Ha-BM for submit@debbugs.gnu.org; Thu, 26 Sep 2019 15:27:24 -0400 Received: from quimby.gnus.org ([80.91.231.51]:39886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDZQA-0002HI-6n for control@debbugs.gnu.org; Thu, 26 Sep 2019 15:27:22 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iDZQ7-00077i-GU for control@debbugs.gnu.org; Thu, 26 Sep 2019 21:27:21 +0200 Date: Thu, 26 Sep 2019 21:27:19 +0200 Message-Id: <87k19uj1t4.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #9516 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 9516 fixed close 9516 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 9516 fixed close 9516 27.1 quit From unknown Sat Aug 16 11:40:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 25 Oct 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator