GNU bug report logs - #9480
24.0.50; (vc-git) stash@{n} - requires shell quoting?

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jambunathan K <kjambunathan <at> gmail.com>
Subject: bug#9480: closed (Re: bug#9480: 24.0.50; (vc-git) stash@{n} -
 requires shell quoting?)
Date: Wed, 14 Sep 2011 12:03:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#9480: 24.0.50; (vc-git) stash@{n} - requires shell quoting?

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 9480 <at> debbugs.gnu.org.

-- 
9480: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9480
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jambunathan K <kjambunathan <at> gmail.com>
Cc: rgm <at> gnu.org, 9480-done <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#9480: 24.0.50; (vc-git) stash@{n} - requires shell quoting?
Date: Wed, 14 Sep 2011 07:57:40 -0400

> From: Jambunathan K <kjambunathan <at> gmail.com>
> Cc:  Stefan Monnier <monnier <at> iro.umontreal.ca>,  9480 <at> debbugs.gnu.org
> Date: Wed, 14 Sep 2011 16:28:27 +0530
> 
> Glenn Morris <rgm <at> gnu.org> writes:
> 
> > Eli Zaretskii wrote:
> >
> >> This should generally work fine, except that IMO globbing in this case
> >> is simply buggy: the braces are removed although a real shell would
> >> expand "{0}" into itself.
> >
> > I agree.
> 
> Glenn
> Thanks for the reference note. I will file a bug report with Cygwin very
> soon.
> 
> Eli
> Feel free to close this bug.

Done.

[Message part 3 (message/rfc822, inline)]

From: Jambunathan K <kjambunathan <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; (vc-git) stash@{n} - requires shell quoting?
Date: Mon, 12 Sep 2011 12:39:43 +0530

[Message part 4 (text/plain, inline)]

While in a *vc-dir* buffer (backed by git) and trying to show or apply a
stash fails.

I am attaching "works for me" patch that shell-quotes stash@{n}
argument. With this "patch", the stash commands work as expected.

My shell-file-name is set to "bash" (cygwin version). My Emacs is

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2011-09-06 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt'

Additional Info:

,----
| VC backend : Git
| Working dir: ~/src/org-mode/
| Branch     : master
| Remote     : orgmode <at> orgmode.org:org-mode.git
| Stash      :
|              {0}: On master: custom tables  <-----
`----

FWIW, the stash line has following keymap:

,----
| (keymap
|  (83 . vc-git-stash-snapshot)
|  (80 . vc-git-stash-pop-at-point)
|  (65 . vc-git-stash-apply-at-point)
|  (13 . vc-git-stash-show-at-point)
|  (61 . vc-git-stash-show-at-point)
|  (11 . vc-git-stash-delete-at-point)
|  (down-mouse-3 . vc-git-stash-menu)
|  (mouse-2 . ignore))
`----

[vc-git.el.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.