GNU bug report logs - #947
Recursive load of ido after unload-feature and reload

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 947 in the body.
You can then email your comments to 947 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Juanma Barranquero" <lekktu <at> gmail.com>
To: "Emacs Bug Tracker" <submit <at> debbugs.gnu.org>
Subject: Recursive load of ido after unload-feature and reload
Date: Tue, 9 Sep 2008 16:29:40 +0200

Package: emacs
Severity: minor

emacs -Q -D
M-x ido-mode <RET>
M-x unload-feature <RET> ido <RET>
M-x ido-mode <RET>

Recursive load: "c:/emacs/trunk/lisp/ido.elc",
"c:/emacs/trunk/lisp/ido.elc", "c:/emacs/trunk/lisp/ido.elc",
"c:/emacs/trunk/lisp/ido.elc", "c:/emacs/trunk/lisp/ido.elc"

The problem is that after unloading ido, the variable ido-mode is
void, and calling ido-mode without an argument runs this code:

  (setq ido-mode
	(cond
	 ((null arg) (if ido-mode nil 'both))
         ; ...

and setting the variable ido-mode runs this code:

  :set #'(lambda (symbol value)
	   (ido-mode value))

so there's really a recursion.

I can think of several crude workarounds, but they aren't pretty and
I'm not sure they will play fair with customize.

Message #12 received at 947 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 947 <at> debbugs.gnu.org
Subject: Re: bug#947: Recursive load of ido after unload-feature and reload
Date: Wed, 10 Sep 2008 14:44:54 -0400

"Juanma Barranquero" wrote:

> and setting the variable ido-mode runs this code:
>
>   :set #'(lambda (symbol value)
> 	   (ido-mode value))
>
> so there's really a recursion.

Isn't this enough, so long as ido-mode is not enabled by default?

*** ido.el	9 Sep 2008 14:01:03 -0000	1.150
--- ido.el	10 Sep 2008 18:44:43 -0000
***************
*** 353,359 ****
  use either \\[customize] or the function `ido-mode'."
    :set #'(lambda (symbol value)
  	   (ido-mode value))
!   :initialize 'custom-initialize-set
    :require 'ido
    :link '(emacs-commentary-link "ido.el")
    :set-after '(ido-save-directory-list-file
--- 353,359 ----
  use either \\[customize] or the function `ido-mode'."
    :set #'(lambda (symbol value)
  	   (ido-mode value))
!   :initialize 'custom-initialize-default
    :require 'ido
    :link '(emacs-commentary-link "ido.el")
    :set-after '(ido-save-directory-list-file

Message #17 received at 947 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Juanma Barranquero" <lekktu <at> gmail.com>
To: "Glenn Morris" <rgm <at> gnu.org>
Cc: 947 <at> debbugs.gnu.org
Subject: Re: bug#947: Recursive load of ido after unload-feature and reload
Date: Thu, 11 Sep 2008 01:56:03 +0200

On Wed, Sep 10, 2008 at 20:44, Glenn Morris <rgm <at> gnu.org> wrote:

> Isn't this enough

Yes, it apparently fixes the problem.

> so long as ido-mode is not enabled by default?

What do you mean, "not enabled by default"?

   Juanma

Message #22 received at 947-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: "Juanma Barranquero" <lekktu <at> gmail.com>
Cc: 947-done <at> debbugs.gnu.org
Subject: Re: bug#947: Recursive load of ido after unload-feature and reload
Date: Thu, 11 Sep 2008 02:11:29 -0400

"Juanma Barranquero" wrote:

> Yes, it apparently fixes the problem.

Installed.

>> so long as ido-mode is not enabled by default?

> What do you mean, "not enabled by default"?

So long as ido-mode the variable has a default value of nil, which I
imagine will always be true.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.