From unknown Fri Jun 20 05:35:57 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#9415 <9415@debbugs.gnu.org> To: bug#9415 <9415@debbugs.gnu.org> Subject: Status: 23.3.50; unerased cursor in a row that extends face to end of line Reply-To: bug#9415 <9415@debbugs.gnu.org> Date: Fri, 20 Jun 2025 12:35:57 +0000 retitle 9415 23.3.50; unerased cursor in a row that extends face to end of = line reassign 9415 emacs submitter 9415 YAMAMOTO Mitsuharu severity 9415 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 31 20:33:24 2011 Received: (at submit) by debbugs.gnu.org; 1 Sep 2011 00:33:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QyvDf-0004d4-MQ for submit@debbugs.gnu.org; Wed, 31 Aug 2011 20:33:24 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QyvDa-0004cu-EZ for submit@debbugs.gnu.org; Wed, 31 Aug 2011 20:33:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QyvAP-0001No-Jx for submit@debbugs.gnu.org; Wed, 31 Aug 2011 20:30:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:41552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyvAP-0001NZ-IF for submit@debbugs.gnu.org; Wed, 31 Aug 2011 20:30:01 -0400 Received: from eggs.gnu.org ([140.186.70.92]:51516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyvAO-0006jL-9E for bug-gnu-emacs@gnu.org; Wed, 31 Aug 2011 20:30:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QyvAM-0001N9-DA for bug-gnu-emacs@gnu.org; Wed, 31 Aug 2011 20:30:00 -0400 Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:57549) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyvAL-0001Mt-LZ for bug-gnu-emacs@gnu.org; Wed, 31 Aug 2011 20:29:58 -0400 Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id B1DBAC0560 for ; Thu, 1 Sep 2011 09:29:53 +0900 (JST) Date: Thu, 01 Sep 2011 09:29:53 +0900 Message-ID: From: YAMAMOTO Mitsuharu To: bug-gnu-emacs@gnu.org Subject: 23.3.50; unerased cursor in a row that extends face to end of line User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) Organization: Faculty of Science, Chiba University MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: NetBSD 3.0 (DF) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.8 (----) Steps to reproduce: 1. $ emacs -Q 2. M-x font-lock-mode RET 3. M-x blink-cursor-mode RET 4. C-SPC C-p 5. M-o o mode-line RET 6. C-x 3 7. C-x 1 8. C-p Result: The cursor at the beginning of the line whose face is mode-line is unerased. The patch below seems to fix it, and the cause of the problem is explained in the added comment. === modified file 'src/xdisp.c' *** src/xdisp.c 2011-07-23 07:32:42 +0000 --- src/xdisp.c 2011-09-01 00:03:30 +0000 *************** *** 24278,24284 **** { int yb = window_text_bottom_y (w); struct glyph_row *row; ! int cursor_cleared_p; struct glyph_row *first_overlapping_row, *last_overlapping_row; TRACE ((stderr, "expose_window (%d, %d, %d, %d)\n", --- 24278,24284 ---- { int yb = window_text_bottom_y (w); struct glyph_row *row; ! int cursor_cleared_p, phys_cursor_on_p; struct glyph_row *first_overlapping_row, *last_overlapping_row; TRACE ((stderr, "expose_window (%d, %d, %d, %d)\n", *************** *** 24298,24303 **** --- 24298,24310 ---- else cursor_cleared_p = 0; + /* If the row containing the cursor extends face to end of line, + then expose_area might overwrite the cursor outside the + rectangle and thus notice_overwritten_cursor might clear + w->phys_cursor_on_p. We remember the original value and + check later if it is changed. */ + phys_cursor_on_p = w->phys_cursor_on_p; + /* Update lines intersecting rectangle R. */ first_overlapping_row = last_overlapping_row = NULL; for (row = w->current_matrix->rows; *************** *** 24364,24370 **** x_draw_vertical_border (w); /* Turn the cursor on again. */ ! if (cursor_cleared_p) update_window_cursor (w, 1); } } --- 24371,24378 ---- x_draw_vertical_border (w); /* Turn the cursor on again. */ ! if (cursor_cleared_p ! || (phys_cursor_on_p && !w->phys_cursor_on_p)) update_window_cursor (w, 1); } } YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. For information about debugging Emacs, please read the file /Users/mituharu/src/bzr/emacs/emacs-23/etc/DEBUG. In GNU Emacs 23.3.50.1 (x86_64-apple-darwin11.0.0, X toolkit) of 2011-08-31 on yamamoto-no-iMac.local Windowing system distributor `The X.Org Foundation', version 11.0.11002000 configured using `configure '--with-jpeg=no' '--with-gif=no' '--with-tiff=no'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: ja_JP.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: None found. Features: (shadow sort mail-extr message ecomplete rfc822 mml easymenu mml-sec password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock sha1 hex-util hashcash mail-utils emacsbug japan-util tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd font-setting tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces cus-face files text-properties overlay md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process font-render-setting x-toolkit x multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 01 11:45:46 2011 Received: (at 9415) by debbugs.gnu.org; 1 Sep 2011 15:45:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qz9Sc-0007VL-3u for submit@debbugs.gnu.org; Thu, 01 Sep 2011 11:45:46 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qz9Sa-0007VD-8w for 9415@debbugs.gnu.org; Thu, 01 Sep 2011 11:45:45 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LQU00C00OS8ZJ00@a-mtaout21.012.net.il> for 9415@debbugs.gnu.org; Thu, 01 Sep 2011 18:39:23 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.229.83.44]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LQU00CADOTMZ210@a-mtaout21.012.net.il>; Thu, 01 Sep 2011 18:39:23 +0300 (IDT) Date: Thu, 01 Sep 2011 18:39:24 +0300 From: Eli Zaretskii Subject: Re: bug#9415: 23.3.50; unerased cursor in a row that extends face to end of line In-reply-to: X-012-Sender: halo1@inter.net.il To: YAMAMOTO Mitsuharu Message-id: <8339gge0gj.fsf@gnu.org> References: X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 9415 Cc: 9415@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > Date: Thu, 01 Sep 2011 09:29:53 +0900 > From: YAMAMOTO Mitsuharu > > The patch below seems to fix it, and the cause of the problem is > explained in the added comment. Looks good to me, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 10 03:04:30 2011 Received: (at 9415-done) by debbugs.gnu.org; 10 Sep 2011 07:04:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R2Hc5-0003wH-Iq for submit@debbugs.gnu.org; Sat, 10 Sep 2011 03:04:30 -0400 Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R2Hbv-0003w0-UG for 9415-done@debbugs.gnu.org; Sat, 10 Sep 2011 03:04:24 -0400 Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 8776FC0560; Sat, 10 Sep 2011 16:00:07 +0900 (JST) Date: Sat, 10 Sep 2011 16:00:07 +0900 Message-ID: From: YAMAMOTO Mitsuharu To: Eli Zaretskii Subject: Re: bug#9415: 23.3.50; unerased cursor in a row that extends face to end of line In-Reply-To: <8339gge0gj.fsf@gnu.org> References: <8339gge0gj.fsf@gnu.org> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) Organization: Faculty of Science, Chiba University MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 9415-done Cc: 9415-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) >>>>> On Thu, 01 Sep 2011 18:39:24 +0300, Eli Zaretskii said: >> The patch below seems to fix it, and the cause of the problem is >> explained in the added comment. > Looks good to me, thanks. Thanks. I've installed the patch to the emacs-23 branch. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp From unknown Fri Jun 20 05:35:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 08 Oct 2011 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator