GNU bug report logs - #9414
Use of 'grep-find-ignored-directories' exclude files from search.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Juri Linkov <juri <at> jurta.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#9414: closed (Use of 'grep-find-ignored-directories' exclude
 files from search.)
Date: Mon, 05 Sep 2011 10:02:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 05 Sep 2011 12:55:32 +0300
with message-id <87k49nqpnv.fsf <at> mail.jurta.org>
and subject line Re: bug#9414: Fixed patch.
has caused the GNU bug report #9414,
regarding Use of 'grep-find-ignored-directories' exclude files from search.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
9414: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9414
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Oleksandr Gavenko <gavenkoa <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Use of 'grep-find-ignored-directories' exclude files from search.
Date: Thu, 01 Sep 2011 00:44:11 +0300

[Message part 3 (text/plain, inline)]

GNU Emacs 23.3.1 (i386-mingw-nt6.1.7601) of 2011-03-10 on 3249CTO

If set:

  (add-to-list 'grep-find-ignored-directories "build" t)

and try search M-x rgrep in hierarchy:

  build/xxx
  src/yyy
  src/build
  build

  $ mkdir  build src;
  $ touch  build/xxx src/yyy src/build

'find' part of 'rgrep' print only (I simplify expression of 'rgrep'):

  $ find . '(' -path '*/build' -o -path '*/lib' ')' \
     -prune -o  -type f  -print
./src/yyy

Correct one is:

  $ find . '(' -type d -path '*/build' -o -path '*/lib' ')' \
     -prune -o  -type f  -print
./src/build
./src/yyy

So any dir added to 'grep-find-ignored-directories' also affected to
*regular* file names...

I previously file bug to findutils, but I am wrong:

  http://savannah.gnu.org/bugs/?34159

This is Emacs bug.

I suggest fix in patch.

[grep-find-ignored-directories.patch (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Juri Linkov <juri <at> jurta.org>
To: Oleksandr Gavenko <gavenkoa <at> gmail.com>
Cc: 9414-done <at> debbugs.gnu.org
Subject: Re: bug#9414: Fixed patch.
Date: Mon, 05 Sep 2011 12:55:32 +0300

> Previous patch is wrong (I miss 'find' options priority).
>
> This one right (more priestly tested and work fine).

Thank you.  This patch is now committed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.