GNU bug report logs - #9408
23.3; vc-git-grep doesn't link to files when git grep uses colour

Previous Next

Package: emacs;

Reported by: Wilfred Hughes <wilfred <at> potatolondon.com>

Date: Tue, 30 Aug 2011 16:08:01 UTC

Severity: normal

Found in version 23.3

Fixed in version 24.1

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> jurta.org>
To: Wilfred Hughes <wilfred <at> potatolondon.com>
Cc: 9408 <at> debbugs.gnu.org
Subject: bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour
Date: Tue, 06 Sep 2011 16:40:10 +0300

> Yes, using git grep without --no-color gets exactly the colour codes you
> describe. But as of revision 105630 (the commit mentioned in message 13),
> vc-git-grep uses the command "git grep --no-color -n -e <R> -- <F>" which
> suppresses search term highlighting. Have I missed something?

You earlier suggested to add "--no-color" to `grep-expand-template'.
Do you think it now can be removed because now search terms are
highlighted correctly and you have no more problems with
hitting RET on them?
This bug report was last modified 13 years and 256 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.