From unknown Sat Jun 14 19:32:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Resent-From: Wilfred Hughes Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Aug 2011 16:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 9408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 9408@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13147204662221 (code B ref -1); Tue, 30 Aug 2011 16:08:01 +0000 Received: (at submit) by debbugs.gnu.org; 30 Aug 2011 16:07:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QyQqm-0000Zk-Q2 for submit@debbugs.gnu.org; Tue, 30 Aug 2011 12:07:46 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QyM1l-0004Xf-G2 for submit@debbugs.gnu.org; Tue, 30 Aug 2011 06:58:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QyLyj-00087w-HA for submit@debbugs.gnu.org; Tue, 30 Aug 2011 06:55:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:60307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyLyj-00087s-FW for submit@debbugs.gnu.org; Tue, 30 Aug 2011 06:55:37 -0400 Received: from eggs.gnu.org ([140.186.70.92]:33427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyLyi-0001XG-Cg for bug-gnu-emacs@gnu.org; Tue, 30 Aug 2011 06:55:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QyLyg-000879-Vr for bug-gnu-emacs@gnu.org; Tue, 30 Aug 2011 06:55:36 -0400 Received: from mail-gy0-f169.google.com ([209.85.160.169]:50372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyLyg-000872-Og for bug-gnu-emacs@gnu.org; Tue, 30 Aug 2011 06:55:34 -0400 Received: by gyg10 with SMTP id 10so2370104gyg.0 for ; Tue, 30 Aug 2011 03:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=potatolondon.com; s=google; h=mime-version:from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=NgIp8mUwdNeJmrUVeV4gTHaBm6RCuOuEyg4mLbTBrM8=; b=DePAZxA5QUvdYMTw5x8TCHkn+I006d2P+14MPDvdT9z/bGf0KeAiVMkw/qKRSv/RmE KZy/flZB2uPH3xYyw0/Yk5pvQ8hLIn7Qn4tn37k3HYf/eYfH37cVVhKp9w9T1j5MlJeT BO33MXBuQeaJ2nP1Bv3ETvRzP5P2V8ijHJR9Q= Received: by 10.43.133.65 with SMTP id hx1mr2540668icc.133.1314701733129; Tue, 30 Aug 2011 03:55:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.145.202 with HTTP; Tue, 30 Aug 2011 03:55:13 -0700 (PDT) From: Wilfred Hughes Date: Tue, 30 Aug 2011 11:55:13 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.6 (------) X-Mailman-Approved-At: Tue, 30 Aug 2011 12:07:42 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) 1. disable colour for git by doing the following in a shell: $ git config --global color.ui never 2. open a file that is in a git repository: (in my case: C-x C-f ~/gxbo/cron.yaml) 3. search for something that exists using vc-git-grep: (in my case: M-x vc-git-grep RET backend RET * RET ~/gxbo RET) 4. results are returned that links to the files where the results were found 5. enable colour for git: $ git config --global color.ui always 6. repeat the search with vc-git grep 7. results are just plain text and hitting RET on them gives "no git hit here". Compared with using grep, I note that my search term 'backend' is not highlighted. I don't know if that's related. Thanks. In GNU Emacs 23.3.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.5) =C2=A0of 2011-08-21 on ovide Windowing system distributor `The X.Org Foundation', version 11.0.11003901 configured using `configure=C2=A0 '--prefix=3D/usr' '--sysconfdir=3D/etc' '--libexecdir=3D/usr/lib' '--localstatedir=3D/var' '--without-sound' '--with-x-toolkit=3Dgtk' '--with-xft' 'CFLAGS=3D-march=3Dx86-64 -mtune=3Dgeneric -O2 -pipe -fstack-protector --param=3Dssp-buffer-size=3D4 -D_FORTIFY_SOURCE=3D2' 'LDFLAGS=3D-Wl,-O1,--sort-common,--as-needed,-z,relro,--hash-style=3Dgnu'' Important settings: =C2=A0 value of $LC_ALL: nil =C2=A0 value of $LC_COLLATE: nil =C2=A0 value of $LC_CTYPE: nil =C2=A0 value of $LC_MESSAGES: nil =C2=A0 value of $LC_MONETARY: nil =C2=A0 value of $LC_NUMERIC: nil =C2=A0 value of $LC_TIME: nil =C2=A0 value of $LANG: en_GB.UTF-8 =C2=A0 value of $XMODIFIERS: nil =C2=A0 locale-coding-system: utf-8-unix =C2=A0 default enable-multibyte-characters: t Major mode: Fundamental Minor modes in effect: =C2=A0 tooltip-mode: t =C2=A0 mouse-wheel-mode: t =C2=A0 tool-bar-mode: t =C2=A0 menu-bar-mode: t =C2=A0 file-name-shadow-mode: t =C2=A0 global-font-lock-mode: t =C2=A0 font-lock-mode: t =C2=A0 blink-cursor-mode: t =C2=A0 auto-encryption-mode: t =C2=A0 auto-compression-mode: t =C2=A0 line-number-mode: t =C2=A0 transient-mark-mode: t Recent input: C-x C-f c r o n . y M-x v c - g i g r e b a c k e n d * C-f M-x v c - g i g b a c k e n d * C-x o M-> M-< C-x o M-x r e p o r < return> Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Loading vc-git...done call-interactively: End of buffer Grep finished (matches found) [2 times] Mark set [2 times] Load-path shadows: None found. Features: (shadow sort mail-extr message idna sendmail regexp-opt ecomplete rfc822 mml easymenu mml-sec password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock sha1 hex-util hashcash mail-utils emacsbug grep compile comint ring vc-git tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd font-setting tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces cus-face files text-properties overlay md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind system-font-setting font-render-setting gtk x-toolkit x multi-tty emacs) From unknown Sat Jun 14 19:32:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9408: A simple patch References: In-Reply-To: Resent-From: Wilfred Hughes Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Aug 2011 16:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 9408@debbugs.gnu.org Received: via spool by 9408-submit@debbugs.gnu.org id=B9408.131472278213524 (code B ref 9408); Tue, 30 Aug 2011 16:47:01 +0000 Received: (at 9408) by debbugs.gnu.org; 30 Aug 2011 16:46:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QyRS9-0003Vq-O4 for submit@debbugs.gnu.org; Tue, 30 Aug 2011 12:46:22 -0400 Received: from mail-yi0-f44.google.com ([209.85.218.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QyRRz-0003UM-Ed for 9408@debbugs.gnu.org; Tue, 30 Aug 2011 12:46:14 -0400 Received: by yie12 with SMTP id 12so4072860yie.3 for <9408@debbugs.gnu.org>; Tue, 30 Aug 2011 09:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=potatolondon.com; s=google; h=mime-version:from:date:message-id:subject:to:content-type; bh=jFRe4iftJMEfpvWmmu7Y3jn+f1lJaKCfzkcbtfqwbe4=; b=nJv+512P9QY+rw9w83jCZONI/y3grE18nHWICGnGyQyFa9vv3mQrfUh/kH97eDiN2s YilHkduNB/7T0Adu5kVwNNWRP9tqlNp0+u6oABxNS0DSSI/0P2dJK5hIX8X6wMJwScpp yTL1gyoE4D4xiHqpsl3Qv1V+q1i/fv4Hv8qu4= Received: by 10.231.47.17 with SMTP id l17mr13620208ibf.24.1314722582485; Tue, 30 Aug 2011 09:43:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.145.202 with HTTP; Tue, 30 Aug 2011 09:42:42 -0700 (PDT) From: Wilfred Hughes Date: Tue, 30 Aug 2011 17:42:42 +0100 Message-ID: Content-Type: multipart/alternative; boundary=0015177414b281dbfa04abbbb487 X-Spam-Score: -5.1 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) --0015177414b281dbfa04abbbb487 Content-Type: text/plain; charset=UTF-8 Fixing this should be just a matter of changing line 890 of vc-git.el: (grep-expand-template "git grep -n -e -- " regexp files)) To: (grep-expand-template "git grep --no-color -n -e -- " regexp files)) Generally --no-color is used, so I can't see any similar issues elsewhere. --0015177414b281dbfa04abbbb487 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Fixing this should be just a matter of changing line 890 of vc-git.el:
<= br>(grep-expand-template "git grep -n -e <R> -- <F>" = regexp files))

To:

(grep-expand-template "git grep --no-= color -n -e <R> -- <F>" regexp files))

Generally --no-color is used, so I can't see any similar issues els= ewhere.
--0015177414b281dbfa04abbbb487-- From unknown Sat Jun 14 19:32:19 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Wilfred Hughes Subject: bug#9408: closed (Re: bug#9408: A simple patch) Message-ID: References: X-Gnu-PR-Message: they-closed 9408 X-Gnu-PR-Package: emacs Reply-To: 9408@debbugs.gnu.org Date: Thu, 01 Sep 2011 07:34:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1314862442-29709-1" This is a multi-part message in MIME format... ------------=_1314862442-29709-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 9408@debbugs.gnu.org. --=20 9408: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D9408 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1314862442-29709-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 9408-done) by debbugs.gnu.org; 1 Sep 2011 07:33:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qz1mQ-0007ih-TK for submit@debbugs.gnu.org; Thu, 01 Sep 2011 03:33:43 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qz1mO-0007ia-8t for 9408-done@debbugs.gnu.org; Thu, 01 Sep 2011 03:33:40 -0400 Received: from localhost ([127.0.0.1]:49738) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qz1j9-0002TE-3Q; Thu, 01 Sep 2011 03:30:20 -0400 From: Glenn Morris To: 9408-done@debbugs.gnu.org Subject: Re: bug#9408: A simple patch References: X-Spook: Mafia fissionable Mossad FTS2000 Telex Tony Blair MIT-LL X-Ran: gO,uQ (Wilfred Hughes's message of "Tue, 30 Aug 2011 17:42:42 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 9408-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) Version: 24.1 Thanks; applied. ------------=_1314862442-29709-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 30 Aug 2011 16:07:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QyQqm-0000Zk-Q2 for submit@debbugs.gnu.org; Tue, 30 Aug 2011 12:07:46 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QyM1l-0004Xf-G2 for submit@debbugs.gnu.org; Tue, 30 Aug 2011 06:58:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QyLyj-00087w-HA for submit@debbugs.gnu.org; Tue, 30 Aug 2011 06:55:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:60307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyLyj-00087s-FW for submit@debbugs.gnu.org; Tue, 30 Aug 2011 06:55:37 -0400 Received: from eggs.gnu.org ([140.186.70.92]:33427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyLyi-0001XG-Cg for bug-gnu-emacs@gnu.org; Tue, 30 Aug 2011 06:55:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QyLyg-000879-Vr for bug-gnu-emacs@gnu.org; Tue, 30 Aug 2011 06:55:36 -0400 Received: from mail-gy0-f169.google.com ([209.85.160.169]:50372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyLyg-000872-Og for bug-gnu-emacs@gnu.org; Tue, 30 Aug 2011 06:55:34 -0400 Received: by gyg10 with SMTP id 10so2370104gyg.0 for ; Tue, 30 Aug 2011 03:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=potatolondon.com; s=google; h=mime-version:from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=NgIp8mUwdNeJmrUVeV4gTHaBm6RCuOuEyg4mLbTBrM8=; b=DePAZxA5QUvdYMTw5x8TCHkn+I006d2P+14MPDvdT9z/bGf0KeAiVMkw/qKRSv/RmE KZy/flZB2uPH3xYyw0/Yk5pvQ8hLIn7Qn4tn37k3HYf/eYfH37cVVhKp9w9T1j5MlJeT BO33MXBuQeaJ2nP1Bv3ETvRzP5P2V8ijHJR9Q= Received: by 10.43.133.65 with SMTP id hx1mr2540668icc.133.1314701733129; Tue, 30 Aug 2011 03:55:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.145.202 with HTTP; Tue, 30 Aug 2011 03:55:13 -0700 (PDT) From: Wilfred Hughes Date: Tue, 30 Aug 2011 11:55:13 +0100 Message-ID: Subject: 23.3; vc-git-grep doesn't link to files when git grep uses colour To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 30 Aug 2011 12:07:42 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) 1. disable colour for git by doing the following in a shell: $ git config --global color.ui never 2. open a file that is in a git repository: (in my case: C-x C-f ~/gxbo/cron.yaml) 3. search for something that exists using vc-git-grep: (in my case: M-x vc-git-grep RET backend RET * RET ~/gxbo RET) 4. results are returned that links to the files where the results were found 5. enable colour for git: $ git config --global color.ui always 6. repeat the search with vc-git grep 7. results are just plain text and hitting RET on them gives "no git hit here". Compared with using grep, I note that my search term 'backend' is not highlighted. I don't know if that's related. Thanks. In GNU Emacs 23.3.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.5) =C2=A0of 2011-08-21 on ovide Windowing system distributor `The X.Org Foundation', version 11.0.11003901 configured using `configure=C2=A0 '--prefix=3D/usr' '--sysconfdir=3D/etc' '--libexecdir=3D/usr/lib' '--localstatedir=3D/var' '--without-sound' '--with-x-toolkit=3Dgtk' '--with-xft' 'CFLAGS=3D-march=3Dx86-64 -mtune=3Dgeneric -O2 -pipe -fstack-protector --param=3Dssp-buffer-size=3D4 -D_FORTIFY_SOURCE=3D2' 'LDFLAGS=3D-Wl,-O1,--sort-common,--as-needed,-z,relro,--hash-style=3Dgnu'' Important settings: =C2=A0 value of $LC_ALL: nil =C2=A0 value of $LC_COLLATE: nil =C2=A0 value of $LC_CTYPE: nil =C2=A0 value of $LC_MESSAGES: nil =C2=A0 value of $LC_MONETARY: nil =C2=A0 value of $LC_NUMERIC: nil =C2=A0 value of $LC_TIME: nil =C2=A0 value of $LANG: en_GB.UTF-8 =C2=A0 value of $XMODIFIERS: nil =C2=A0 locale-coding-system: utf-8-unix =C2=A0 default enable-multibyte-characters: t Major mode: Fundamental Minor modes in effect: =C2=A0 tooltip-mode: t =C2=A0 mouse-wheel-mode: t =C2=A0 tool-bar-mode: t =C2=A0 menu-bar-mode: t =C2=A0 file-name-shadow-mode: t =C2=A0 global-font-lock-mode: t =C2=A0 font-lock-mode: t =C2=A0 blink-cursor-mode: t =C2=A0 auto-encryption-mode: t =C2=A0 auto-compression-mode: t =C2=A0 line-number-mode: t =C2=A0 transient-mark-mode: t Recent input: C-x C-f c r o n . y M-x v c - g i g r e b a c k e n d * C-f M-x v c - g i g b a c k e n d * C-x o M-> M-< C-x o M-x r e p o r < return> Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Loading vc-git...done call-interactively: End of buffer Grep finished (matches found) [2 times] Mark set [2 times] Load-path shadows: None found. Features: (shadow sort mail-extr message idna sendmail regexp-opt ecomplete rfc822 mml easymenu mml-sec password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock sha1 hex-util hashcash mail-utils emacsbug grep compile comint ring vc-git tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd font-setting tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces cus-face files text-properties overlay md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind system-font-setting font-render-setting gtk x-toolkit x multi-tty emacs) ------------=_1314862442-29709-1-- From unknown Sat Jun 14 19:32:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Sep 2011 08:55:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Wilfred Hughes Cc: 9408@debbugs.gnu.org Received: via spool by 9408-submit@debbugs.gnu.org id=B9408.131521289426317 (code B ref 9408); Mon, 05 Sep 2011 08:55:03 +0000 Received: (at 9408) by debbugs.gnu.org; 5 Sep 2011 08:54:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0UxC-0006qQ-Ih for submit@debbugs.gnu.org; Mon, 05 Sep 2011 04:54:54 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0Ux8-0006qF-Tp for 9408@debbugs.gnu.org; Mon, 05 Sep 2011 04:54:51 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id D49446E805D; Mon, 5 Sep 2011 01:51:09 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 881C5451C356; Mon, 5 Sep 2011 01:51:07 -0700 (PDT) From: Juri Linkov Organization: JURTA References: Date: Mon, 05 Sep 2011 11:28:17 +0300 In-Reply-To: (Wilfred Hughes's message of "Tue, 30 Aug 2011 11:55:13 +0100") Message-ID: <87sjoci6tu.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > Compared with using grep, I note that my search term 'backend' is not > highlighted. I don't know if that's related. git-grep emits "\033[1;31m" escape sequences unlike expected "\033[01;31m" as GNU Grep does. I fixed this in the Bzr repo, so now search terms can be highlighted by `vc-git-grep'. Could you please try the fixed version now? From unknown Sat Jun 14 19:32:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Resent-From: Wilfred Hughes Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Sep 2011 12:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 9408@debbugs.gnu.org Received: via spool by 9408-submit@debbugs.gnu.org id=B9408.131522685024053 (code B ref 9408); Mon, 05 Sep 2011 12:48:01 +0000 Received: (at 9408) by debbugs.gnu.org; 5 Sep 2011 12:47:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0YaE-0006Fp-4y for submit@debbugs.gnu.org; Mon, 05 Sep 2011 08:47:30 -0400 Received: from mail-iy0-f172.google.com ([209.85.210.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0Ya7-0006Fe-Km for 9408@debbugs.gnu.org; Mon, 05 Sep 2011 08:47:24 -0400 Received: by iakc1 with SMTP id c1so6309119iak.3 for <9408@debbugs.gnu.org>; Mon, 05 Sep 2011 05:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=potatolondon.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=NCFzbcRZ8MCOMvs2UHYm4/LN2YE4wUZ+/nHkIbSEdRw=; b=gDJiVQwEDu9XspUAKB6WGJ27u102Epj/iwHH1+tB3szIJ5pjlJY/gzo5N0eilb8h89 nnQAgWDDwKWg2jKX+HpzWYZ5V0qF2QRcvTDHorz+8ceRjInkvasjCwn82cX3ffwkvqt2 RXeG6WsZfZS0UxcFM/Xgp37H0K2w+hplwkcyw= Received: by 10.231.55.2 with SMTP id s2mr7587404ibg.37.1315226617099; Mon, 05 Sep 2011 05:43:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.145.202 with HTTP; Mon, 5 Sep 2011 05:43:17 -0700 (PDT) In-Reply-To: <87sjoci6tu.fsf@mail.jurta.org> References: <87sjoci6tu.fsf@mail.jurta.org> From: Wilfred Hughes Date: Mon, 5 Sep 2011 13:43:17 +0100 Message-ID: Content-Type: multipart/alternative; boundary=000e0cd290604fb4d504ac310fd5 X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) --000e0cd290604fb4d504ac310fd5 Content-Type: text/plain; charset=UTF-8 I built revision 105661, then ran $ src/emacs -Q but I did not get search highlighting with vc-git-grep. File name highlighting works fine. My git version is: $ git --version git version 1.7.6.1 On 5 September 2011 09:28, Juri Linkov wrote: > > Compared with using grep, I note that my search term 'backend' is not > > highlighted. I don't know if that's related. > > git-grep emits "\033[1;31m" escape sequences unlike expected "\033[01;31m" > as GNU Grep does. I fixed this in the Bzr repo, so now search terms can be > highlighted by `vc-git-grep'. Could you please try the fixed version now? > --000e0cd290604fb4d504ac310fd5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I built revision 105661, then ran $ src/emacs -Q but I did not get search h= ighlighting with vc-git-grep. File name highlighting works fine. My git ver= sion is:

$ git --version
git version 1.7.6.1

On 5 September 2011 09:28, Juri Linkov <juri@jurta.org> wrote:
> Compared with using grep, I note that my search term= 'backend' is not
> highlighted. I don't know if that's related.

git-grep emits "\033[1;31m" escape sequences unlike expecte= d "\033[01;31m"
as GNU Grep does. =C2=A0I fixed this in the Bzr repo, so now search terms c= an be
highlighted by `vc-git-grep'. =C2=A0Could you please try the fixed vers= ion now?

--000e0cd290604fb4d504ac310fd5-- From unknown Sat Jun 14 19:32:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2011 09:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Wilfred Hughes Cc: 9408@debbugs.gnu.org Received: via spool by 9408-submit@debbugs.gnu.org id=B9408.131530198124861 (code B ref 9408); Tue, 06 Sep 2011 09:40:02 +0000 Received: (at 9408) by debbugs.gnu.org; 6 Sep 2011 09:39:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0s84-0006Sv-Q0 for submit@debbugs.gnu.org; Tue, 06 Sep 2011 05:39:41 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0s82-0006Si-Ia for 9408@debbugs.gnu.org; Tue, 06 Sep 2011 05:39:39 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 0944E6E8068; Tue, 6 Sep 2011 02:35:52 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id D9E85451C45D; Tue, 6 Sep 2011 02:35:50 -0700 (PDT) From: Juri Linkov Organization: JURTA References: <87sjoci6tu.fsf@mail.jurta.org> Date: Tue, 06 Sep 2011 12:32:54 +0300 In-Reply-To: (Wilfred Hughes's message of "Mon, 5 Sep 2011 13:43:17 +0100") Message-ID: <87bouyj9rt.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > I built revision 105661, then ran $ src/emacs -Q but I did not get search > highlighting with vc-git-grep. File name highlighting works fine. My git > version is: > > $ git --version > git version 1.7.6.1 My git version is 1.7.1 and I get search highlighting when I enable colour for git with: $ git config --global color.ui auto and when `git grep' runs without "--no-color". From unknown Sat Jun 14 19:32:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Resent-From: Wilfred Hughes Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2011 13:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 9408@debbugs.gnu.org Received: via spool by 9408-submit@debbugs.gnu.org id=B9408.131531590522005 (code B ref 9408); Tue, 06 Sep 2011 13:32:01 +0000 Received: (at 9408) by debbugs.gnu.org; 6 Sep 2011 13:31:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0vke-0005ir-OW for submit@debbugs.gnu.org; Tue, 06 Sep 2011 09:31:45 -0400 Received: from mail-yx0-f172.google.com ([209.85.213.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0vkZ-0005ig-2I for 9408@debbugs.gnu.org; Tue, 06 Sep 2011 09:31:41 -0400 Received: by yxj17 with SMTP id 17so2564629yxj.3 for <9408@debbugs.gnu.org>; Tue, 06 Sep 2011 06:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=potatolondon.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=+oEAuDSjs44Q5xy0D4rbhMzxbyCMDvFCJFJGMMPeWGU=; b=gCuhqVqq1T5wnUIjTpW972meBOZO4AjQVrX2WfJjMgDwaoPMhzIYcx5efuOyrXS9i5 wbjFFZQ3jG1XzH7ZKgG2iBV/6CIPRvLQpEKQGIRmSF5wry6HQjcPyMx5uTi1yrUEeG9+ bwN9xB5AqKF7ahbup0W4HPkW5DOnEG70kMul8= Received: by 10.42.168.136 with SMTP id w8mr4747925icy.267.1315315671071; Tue, 06 Sep 2011 06:27:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.145.202 with HTTP; Tue, 6 Sep 2011 06:27:31 -0700 (PDT) In-Reply-To: <87bouyj9rt.fsf@mail.jurta.org> References: <87sjoci6tu.fsf@mail.jurta.org> <87bouyj9rt.fsf@mail.jurta.org> From: Wilfred Hughes Date: Tue, 6 Sep 2011 14:27:31 +0100 Message-ID: Content-Type: multipart/alternative; boundary=90e6ba613854577d4c04ac45cb21 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.0 (----) --90e6ba613854577d4c04ac45cb21 Content-Type: text/plain; charset=UTF-8 Yes, using git grep without --no-color gets exactly the colour codes you describe. But as of revision 105630 (the commit mentioned in message 13), vc-git-grep uses the command "git grep --no-color -n -e -- " which suppresses search term highlighting. Have I missed something? On 6 September 2011 10:32, Juri Linkov wrote: > > I built revision 105661, then ran $ src/emacs -Q but I did not get search > > highlighting with vc-git-grep. File name highlighting works fine. My git > > version is: > > > > $ git --version > > git version 1.7.6.1 > > My git version is 1.7.1 and I get search highlighting when I enable > colour for git with: $ git config --global color.ui auto > and when `git grep' runs without "--no-color". > --90e6ba613854577d4c04ac45cb21 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Yes, using git grep without --no-color gets exactly the colour codes you de= scribe. But as of revision 105630 (the commit mentioned in message 13), vc-= git-grep uses the command "git grep --no-color -n -e <R> -- <= F>" which suppresses search term highlighting. Have I missed someth= ing?

On 6 September 2011 10:32, Juri Linkov <juri@jurta.org> wrote:
> I built revision 105661, then ran $ src/emacs -Q but= I did not get search
> highlighting with vc-git-grep. File name highlighting works fine. My g= it
> version is:
>
> $ git --version
> git version 1.7.6.1

My git version is 1.7.1 and I get search highlighting when I enable colour for git with: $ git config --global color.ui auto
and when `git grep' runs without "--no-color".

--90e6ba613854577d4c04ac45cb21-- From unknown Sat Jun 14 19:32:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2011 13:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Wilfred Hughes Cc: 9408@debbugs.gnu.org Received: via spool by 9408-submit@debbugs.gnu.org id=B9408.131531674625797 (code B ref 9408); Tue, 06 Sep 2011 13:46:01 +0000 Received: (at 9408) by debbugs.gnu.org; 6 Sep 2011 13:45:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0vyD-0006i1-Hc for submit@debbugs.gnu.org; Tue, 06 Sep 2011 09:45:46 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0vyA-0006ht-6f for 9408@debbugs.gnu.org; Tue, 06 Sep 2011 09:45:43 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 1C9E86E8065; Tue, 6 Sep 2011 06:41:54 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id F15B3451C42E; Tue, 6 Sep 2011 06:41:52 -0700 (PDT) From: Juri Linkov Organization: JURTA References: <87sjoci6tu.fsf@mail.jurta.org> <87bouyj9rt.fsf@mail.jurta.org> Date: Tue, 06 Sep 2011 16:40:10 +0300 In-Reply-To: (Wilfred Hughes's message of "Tue, 6 Sep 2011 14:27:31 +0100") Message-ID: <871uvtiybp.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > Yes, using git grep without --no-color gets exactly the colour codes you > describe. But as of revision 105630 (the commit mentioned in message 13), > vc-git-grep uses the command "git grep --no-color -n -e -- " which > suppresses search term highlighting. Have I missed something? You earlier suggested to add "--no-color" to `grep-expand-template'. Do you think it now can be removed because now search terms are highlighted correctly and you have no more problems with hitting RET on them? From unknown Sat Jun 14 19:32:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Resent-From: Wilfred Hughes Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2011 14:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 9408@debbugs.gnu.org Received: via spool by 9408-submit@debbugs.gnu.org id=B9408.131531826830966 (code B ref 9408); Tue, 06 Sep 2011 14:12:01 +0000 Received: (at 9408) by debbugs.gnu.org; 6 Sep 2011 14:11:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0wMl-00083O-Jm for submit@debbugs.gnu.org; Tue, 06 Sep 2011 10:11:07 -0400 Received: from mail-gx0-f172.google.com ([209.85.161.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0wMi-00083F-FZ for 9408@debbugs.gnu.org; Tue, 06 Sep 2011 10:11:06 -0400 Received: by gxk19 with SMTP id 19so3511180gxk.3 for <9408@debbugs.gnu.org>; Tue, 06 Sep 2011 07:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=potatolondon.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=NNUb33aepzHtu1lTGlwsAq2KhrjFCfqrRFacI4Q2BXE=; b=REt7gxsHw1mojXU93t+UXzBdooJYcGWR3zmyzHw9+gFXCokl9kDimy5ZzxKPexa3eZ 9weGg5akB3m/oPkkY9vonso2Hp91l3A/m14giF8CGIQIgW0UNmY3BmyueV2Aq7bHGFZ3 mddinbqcxwh0qdS6EeOHmMOFv0dN4FaZfheds= Received: by 10.42.28.135 with SMTP id n7mr4691201icc.200.1315318036294; Tue, 06 Sep 2011 07:07:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.145.202 with HTTP; Tue, 6 Sep 2011 07:06:45 -0700 (PDT) In-Reply-To: <871uvtiybp.fsf@mail.jurta.org> References: <87sjoci6tu.fsf@mail.jurta.org> <87bouyj9rt.fsf@mail.jurta.org> <871uvtiybp.fsf@mail.jurta.org> From: Wilfred Hughes Date: Tue, 6 Sep 2011 15:06:45 +0100 Message-ID: Content-Type: multipart/alternative; boundary=20cf3042719051ebd604ac46586a X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) --20cf3042719051ebd604ac46586a Content-Type: text/plain; charset=UTF-8 Oh, sorry. Yes, it can be removed and works perfectly. Many thanks. On 6 September 2011 14:40, Juri Linkov wrote: > > Yes, using git grep without --no-color gets exactly the colour codes you > > describe. But as of revision 105630 (the commit mentioned in message 13), > > vc-git-grep uses the command "git grep --no-color -n -e -- " which > > suppresses search term highlighting. Have I missed something? > > You earlier suggested to add "--no-color" to `grep-expand-template'. > Do you think it now can be removed because now search terms are > highlighted correctly and you have no more problems with > hitting RET on them? > --20cf3042719051ebd604ac46586a Content-Type: text/html; charset=UTF-8 Oh, sorry. Yes, it can be removed and works perfectly. Many thanks.

On 6 September 2011 14:40, Juri Linkov <juri@jurta.org> wrote:
> Yes, using git grep without --no-color gets exactly the colour codes you
> describe. But as of revision 105630 (the commit mentioned in message 13),
> vc-git-grep uses the command "git grep --no-color -n -e <R> -- <F>" which
> suppresses search term highlighting. Have I missed something?

You earlier suggested to add "--no-color" to `grep-expand-template'.
Do you think it now can be removed because now search terms are
highlighted correctly and you have no more problems with
hitting RET on them?

--20cf3042719051ebd604ac46586a--