From unknown Fri Jun 13 10:42:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9407: GNUmakefile mode thinks comments need a space before them after colon Resent-From: jidanni@jidanni.org Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Aug 2011 11:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 9407 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 9407@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.131470500032391 (code B ref -1); Tue, 30 Aug 2011 11:50:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Aug 2011 11:50:00 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QyMpK-0008QH-R6 for submit@debbugs.gnu.org; Tue, 30 Aug 2011 07:50:00 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QyMpI-0008Q9-A2 for submit@debbugs.gnu.org; Tue, 30 Aug 2011 07:49:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QyMmG-000113-KV for submit@debbugs.gnu.org; Tue, 30 Aug 2011 07:46:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:51609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyMmG-00010z-J0 for submit@debbugs.gnu.org; Tue, 30 Aug 2011 07:46:48 -0400 Received: from eggs.gnu.org ([140.186.70.92]:56182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyMmF-0007BB-Oc for bug-gnu-emacs@gnu.org; Tue, 30 Aug 2011 07:46:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QyMmE-0000xv-PU for bug-gnu-emacs@gnu.org; Tue, 30 Aug 2011 07:46:47 -0400 Received: from caiajhbdcaib.dreamhost.com ([208.97.132.81]:59203 helo=homiemail-a1.g.dreamhost.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyMmE-0000uZ-Dz for bug-gnu-emacs@gnu.org; Tue, 30 Aug 2011 07:46:46 -0400 Received: from homiemail-a1.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a1.g.dreamhost.com (Postfix) with ESMTP id 1E57034806E for ; Tue, 30 Aug 2011 04:46:42 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=jidanni.org; h=from:to:subject :date:message-id:mime-version:content-type; q=dns; s=jidanni.org ; b=JgAM8hDzDl3aed/Veb0l3dc8RJLp88sobfyCuFSRUHFft7WRsKLWX4wJgTjZ nb43qHZEWm/No2beGDB7TR555B8sIkWVjnjV7KEp72zT86kvFemulJgwaLyVLvt6 pIiuJE6IAIi23oc89L2Iug2Q4gQq8gfJLYlv2v7o22ThDws= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jidanni.org; h=from:to :subject:date:message-id:mime-version:content-type; s= jidanni.org; bh=EHuwI961Rv3HUBMGqd/BbmXD6QE=; b=KJ9KA9B1oQOQCYjQ 4KV24J6yILUEC5qjDioKHgId2ruKCK+V2wqIYsukDzUDxgGOojvGNGiaBzDUJb2w JK3CXgfCawLL4Iz+SQgXgtnZ27711Y5hdgwdZmrMpb5tuK+dEORvdgu+kE4mfDTQ O/TmR6iTDA4+Hfws+qQ3ol/RouI= Received: from jidanni.org (218-163-7-118.dynamic.hinet.net [218.163.7.118]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by homiemail-a1.g.dreamhost.com (Postfix) with ESMTPSA id CC9A434806B for ; Tue, 30 Aug 2011 04:46:41 -0700 (PDT) From: jidanni@jidanni.org Date: Tue, 30 Aug 2011 18:32:31 +0800 Message-ID: <87y5ybdwao.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.4 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.4 (-----) $ cat makefile m: #this is a comment, which we note is in proper comment color n:#this is also a comment, which we note is NOT in proper comment color $ emacs -Q makefile From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 11:40:12 2016 Received: (at control) by debbugs.gnu.org; 6 Sep 2016 15:40:12 +0000 Received: from localhost ([127.0.0.1]:51525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhITo-0000rS-Gl for submit@debbugs.gnu.org; Tue, 06 Sep 2016 11:40:12 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:35940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhITe-0000q0-2h for control@debbugs.gnu.org; Tue, 06 Sep 2016 11:40:02 -0400 Received: by mail-oi0-f54.google.com with SMTP id w78so106180394oie.3 for ; Tue, 06 Sep 2016 08:39:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=uFq3sEIRYVy1LtsT6ht9W2TD5dNWUpG/3v2D5OTJf6c=; b=IJcEH4DKE3fYVDAQKbaOPpkzTDO559t98Bjm9PT5adic3CSqNan06XTYUF2XrPli55 CMKLXPgesf50uLX5ovpGFonHREW2HvZWt5H853zHUhq4DtjtnfpGPyhrx1q3dcGkhWKV 75MWVOwVmFSDr7eCvyATxUE2DleIB+FOJ+/OiqJWR8Ca97pPlcotSgk01IJSzdlT1wKt ascWEHYBB5SxHE1I98Rw+NUQs1Juc3sAsNMNIsVIoZLBOJFzEot1U14KbHJztFhug2d3 tyCWw27v+GBT5kkdQSCuh49qLsJFdFTd0K7qpediQDdH8VqUf2K4p+X5mtqVZbaG3OtX Hf+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=uFq3sEIRYVy1LtsT6ht9W2TD5dNWUpG/3v2D5OTJf6c=; b=Iuhxldl5eoF5ndYr8NcEPR3MNMq0ZXn7its/PTTNEFnYgANs5Z6C4wwKVAk6Wl2QpN 18UIJZ0b/LZit1UN7gTXLmizNh/G8AomF2L+vTJCEIrV/8aPUKoWQ/oo5dLPlJC1xwEk 4XKOcGw/POf0lIoCEBF36vuuLrdsm72BDRa+C39ZBFihgB15MGYUrPirYazvbFb9lN3b /YipGBhY7h/V3fwZ2u29b0+CJ69bXlIpVXaJMJ1GNNCyz124v1nY5KuDYQcZF9Cr08lJ vrDLAO9gUxVeFlFQlyMzW3ZdEF+taCUnHvHzBKp/W0aGh7iorm1eHmw3+v9S0o65ueRB 4Bng== X-Gm-Message-State: AE9vXwOTu0HLe2PLGWp/Eu16x4vq0Qv46X8+trzslCSkMQzX/O8JB7b2q9GxLSOkkFEQkTcIL7/mg2y7xuRIUA== X-Received: by 10.157.8.118 with SMTP id 109mr35065763oty.17.1473176391389; Tue, 06 Sep 2016 08:39:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.7.195 with HTTP; Tue, 6 Sep 2016 08:39:51 -0700 (PDT) In-Reply-To: <87eg4xm4gp.fsf@jidanni.org> References: <87inu9m6jh.fsf@jidanni.org> <87eg4xm4gp.fsf@jidanni.org> From: Noam Postavsky Date: Tue, 6 Sep 2016 11:39:51 -0400 X-Google-Sender-Auth: T-XByN45vSL-eSuRu-_YOF-eipM Message-ID: Subject: Re: bug#24380: GNUmakefile mode gets wrong colors for comment To: =?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Bcc: control@debbugs.gnu.org X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control Cc: 24380@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) forcemerge 9407 24380 quit On Tue, Sep 6, 2016 at 11:29 AM, =E7=A9=8D=E4=B8=B9=E5=B0=BC Dan Jacobson <= jidanni@jidanni.org> wrote: > I think you need to Cc control, > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D9407 doesn't show the merg= e. Oops, right, I left it off. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 03 12:14:30 2018 Received: (at control) by debbugs.gnu.org; 3 Nov 2018 16:14:30 +0000 Received: from localhost ([127.0.0.1]:33109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gIyZC-0007Y1-6j for submit@debbugs.gnu.org; Sat, 03 Nov 2018 12:14:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gIyZA-0007Xp-N6 for control@debbugs.gnu.org; Sat, 03 Nov 2018 12:14:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gIyYw-0006Tr-Br for control@debbugs.gnu.org; Sat, 03 Nov 2018 12:14:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41752) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gIyYq-0006BZ-Tk for control@debbugs.gnu.org; Sat, 03 Nov 2018 12:14:09 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1gIyYq-00038v-Pn for control@debbugs.gnu.org; Sat, 03 Nov 2018 12:14:08 -0400 Subject: control message for bug 33247 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Sat, 03 Nov 2018 12:14:08 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) merge 9407 33247 From unknown Fri Jun 13 10:42:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9407: GNUmakefile mode thinks comments need a space before them after colon References: <87y5ybdwao.fsf@jidanni.org> In-Reply-To: <87y5ybdwao.fsf@jidanni.org> Resent-From: Matt Armstrong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Feb 2021 08:45:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9407 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 9407@debbugs.gnu.org Received: via spool by 9407-submit@debbugs.gnu.org id=B9407.16126874915597 (code B ref 9407); Sun, 07 Feb 2021 08:45:03 +0000 Received: (at 9407) by debbugs.gnu.org; 7 Feb 2021 08:44:51 +0000 Received: from localhost ([127.0.0.1]:46847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8fgZ-0001S7-AL for submit@debbugs.gnu.org; Sun, 07 Feb 2021 03:44:51 -0500 Received: from mail-yb1-f173.google.com ([209.85.219.173]:33662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8WQ3-0003pP-8J for 9407@debbugs.gnu.org; Sat, 06 Feb 2021 17:51:11 -0500 Received: by mail-yb1-f173.google.com with SMTP id m76so10730829ybf.0 for <9407@debbugs.gnu.org>; Sat, 06 Feb 2021 14:51:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=OSjR0nj16+pjoRE0rEQDk5VGGwxqlkiGGgsm/UmP/mE=; b=YZ+iIdO146EjgjkwvyuctzGs+WcQiljK9hKk4GeUTVWs93wVTuVOO85uc1KS81VrNf iPX5BCQYq2jtk5VMJSWjgGU8TCEtJ2Ng0zoVjrEJabLz6SpGtCMlGetDcyEI6ElUMh2G r2rP52axPf5E9+cdWdTtdPOXCB0HVNHlTJviZlQYt6xvW5Q8rq9XpjA6aJovDosxxmSh 7V8pJnfVb5xkHRGBHIh0Csu+1U7ZYulUIGdWxRn/5USLuv5f77YguagqL/Knts6Za11f XIF9yAdoQ+K3/ubg2a0ovUaV+ljfX6vgdH8ZqQLEe8svGZ2g+h5VWbQfkfTbW23T6ygy BEJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=OSjR0nj16+pjoRE0rEQDk5VGGwxqlkiGGgsm/UmP/mE=; b=OnNUKRW5JnPa0WtV+8FT4jAOnOTJrN45Zg3hq98BGyBN6s7NFJ5Zfbu34PUo+NB1aF Q3FfTV2/RhUeQoun05h8zN1j8UnH0hHFCfG/RYCIAENqQCQYPnVPVQfwnr0eu/TNy1No HjRIadMGVfheSGkkHMe1iVnY62V9I2ygqAG3Sd+lk9EjUVh3Edd83Hyh3bLIxGc+G0/b azxtQ6GAGGUZ8IhjW5m7JPIfhVeC/gYYeIlFE+eY5zIOvW7jCP/fqhSPWV5LiKIEggjg qwQu5EhxJl6wVZv97NcOw55KuigrA8FsEwwafXrtkhWbh47abdmHAZT50RlgcQu+DHGh /BlQ== X-Gm-Message-State: AOAM533sUVuFipPFY+rOtXKJyRvqV9j3DPX2I7yeLW63RHo5FwHOzOLo 5QPGFvL9Nsi1iT22wfHyLT+qeleXaRymb6ChPWYA5vsf4nRQXw== X-Google-Smtp-Source: ABdhPJzuu+/YpLoOcakqinQedgg7TTGQ/iMxDiURPPZzZEOUun7pEVWPyIriJzO3PsG9DsjCMjDv78fHK6dKkoXRkTQ= X-Received: by 2002:a25:f309:: with SMTP id c9mr14957138ybs.379.1612651865472; Sat, 06 Feb 2021 14:51:05 -0800 (PST) MIME-Version: 1.0 From: Matt Armstrong Date: Sat, 6 Feb 2021 14:50:54 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Sun, 07 Feb 2021 03:44:46 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I looked at this bug a bit over the past few days and found it to be a surprisingly subtle bug. So subtle, in fact, that I am inclined to give up trying to fix it, at least without removing make-mode.el features. I'll explain why. Despite bug#9407 being the main bug, some interesting discussion happened in bug#33247, as well as in some of the other bugs filed by Dan Jacobson for similar issues. In bug#9407 Stefan said that make-mode.el aims to fontify shell comments in make commands, which is why the mode copied some of the shell mode regex code to recognize them. In the same bug, Alan suggested adding the colon `:' to `makefile-syntax-propertize-function' in make-mode.el to fix this bug. First, Alan's suggested fix is insufficient, because it trades one problem for another. In the example below, it will correctly highlight the first comment below, but it will also highlight "not a comment" as a comment, when in fact it isn't. target:#This is a comment echo This is:#not a comment In other words, today Emacs highlights comments only if they're valid Bourne shell comments, despite only the command lines being written in shell. This heuristic seems to be correct for almost everything in a Makefile, but edge cases like this bug arise. Two things send me running for the hills and giving up: - GNU make lets you change the shell used for commands. It need not be a Bourne shell at all. It could be as exotic as Scheme shell! Yet make-mode.el attempts to highlight a rule's commands as if they were shell code (there is logic in there to support perl as well). - GNU make lets you change the leading character used for command lines, so it need not even be a TAB character. The first point is the biggie. Given that the command language, at least in a GNU makefile, is not fixed, I might opt to strip out all highlighting of the underlying command language, and instead focus on parsing command text in the limited way that make itself does, and highlight the rest as, perhaps, a string. This might fix a number of separate issues as reported by Dan, some of which seem to relate to this. Just a thought.