From unknown Mon Aug 18 14:15:44 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#9400 <9400@debbugs.gnu.org> To: bug#9400 <9400@debbugs.gnu.org> Subject: Status: parallel-tests doesn't support `-' character in test extensions Reply-To: bug#9400 <9400@debbugs.gnu.org> Date: Mon, 18 Aug 2025 21:15:44 +0000 retitle 9400 parallel-tests doesn't support `-' character in test extensions reassign 9400 automake submitter 9400 Stefano Lattarini severity 9400 normal tag 9400 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 29 08:02:37 2011 Received: (at submit) by debbugs.gnu.org; 29 Aug 2011 12:02:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qy0Y1-0004Ao-DK for submit@debbugs.gnu.org; Mon, 29 Aug 2011 08:02:37 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qy0Xy-0004Ah-Qc for submit@debbugs.gnu.org; Mon, 29 Aug 2011 08:02:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qy0V2-0005zn-KL for submit@debbugs.gnu.org; Mon, 29 Aug 2011 07:59:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,RCVD_IN_DNSWL_LOW,T_DKIM_INVALID,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:48342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qy0V2-0005zi-Io for submit@debbugs.gnu.org; Mon, 29 Aug 2011 07:59:32 -0400 Received: from eggs.gnu.org ([140.186.70.92]:37697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qy0V1-0003qX-IV for bug-automake@gnu.org; Mon, 29 Aug 2011 07:59:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qy0V0-0005zP-Ie for bug-automake@gnu.org; Mon, 29 Aug 2011 07:59:31 -0400 Received: from mail-ew0-f41.google.com ([209.85.215.41]:49622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qy0V0-0005zG-7F for bug-automake@gnu.org; Mon, 29 Aug 2011 07:59:30 -0400 Received: by ewy9 with SMTP id 9so2648205ewy.0 for ; Mon, 29 Aug 2011 04:59:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:x-kmail-markup:mime-version :content-type:content-transfer-encoding:message-id; bh=NBCFQ8wNWTeq0naYu/kbEGyBBetCssTkMp95WwTHGNg=; b=kQAlaXnFLAeuLEya1wY0gYPlwOrT6rsn1NsY3r3OkjCdmEtfMaTavmioxh0Mdov6lw w76b8vIWX9QgVQyTcDN60zeENBjz31iHizjKTBxQclEgs03rJ7RXG7jhf5qvWb+ITSP+ pUfvfFs+dbxvpfyz1iXCrNmg/EB1gOm/gAHGY= Received: by 10.14.13.129 with SMTP id b1mr1460457eeb.77.1314619168607; Mon, 29 Aug 2011 04:59:28 -0700 (PDT) Received: from bigio.localnet (host121-95-dynamic.10-79-r.retail.telecomitalia.it [79.10.95.121]) by mx.google.com with ESMTPS id v54sm2927127eeh.16.2011.08.29.04.59.25 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 29 Aug 2011 04:59:27 -0700 (PDT) From: Stefano Lattarini To: bug-automake@gnu.org Subject: parallel-tests doesn't support `-' character in test extensions Date: Mon, 29 Aug 2011 13:59:09 +0200 User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; ) X-KMail-Markup: true MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="Boundary-01=_N83WOtpbNRoqS8T" Content-Transfer-Encoding: 7bit Message-Id: <201108291359.09946.stefano.lattarini@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) --Boundary-01=_N83WOtpbNRoqS8T Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit I catched this while working some more on the Automake testsuite: $ cat Makefile.am TEST_EXTENSIONS = .t-1 TESTS = foo.t-1 $ cat configure.ac AC_INIT([foo], [1.0]) AM_INIT_AUTOMAKE([foreign -Wall parallel-tests]) AC_CONFIG_FILES([Makefile]) AC_OUTPUT $ aclocal $ autoconf $ : > install-sh $ : > missing $ automake automake: bad characters in variable name `T-1_LOG_COMPILE' automake: T-1_LOG_COMPILER: non-POSIX variable name automake: AM_T-1_LOG_FLAGS: non-POSIX variable name automake: T-1_LOG_FLAGS: non-POSIX variable name Do you think it would be worthwhile to lift this limitation, by automatically transliterating `-' (and maybe other non-alphabetic characters) to `_'? Or should we simply give an error when something in $(TEST_EXTENSIONS) contains non-alphabetic characters? Regards, Stefano --Boundary-01=_N83WOtpbNRoqS8T Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

I catched this while working some more on the Automake testsuite:


$ cat Makefile.am

TEST_EXTENSIONS = .t-1

TESTS = foo.t-1

$ cat configure.ac

AC_INIT([foo], [1.0])

AM_INIT_AUTOMAKE([foreign -Wall parallel-tests])

AC_CONFIG_FILES([Makefile])

AC_OUTPUT

$ aclocal

$ autoconf

$ : > install-sh

$ : > missing

$ automake

automake: bad characters in variable name `T-1_LOG_COMPILE'

automake: T-1_LOG_COMPILER: non-POSIX variable name

automake: AM_T-1_LOG_FLAGS: non-POSIX variable name

automake: T-1_LOG_FLAGS: non-POSIX variable name


Do you think it would be worthwhile to lift this limitation, by

automatically transliterating `-' (and maybe other non-alphabetic

characters) to `_'? Or should we simply give an error when something

in $(TEST_EXTENSIONS) contains non-alphabetic characters?


Regards,

Stefano

--Boundary-01=_N83WOtpbNRoqS8T-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 01 16:13:53 2011 Received: (at submit) by debbugs.gnu.org; 1 Oct 2011 20:13:53 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RA5wX-0000AG-24 for submit@debbugs.gnu.org; Sat, 01 Oct 2011 16:13:53 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RA5wI-00009n-Bw for submit@debbugs.gnu.org; Sat, 01 Oct 2011 16:13:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RA5v5-0004bd-2H for submit@debbugs.gnu.org; Sat, 01 Oct 2011 16:12:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID,T_TO_NO_BRKTS_FREEMAIL,URIBL_BLACK autolearn=no version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:35983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RA5v5-0004bZ-0j for submit@debbugs.gnu.org; Sat, 01 Oct 2011 16:12:23 -0400 Received: from eggs.gnu.org ([140.186.70.92]:40728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RA5v3-0004n4-Az for bug-automake@gnu.org; Sat, 01 Oct 2011 16:12:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RA5v1-0004bH-B1 for bug-automake@gnu.org; Sat, 01 Oct 2011 16:12:21 -0400 Received: from mail-bw0-f41.google.com ([209.85.214.41]:44537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RA5v0-0004bB-VQ for bug-automake@gnu.org; Sat, 01 Oct 2011 16:12:19 -0400 Received: by bkbzs2 with SMTP id zs2so3743175bkb.0 for ; Sat, 01 Oct 2011 13:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:message-id; bh=ll62TmwfSSEC8Vvri1r0okeoINV88Ryd2ZzOFDmoK8I=; b=TsXxv8GjhWm/khtME8e77c2r9cdi1V2uN5nZ1Eko2QJNdEbMo4K+viQIuO3jUGtH1c B1QnHxY/xvO8Z8nbzAHuIeoYpBhoZD1/p2WXYKI+tXSHaKAfDkY4iP5dX5pUYQM4ZEg2 Fn5YBhDBZJokXnZ5Smu6FGo1e3qowL3LNdpuA= Received: by 10.223.31.89 with SMTP id x25mr11847411fac.52.1317499936704; Sat, 01 Oct 2011 13:12:16 -0700 (PDT) Received: from bigio.localnet (host164-36-dynamic.60-82-r.retail.telecomitalia.it. [82.60.36.164]) by mx.google.com with ESMTPS id m26sm13069556fac.6.2011.10.01.13.12.13 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 01 Oct 2011 13:12:14 -0700 (PDT) From: Stefano Lattarini To: bug-automake@gnu.org Subject: Re: bug#9400: parallel-tests doesn't support `-' character in test extensions Date: Sat, 1 Oct 2011 22:12:04 +0200 User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; ) References: <201108291359.09946.stefano.lattarini@gmail.com> In-Reply-To: <201108291359.09946.stefano.lattarini@gmail.com> MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_VQ3hOkPfoQG47SP" Message-Id: <201110012212.05437.stefano.lattarini@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit Cc: 9400@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.1 (----) --Boundary-00=_VQ3hOkPfoQG47SP Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Monday 29 August 2011, Stefano Lattarini wrote: > I catched this while working some more on the Automake testsuite: > > $ cat Makefile.am > TEST_EXTENSIONS = .t-1 > TESTS = foo.t-1 > $ cat configure.ac > AC_INIT([foo], [1.0]) > AM_INIT_AUTOMAKE([foreign -Wall parallel-tests]) > AC_CONFIG_FILES([Makefile]) > AC_OUTPUT > $ aclocal > $ autoconf > $ : > install-sh > $ : > missing > $ automake > automake: bad characters in variable name `T-1_LOG_COMPILE' > automake: T-1_LOG_COMPILER: non-POSIX variable name > automake: AM_T-1_LOG_FLAGS: non-POSIX variable name > automake: T-1_LOG_FLAGS: non-POSIX variable name > > Do you think it would be worthwhile to lift this limitation, by > automatically transliterating `-' (and maybe other non-alphabetic > characters) to `_'? Or should we simply give an error when something > in $(TEST_EXTENSIONS) contains non-alphabetic characters? > > Regards, > Stefano > For the moment, I've decided to take the easiest route, documenting the limitation and correcting the diagnostic. Such restriction could easily be lifted at a later time, with no backward-compatibility issues. Attached is the patch I'll push in a couple of days if there is no objection. As usual, reviews are welcome. Regards, Stefano --Boundary-00=_VQ3hOkPfoQG47SP Content-Type: text/x-patch; charset="utf-8"; name="0001-parallel-tests-automake-error-our-on-invalid-TEST_EX.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="0001-parallel-tests-automake-error-our-on-invalid-TEST_EX.patch" =46rom 90bea64bc5023be075b63bf7c651d0242f35a83c Mon Sep 17 00:00:00 2001 Message-Id: <90bea64bc5023be075b63bf7c651d0242f35a83c.1317499108.git.stefan= o.lattarini@gmail.com> =46rom: Stefano Lattarini Date: Sat, 1 Oct 2011 21:31:07 +0200 Subject: [PATCH] parallel-tests: automake error our on invalid TEST_EXTENSI= ONS This change fixes automake bug#9400. * automake.in (handle_tests): Bail out if a suffix specified in TEST_EXTENSIONS would produce an invalid `xxx_LOG_COMPILER' variable or an invalid suffix rule. Before this change, automake would have issued a confusing error messages (about invalid or non-POSIX variables being defined), and in some situations would have even produced a broken `Makefile.in' file. ($TEST_EXTENSION_PATTERN): New helper variable. * doc/automake.texi (Simple Tests using parallel-tests): Document the limitations on TEST_EXTENSIONS explicitly. * NEWS: Update. * tests/test-extensions.test: New test. * tests/Makefile.am (TESTS): Update. =2D-- ChangeLog | 17 ++++++++++ NEWS | 6 +++ automake.in | 12 ++++++- doc/automake.texi | 12 +++++-- tests/Makefile.am | 1 + tests/Makefile.in | 1 + tests/test-extensions.test | 73 ++++++++++++++++++++++++++++++++++++++++= ++++ 7 files changed, 118 insertions(+), 4 deletions(-) create mode 100755 tests/test-extensions.test diff --git a/ChangeLog b/ChangeLog index 47aee92..e52a275 100644 =2D-- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,20 @@ +2011-10-01 Stefano Lattarini + + parallel-tests: automake error our on invalid TEST_EXTENSIONS + This change fixes automake bug#9400. + * automake.in (handle_tests): Bail out if a suffix specified in + TEST_EXTENSIONS would produce an invalid `xxx_LOG_COMPILER' + variable or an invalid suffix rule. Before this change, automake + would have issued a confusing error messages (about invalid or + non-POSIX variables being defined), and in some situations would + have even produced a broken `Makefile.in' file. + ($TEST_EXTENSION_PATTERN): New helper variable. + * doc/automake.texi (Simple Tests using parallel-tests): Document + the limitations on TEST_EXTENSIONS explicitly. + * NEWS: Update. + * tests/test-extensions.test: New test. + * tests/Makefile.am (TESTS): Update. + 2011-09-22 Stefano Lattarini =20 tests: fix tests on aclocal search path precedences diff --git a/NEWS b/NEWS index b696977..fe78238 100644 =2D-- a/NEWS +++ b/NEWS @@ -49,6 +49,12 @@ Bugs fixed in 1.11.0a: does not report spurious successes when used with concurrent FreeBSD make (e.g., "make check -j3"). =20 + - Automake now explicitly rejects invalid entries in TEST_EXTENSIONS when + the parallel-tests diver is in use, instead of issuing confusing and + apparently unrelated error messages (about "non-POSIX variable name" + or "bad characters in variable name"), or even, in some situations, + producing broken `Makefile.in' files. + - The `silent-rules' option now also silences all compile rules if depen= dency tracking is disabled. Also, when `silent-rules' is not used, the outp= ut from `make' does not contain spurious extra lines with only a backslash in = them diff --git a/automake.in b/automake.in index 215881b..a60bc9f 100755 =2D-- a/automake.in +++ b/automake.in @@ -213,6 +213,8 @@ my $DASH_D_PATTERN =3D "(^|\\s)-d(\\s|\$)"; # Directories installed during 'install-exec' phase. my $EXEC_DIR_PATTERN =3D '^(?:bin|sbin|libexec|sysconf|localstate|lib|pkglib|.*exec.*)' . "\$"; +# Suffixes that can appear in TEST_EXTENSIONS (parallel-tests support). +my $TEST_EXTENSION_PATTERN =3D '^(\.[a-zA-Z_][a-zA-Z0-9_]*|@[a-zA-Z0-9_]+@= )$'; =20 # Values for AC_CANONICAL_* use constant AC_CANONICAL_BUILD =3D> 1; @@ -4971,7 +4973,15 @@ sub handle_tests } define_variable ('TEST_EXTENSIONS', $suff, INTERNAL); # FIXME: this mishandles conditions. =2D my @test_suffixes =3D (var 'TEST_EXTENSIONS')->value_as_list_recursiv= e; + my $var =3D rvar 'TEST_EXTENSIONS'; + my @test_suffixes =3D $var->value_as_list_recursive; + if ((my @invalid_test_suffixes =3D + grep { !/$TEST_EXTENSION_PATTERN/o } @test_suffixes) > 0) + { + error $var->rdef (TRUE)->location, + "invalid test extensions: @invalid_test_suffixes"; + } + @test_suffixes =3D grep { /$TEST_EXTENSION_PATTERN/o } @test_suf= fixes; if ($handle_exeext) { unshift (@test_suffixes, $at_exeext) diff --git a/doc/automake.texi b/doc/automake.texi index a8233dd..875e191 100644 =2D-- a/doc/automake.texi +++ b/doc/automake.texi @@ -8808,9 +8808,15 @@ Each log file is created when the corresponding test= has completed. The set of log files is listed in the read-only variable @code{TEST_LOGS}, and defaults to @code{TESTS}, with the executable extension if any (@pxref{EXEEXT}), as well as any suffix listed in =2D@code{TEST_EXTENSIONS} removed, and @file{.log} appended. =2D@code{TEST_EXTENSIONS} defaults to @file{.test}. Results are undefined =2Dif a test file name ends in several concatenated suffixes. +@code{TEST_EXTENSIONS} removed, and @file{.log} appended. Results +are undefined if a test file name ends in several concatenated suffixes. +@code{TEST_EXTENSIONS} defaults to @file{.test}; it can be overridden by +the user, in which case any extension listed in it must be constituted +by a dot, followed by a non-digit alphabetic character, followed by any +number of alphabetic characters. +@c Keep in sync with test-extensions.test. +For example, @samp{.sh}, @samp{.T} and @samp{.t1} are valid extensions, +while @samp{.x-y}, @samp{.6c} and @samp{.t.1} are not. =20 @vindex _LOG_COMPILE @vindex _LOG_COMPILER diff --git a/tests/Makefile.am b/tests/Makefile.am index 1d258c9..3f9fc08 100644 =2D-- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -628,6 +628,7 @@ parallel-tests-log-override-1.test \ parallel-tests-log-override-2.test \ parallel-tests-log-override-recheck.test \ parallel-tests-log-compiler-example.test \ +test-extensions.test \ parse.test \ percent.test \ percent2.test \ diff --git a/tests/Makefile.in b/tests/Makefile.in index 7e9bc20..2e7f39f 100644 =2D-- a/tests/Makefile.in +++ b/tests/Makefile.in @@ -906,6 +906,7 @@ parallel-tests-log-override-1.test \ parallel-tests-log-override-2.test \ parallel-tests-log-override-recheck.test \ parallel-tests-log-compiler-example.test \ +test-extensions.test \ parse.test \ percent.test \ percent2.test \ diff --git a/tests/test-extensions.test b/tests/test-extensions.test new file mode 100755 index 0000000..1d5872c =2D-- /dev/null +++ b/tests/test-extensions.test @@ -0,0 +1,73 @@ +#! /bin/sh +# Copyright (C) 2011 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Make sure that Automake diagnose invalid entries in TEST_EXTENSIONS, +# and do not diagnose valid (albeit more unusual) ones. +# See automake bug#9400. + +parallel_tests=3Dyes +. ./defs || Exit 1 + +set -e + +cat >> configure.in <<'END' +AC_SUBST([ext], [".e"]) +AC_OUTPUT +END + +$ACLOCAL +$AUTOCONF + +cat > Makefile.am << 'END' +TESTS =3D +TEST_EXTENSIONS =3D .sh .T .t1 ._foo .BAR .x_Y_z ._ @ext@ +END + +$AUTOMAKE + +$EGREP -i 'log|ext' Makefile.in # For debugging. + +for lc in sh T t1 _foo BAR x_Y_z _; do + uc=3D`echo $lc | tr '[a-z]' '[A-Z]'` + $FGREP "\$(${uc}_LOG_COMPILER)" Makefile.in + grep "^${uc}_LOG_COMPILE =3D" Makefile.in + grep "^\.${lc}\.log:" Makefile.in +done +grep "^@ext@\.log:" Makefile.in + +# The produced Makefile is not broken. +./configure +$MAKE all check + +cat > Makefile.am << 'END' +TESTS =3D foo.test bar.sh +TEST_EXTENSIONS =3D .test mu .x-y a-b .t.1 .sh .6c .0 .11 .@ .t33 .a=3Db _= &_ +END + +AUTOMAKE_fails +for suf in mu .x-y a-b .t.1 .6c .0 .11 '.@' '.a=3Db' '_&_'; do + suf2=3D`printf '%s\n' "$suf" | sed -e 's/\./\\./'` + $EGREP "^Makefile\.am:2:.*invalid test extension.* $suf2( |$)" stderr +done + +# Verify that we accept valid suffixes, even if intermixed with +# invalid ones. +$EGREP '\.(sh|test|t33)' stderr && Exit 1 + +# Verify that we don't try to handle invalid suffixes. +$EGREP '(LOG_COMPILER|non-POSIX var|bad character)' stderr && Exit 1 + +: =2D-=20 1.7.2.3 --Boundary-00=_VQ3hOkPfoQG47SP-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 06 04:57:19 2011 Received: (at submit) by debbugs.gnu.org; 6 Oct 2011 08:57:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RBjlX-0007l9-2q for submit@debbugs.gnu.org; Thu, 06 Oct 2011 04:57:19 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RBjlS-0007kb-0k for submit@debbugs.gnu.org; Thu, 06 Oct 2011 04:57:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RBjlE-0003eR-D2 for submit@debbugs.gnu.org; Thu, 06 Oct 2011 04:57:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:48334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBjlE-0003eI-BN for submit@debbugs.gnu.org; Thu, 06 Oct 2011 04:57:00 -0400 Received: from eggs.gnu.org ([140.186.70.92]:39058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBjlD-0001IY-9L for bug-automake@gnu.org; Thu, 06 Oct 2011 04:57:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RBjlB-0003dl-Ju for bug-automake@gnu.org; Thu, 06 Oct 2011 04:56:59 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:41964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBjlB-0003dX-Eb; Thu, 06 Oct 2011 04:56:57 -0400 Received: by wyf22 with SMTP id 22so3031436wyf.0 for ; Thu, 06 Oct 2011 01:56:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; bh=6xshj4HdIUcRlzsLTuBcRcmYdIdG0QozeOcbBLVSNWg=; b=C7hq3im2WwWCeiRoqZIgh8O5RR4+viPz/cOnZNQ8gvTBfZCzP6/TiDymTV47o/N248 FWR6qipPPQS0VyBWhERgzWzMXHoLiTDRffmxjPNKGtpBkYpwdMp6qzODByMMgcN/AZJs dhC9J241SBpAqvBfOVc2A2mlZyPh4csfdSMhs= Received: by 10.227.195.208 with SMTP id ed16mr636037wbb.78.1317891391038; Thu, 06 Oct 2011 01:56:31 -0700 (PDT) Received: from bigio.localnet (host113-62-dynamic.21-87-r.retail.telecomitalia.it. [87.21.62.113]) by mx.google.com with ESMTPS id j18sm9035589wbo.6.2011.10.06.01.56.27 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 06 Oct 2011 01:56:27 -0700 (PDT) From: Stefano Lattarini To: bug-automake@gnu.org Subject: Re: bug#9400: parallel-tests doesn't support `-' character in test extensions Date: Thu, 6 Oct 2011 10:56:18 +0200 User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; ) References: <201108291359.09946.stefano.lattarini@gmail.com> <201110012212.05437.stefano.lattarini@gmail.com> In-Reply-To: <201110012212.05437.stefano.lattarini@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201110061056.18760.stefano.lattarini@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: submit Cc: 9400@debbugs.gnu.org, automake-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) tags 9400 patch close 9400 thanks Reference: On Saturday 01 October 2011, Stefano Lattarini wrote: > For the moment, I've decided to take the easiest route, documenting the > limitation and correcting the diagnostic. Such restriction could easily > be lifted at a later time, with no backward-compatibility issues. > > Attached is the patch I'll push in a couple of days if there is no > objection. As usual, reviews are welcome. > I've pushed this patch now, and I'm closing this bug report. Regards, Stefano From unknown Mon Aug 18 14:15:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 03 Nov 2011 11:24:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator