From unknown Sat Jun 21 05:17:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9363: display-battery-mode Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Aug 2011 18:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 9363 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 9363@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.131420993532008 (code B ref -1); Wed, 24 Aug 2011 18:19:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Aug 2011 18:18:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QwI2R-0008KD-Je for submit@debbugs.gnu.org; Wed, 24 Aug 2011 14:18:55 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QwI2P-0008K6-DB for submit@debbugs.gnu.org; Wed, 24 Aug 2011 14:18:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QwHzt-0007vn-SC for submit@debbugs.gnu.org; Wed, 24 Aug 2011 14:16:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:41165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwHzt-0007vg-Qi for submit@debbugs.gnu.org; Wed, 24 Aug 2011 14:16:17 -0400 Received: from eggs.gnu.org ([140.186.70.92]:51714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwHzs-0007UT-NK for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2011 14:16:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QwHzr-0007vO-MC for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2011 14:16:16 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]:54524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwHzr-0007vB-Br for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2011 14:16:15 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 6097E6E80BB for ; Wed, 24 Aug 2011 11:16:14 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id BFD79451C28D for ; Wed, 24 Aug 2011 11:16:13 -0700 (PDT) From: Juri Linkov Organization: JURTA Date: Wed, 24 Aug 2011 21:12:08 +0300 Message-ID: <874o16el1j.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.6 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) When ACPI is turned off with `acpi=off' after booting the Linux kernel `M-x display-battery-mode RET' fails with: Debugger entered--Lisp error: (wrong-type-argument stringp nil) read-from-string(nil) battery-update() display-battery-mode(toggle) call-interactively(display-battery-mode t nil) execute-extended-command(nil) call-interactively(execute-extended-command nil nil) whereas `M-x battery RET' displays a polite message "Battery status not available". This patch fixes `display-battery-mode' to display the same message when `battery-status-function' is nil. I don't know if it's desirable to force turning off this mode and to reset the value of `display-battery-mode' to nil in this case. But at least, the message is informative with this patch: === modified file 'lisp/battery.el' --- lisp/battery.el 2011-06-27 08:04:55 +0000 +++ lisp/battery.el 2011-08-24 18:11:15 +0000 @@ -173,13 +173,15 @@ (define-minor-mode display-battery-mode (setq battery-mode-line-string "") (or global-mode-string (setq global-mode-string '(""))) (and battery-update-timer (cancel-timer battery-update-timer)) - (if (not display-battery-mode) - (setq global-mode-string - (delq 'battery-mode-line-string global-mode-string)) - (add-to-list 'global-mode-string 'battery-mode-line-string t) - (setq battery-update-timer (run-at-time nil battery-update-interval - 'battery-update-handler)) - (battery-update))) + (if (and battery-status-function battery-mode-line-format) + (if (not display-battery-mode) + (setq global-mode-string + (delq 'battery-mode-line-string global-mode-string)) + (add-to-list 'global-mode-string 'battery-mode-line-string t) + (setq battery-update-timer (run-at-time nil battery-update-interval + 'battery-update-handler)) + (battery-update)) + (message "Battery status not available"))) (defun battery-update-handler () (battery-update) From unknown Sat Jun 21 05:17:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9363: display-battery-mode Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Aug 2011 13:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9363 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: 9363@debbugs.gnu.org Received: via spool by 9363-submit@debbugs.gnu.org id=B9363.131427958911150 (code B ref 9363); Thu, 25 Aug 2011 13:40:02 +0000 Received: (at 9363) by debbugs.gnu.org; 25 Aug 2011 13:39:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qwa9s-0002tl-BW for submit@debbugs.gnu.org; Thu, 25 Aug 2011 09:39:49 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qwa9q-0002tc-1W for 9363@debbugs.gnu.org; Thu, 25 Aug 2011 09:39:46 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAHxOVk5MCpTr/2dsb2JhbABCqAB4gUABAQQBViMFCws0EhQYDSSIBbsahkwEn3iEOA X-IronPort-AV: E=Sophos;i="4.68,280,1312171200"; d="scan'208";a="132760167" Received: from 76-10-148-235.dsl.teksavvy.com (HELO ceviche.home) ([76.10.148.235]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 25 Aug 2011 09:37:05 -0400 Received: by ceviche.home (Postfix, from userid 20848) id A2CFE660CF; Thu, 25 Aug 2011 09:37:05 -0400 (EDT) From: Stefan Monnier Message-ID: References: <874o16el1j.fsf@mail.jurta.org> Date: Thu, 25 Aug 2011 09:37:05 -0400 In-Reply-To: <874o16el1j.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 24 Aug 2011 21:12:08 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > I don't know if it's desirable to force turning off this mode and to > reset the value of `display-battery-mode' to nil in this case. Setting it to nil would be good, yes. Stefan From unknown Sat Jun 21 05:17:11 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Juri Linkov Subject: bug#9363: closed (Re: bug#9363: display-battery-mode) Message-ID: References: <87ei09uv74.fsf@mail.jurta.org> <874o16el1j.fsf@mail.jurta.org> X-Gnu-PR-Message: they-closed 9363 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 9363@debbugs.gnu.org Date: Thu, 25 Aug 2011 19:54:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1314302041-12675-1" This is a multi-part message in MIME format... ------------=_1314302041-12675-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #9363: display-battery-mode which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 9363@debbugs.gnu.org. --=20 9363: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D9363 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1314302041-12675-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 9363-done) by debbugs.gnu.org; 25 Aug 2011 19:53:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qwfzm-0003Hx-GY for submit@debbugs.gnu.org; Thu, 25 Aug 2011 15:53:46 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qwfzk-0003Hq-Op for 9363-done@debbugs.gnu.org; Thu, 25 Aug 2011 15:53:45 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 2F4F96E808B; Thu, 25 Aug 2011 12:51:03 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 1D72A451C28D; Thu, 25 Aug 2011 12:51:01 -0700 (PDT) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#9363: display-battery-mode Organization: JURTA References: <874o16el1j.fsf@mail.jurta.org> Date: Thu, 25 Aug 2011 22:50:39 +0300 In-Reply-To: (Stefan Monnier's message of "Thu, 25 Aug 2011 09:37:05 -0400") Message-ID: <87ei09uv74.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9363-done Cc: 9363-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >> I don't know if it's desirable to force turning off this mode and to >> reset the value of `display-battery-mode' to nil in this case. > > Setting it to nil would be good, yes. Done. ------------=_1314302041-12675-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Aug 2011 18:18:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QwI2R-0008KD-Je for submit@debbugs.gnu.org; Wed, 24 Aug 2011 14:18:55 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QwI2P-0008K6-DB for submit@debbugs.gnu.org; Wed, 24 Aug 2011 14:18:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QwHzt-0007vn-SC for submit@debbugs.gnu.org; Wed, 24 Aug 2011 14:16:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:41165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwHzt-0007vg-Qi for submit@debbugs.gnu.org; Wed, 24 Aug 2011 14:16:17 -0400 Received: from eggs.gnu.org ([140.186.70.92]:51714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwHzs-0007UT-NK for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2011 14:16:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QwHzr-0007vO-MC for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2011 14:16:16 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]:54524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwHzr-0007vB-Br for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2011 14:16:15 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 6097E6E80BB for ; Wed, 24 Aug 2011 11:16:14 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id BFD79451C28D for ; Wed, 24 Aug 2011 11:16:13 -0700 (PDT) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: display-battery-mode Organization: JURTA Date: Wed, 24 Aug 2011 21:12:08 +0300 Message-ID: <874o16el1j.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) When ACPI is turned off with `acpi=off' after booting the Linux kernel `M-x display-battery-mode RET' fails with: Debugger entered--Lisp error: (wrong-type-argument stringp nil) read-from-string(nil) battery-update() display-battery-mode(toggle) call-interactively(display-battery-mode t nil) execute-extended-command(nil) call-interactively(execute-extended-command nil nil) whereas `M-x battery RET' displays a polite message "Battery status not available". This patch fixes `display-battery-mode' to display the same message when `battery-status-function' is nil. I don't know if it's desirable to force turning off this mode and to reset the value of `display-battery-mode' to nil in this case. But at least, the message is informative with this patch: === modified file 'lisp/battery.el' --- lisp/battery.el 2011-06-27 08:04:55 +0000 +++ lisp/battery.el 2011-08-24 18:11:15 +0000 @@ -173,13 +173,15 @@ (define-minor-mode display-battery-mode (setq battery-mode-line-string "") (or global-mode-string (setq global-mode-string '(""))) (and battery-update-timer (cancel-timer battery-update-timer)) - (if (not display-battery-mode) - (setq global-mode-string - (delq 'battery-mode-line-string global-mode-string)) - (add-to-list 'global-mode-string 'battery-mode-line-string t) - (setq battery-update-timer (run-at-time nil battery-update-interval - 'battery-update-handler)) - (battery-update))) + (if (and battery-status-function battery-mode-line-format) + (if (not display-battery-mode) + (setq global-mode-string + (delq 'battery-mode-line-string global-mode-string)) + (add-to-list 'global-mode-string 'battery-mode-line-string t) + (setq battery-update-timer (run-at-time nil battery-update-interval + 'battery-update-handler)) + (battery-update)) + (message "Battery status not available"))) (defun battery-update-handler () (battery-update) ------------=_1314302041-12675-1--