GNU bug report logs - #9353
24.0.50; default grep file name face is uglier now

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Juri Linkov <juri <at> jurta.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#9353: closed (24.0.50; default grep file name face is uglier now)
Date: Wed, 24 Aug 2011 18:06:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 24 Aug 2011 21:02:15 +0300
with message-id <87aaayeli0.fsf <at> mail.jurta.org>
and subject line Re: bug#9353: 24.0.50; default grep file name face is uglier now
has caused the GNU bug report #9353,
regarding 24.0.50; default grep file name face is uglier now
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
9353: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9353
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.50; default grep file name face is uglier now
Date: Tue, 23 Aug 2011 13:18:54 -0700

[Message part 3 (text/plain, inline)]

See attached images. The old face inherited from `font-lock-type-face',
and the appearace was OK (though not wonderful).
 
The new face inherits from a face called `success'. It is uhhhhgggly.
 
For one thing, it should not be bold.  We should almost never use a bold
face as the default face for something, because boldness does not work
well on some platforms and for some (many) faces.
 
I applaud not inheriting from a font-lock face: there is no logical
connection to a grepped file.  But there is also no logical connection
to "success" here.
 
Anyway, whatever you inherit from (but why must you always inherit?),
the default appearance should not be ugly and difficult to read.  That
just forces more users to customize it or live with the difficulty.

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2011-08-22 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt'
 

[throw-grep-file-old.png (image/png, attachment)]

[throw-grep-file-new.png (image/png, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Juri Linkov <juri <at> jurta.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 9353-done <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#9353: 24.0.50; default grep file name face is uglier now
Date: Wed, 24 Aug 2011 21:02:15 +0300

>> OTOH, changing its color from "Green3" to "ForestGreen" looks like
>> a good change that makes it more readable (with default large fonts).
>
> I don't mind, so feel free to make this change.

I've changed the color without removing boldness, and tested that
objectively it looks good with other faces in etc/compilation.txt
and in the compilation/grep mode-line with default large fonts.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.