From unknown Sun Jun 22 00:27:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9319: Compilation fontification regression Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Aug 2011 11:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 9319 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 9319@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.131366846024072 (code B ref -1); Thu, 18 Aug 2011 11:55:01 +0000 Received: (at submit) by debbugs.gnu.org; 18 Aug 2011 11:54:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qu1Ax-0006GD-Sb for submit@debbugs.gnu.org; Thu, 18 Aug 2011 07:54:20 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qu1At-0006G1-2A for submit@debbugs.gnu.org; Thu, 18 Aug 2011 07:54:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qu18x-0004P5-6G for submit@debbugs.gnu.org; Thu, 18 Aug 2011 07:52:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:56557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qu18x-0004Ox-4r for submit@debbugs.gnu.org; Thu, 18 Aug 2011 07:52:15 -0400 Received: from eggs.gnu.org ([140.186.70.92]:37055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qu18v-0008J9-Oa for bug-gnu-emacs@gnu.org; Thu, 18 Aug 2011 07:52:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qu18u-0004Oh-Qh for bug-gnu-emacs@gnu.org; Thu, 18 Aug 2011 07:52:13 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]:38514) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qu18u-0004Ob-LP for bug-gnu-emacs@gnu.org; Thu, 18 Aug 2011 07:52:12 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id F2F6D6E806B for ; Thu, 18 Aug 2011 04:52:11 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 54471451C3C3 for ; Thu, 18 Aug 2011 04:52:11 -0700 (PDT) From: Juri Linkov Organization: JURTA Date: Thu, 18 Aug 2011 14:47:01 +0300 Message-ID: <87ty9f54cq.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.6 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) 1. Comparing etc/compilation.txt in side-by-side frames with versions 23.1 and 24.0 (current Bzr trunk) reveals the regression in fontification of some compilation error/warning messages. I see differences in the following sections: * IBM jikes, Sparc Pascal, GCOV, Podchecker - errors/warnings not highlighted, so this looks like a bug. * ant - warning highlighted with `error' face. But maybe this change is based on the user's request, I don't know. Other changes between 23.1 and 24.0 look like bug fixes that provide more correct fontification. 2. Sometimes errors/warnings are not fontified at all. For instance, C-x C-f etc/compilation.txt RET C-s RET symbol: sun RET i.e. non-incremental search that goes directly to the given section, fontifies nothing. But scrolling slowly with C-v from the beginning of the etc/compilation.txt buffer, fontifies everything. From unknown Sun Jun 22 00:27:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9319: Compilation fontification regression Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Aug 2011 02:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9319 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 9319@debbugs.gnu.org Received: via spool by 9319-submit@debbugs.gnu.org id=B9319.13138927696316 (code B ref 9319); Sun, 21 Aug 2011 02:13:01 +0000 Received: (at 9319) by debbugs.gnu.org; 21 Aug 2011 02:12:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QuxWq-0001dp-SA for submit@debbugs.gnu.org; Sat, 20 Aug 2011 22:12:49 -0400 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QuxWo-0001di-SU for 9319@debbugs.gnu.org; Sat, 20 Aug 2011 22:12:48 -0400 Received: from furball (dhcp-128-36-14-148.central.yale.edu [128.36.14.148]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p7L2AWvx008305 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 20 Aug 2011 22:10:32 -0400 From: Chong Yidong References: <87ty9f54cq.fsf@mail.jurta.org> Date: Sat, 20 Aug 2011 22:10:32 -0400 In-Reply-To: <87ty9f54cq.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 18 Aug 2011 14:47:01 +0300") Message-ID: <87y5ynv7jb.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Juri Linkov writes: > * IBM jikes, Sparc Pascal, GCOV, Podchecker > - errors/warnings not highlighted, > so this looks like a bug. > > * ant > - warning highlighted with `error' face. But maybe this change > is based on the user's request, I don't know. > > Other changes between 23.1 and 24.0 look like bug fixes > that provide more correct fontification. > > 2. Sometimes errors/warnings are not fontified at all. > For instance, > > C-x C-f etc/compilation.txt RET > C-s RET symbol: sun RET > > i.e. non-incremental search that goes directly to the given section, > fontifies nothing. Both problems were due to incorrect code in compilation-error-properties causing it to signal an error for error definitions with nil filenames, introduced when Stefan revamped compile.el. I've committed a fix. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 20 22:12:58 2011 Received: (at control) by debbugs.gnu.org; 21 Aug 2011 02:12:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QuxX0-0001e9-BV for submit@debbugs.gnu.org; Sat, 20 Aug 2011 22:12:58 -0400 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QuxWy-0001e3-Ug for control@debbugs.gnu.org; Sat, 20 Aug 2011 22:12:57 -0400 Received: from furball (dhcp-128-36-14-148.central.yale.edu [128.36.14.148]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p7L2Agw3008345 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Sat, 20 Aug 2011 22:10:43 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 9319 Date: Sat, 20 Aug 2011 22:10:42 -0400 Message-ID: <87hb5bh5ul.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 9319 thanks From unknown Sun Jun 22 00:27:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9319: Compilation fontification regression Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Aug 2011 12:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9319 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Chong Yidong Cc: 9319@debbugs.gnu.org Received: via spool by 9319-submit@debbugs.gnu.org id=B9319.131401746826428 (code B ref 9319); Mon, 22 Aug 2011 12:52:02 +0000 Received: (at 9319) by debbugs.gnu.org; 22 Aug 2011 12:51:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QvTy8-0006sC-6w for submit@debbugs.gnu.org; Mon, 22 Aug 2011 08:51:08 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QvTy3-0006rp-1o for 9319@debbugs.gnu.org; Mon, 22 Aug 2011 08:51:05 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id E68116E806A; Mon, 22 Aug 2011 05:48:39 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 20857451C35E; Mon, 22 Aug 2011 05:48:38 -0700 (PDT) From: Juri Linkov Organization: JURTA References: <87ty9f54cq.fsf@mail.jurta.org> <87y5ynv7jb.fsf@stupidchicken.com> Date: Mon, 22 Aug 2011 15:48:08 +0300 In-Reply-To: <87y5ynv7jb.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 20 Aug 2011 22:10:32 -0400") Message-ID: <874o19eho7.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > Both problems were due to incorrect code in compilation-error-properties > causing it to signal an error for error definitions with nil filenames, > introduced when Stefan revamped compile.el. I've committed a fix. Thanks, now this is fixed. I noticed another regression: in etc/compilation.txt the line tool1 -output=foo foo.x is highlighted incorrectly. This is caused by revno:102131 from: http://lists.gnu.org/archive/html/emacs-devel/2010-10/msg01018.html I fixed this by reverting to the old regexp and removing just one unnecessary question mark. Now all these samples are highlighted correctly: tool -o foo.o foo.c tool -o=foo.o foo.c tool -output foo.o foo.c tool -output=foo.o foo.c tool -outfile foo.o foo.c tool -outfile=foo.o foo.c tool --output foo.o foo.c tool --output=foo.o foo.c tool --outfile foo.o foo.c tool --outfile=foo.o foo.c whereas the following are not highlighted: tool --omega foo.c tool --output-html-file foo.c