GNU bug report logs - #9317
[PATCH] Don't install .dir-locals.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9317 in the body.
You can then email your comments to 9317 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Don't install .dir-locals.el
Date: Thu, 18 Aug 2011 11:47:40 +0800

This is a minor bug but since the main .dir-locals.el in the toplevel of
the repo isn't installed, neither should lisp/gnus/.dir-locals.el and
maybe others.


=== modified file 'Makefile.in'
--- Makefile.in	2011-07-09 00:18:49 +0000
+++ Makefile.in	2011-08-18 03:45:26 +0000
@@ -535,6 +535,7 @@
 		rm -f  $${subdir}/.gitignore ; \
 		rm -f  $${subdir}/.arch-inventory ; \
 		rm -f  $${subdir}/.DS_Store ; \
+		rm -f  $${subdir}/.dir-locals.el ; \
 		rm -f  $${subdir}/\#* ; \
 		rm -f  $${subdir}/.\#* ; \
 		rm -f  $${subdir}/*~ ; \

Message #8 received at 9317 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo <sdl.web <at> gmail.com>
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>, 9317 <at> debbugs.gnu.org,
	Chong Yidong <cyd <at> stupidchicken.com>
Subject: Re: bug#9317: [PATCH] Don't install .dir-locals.el
Date: Thu, 18 Aug 2011 23:04:09 -0400

> This is a minor bug but since the main .dir-locals.el in the toplevel of
> the repo isn't installed, neither should lisp/gnus/.dir-locals.el and
> maybe others.

I'm not sure it's something that needs fixing: the toplevel .dir-locals
has no clear destination (since the various subdirectories get installed
into different parts of the file system), where the
lisp/gnus/.dir-locals.el has a very clear destination, so I think it's
actually good to install it there.


        Stefan


> === modified file 'Makefile.in'
> --- Makefile.in	2011-07-09 00:18:49 +0000
> +++ Makefile.in	2011-08-18 03:45:26 +0000
> @@ -535,6 +535,7 @@
>  		rm -f  $${subdir}/.gitignore ; \
>  		rm -f  $${subdir}/.arch-inventory ; \
>  		rm -f  $${subdir}/.DS_Store ; \
> +		rm -f  $${subdir}/.dir-locals.el ; \
>  		rm -f  $${subdir}/\#* ; \
>  		rm -f  $${subdir}/.\#* ; \
>  		rm -f  $${subdir}/*~ ; \

Message #11 received at 9317 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>, 9317 <at> debbugs.gnu.org,
	Chong Yidong <cyd <at> stupidchicken.com>
Subject: Re: bug#9317: [PATCH] Don't install .dir-locals.el
Date: Fri, 19 Aug 2011 13:43:33 +0800

On 2011-08-19 11:04 +0800, Stefan Monnier wrote:
> I'm not sure it's something that needs fixing: the toplevel .dir-locals
> has no clear destination (since the various subdirectories get installed
> into different parts of the file system), where the
> lisp/gnus/.dir-locals.el has a very clear destination, so I think it's
> actually good to install it there.

subdir .dir-locals.el often just complement the toplevel one. So it is
not self-contained.

Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.