From unknown Sat Aug 16 18:16:07 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#931 <931@debbugs.gnu.org> To: bug#931 <931@debbugs.gnu.org> Subject: Status: 23.0.60; Bug in bytecomp.el: displaying warnings Reply-To: bug#931 <931@debbugs.gnu.org> Date: Sun, 17 Aug 2025 01:16:07 +0000 retitle 931 23.0.60; Bug in bytecomp.el: displaying warnings reassign 931 emacs submitter 931 michael_heerdegen@web.de severity 931 normal thanks From Michael_Heerdegen@web.de Mon Sep 8 12:37:36 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.0 required=4.0 tests=BAYES_00,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 8 Sep 2008 19:37:36 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m88JbWNA003843 for ; Mon, 8 Sep 2008 12:37:34 -0700 Received: from mx10.gnu.org ([199.232.76.166]:34890) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KcmWZ-00088j-EO for emacs-pretest-bug@gnu.org; Mon, 08 Sep 2008 15:35:47 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KcmYA-0004LN-UA for emacs-pretest-bug@gnu.org; Mon, 08 Sep 2008 15:37:32 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:56210) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KcmYA-0004L1-Ha for emacs-pretest-bug@gnu.org; Mon, 08 Sep 2008 15:37:26 -0400 Received: from smtp05.web.de (fmsmtp05.dlan.cinetic.de [172.20.4.166]) by fmmailgate01.web.de (Postfix) with ESMTP id B8AB0EEEF0EE for ; Mon, 8 Sep 2008 21:37:24 +0200 (CEST) Received: from [92.75.235.128] (helo=green) by smtp05.web.de with asmtp (WEB.DE 4.109 #226) id 1KcmY8-0007fl-00 for emacs-pretest-bug@gnu.org; Mon, 08 Sep 2008 21:37:24 +0200 From: Michael Heerdegen To: emacs-pretest-bug@gnu.org Subject: 23.0.60; Bug in bytecomp.el: displaying warnings Reply-to: michael_heerdegen@web.de Date: Mon, 8 Sep 2008 21:35:23 +0200 Message-Id: <1220902523.951243.11457@green> Sender: Michael_Heerdegen@web.de X-Sender: michael_heerdegen@web.de X-Provags-ID: V01U2FsdGVkX1/SN1YFL+MlulurhOf/72HW0NE1N0JvHaibw+tw Ku60BlrOwqci2wteBCf9IWXnspr/guC8ZiRKEAvPzihw37IrT5 cKbf4bzDp0kAsd6BJxzQ== X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 When pop-up-windows is nil, the byte compiler sometimes aborts with the error message End of file during parsing after displaying warnings, although the source file is ok. You can reproduce this with CVS Gnu Emacs as follows: 1. Create a file test.el with the following contents: (setq a 1) 2. emacs -Q 3. M-: (setq pop-up-windows nil) RET 4. Byte compile test.el The reason for the bug is an error in `byte-compile-from-buffer'. Its definition looks like that: (defun byte-compile-from-buffer (inbuffer &optional filename) ... (let ... (byte-compile-close-variables ... (displaying-byte-compile-warnings ... (with-current-buffer inbuffer ... (while ... ...) ...) ...)) ...)) If pop-up-windows is nil, and warnings have to be displayed, `byte-compile-report-error' is called, and after that, (current-buffer) will be the Compile Log buffer, and the current buffer is not restored for further iterations of the while loop. From rudalics@gmx.at Mon Sep 8 14:15:08 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 931) by emacsbugs.donarmstrong.com; 8 Sep 2008 21:15:09 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m88LF4X6005660 for <931@emacsbugs.donarmstrong.com>; Mon, 8 Sep 2008 14:15:06 -0700 Received: (qmail invoked by alias); 08 Sep 2008 21:14:58 -0000 Received: from 62-47-44-248.adsl.highway.telekom.at (EHLO [62.47.44.248]) [62.47.44.248] by mail.gmx.net (mp042) with SMTP; 08 Sep 2008 23:14:58 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19HqC8jWU1HXFYrt4K+OkdpkJcr/3+E6KlHNbzRmn g2VDbryAWQeJ4n Message-ID: <48C59543.2020907@gmx.at> Date: Mon, 08 Sep 2008 23:12:35 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: 931@debbugs.gnu.org CC: michael_heerdegen@web.de Subject: Re: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings References: <1220902523.951243.11457@green> In-Reply-To: <1220902523.951243.11457@green> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.82 > If pop-up-windows is nil, and warnings have to be displayed, > `byte-compile-report-error' is called, and after that, > (current-buffer) will be the Compile Log buffer, and the current > buffer is not restored for further iterations of the while loop. I suppose the byte-compiler should either refrain from using `display-warning' or, if `pop-up-windows' and `pop-up-frames' are nil, not display a warning until compilation is complete. martin From rms@gnu.org Tue Sep 9 01:13:32 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.4 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 9 Sep 2008 08:13:32 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m898DTiS009964 for ; Tue, 9 Sep 2008 01:13:30 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KcyLn-0006Jh-Ez for bug-gnu-emacs@gnu.org; Tue, 09 Sep 2008 04:13:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KcyLj-0006IV-6s for bug-gnu-emacs@gnu.org; Tue, 09 Sep 2008 04:13:23 -0400 Received: from [199.232.76.173] (port=38509 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KcyLg-0006Hy-PW for bug-gnu-emacs@gnu.org; Tue, 09 Sep 2008 04:13:21 -0400 Received: from fencepost.gnu.org ([140.186.70.10]:38731) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KcyLg-0006vg-Jc for bug-gnu-emacs@gnu.org; Tue, 09 Sep 2008 04:13:20 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KcyJx-0002xV-VV; Tue, 09 Sep 2008 04:11:33 -0400 Content-Type: text/plain; charset=ISO-8859-15 From: "Richard M. Stallman" To: martin rudalics , 931@debbugs.gnu.org CC: 931@debbugs.gnu.org, bug-submit-list@donarmstrong.com, michael_heerdegen@web.de, bug-gnu-emacs@gnu.org In-reply-to: <48C59543.2020907@gmx.at> (message from martin rudalics on Mon, 08 Sep 2008 23:12:35 +0200) Subject: Re: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings Reply-to: rms@gnu.org References: <1220902523.951243.11457@green> <48C59543.2020907@gmx.at> Message-Id: Date: Tue, 09 Sep 2008 04:11:33 -0400 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-CrossAssassin-Score: 2 > If pop-up-windows is nil, and warnings have to be displayed, > `byte-compile-report-error' is called, and after that, > (current-buffer) will be the Compile Log buffer, and the current > buffer is not restored for further iterations of the while loop. I suppose the byte-compiler should either refrain from using `display-warning' That would be very drastic and cause a lot of inconvenience in the normal situation where there is no bug! or, if `pop-up-windows' and `pop-up-frames' are nil, not display a warning until compilation is complete. The solution that occurs to me is that `display-warning' should bind `pop-up-windows' to t in that case. From monnier@iro.umontreal.ca Tue Sep 9 07:33:57 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.8 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 9 Sep 2008 14:33:57 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m89EXkg1014250 for ; Tue, 9 Sep 2008 07:33:47 -0700 Received: from mail.gnu.org ([199.232.76.166]:44446 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Kd4G7-0006vW-Qk for emacs-pretest-bug@gnu.org; Tue, 09 Sep 2008 10:31:59 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Kd4Hj-0003CP-Mn for emacs-pretest-bug@gnu.org; Tue, 09 Sep 2008 10:33:44 -0400 Received: from ironport2-out.pppoe.ca ([206.248.154.182]:61657 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kd4Hj-0003Bw-9s for emacs-pretest-bug@gnu.org; Tue, 09 Sep 2008 10:33:39 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AsAEALEmxkhFxIqP/2dsb2JhbACBZbRXgWSBBw X-IronPort-AV: E=Sophos;i="4.32,365,1217822400"; d="scan'208";a="26559112" Received: from 69-196-138-143.dsl.teksavvy.com (HELO pastel.home) ([69.196.138.143]) by ironport2-out.teksavvy.com with ESMTP; 09 Sep 2008 10:33:37 -0400 Received: by pastel.home (Postfix, from userid 20848) id B4E8054279; Tue, 9 Sep 2008 10:33:37 -0400 (EDT) From: Stefan Monnier To: michael_heerdegen@web.de Cc: 931@debbugs.gnu.org, emacs-pretest-bug@gnu.org Subject: Re: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings Message-ID: References: <1220902523.951243.11457@green> Date: Tue, 09 Sep 2008 10:33:37 -0400 In-Reply-To: <1220902523.951243.11457@green> (Michael Heerdegen's message of "Mon, 8 Sep 2008 21:35:23 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-CrossAssassin-Score: 2 > If pop-up-windows is nil, and warnings have to be displayed, > `byte-compile-report-error' is called, and after that, > (current-buffer) will be the Compile Log buffer, and the current > buffer is not restored for further iterations of the while loop. Does the patch below fix the problem? Maybe the fix should even be pushed further down into display-buffer? Stefan === modified file 'lisp/emacs-lisp/warnings.el' --- lisp/emacs-lisp/warnings.el 2008-05-06 14:18:59 +0000 +++ lisp/emacs-lisp/warnings.el 2008-09-09 14:32:38 +0000 @@ -286,11 +286,15 @@ (or (< (warning-numeric-level level) (warning-numeric-level warning-minimum-level)) (warning-suppress-p type warning-suppress-types) + ;; `display-buffer' usually preserves current-buffer, except + ;; when it ends up doing switch-to-buffer (e.g. pop-up-windows + ;; is nil). + (save-current-buffer (let ((window (display-buffer buffer))) (when (and (markerp warning-series) (eq (marker-buffer warning-series) buffer)) (set-window-start window warning-series)) - (sit-for 0))))))) + (sit-for 0)))))))) ;;;###autoload (defun lwarn (type level message &rest args) From rudalics@gmx.at Wed Sep 10 02:28:31 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 931) by emacsbugs.donarmstrong.com; 10 Sep 2008 09:28:31 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m8A9SQAc024287 for <931@emacsbugs.donarmstrong.com>; Wed, 10 Sep 2008 02:28:28 -0700 Received: (qmail invoked by alias); 10 Sep 2008 09:28:21 -0000 Received: from 62-47-41-103.adsl.highway.telekom.at (EHLO [62.47.41.103]) [62.47.41.103] by mail.gmx.net (mp056) with SMTP; 10 Sep 2008 11:28:21 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18bPSc9WCgbDc72X+JOMI+uWO1LF6Jv9BUVshdUjM vCw/tgSAj/Ht/w Message-ID: <48C79200.2000708@gmx.at> Date: Wed, 10 Sep 2008 11:23:12 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: rms@gnu.org CC: 931@debbugs.gnu.org, michael_heerdegen@web.de Subject: Re: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings References: <1220902523.951243.11457@green> <48C59543.2020907@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.79 > I suppose the byte-compiler should either refrain from using > `display-warning' > > That would be very drastic and cause a lot of inconvenience > in the normal situation where there is no bug! I obviously meant use something different instead of `display-warning'. > or, if `pop-up-windows' and `pop-up-frames' are nil, > not display a warning until compilation is complete. > > The solution that occurs to me is that `display-warning' should > bind `pop-up-windows' to t in that case. This would (1) ignore a user preference and (2) not work when the window can't be split for some reason. martin From rudalics@gmx.at Wed Sep 10 02:28:32 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 931) by emacsbugs.donarmstrong.com; 10 Sep 2008 09:28:32 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m8A9SSnj024288 for <931@emacsbugs.donarmstrong.com>; Wed, 10 Sep 2008 02:28:30 -0700 Received: (qmail invoked by alias); 10 Sep 2008 09:28:23 -0000 Received: from 62-47-41-103.adsl.highway.telekom.at (EHLO [62.47.41.103]) [62.47.41.103] by mail.gmx.net (mp028) with SMTP; 10 Sep 2008 11:28:23 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18WUux1wqEWDklzoxtsvx3bujmW/8paQtfFDwS8OX u9UAj+0KyEshXl Message-ID: <48C7921F.6020206@gmx.at> Date: Wed, 10 Sep 2008 11:23:43 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Stefan Monnier , 931@debbugs.gnu.org CC: michael_heerdegen@web.de Subject: Re: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings References: <1220902523.951243.11457@green> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.67 > + ;; `display-buffer' usually preserves current-buffer, except > + ;; when it ends up doing switch-to-buffer (e.g. pop-up-windows > + ;; is nil). FWIW it's set_window_buffer in /* We must select BUFFER for running the window-scroll-functions. If WINDOW is selected, switch permanently. Otherwise, switch but go back to the ambient buffer afterward. */ if (EQ (window, selected_window)) Fset_buffer (buffer); which is not very clean (and not documented in `set-window-buffer'). > + (save-current-buffer > (let ((window (display-buffer buffer))) > (when (and (markerp warning-series) > (eq (marker-buffer warning-series) buffer)) > (set-window-start window warning-series)) > - (sit-for 0))))))) > + (sit-for 0)))))))) This will cause the *Warnings* buffer to flash shortly here and immediately get replaced when compilation finished. martin From monnier@iro.umontreal.ca Wed Sep 10 09:25:06 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.8 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 931) by emacsbugs.donarmstrong.com; 10 Sep 2008 16:25:07 +0000 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8AGP1sU011284 for <931@emacsbugs.donarmstrong.com>; Wed, 10 Sep 2008 09:25:04 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhwGAACSx0hFxIqP/2dsb2JhbACBZbcOgWSBBg X-IronPort-AV: E=Sophos;i="4.32,373,1217822400"; d="scan'208";a="26616067" Received: from 69-196-138-143.dsl.teksavvy.com (HELO pastel.home) ([69.196.138.143]) by ironport2-out.teksavvy.com with ESMTP; 10 Sep 2008 12:24:55 -0400 Received: by pastel.home (Postfix, from userid 20848) id 0408C85E5; Wed, 10 Sep 2008 12:24:55 -0400 (EDT) From: Stefan Monnier To: martin rudalics Cc: 931@debbugs.gnu.org, michael_heerdegen@web.de Subject: Re: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings Message-ID: References: <1220902523.951243.11457@green> <48C7921F.6020206@gmx.at> Date: Wed, 10 Sep 2008 12:24:54 -0400 In-Reply-To: <48C7921F.6020206@gmx.at> (martin rudalics's message of "Wed, 10 Sep 2008 11:23:43 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> + (save-current-buffer >> (let ((window (display-buffer buffer))) >> (when (and (markerp warning-series) >> (eq (marker-buffer warning-series) buffer)) >> (set-window-start window warning-series)) >> - (sit-for 0))))))) >> + (sit-for 0)))))))) > This will cause the *Warnings* buffer to flash shortly here and > immediately get replaced when compilation finished. Are you sure? save-current-buffer does not mess with selected windows, so it should have no such effect. Stefan From rudalics@gmx.at Wed Sep 10 10:39:58 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 931) by emacsbugs.donarmstrong.com; 10 Sep 2008 17:39:58 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m8AHdnPS006320 for <931@emacsbugs.donarmstrong.com>; Wed, 10 Sep 2008 10:39:51 -0700 Received: (qmail invoked by alias); 10 Sep 2008 17:39:44 -0000 Received: from 88-117-44-45.adsl.highway.telekom.at (EHLO [88.117.44.45]) [88.117.44.45] by mail.gmx.net (mp055) with SMTP; 10 Sep 2008 19:39:44 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1//8clVvyn/HYC+o7Oe0YX9fd5N8ezck7AMJYxYIb MSiMgdZziBX1c1 Message-ID: <48C805CC.4050303@gmx.at> Date: Wed, 10 Sep 2008 19:37:16 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Stefan Monnier CC: 931@debbugs.gnu.org, michael_heerdegen@web.de Subject: Re: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings References: <1220902523.951243.11457@green> <48C7921F.6020206@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.83 >> This will cause the *Warnings* buffer to flash shortly here and >> immediately get replaced when compilation finished. > > Are you sure? save-current-buffer does not mess with selected windows, > so it should have no such effect. The *Warnings* buffer is displayed for less than a second and gets replaced by the buffer I compile. Did you mean the *Warnings* buffer would stay in the selected window after compilation finishes? That would mean that `display-buffer' messed with the selected window. martin From rms@gnu.org Wed Sep 10 13:48:42 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.4 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 10 Sep 2008 20:48:42 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8AKmc4B009970 for ; Wed, 10 Sep 2008 13:48:39 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KdWc9-0007tp-0q for bug-gnu-emacs@gnu.org; Wed, 10 Sep 2008 16:48:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KdWc7-0007t0-AO for bug-gnu-emacs@gnu.org; Wed, 10 Sep 2008 16:48:36 -0400 Received: from [199.232.76.173] (port=47946 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KdWc7-0007st-5U for bug-gnu-emacs@gnu.org; Wed, 10 Sep 2008 16:48:35 -0400 Received: from fencepost.gnu.org ([140.186.70.10]:46255) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KdWc6-00071e-UZ for bug-gnu-emacs@gnu.org; Wed, 10 Sep 2008 16:48:35 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KdWaM-0007US-B7; Wed, 10 Sep 2008 16:46:46 -0400 Content-Type: text/plain; charset=ISO-8859-15 From: "Richard M. Stallman" To: martin rudalics , 931@debbugs.gnu.org CC: bug-submit-list@donarmstrong.com, 931@debbugs.gnu.org, michael_heerdegen@web.de, bug-gnu-emacs@gnu.org In-reply-to: <48C79200.2000708@gmx.at> (message from martin rudalics on Wed, 10 Sep 2008 11:23:12 +0200) Subject: Re: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings Reply-to: rms@gnu.org References: <1220902523.951243.11457@green> <48C59543.2020907@gmx.at> <48C79200.2000708@gmx.at> Message-Id: Date: Wed, 10 Sep 2008 16:46:46 -0400 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-CrossAssassin-Score: 2 > I suppose the byte-compiler should either refrain from using > `display-warning' > > That would be very drastic and cause a lot of inconvenience > in the normal situation where there is no bug! I obviously meant use something different instead of `display-warning'. `display-warning' was made for uses like this. If what it does now is not right in some circumstances, we should change it to do something better. Whatever is the right thing to do for these messages, `display-warning' should do it. > The solution that occurs to me is that `display-warning' should > bind `pop-up-windows' to t in that case. This would (1) ignore a user preference That is a general preference. There is no need to be rigid about it in a special case where it leads to clearly undesirable behavior. and (2) not work when the window can't be split for some reason. That is true. Fortunately such cases are rare. `display-warning' could do something special for those cases. Perhaps just mention in the echo area that there are warnings. From monnier@iro.umontreal.ca Wed Sep 10 18:52:52 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.9 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 931) by emacsbugs.donarmstrong.com; 11 Sep 2008 01:52:52 +0000 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8B1qmhI024296 for <931@emacsbugs.donarmstrong.com>; Wed, 10 Sep 2008 18:52:49 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjkFAGMWyEhFxIqP/2dsb2JhbACBZbcMgWSBBg X-IronPort-AV: E=Sophos;i="4.32,375,1217822400"; d="scan'208";a="26643560" Received: from 69-196-138-143.dsl.teksavvy.com (HELO ceviche.home) ([69.196.138.143]) by ironport2-out.teksavvy.com with ESMTP; 10 Sep 2008 21:52:42 -0400 Received: by ceviche.home (Postfix, from userid 20848) id D2BF7B4062; Wed, 10 Sep 2008 21:52:42 -0400 (EDT) From: Stefan Monnier To: martin rudalics Cc: 931@debbugs.gnu.org, michael_heerdegen@web.de Subject: Re: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings Message-ID: References: <1220902523.951243.11457@green> <48C7921F.6020206@gmx.at> <48C805CC.4050303@gmx.at> Date: Wed, 10 Sep 2008 21:52:42 -0400 In-Reply-To: <48C805CC.4050303@gmx.at> (martin rudalics's message of "Wed, 10 Sep 2008 19:37:16 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >>> This will cause the *Warnings* buffer to flash shortly here and >>> immediately get replaced when compilation finished. >> Are you sure? save-current-buffer does not mess with selected windows, >> so it should have no such effect. > The *Warnings* buffer is displayed for less than a second and gets > replaced by the buffer I compile. OK. But it does fix the OP's problem (that the compilation fails with an error), right? Stefan From rudalics@gmx.at Thu Sep 11 01:58:26 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 931) by emacsbugs.donarmstrong.com; 11 Sep 2008 08:58:26 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m8B8wJ9E013709 for <931@emacsbugs.donarmstrong.com>; Thu, 11 Sep 2008 01:58:21 -0700 Received: (qmail invoked by alias); 11 Sep 2008 08:58:14 -0000 Received: from 62-47-61-65.adsl.highway.telekom.at (EHLO [62.47.61.65]) [62.47.61.65] by mail.gmx.net (mp042) with SMTP; 11 Sep 2008 10:58:14 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/cgTpXPcbc2TlaUH/DF1ks+7tKUiCPGDJb7IND8p wig+h8UARReaea Message-ID: <48C8DC90.9050605@gmx.at> Date: Thu, 11 Sep 2008 10:53:36 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: rms@gnu.org CC: 931@debbugs.gnu.org, michael_heerdegen@web.de Subject: Re: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings References: <1220902523.951243.11457@green> <48C59543.2020907@gmx.at> <48C79200.2000708@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.86 > `display-warning' was made for uses like this. If what it does now is > not right in some circumstances, we should change it to do something > better. Whatever is the right thing to do for these messages, > `display-warning' should do it. We could do something special if `warning-series' is non-nil. Or maybe `displaying-byte-compile-warnings' could do that. martin From rudalics@gmx.at Thu Sep 11 01:58:28 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 931) by emacsbugs.donarmstrong.com; 11 Sep 2008 08:58:29 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m8B8wIMN013708 for <931@emacsbugs.donarmstrong.com>; Thu, 11 Sep 2008 01:58:20 -0700 Received: (qmail invoked by alias); 11 Sep 2008 08:58:12 -0000 Received: from 62-47-61-65.adsl.highway.telekom.at (EHLO [62.47.61.65]) [62.47.61.65] by mail.gmx.net (mp004) with SMTP; 11 Sep 2008 10:58:12 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/hbGUe00zh2FEk2zKdmYv38Q28y5O9+l2pJb9JYP bHdINn6oS2Is15 Message-ID: <48C8DC84.3080907@gmx.at> Date: Thu, 11 Sep 2008 10:53:24 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Stefan Monnier CC: 931@debbugs.gnu.org, michael_heerdegen@web.de Subject: Re: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings References: <1220902523.951243.11457@green> <48C7921F.6020206@gmx.at> <48C805CC.4050303@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.84 > OK. But it does fix the OP's problem (that the compilation fails with > an error), right? Sure ;-) martin From monnier@iro.umontreal.ca Fri Sep 12 09:30:32 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.8 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 931) by emacsbugs.donarmstrong.com; 12 Sep 2008 16:30:32 +0000 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8CGUQeg010031 for <931@emacsbugs.donarmstrong.com>; Fri, 12 Sep 2008 09:30:30 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AuUEACY2ykhFxIqP/2dsb2JhbACBY7Y4gWKBBg X-IronPort-AV: E=Sophos;i="4.32,390,1217822400"; d="scan'208";a="26730295" Received: from 69-196-138-143.dsl.teksavvy.com (HELO pastel.home) ([69.196.138.143]) by ironport2-out.teksavvy.com with ESMTP; 12 Sep 2008 12:30:20 -0400 Received: by pastel.home (Postfix, from userid 20848) id DA36B8136; Fri, 12 Sep 2008 12:30:20 -0400 (EDT) From: Stefan Monnier To: martin rudalics Cc: 931@debbugs.gnu.org, michael_heerdegen@web.de Subject: Re: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings Message-ID: References: <1220902523.951243.11457@green> <48C7921F.6020206@gmx.at> Date: Fri, 12 Sep 2008 12:30:20 -0400 In-Reply-To: <48C7921F.6020206@gmx.at> (martin rudalics's message of "Wed, 10 Sep 2008 11:23:43 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> + ;; `display-buffer' usually preserves current-buffer, except >> + ;; when it ends up doing switch-to-buffer (e.g. pop-up-windows >> + ;; is nil). > FWIW it's set_window_buffer in > /* We must select BUFFER for running the window-scroll-functions. > If WINDOW is selected, switch permanently. > Otherwise, switch but go back to the ambient buffer afterward. */ > if (EQ (window, selected_window)) > Fset_buffer (buffer); > which is not very clean (and not documented in `set-window-buffer'). I've fixed this so set-window-buffer should never change current-buffer now. Does it fix the OP's original problem? Stefan From rudalics@gmx.at Fri Sep 12 11:08:24 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 931) by emacsbugs.donarmstrong.com; 12 Sep 2008 18:08:24 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m8CI8K2i013862 for <931@emacsbugs.donarmstrong.com>; Fri, 12 Sep 2008 11:08:21 -0700 Received: (qmail invoked by alias); 12 Sep 2008 18:08:14 -0000 Received: from 62-47-50-244.adsl.highway.telekom.at (EHLO [62.47.50.244]) [62.47.50.244] by mail.gmx.net (mp054) with SMTP; 12 Sep 2008 20:08:14 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19yClcMxely7sSOUONGgorGgiG4mzC91DMwni2kFG tkWI5yHgU+BFrc Message-ID: <48CAAF4B.3060801@gmx.at> Date: Fri, 12 Sep 2008 20:04:59 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Stefan Monnier CC: 931@debbugs.gnu.org, michael_heerdegen@web.de Subject: Re: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings References: <1220902523.951243.11457@green> <48C7921F.6020206@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.74 > I've fixed this so set-window-buffer should never change > current-buffer now. Does it fix the OP's original problem? Keeping my fingers still crossed for that change, so I can't type much today ;-) FWIW it fixes the original problem but we should show *Compile-Log* instead of the original buffer when compilation finishes. As I suggested earlier `displaying-byte-compile-warnings' could do that when `pop-up-windows' is nil (maybe only if a critical bug has been found). This could be a wishlist item. martin From monnier@iro.umontreal.ca Fri Sep 12 12:52:11 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.8 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 931-close) by emacsbugs.donarmstrong.com; 12 Sep 2008 19:52:11 +0000 Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8CJq5CO019329 for <931-close@emacsbugs.donarmstrong.com>; Fri, 12 Sep 2008 12:52:09 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AuUEAARlykhFxIqP/2dsb2JhbACBY7YAgWKBBg X-IronPort-AV: E=Sophos;i="4.32,391,1217822400"; d="scan'208";a="26746442" Received: from 69-196-138-143.dsl.teksavvy.com (HELO pastel.home) ([69.196.138.143]) by ironport2-out.teksavvy.com with ESMTP; 12 Sep 2008 15:52:00 -0400 Received: by pastel.home (Postfix, from userid 20848) id 080848136; Fri, 12 Sep 2008 15:52:00 -0400 (EDT) From: Stefan Monnier To: martin rudalics Cc: 931-close@debbugs.gnu.org, michael_heerdegen@web.de Subject: Re: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings Message-ID: References: <1220902523.951243.11457@green> <48C7921F.6020206@gmx.at> <48CAAF4B.3060801@gmx.at> Date: Fri, 12 Sep 2008 15:51:59 -0400 In-Reply-To: <48CAAF4B.3060801@gmx.at> (martin rudalics's message of "Fri, 12 Sep 2008 20:04:59 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> I've fixed this so set-window-buffer should never change >> current-buffer now. Does it fix the OP's original problem? > Keeping my fingers still crossed for that change, so I can't type much > today ;-) > FWIW it fixes the original problem Good, thanks. > but we should show *Compile-Log* instead of the original buffer when > compilation finishes. That's a separate problem. And I'm not even sure if that's really what should happen anyway. > This could be a wishlist item. Indeed. Stefan From unknown Sat Aug 16 18:16:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Sat, 11 Oct 2008 14:24:03 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator