GNU bug report logs - #9258
24.0.50; image-next-line doesnt allow omitting arg

Previous Next

Package: emacs;

Reported by: joakim <at> verona.se

Date: Sat, 6 Aug 2011 22:15:02 UTC

Severity: minor

Tags: fixed

Found in version 24.0.50

Fixed in version 24.1

Done: Lars Magne Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 9258 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: joakim <at> verona.se
Cc: 9258 <at> debbugs.gnu.org
Subject: Re: bug#9258: 24.0.50; image-next-line doesnt allow omitting arg
Date: Sun, 07 Aug 2011 13:59:13 -0400

> (defun image-next-line (&optional n)
>   "Scroll image in current window upward by N lines.
> Stop if the bottom edge of the image is reached."
>   (interactive "p")
>   (cond ((= n 0) nil)
> 	((< n 0)
> 	 (image-set-window-vscroll (max 0 (+ (window-vscroll) n))))
> 	(t
> 	 (let* ((image (image-get-display-property))
> 		(edges (window-inside-edges))
> 		(win-height (- (nth 3 edges) (nth 1 edges)))
> 		(img-height (ceiling (cdr (image-display-size image)))))
> 	   (image-set-window-vscroll (min (max 0 (- img-height win-height))
> 					  (+ n (window-vscroll))))))))

> declaration says n is optional but nil will fail on the numeric tests.
> so, either n isn't optional or the cond rearanged.

Please just make it mandatory.


        Stefan
This bug report was last modified 13 years and 341 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.