From unknown Thu Aug 14 17:30:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#9229 <9229@debbugs.gnu.org> To: bug#9229 <9229@debbugs.gnu.org> Subject: Status: 24.0.50; Bidi problem with `cursor' property Reply-To: bug#9229 <9229@debbugs.gnu.org> Date: Fri, 15 Aug 2025 00:30:05 +0000 retitle 9229 24.0.50; Bidi problem with `cursor' property reassign 9229 emacs submitter 9229 Johan Bockg=C3=A5rd severity 9229 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 03 10:30:51 2011 Received: (at submit) by debbugs.gnu.org; 3 Aug 2011 14:30:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QocT8-0004eL-EK for submit@debbugs.gnu.org; Wed, 03 Aug 2011 10:30:51 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QocT4-0004e8-1h for submit@debbugs.gnu.org; Wed, 03 Aug 2011 10:30:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QocSV-00031h-1P for submit@debbugs.gnu.org; Wed, 03 Aug 2011 10:30:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:57219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QocSV-00031T-01 for submit@debbugs.gnu.org; Wed, 03 Aug 2011 10:30:07 -0400 Received: from eggs.gnu.org ([140.186.70.92]:51989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QocST-00080m-Ro for bug-gnu-emacs@gnu.org; Wed, 03 Aug 2011 10:30:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QocSS-0002zh-Va for bug-gnu-emacs@gnu.org; Wed, 03 Aug 2011 10:30:05 -0400 Received: from smtprelay-h21.telenor.se ([195.54.99.196]:49384) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QocSS-0002xz-Gw for bug-gnu-emacs@gnu.org; Wed, 03 Aug 2011 10:30:04 -0400 Received: from ipb2.telenor.se (ipb2.telenor.se [195.54.127.165]) by smtprelay-h21.telenor.se (Postfix) with ESMTP id CF164E9E0E for ; Wed, 3 Aug 2011 16:29:53 +0200 (CEST) X-SMTPAUTH-B2: [bocjoh] X-SENDER-IP: [85.228.202.196] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmaRAKxaOU5V5MrEPGdsb2JhbABCiQ6PPI8VCwEBAQE3MoIdXzQBBBgBDAqIG6B9oAmGQgSjYQ X-IronPort-AV: E=Sophos;i="4.67,310,1309730400"; d="scan'208";a="209869587" Received: from c-c4cae455.04-211-6c6b701.cust.bredbandsbolaget.se (HELO muon.localdomain) ([85.228.202.196]) by ipb2.telenor.se with ESMTP; 03 Aug 2011 16:29:53 +0200 Received: by muon.localdomain (Postfix, from userid 1000) id 5DE86484249; Wed, 3 Aug 2011 16:29:52 +0200 (CEST) From: =?utf-8?Q?Johan_Bockg=C3=A5rd?= To: bug-gnu-emacs@gnu.org Subject: 24.0.50; Bidi problem with `cursor' property Date: Wed, 03 Aug 2011 16:29:52 +0200 Message-ID: <87sjpi600v.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) The `cursor' property does not work properly on overlays when bidi-display-reordering is t and the overlay string is line wrapped. emacs -Q Eval (let ((o (make-overlay (point-max) (point-max))) (s (make-string (+ 5 (window-width)) ?-))) (put-text-property 0 1 'cursor t s) (overlay-put o 'after-string s) (goto-char (point-max))) The cursor is expected to be displayed before the overlay, but is displayed after it. (This bug makes icomplete-mode very confusing to use.) From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 03 12:22:51 2011 Received: (at 9229) by debbugs.gnu.org; 3 Aug 2011 16:22:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QoeDa-0000R8-W5 for submit@debbugs.gnu.org; Wed, 03 Aug 2011 12:22:51 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QoeDY-0000Qz-9v for 9229@debbugs.gnu.org; Wed, 03 Aug 2011 12:22:49 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LPD004001FH6H00@a-mtaout23.012.net.il> for 9229@debbugs.gnu.org; Wed, 03 Aug 2011 19:21:47 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.48.51]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LPD004B61G93K50@a-mtaout23.012.net.il>; Wed, 03 Aug 2011 19:21:47 +0300 (IDT) Date: Wed, 03 Aug 2011 19:19:45 +0300 From: Eli Zaretskii Subject: Re: bug#9229: 24.0.50; Bidi problem with `cursor' property In-reply-to: <87sjpi600v.fsf@gnu.org> To: Johan =?WINDOWS-1255?Q?Bockg=E5rd?= Message-id: <83ei12a2n2.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-transfer-encoding: QUOTED-PRINTABLE X-012-Sender: halo1@inter.net.il References: <87sjpi600v.fsf@gnu.org> X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 9229 Cc: 9229@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.7 (-) > From: Johan Bockg=E5rd > Date: Wed, 03 Aug 2011 16:29:52 +0200 >=20 >=20 > (let ((o (make-overlay (point-max) (point-max))) > (s (make-string (+ 5 (window-width)) ?-))) > (put-text-property 0 1 'cursor t s) > (overlay-put o 'after-string s) > (goto-char (point-max))) >=20 > The cursor is expected to be displayed before the overlay, but is > displayed after it. >=20 > (This bug makes icomplete-mode very confusing to use.) Thanks, I will get to this soon. Sorry for the inconvenience. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 03 15:16:16 2011 Received: (at 9229) by debbugs.gnu.org; 3 Aug 2011 19:16:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QogvQ-0004Rw-LY for submit@debbugs.gnu.org; Wed, 03 Aug 2011 15:16:16 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QogvN-0004Rl-R4 for 9229@debbugs.gnu.org; Wed, 03 Aug 2011 15:16:15 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LPD001009EQXK00@a-mtaout20.012.net.il> for 9229@debbugs.gnu.org; Wed, 03 Aug 2011 22:15:18 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.48.51]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LPD000NU9HGV2I0@a-mtaout20.012.net.il>; Wed, 03 Aug 2011 22:15:18 +0300 (IDT) Date: Wed, 03 Aug 2011 22:13:16 +0300 From: Eli Zaretskii Subject: Re: bug#9229: 24.0.50; Bidi problem with `cursor' property In-reply-to: <83ei12a2n2.fsf@gnu.org> To: bojohan@gnu.org Message-id: <837h6upaur.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-transfer-encoding: QUOTED-PRINTABLE X-012-Sender: halo1@inter.net.il References: <87sjpi600v.fsf@gnu.org> <83ei12a2n2.fsf@gnu.org> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 9229 Cc: 9229@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > Date: Wed, 03 Aug 2011 19:19:45 +0300 > From: Eli Zaretskii > Cc: 9229@debbugs.gnu.org >=20 > > From: Johan Bockg=E5rd > > Date: Wed, 03 Aug 2011 16:29:52 +0200 > >=20 > >=20 > > (let ((o (make-overlay (point-max) (point-max))) > > (s (make-string (+ 5 (window-width)) ?-))) > > (put-text-property 0 1 'cursor t s) > > (overlay-put o 'after-string s) > > (goto-char (point-max))) > >=20 > > The cursor is expected to be displayed before the overlay, but is > > displayed after it. > >=20 > > (This bug makes icomplete-mode very confusing to use.) Does the patch below give good results? If it solves this particular problem, please try it in your regular use for a day or two, and see if there are any adverse effects. If you don't spot any trouble, I will install this on the trunk. Thanks. Here's the patch to try: =3D=3D=3D modified file 'src/xdisp.c' --- src/xdisp.c=092011-08-03 05:24:30 +0000 +++ src/xdisp.c=092011-08-03 19:04:49 +0000 @@ -13706,14 +13706,15 @@ set_cursor_from_row (struct window *w, s w->cursor.vpos >=3D 0 /* that candidate is not the row we are processing */ && MATRIX_ROW (matrix, w->cursor.vpos) !=3D row - /* the row we are processing is part of a continued line */ - && (row->continued_p || MATRIX_ROW_CONTINUATION_LINE_P (row)) /* Make sure cursor.vpos specifies a row whose start and end =09 charpos occlude point. This is because some callers of this =09 function leave cursor.vpos at the row where the cursor was =09 displayed during the last redisplay cycle. */ && MATRIX_ROW_START_CHARPOS (MATRIX_ROW (matrix, w->cursor.vpo= s)) <=3D pt_old - && pt_old < MATRIX_ROW_END_CHARPOS (MATRIX_ROW (matrix, w->cur= sor.vpos))) + && (pt_old < MATRIX_ROW_END_CHARPOS (MATRIX_ROW (matrix, w->cu= rsor.vpos)) +=09 /* the entire line is from display string */ +=09 || (pt_old =3D=3D MATRIX_ROW_START_CHARPOS (MATRIX_ROW (matrix,= w->cursor.vpos)) +=09 && pt_old =3D=3D MATRIX_ROW_END_CHARPOS (MATRIX_ROW (matrix= , w->cursor.vpos))))) { struct glyph *g1 =3D =09MATRIX_ROW_GLYPH_START (matrix, w->cursor.vpos) + w->cursor.hpos; @@ -13722,15 +13723,20 @@ set_cursor_from_row (struct window *w, s if (!(row->reversed_p ? glyph > glyphs_end : glyph < glyphs_en= d)) =09return 0; /* Keep the candidate whose buffer position is the closest to -=09 point. */ +=09 point or has the `cursor' property. */ if (/* previous candidate is a glyph in TEXT_AREA of that row = */ =09 w->cursor.hpos >=3D 0 =09 && w->cursor.hpos < MATRIX_ROW_USED (matrix, w->cursor.vpos) -=09 && BUFFERP (g1->object) -=09 && (g1->charpos =3D=3D pt_old /* an exact match always wins */ -=09 || (BUFFERP (glyph->object) -=09=09 && eabs (g1->charpos - pt_old) -=09=09 < eabs (glyph->charpos - pt_old)))) +=09 && ((BUFFERP (g1->object) +=09 && (g1->charpos =3D=3D pt_old /* an exact match always win= s */ +=09=09 || (BUFFERP (glyph->object) +=09=09 && eabs (g1->charpos - pt_old) +=09=09 < eabs (glyph->charpos - pt_old)))) +=09 /* previous candidate is a glyph from a string that has +=09=09 a non-nil `cursor' property */ +=09 || (STRINGP (g1->object) +=09=09 && !NILP (Fget_char_property (make_number (g1->charpos), +=09=09=09=09=09=09Qcursor, g1->object))))) =09return 0; /* If this candidate gives an exact match, use that. */ if (!(BUFFERP (glyph->object) && glyph->charpos =3D=3D pt_old) From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 03 16:04:46 2011 Received: (at 9229) by debbugs.gnu.org; 3 Aug 2011 20:04:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QohgM-0005YN-Dn for submit@debbugs.gnu.org; Wed, 03 Aug 2011 16:04:46 -0400 Received: from smtprelay-b12.telenor.se ([62.127.194.21]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QohgK-0005YD-8Z for 9229@debbugs.gnu.org; Wed, 03 Aug 2011 16:04:45 -0400 Received: from ipb1.telenor.se (ipb1.telenor.se [195.54.127.164]) by smtprelay-b12.telenor.se (Postfix) with ESMTP id 15B7EE9880 for <9229@debbugs.gnu.org>; Wed, 3 Aug 2011 22:04:08 +0200 (CEST) X-SMTPAUTH-B2: [bocjoh] X-SENDER-IP: [85.228.202.196] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AidoAJGpOU5V5MrEPGdsb2JhbABChEeER55SCwEBAQE3MoFAAQEEASMzIxALFAEFAgUhAgIPAQQYAQwKGhOHbAKvYZFEgSuEB4EQBKNh X-IronPort-AV: E=Sophos;i="4.67,312,1309730400"; d="scan'208";a="211439550" Received: from c-c4cae455.04-211-6c6b701.cust.bredbandsbolaget.se (HELO muon.localdomain) ([85.228.202.196]) by ipb1.telenor.se with ESMTP; 03 Aug 2011 22:03:54 +0200 Received: by muon.localdomain (Postfix, from userid 1000) id A20C248446C; Wed, 3 Aug 2011 22:03:52 +0200 (CEST) From: =?utf-8?Q?Johan_Bockg=C3=A5rd?= To: Eli Zaretskii Subject: Re: bug#9229: 24.0.50; Bidi problem with `cursor' property References: <87sjpi600v.fsf@gnu.org> <83ei12a2n2.fsf@gnu.org> <837h6upaur.fsf@gnu.org> Date: Wed, 03 Aug 2011 22:03:51 +0200 In-Reply-To: <837h6upaur.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 03 Aug 2011 22:13:16 +0300") Message-ID: <87liva5kk8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9229 Cc: 9229@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Eli Zaretskii writes: >> Date: Wed, 03 Aug 2011 19:19:45 +0300 >> From: Eli Zaretskii >> Cc: 9229@debbugs.gnu.org >>=20 >> > From: Johan Bockg=C3=A5rd >> > Date: Wed, 03 Aug 2011 16:29:52 +0200 >> >=20 >> >=20 >> > (let ((o (make-overlay (point-max) (point-max))) >> > (s (make-string (+ 5 (window-width)) ?-))) >> > (put-text-property 0 1 'cursor t s) >> > (overlay-put o 'after-string s) >> > (goto-char (point-max))) >> >=20 >> > The cursor is expected to be displayed before the overlay, but is >> > displayed after it. >> >=20 >> > (This bug makes icomplete-mode very confusing to use.) > > Does the patch below give good results? If it solves this particular > problem, please try it in your regular use for a day or two, and see > if there are any adverse effects. If you don't spot any trouble, I > will install this on the trunk. Apparently, the patch only tries to fix the case where "the entire line is from display string", which doesn't solve the icomplete problem: emacs -Q M-x icomplete-mode RET M-x a From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 03 16:44:34 2011 Received: (at 9229) by debbugs.gnu.org; 3 Aug 2011 20:44:34 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QoiIs-0006WI-8u for submit@debbugs.gnu.org; Wed, 03 Aug 2011 16:44:34 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QoiIp-0006W8-ET for 9229@debbugs.gnu.org; Wed, 03 Aug 2011 16:44:32 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LPD00H00CYU7F00@a-mtaout22.012.net.il> for 9229@debbugs.gnu.org; Wed, 03 Aug 2011 23:43:50 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.94.185]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LPD00G3KDL1U4G0@a-mtaout22.012.net.il>; Wed, 03 Aug 2011 23:43:50 +0300 (IDT) Date: Wed, 03 Aug 2011 23:41:49 +0300 From: Eli Zaretskii Subject: Re: bug#9229: 24.0.50; Bidi problem with `cursor' property In-reply-to: <87liva5kk8.fsf@gnu.org> To: Johan =?WINDOWS-1255?Q?Bockg=C3=A5rd?= Message-id: <83zkjqns6q.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: QUOTED-PRINTABLE X-012-Sender: halo1@inter.net.il References: <87sjpi600v.fsf@gnu.org> <83ei12a2n2.fsf@gnu.org> <837h6upaur.fsf@gnu.org> <87liva5kk8.fsf@gnu.org> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 9229 Cc: 9229@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: Johan Bockg=C3=A5rd > Cc: 9229@debbugs.gnu.org > Date: Wed, 03 Aug 2011 22:03:51 +0200 >=20 > Apparently, the patch only tries to fix the case where "the entire = line > is from display string", which doesn't solve the icomplete problem: >=20 > emacs -Q >=20 > M-x icomplete-mode RET >=20 > M-x a What about this one? (Apply it after "bzr revert".) =3D=3D=3D modified file 'src/xdisp.c' --- src/xdisp.c=092011-08-03 05:24:30 +0000 +++ src/xdisp.c=092011-08-03 20:33:08 +0000 @@ -13706,14 +13706,12 @@ set_cursor_from_row (struct window *w, s w->cursor.vpos >=3D 0 /* that candidate is not the row we are processing */ && MATRIX_ROW (matrix, w->cursor.vpos) !=3D row - /* the row we are processing is part of a continued line */ - && (row->continued_p || MATRIX_ROW_CONTINUATION_LINE_P (row)) /* Make sure cursor.vpos specifies a row whose start and end =09 charpos occlude point. This is because some callers of this =09 function leave cursor.vpos at the row where the cursor was =09 displayed during the last redisplay cycle. */ && MATRIX_ROW_START_CHARPOS (MATRIX_ROW (matrix, w->cursor.vpo= s)) <=3D pt_old - && pt_old < MATRIX_ROW_END_CHARPOS (MATRIX_ROW (matrix, w->cur= sor.vpos))) + && pt_old <=3D MATRIX_ROW_END_CHARPOS (MATRIX_ROW (matrix, w->= cursor.vpos))) { struct glyph *g1 =3D =09MATRIX_ROW_GLYPH_START (matrix, w->cursor.vpos) + w->cursor.hpos; @@ -13722,15 +13720,20 @@ set_cursor_from_row (struct window *w, s if (!(row->reversed_p ? glyph > glyphs_end : glyph < glyphs_en= d)) =09return 0; /* Keep the candidate whose buffer position is the closest to -=09 point. */ +=09 point or has the `cursor' property. */ if (/* previous candidate is a glyph in TEXT_AREA of that row = */ =09 w->cursor.hpos >=3D 0 =09 && w->cursor.hpos < MATRIX_ROW_USED (matrix, w->cursor.vpos) -=09 && BUFFERP (g1->object) -=09 && (g1->charpos =3D=3D pt_old /* an exact match always wins */ -=09 || (BUFFERP (glyph->object) -=09=09 && eabs (g1->charpos - pt_old) -=09=09 < eabs (glyph->charpos - pt_old)))) +=09 && ((BUFFERP (g1->object) +=09 && (g1->charpos =3D=3D pt_old /* an exact match always win= s */ +=09=09 || (BUFFERP (glyph->object) +=09=09 && eabs (g1->charpos - pt_old) +=09=09 < eabs (glyph->charpos - pt_old)))) +=09 /* previous candidate is a glyph from a string that has +=09=09 a non-nil `cursor' property */ +=09 || (STRINGP (g1->object) +=09=09 && !NILP (Fget_char_property (make_number (g1->charpos), +=09=09=09=09=09=09Qcursor, g1->object))))) =09return 0; /* If this candidate gives an exact match, use that. */ if (!(BUFFERP (glyph->object) && glyph->charpos =3D=3D pt_old) From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 04 12:29:35 2011 Received: (at 9229) by debbugs.gnu.org; 4 Aug 2011 16:29:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qp0ne-0001ZJ-SD for submit@debbugs.gnu.org; Thu, 04 Aug 2011 12:29:35 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qp0nc-0001Z9-Iz for 9229@debbugs.gnu.org; Thu, 04 Aug 2011 12:29:33 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LPE00F00WCYGF00@a-mtaout20.012.net.il> for 9229@debbugs.gnu.org; Thu, 04 Aug 2011 19:28:43 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.94.185]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LPE00ERXWFU2KN0@a-mtaout20.012.net.il>; Thu, 04 Aug 2011 19:28:43 +0300 (IDT) Date: Thu, 04 Aug 2011 19:26:43 +0300 From: Eli Zaretskii Subject: Re: bug#9229: 24.0.50; Bidi problem with `cursor' property In-reply-to: <83zkjqns6q.fsf@gnu.org> To: bojohan@gnu.org Message-id: <83wretnnwc.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: QUOTED-PRINTABLE X-012-Sender: halo1@inter.net.il References: <87sjpi600v.fsf@gnu.org> <83ei12a2n2.fsf@gnu.org> <837h6upaur.fsf@gnu.org> <87liva5kk8.fsf@gnu.org> <83zkjqns6q.fsf@gnu.org> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 9229 Cc: 9229@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > Date: Wed, 03 Aug 2011 23:41:49 +0300 > From: Eli Zaretskii > Cc: 9229@debbugs.gnu.org >=20 > > From: Johan Bockg=C3=A5rd > > Cc: 9229@debbugs.gnu.org > > Date: Wed, 03 Aug 2011 22:03:51 +0200 > >=20 > > Apparently, the patch only tries to fix the case where "the entir= e line > > is from display string", which doesn't solve the icomplete proble= m: > >=20 > > emacs -Q > >=20 > > M-x icomplete-mode RET > >=20 > > M-x a >=20 > What about this one? (Apply it after "bzr revert".) Any experience with this patch, positive or otherwise? TIA From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 04 12:46:39 2011 Received: (at 9229) by debbugs.gnu.org; 4 Aug 2011 16:46:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qp14B-0001zU-8y for submit@debbugs.gnu.org; Thu, 04 Aug 2011 12:46:39 -0400 Received: from smtprelay-h22.telenor.se ([195.54.99.197]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qp147-0001zL-GC for 9229@debbugs.gnu.org; Thu, 04 Aug 2011 12:46:36 -0400 Received: from ipb3.telenor.se (ipb3.telenor.se [195.54.127.166]) by smtprelay-h22.telenor.se (Postfix) with ESMTP id 2E93BE9D88 for <9229@debbugs.gnu.org>; Thu, 4 Aug 2011 18:45:53 +0200 (CEST) X-SMTPAUTH-B2: [bocjoh] X-SENDER-IP: [85.228.202.196] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Asl1AJbLOk5V5MrEPGdsb2JhbABDiQ6eWQsBAQEBNzKBQAEBBAFWIwULCyElDwEEGAEMChoTh2wCwViGQgSjYQ X-IronPort-AV: E=Sophos;i="4.67,318,1309730400"; d="scan'208";a="32901984" Received: from c-c4cae455.04-211-6c6b701.cust.bredbandsbolaget.se (HELO muon.localdomain) ([85.228.202.196]) by ipb3.telenor.se with ESMTP; 04 Aug 2011 18:45:53 +0200 Received: by muon.localdomain (Postfix, from userid 1000) id 3B0B3484280; Thu, 4 Aug 2011 18:45:52 +0200 (CEST) From: =?utf-8?Q?Johan_Bockg=C3=A5rd?= To: Eli Zaretskii Subject: Re: bug#9229: 24.0.50; Bidi problem with `cursor' property References: <87sjpi600v.fsf@gnu.org> <83ei12a2n2.fsf@gnu.org> <837h6upaur.fsf@gnu.org> <87liva5kk8.fsf@gnu.org> <83zkjqns6q.fsf@gnu.org> <83wretnnwc.fsf@gnu.org> Mail-Copies-To: never Date: Thu, 04 Aug 2011 18:45:51 +0200 In-Reply-To: <83wretnnwc.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 04 Aug 2011 19:26:43 +0300") Message-ID: <87fwlhi0qo.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9229 Cc: 9229@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Eli Zaretskii writes: > Any experience with this patch, positive or otherwise? It works so far. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 05 06:37:06 2011 Received: (at 9229-done) by debbugs.gnu.org; 5 Aug 2011 10:37:06 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QpHm5-0000gQ-SS for submit@debbugs.gnu.org; Fri, 05 Aug 2011 06:37:06 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QpHm2-0000fz-GH for 9229-done@debbugs.gnu.org; Fri, 05 Aug 2011 06:37:03 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LPG00E00AGV6K00@a-mtaout23.012.net.il> for 9229-done@debbugs.gnu.org; Fri, 05 Aug 2011 13:36:16 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.94.185]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LPG00ER4ASF3G60@a-mtaout23.012.net.il>; Fri, 05 Aug 2011 13:36:16 +0300 (IDT) Date: Fri, 05 Aug 2011 13:34:16 +0300 From: Eli Zaretskii Subject: Re: bug#9229: 24.0.50; Bidi problem with `cursor' property In-reply-to: <87fwlhi0qo.fsf@gnu.org> To: Johan =?WINDOWS-1255?Q?Bockg=E5rd?= Message-id: <83ipqcno47.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-transfer-encoding: QUOTED-PRINTABLE X-012-Sender: halo1@inter.net.il References: <87sjpi600v.fsf@gnu.org> <83ei12a2n2.fsf@gnu.org> <837h6upaur.fsf@gnu.org> <87liva5kk8.fsf@gnu.org> <83zkjqns6q.fsf@gnu.org> <83wretnnwc.fsf@gnu.org> <87fwlhi0qo.fsf@gnu.org> X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 9229-done Cc: 9229-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.7 (-) > From: Johan Bockg=E5rd > Cc: 9229@debbugs.gnu.org > Date: Thu, 04 Aug 2011 18:45:51 +0200 >=20 > Eli Zaretskii writes: >=20 > > Any experience with this patch, positive or otherwise? >=20 > It works so far. Thanks. Committed as revision 105406 on the trunk. Thanks. From unknown Thu Aug 14 17:30:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 02 Sep 2011 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator