Subject: bug#9203: 24.0.50; some Clang experience

From: Andreas Schwab <[email-masked]>
Date: Sat, 30 Jul 2011 15:22:11 +0200

Eli Zaretskii <[email-masked]> writes:

>> From: Peter Dyballa <[email-masked]>
>> Date: Sat, 30 Jul 2011 13:53:30 +0200
>> 
>> When using
>> 
>> 	Apple clang version 2.0 (tags/Apple/clang-139) (based on LLVM 2.9svn)
>> 	Target: x86_64-apple-darwin10
>> 	Thread model: posix
>> 
>> to compile GNU Emacs on Mac OS X 10.6.8 with intel Core i7 it warns about some statements:
>> 
>> emacs-24.0.50/lib-src/../src/regex.c:6603:15: warning: 
>>       comparison of unsigned enum expression >= 0 is always true [-Wtautological-compare]
>>       if (ret >= 0)
>>           ~~~ ^  ~
>
> `ret' is of the type `reg_errcode_t', which is an enumerated data
> type, so its signedness is implementation-defined, AFAIK.

But re_search returns regoff_t, so the type is wrong.

Andreas.

-- 
Andreas Schwab, [email-masked]
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."