Subject: bug#9170: [PATCH] cp "restores" permissions it never set

From: Eric Blake <[email-masked]>
Date: Mon, 25 Jul 2011 15:21:33 -0600

On 07/25/2011 03:06 PM, Paul Eggert wrote:
> Thanks for the bug report.  I committed this patch:
>
> +++ b/src/copy.c
> @@ -2211,6 +2211,8 @@ copy_internal (char const *src_name, char const *dst_name,
>             if (x->verbose)
>               emit_verbose (src_name, dst_name, NULL);
>           }
> +      else
> +        omitted_permissions = 0;

This violates the style guide in HACKING; it should either be:

if (!cond)
   omitted_permissions = 0;
else
   {
     lots of lines
   }

or:

if (cond)
   {
      lots of lines
   }
else
   {
     omitted_permissions = 0;
   }

-- 
Eric Blake   [email-masked]    +1-801-349-2682
Libvirt virtualization library http://libvirt.org