GNU bug report logs - #9157
[PATCH] dd: sparse conv flag

Previous Next

Full log

Message #26 received at 9157 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 9157 <at> debbugs.gnu.org, "Roman Rybalko \(devel\)" <devel <at> romanr.info>
Subject: Re: bug#9157: [PATCH] dd: sparse conv flag
Date: Mon, 27 Feb 2012 16:10:23 +0000

On 02/27/2012 03:50 PM, Paul Eggert wrote:
> Thanks for looking into this!  Some nits:
> 
> On 02/27/2012 07:20 AM, Pádraig Brady wrote:
>> +is_nul (const char* buf, size_t bufsize)
> 
> The usual spacing style is "const char *buf", since the
> "*" really belongs to the "buf" in C.
> 
>> +  memset (obuf + output_blocksize, 1, sizeof (uintptr_t));
> 
> This constraint on OUTPUT_BLOCK_SLOP should be documented, thus:
> 
> #define OUTPUT_BLOCK_SLOP MAX (sizeof (uintptr_t), page_size - 1)
> 
>> +  /* write sentinel to slop after the buffer,
>> +     to allow efficient checking for NUL blocks.  */
> 
> Initial cap for sentence.  The next comment has a similar issue.
> 

Thanks Paul. Adjustments made.

I'm also thinking I should warn once when
the new lseek fails, but only after the fall back
write() succeeds.

cheers,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.