From unknown Wed Sep 10 19:32:15 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#9149 <9149@debbugs.gnu.org> To: bug#9149 <9149@debbugs.gnu.org> Subject: Status: 24.0.50; regression on mouse-face for completions Reply-To: bug#9149 <9149@debbugs.gnu.org> Date: Thu, 11 Sep 2025 02:32:15 +0000 retitle 9149 24.0.50; regression on mouse-face for completions reassign 9149 emacs submitter 9149 "Drew Adams" severity 9149 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 22 10:57:18 2011 Received: (at submit) by debbugs.gnu.org; 22 Jul 2011 14:57:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkHAE-0002pJ-Cn for submit@debbugs.gnu.org; Fri, 22 Jul 2011 10:57:18 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkHAC-0002p7-Cz for submit@debbugs.gnu.org; Fri, 22 Jul 2011 10:57:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QkHA6-0003uS-K4 for submit@debbugs.gnu.org; Fri, 22 Jul 2011 10:57:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:38939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkHA6-0003uO-IZ for submit@debbugs.gnu.org; Fri, 22 Jul 2011 10:57:10 -0400 Received: from eggs.gnu.org ([140.186.70.92]:46078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkHA5-0002ND-JA for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2011 10:57:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QkHA4-0003th-A4 for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2011 10:57:09 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:26212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkHA4-0003rU-45 for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2011 10:57:08 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p6MEv2tY008659 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 22 Jul 2011 14:57:04 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p6MEv1ed029085 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 22 Jul 2011 14:57:02 GMT Received: from abhmt117.oracle.com (abhmt117.oracle.com [141.146.116.69]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p6MEuusn011999 for ; Fri, 22 Jul 2011 09:56:56 -0500 Received: from dradamslap1 (/10.159.44.149) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 22 Jul 2011 07:56:56 -0700 From: "Drew Adams" To: Subject: 24.0.50; regression on mouse-face for completions Date: Fri, 22 Jul 2011 07:56:56 -0700 Message-ID: <5AD5B9D01FE74B009E3E5697483A6E47@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 Thread-Index: AcxIf5mYlH1BlsxCTp616omd3wbDEg== X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090202.4E298FC1.000C:SCFMA922111,ss=1,re=-4.000,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) This bug seems to have been introduced between the published Windows builds of 2010-10-19 (no bug) and 2010-10-25 (bug). I tried to examine changes made to the sources during that week, but didn't see anything super obvious as the cause. What might have introduced the bug was this change (just a guess): Eli Zaretskii2010-10-23 15:30:45(101157.1.16 test) Revision ID: eliz@gnu.org-20101023153045-9zcud9tw7y2p7b3a Implement mouse highlight for bidi-reordered lines. xdisp.c (fast_find_string_pos): #ifdef away, not used anymore. (mouse_face_from_string_pos): New function, replaces fast_find_string_pos. (note_mouse_highlight): Call it instead of fast_find_string_pos. (note_mode_line_or_margin_highlight): Support bidi-reordered strings and R2L glyph rows. Fix comments. (note_mouse_highlight): When bidi reordering is turned on in a buffer, call next-single-property-change and previous-single-property-change with last argument nil. Clear mouse highlight when mouse pointer is in a R2L row on the stretch glyph that stands for no text beyond the line end. (row_containing_pos): Don't return too early when CHARPOS is in a bidi-reordered continued line. Return immediately when the first hit is found in a line that is not continued, or when an exact match for CHARPOS is found. (rows_from_pos_range): New function. (mouse_face_from_buffer_pos): Use it instead of calling row_containing_pos for START_CHARPOS and END_CHARPOS. Rewrite the function to support mouse highlight in bidi-reordered lines and not to assume that START_CHARPOS is always in mouse_face_beg_row. If necessary, swap mouse_face_beg_row and mouse_face_end_row so that the former is always above the latter or identical to it. (show_mouse_face): Support drawing highlighted R2L lines. (coords_in_mouse_face_p): New function, bidi-aware. (cursor_in_mouse_face_p, note_mouse_highlight, erase_phys_cursor): Call it instead of comparing with mouse-face members of dpyinfo. (note_mode_line_or_margin_highlight): Fix confusingly swapped usage of hpos and vpos. files modified: src/ChangeLog src/xdisp.c The bug is that the `mouse-face' highlighting is not applied to an entire completion candidate, if that candidate is multiline and it contains an empty line. What happens is that the `mouse-face' highlighting stops as soon as the empty line (i.e., \n$) is encountered. The rest of the text of the candidate does not have the `mouse-face' highlighting. Here's a recipe to reproduce the problem: emacs -Q Evaluate this code: (setq foo '(("abcdefgh ijklmn opqrst uvwxyz abcde") ("123456 7890123 45678 9012345 678901 23456"))) (completing-read "ff: " foo) When you evaluate the `completing-read' call, move the mouse pointer over the two candidates in *Completions*. Each candidate should be completely `mouse-face' highlighted, but is not. The highlighting of each candidate stops as soon as the first blank line within the candidate is encountered. In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2011-07-18 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.5) --no-opt --cflags -Ic:/build/include' From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 22 13:45:55 2011 Received: (at 9149-done) by debbugs.gnu.org; 22 Jul 2011 17:45:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkJnO-0006mq-VR for submit@debbugs.gnu.org; Fri, 22 Jul 2011 13:45:55 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkJnN-0006md-25 for 9149-done@debbugs.gnu.org; Fri, 22 Jul 2011 13:45:53 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LOQ00I00X9UFO00@a-mtaout20.012.net.il> for 9149-done@debbugs.gnu.org; Fri, 22 Jul 2011 20:45:41 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.229.133.66]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LOQ00IVHXC4F910@a-mtaout20.012.net.il>; Fri, 22 Jul 2011 20:45:41 +0300 (IDT) Date: Fri, 22 Jul 2011 20:45:46 +0300 From: Eli Zaretskii Subject: Re: bug#9149: 24.0.50; regression on mouse-face for completions In-reply-to: <5AD5B9D01FE74B009E3E5697483A6E47@us.oracle.com> X-012-Sender: halo1@inter.net.il To: Drew Adams Message-id: <83aac6dx9x.fsf@gnu.org> References: <5AD5B9D01FE74B009E3E5697483A6E47@us.oracle.com> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 9149-done Cc: 9149-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: "Drew Adams" > Date: Fri, 22 Jul 2011 07:56:56 -0700 > > This bug seems to have been introduced between the published Windows > builds of 2010-10-19 (no bug) and 2010-10-25 (bug). I tried to examine > changes made to the sources during that week, but didn't see anything > super obvious as the cause. > > What might have introduced the bug was this change (just a guess): > > Eli Zaretskii2010-10-23 15:30:45(101157.1.16 test) > Revision ID: eliz@gnu.org-20101023153045-9zcud9tw7y2p7b3a > > Implement mouse highlight for bidi-reordered lines. Yes, it was my fault. Should be fixed now. Thanks for the test case. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 22 13:55:32 2011 Received: (at 9149-done) by debbugs.gnu.org; 22 Jul 2011 17:55:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkJwi-00070G-DR for submit@debbugs.gnu.org; Fri, 22 Jul 2011 13:55:32 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkJwg-000704-7u for 9149-done@debbugs.gnu.org; Fri, 22 Jul 2011 13:55:30 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p6MHtMbX018401 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 22 Jul 2011 17:55:24 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p6MHtLPS003911 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 22 Jul 2011 17:55:22 GMT Received: from abhmt107.oracle.com (abhmt107.oracle.com [141.146.116.59]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p6MHtGw5026548; Fri, 22 Jul 2011 12:55:16 -0500 Received: from dradamslap1 (/10.159.44.149) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 22 Jul 2011 10:55:16 -0700 From: "Drew Adams" To: "'Eli Zaretskii'" References: <5AD5B9D01FE74B009E3E5697483A6E47@us.oracle.com> <83aac6dx9x.fsf@gnu.org> Subject: RE: bug#9149: 24.0.50; regression on mouse-face for completions Date: Fri, 22 Jul 2011 10:55:17 -0700 Message-ID: <49EFB89CD930494396220CA420CDCFD2@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <83aac6dx9x.fsf@gnu.org> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 Thread-Index: AcxIlzVlVUf+5oSsS56dpKh6FoVdpgAAUfBQ X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090207.4E29B98C.0122:SCFMA922111,ss=1,re=-4.000,fgs=0 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 9149-done Cc: 9149-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) That was quick. Thank you. From unknown Wed Sep 10 19:32:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 20 Aug 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator