From unknown Fri Aug 15 12:50:52 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#9140 <9140@debbugs.gnu.org> To: bug#9140 <9140@debbugs.gnu.org> Subject: Status: [du] broken on OSX 10.7 (Lion) for >4TB file systems Reply-To: bug#9140 <9140@debbugs.gnu.org> Date: Fri, 15 Aug 2025 19:50:52 +0000 retitle 9140 [du] broken on OSX 10.7 (Lion) for >4TB file systems reassign 9140 coreutils submitter 9140 Herb Wartens severity 9140 normal tag 9140 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 21 12:04:02 2011 Received: (at submit) by debbugs.gnu.org; 21 Jul 2011 16:04:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QjvjF-0002yM-E9 for submit@debbugs.gnu.org; Thu, 21 Jul 2011 12:04:01 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qjn9S-0006bJ-Am for submit@debbugs.gnu.org; Thu, 21 Jul 2011 02:54:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qjn9M-0003io-FT for submit@debbugs.gnu.org; Thu, 21 Jul 2011 02:54:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:39956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qjn9M-0003ik-Dx for submit@debbugs.gnu.org; Thu, 21 Jul 2011 02:54:24 -0400 Received: from eggs.gnu.org ([140.186.70.92]:40534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qjn9L-0001KN-Jg for bug-coreutils@gnu.org; Thu, 21 Jul 2011 02:54:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qjn9K-0003i0-Bw for bug-coreutils@gnu.org; Thu, 21 Jul 2011 02:54:23 -0400 Received: from mail-yw0-f41.google.com ([209.85.213.41]:64410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qjn9K-0003hl-9F for bug-coreutils@gnu.org; Thu, 21 Jul 2011 02:54:22 -0400 Received: by ywm39 with SMTP id 39so562931ywm.0 for ; Wed, 20 Jul 2011 23:54:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:content-type:subject:date:message-id:to:mime-version:x-mailer; bh=0LBsrYgzkQQkJ930xdMuH0GeJegXI6LnHhCVqNVMe5k=; b=kG4PkAwl8p6Wv2xnHDdeBhZTDk8xdTvBYJuRQWz7DVcWBIaxhAACb3J9w8q7n5HxJn 890QNksQ+7uR4TGdwW9FRAe6sp7s38+0YDMpJ9jKNG6o4dAFP2+68Z8aTTJlgvda0TVY Mt5HIusCS/v7UV0NIAf/CqHSYIzt+4wNDngRE= Received: by 10.151.11.16 with SMTP id o16mr256706ybi.172.1311231260994; Wed, 20 Jul 2011 23:54:20 -0700 (PDT) Received: from [192.168.101.145] (76-247-188-17.lightspeed.sntcca.sbcglobal.net [76.247.188.17]) by mx.google.com with ESMTPS id x11sm714034ibd.7.2011.07.20.23.54.19 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 20 Jul 2011 23:54:19 -0700 (PDT) From: Herb Wartens Content-Type: multipart/mixed; boundary="Apple-Mail=_190337A3-4D15-4ED8-9C53-CFA4C2682562" Subject: Coreutils Bug on OSX 10.7 (Lion) Date: Wed, 20 Jul 2011 23:54:17 -0700 Message-Id: To: bug-coreutils@gnu.org Mime-Version: 1.0 (Apple Message framework v1244.3) X-Mailer: Apple Mail (2.1244.3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 21 Jul 2011 12:03:59 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) --Apple-Mail=_190337A3-4D15-4ED8-9C53-CFA4C2682562 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii After installing coreutils-8.12 on OSX 10.7 today, I found an issue = immediately where df was overflowing the structure returned from = statvfs. On OSX 10.7 the relevant fields of the statvfs structure are = defined to be fsblkcnt_t, or only 4 bytes long. I have put together an = initial fix for 10.7. Hope this helps. Looking through your bug reports, I believe this is likely a fix for bug = 7355. -Herb --Apple-Mail=_190337A3-4D15-4ED8-9C53-CFA4C2682562 Content-Disposition: attachment; filename=coreutils_du.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="coreutils_du.diff" Content-Transfer-Encoding: 7bit --- coreutils-8.12/lib/fsusage.c 2011-04-24 10:21:45.000000000 -0700 +++ coreutils-8.12.new/lib/fsusage.c 2011-07-20 23:50:51.000000000 -0700 @@ -23,7 +23,11 @@ #include #include -#if STAT_STATVFS /* POSIX 1003.1-2001 (and later) with XSI */ +#if defined __APPLE__ && defined __MACH__ && HAVE_LANGINFO_CODESET +#define DARWIN7 +#endif + +#if STAT_STATVFS && !defined(DARWIN7) /* POSIX 1003.1-2001 (and later) with XSI */ # include #else /* Don't include backward-compatibility files unless they're needed. @@ -94,7 +98,7 @@ int get_fs_usage (char const *file, char const *disk, struct fs_usage *fsp) { -#if defined STAT_STATVFS /* POSIX, except glibc/Linux */ +#if defined STAT_STATVFS && ! defined DARWIN7 /* POSIX, except glibc/Linux */ struct statvfs fsd; @@ -165,9 +169,11 @@ get_fs_usage (char const *file, char con fsp->fsu_blocksize = PROPAGATE_ALL_ONES (fsd.f_fsize); -#elif defined STAT_STATFS2_BSIZE /* glibc/Linux, 4.3BSD, SunOS 4, \ - MacOS X < 10.4, FreeBSD < 5.0, \ - NetBSD < 3.0, OpenBSD < 4.4 */ +#elif defined STAT_STATFS2_BSIZE || defined DARWIN7 /* glibc/Linux, 4.3BSD, \ + * SunOS 4, MacOS X, \ + * FreeBSD < 5.0, \ + * NetBSD < 3.0, \ + * OpenBSD < 4.4 */ struct statfs fsd; @@ -224,7 +230,8 @@ get_fs_usage (char const *file, char con #endif #if (defined STAT_STATVFS \ - || (!defined STAT_STATFS2_FS_DATA && !defined STAT_READ_FILSYS)) + || (!defined STAT_STATFS2_FS_DATA && !defined STAT_READ_FILSYS) \ + || defined DARWIN7) fsp->fsu_blocks = PROPAGATE_ALL_ONES (fsd.f_blocks); fsp->fsu_bfree = PROPAGATE_ALL_ONES (fsd.f_bfree); --Apple-Mail=_190337A3-4D15-4ED8-9C53-CFA4C2682562 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail=_190337A3-4D15-4ED8-9C53-CFA4C2682562-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 21 17:40:06 2011 Received: (at 9140) by debbugs.gnu.org; 21 Jul 2011 21:40:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qk0yU-00032z-L4 for submit@debbugs.gnu.org; Thu, 21 Jul 2011 17:40:06 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qk0yR-00032S-Kd for 9140@debbugs.gnu.org; Thu, 21 Jul 2011 17:40:05 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 937A239E80FF; Thu, 21 Jul 2011 14:39:57 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kqgayNmrw-RY; Thu, 21 Jul 2011 14:39:57 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 2065939E80FA; Thu, 21 Jul 2011 14:39:57 -0700 (PDT) Message-ID: <4E289CAC.7030108@cs.ucla.edu> Date: Thu, 21 Jul 2011 14:39:56 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Thunderbird/3.1.11 MIME-Version: 1.0 To: Herb Wartens Subject: Re: bug#9140: Coreutils Bug on OSX 10.7 (Lion) References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.1 (---) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.1 (---) > On OSX 10.7 the relevant fields of the statvfs structure > are defined to be fsblkcnt_t, or only 4 bytes long. Thanks for the bug report. Could you please give more details about the problem? What is the size of your file system? What are the types (e.g., are the types signed? and what are their sizes?) and values of f_frsize, f_bsize, f_blocks, and all the other members of a struct statvfs? The patch you sent essentially says "statvfs is broken so badly on MacOS X 10.7 that nobody should ever use it". Is that really right? It sounds extreme. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 21 19:36:40 2011 Received: (at 9140) by debbugs.gnu.org; 21 Jul 2011 23:36:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qk2nI-0005eO-5l for submit@debbugs.gnu.org; Thu, 21 Jul 2011 19:36:40 -0400 Received: from mail-ww0-f46.google.com ([74.125.82.46]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qk2nG-0005eD-5P for 9140@debbugs.gnu.org; Thu, 21 Jul 2011 19:36:38 -0400 Received: by wwf25 with SMTP id 25so1696758wwf.15 for <9140@debbugs.gnu.org>; Thu, 21 Jul 2011 16:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=joUoYxPszp+Fh9bFn//wBlozImB0/I7f9AgKehrPzcE=; b=QqkpdzksitCsDP0zPX+aKeuJQ1c4uYwhkJcKpOlrR79g4CnCuxezHelxE/0PLrhwx2 wNp1tuYFgMzpk+Bwjhjqoq3XiGcoda3SCcPf8aRn6CY4k8nMv2unV9bMVhzGJFwrzC+W EwvsqIIR7g0XVaSSL511sqwmhufaXU9EkBrVI= Received: by 10.216.220.220 with SMTP id o70mr1213187wep.71.1311291392206; Thu, 21 Jul 2011 16:36:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.180.21 with HTTP; Thu, 21 Jul 2011 16:35:52 -0700 (PDT) In-Reply-To: <4E289CAC.7030108@cs.ucla.edu> References: <4E289CAC.7030108@cs.ucla.edu> From: Herb Wartens Date: Thu, 21 Jul 2011 16:35:52 -0700 Message-ID: Subject: Re: bug#9140: Coreutils Bug on OSX 10.7 (Lion) To: Paul Eggert Content-Type: multipart/alternative; boundary=0016e659f5a2a12a4204a89cd12b X-Spam-Score: -3.2 (---) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.1 (---) --0016e659f5a2a12a4204a89cd12b Content-Type: text/plain; charset=ISO-8859-1 On Thu, Jul 21, 2011 at 2:39 PM, Paul Eggert wrote: > > On OSX 10.7 the relevant fields of the statvfs structure > > are defined to be fsblkcnt_t, or only 4 bytes long. > > Thanks for the bug report. Could you please give more details about > the problem? What is the size of your file system? What are the > types (e.g., are the types signed? and what are their sizes?) > and values of f_frsize, f_bsize, f_blocks, and all the other > members of a struct statvfs? > > Sure. The filesystem is 5.5TiB (5,858,217,984 bytes). This is beyond the capacity an unsigned int can hold. Here is an example of the bug: > df /Volumes/VIDEO Filesystem 1K-blocks Used Available Use% Mounted on //user1@192.168.1.100/VIDEO 1563250688 -1474553224 -1257163384 54% /Volumes/VIDEO Here is what it should look like: > df /Volumes/VIDEO Filesystem 1K-blocks Used Available Use% Mounted on //user1@192.168.1.100/VIDEO 5858217984 2820414072 3037803912 49% /Volumes/VIDEO Here are the relevant definitions on OSX: struct statvfs { unsigned long f_bsize; /* File system block size */ unsigned long f_frsize; /* Fundamental file system block size */ fsblkcnt_t f_blocks; /* Blocks on FS in units of f_frsize */ fsblkcnt_t f_bfree; /* Free blocks */ fsblkcnt_t f_bavail; /* Blocks available to non-root */ fsfilcnt_t f_files; /* Total inodes */ fsfilcnt_t f_ffree; /* Free inodes */ fsfilcnt_t f_favail; /* Free inodes for non-root */ unsigned long f_fsid; /* Filesystem ID */ unsigned long f_flag; /* Bit mask of values */ unsigned long f_namemax; /* Max file name length */ }; typedef __darwin_fsblkcnt_t fsblkcnt_t; typedef __darwin_fsfilcnt_t fsfilcnt_t; typedef unsigned int __darwin_fsblkcnt_t; /* Used by statvfs and fstatvfs */ typedef unsigned int __darwin_fsfilcnt_t; /* Used by statvfs and fstatvfs */ (gdb) print sizeof(buf.f_bsize) $2 = 8 (gdb) print sizeof(buf.f_frsize) $3 = 8 (gdb) print sizeof(buf.f_blocks) $4 = 4 (gdb) print sizeof(buf.f_bfree) $5 = 4 (gdb) print sizeof(buf.f_bavail) $6 = 4 (gdb) print sizeof(buf.f_files) $7 = 4 (gdb) print sizeof(buf.f_ffree) $8 = 4 (gdb) print sizeof(buf.f_favail) $9 = 4 (gdb) print sizeof(buf.f_fsid) $10 = 8 (gdb) print sizeof(buf.f_flag) $11 = 8 (gdb) print sizeof(buf.f_namemax) $12 = 8 > The patch you sent essentially says "statvfs is broken so badly on > MacOS X 10.7 that nobody should ever use it". Is that really right? > It sounds extreme. > > Not saying no one should use it at all. All I am saying is that when using really large filesystems, then the statvfs structure is insufficient on OSX. Hope this helps. -Herb --0016e659f5a2a12a4204a89cd12b Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Thu, Jul 21, 2011 at 2:39 PM, Paul Eg= gert <eggert@cs.ucla.edu> wrote:
> On OSX 10.7 the relevant fields of the statvfs structure
> are defined to be fsblkcnt_t, or only 4 bytes long.

Thanks for the bug report. =A0Could you please give more details about
the problem? =A0What is the size of your file system? =A0What are the
types (e.g., are the types signed? and what are their sizes?)
and values of f_frsize, f_bsize, f_blocks, and all the other
members of a struct statvfs?


Sure. =A0The filesystem is 5.5TiB (5,8= 58,217,984 bytes). =A0This is beyond the capacity an unsigned int can hold.= =A0Here is an example of the bug:
> df /Volumes/VIDEO
Filesystem =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 1K-blocks =A0 =A0 =A0 =A0Used = =A0 Available Use% Mounted on
//user1@192.168.1.100/VIDEO=A0 =A0 = =A0 =A01563250688 -1474553224 -1257163384 =A054% /Volumes/VIDEO

Here is what it should look like:
> df /Volum= es/VIDEO
Filesystem =A0 =A0 =A0= =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 1K-blocks =A0 =A0 =A0 Used =A0Availabl= e Use% Mounted on
//user1@192.168.1.100/VIDEO=A0 =A0 =A0 =A05858217= 984 2820414072 3037803912 =A049% /Volumes/VIDEO


Here are the relevant definitions on OSX:
struct statvf= s {
=A0 = =A0 unsigned long f_bsize; =A0 =A0/* File system block size */
=A0 =A0 unsigned long = f_frsize; =A0 /* Fundamental file system block size */
=A0 =A0 fsblkcnt_t =A0 =A0f_bl= ocks; =A0 /* Blocks on FS in units of f_frsize */
=A0 =A0 fsblkcnt_t =A0= =A0f_bfree; =A0 =A0/* Free blocks */
=A0 =A0 fsblkcnt_t =A0 =A0f_bavail; =A0 /* Bloc= ks available to non-root */
=A0 =A0 fsfilcnt_t =A0= =A0f_files; =A0 =A0/* Total inodes */
=A0 =A0 fsfilcnt_t =A0 =A0f_ffree; =A0 =A0/* F= ree inodes */
=A0 =A0 fsfilcnt_t =A0= =A0f_favail; =A0 /* Free inodes for non-root */
=A0 =A0 unsigned long f_fsid; =A0 = =A0 /* Filesystem ID */
=A0 =A0 unsigned long = f_flag; =A0 =A0 /* Bit mask of values */
=A0 =A0 unsigned long f_namemax; =A0/* Max f= ile name length */
};
<= div>
<= font face=3D"'courier new', monospace">typedef __darwin_fsblkcnt_t= =A0fsblkcnt_t;
typedef __darwin_fsfil= cnt_t fsfilcnt_t;

typedef u= nsigned int __darwin_fsblkcnt_t= ; /* Used by statvfs and fstatv= fs */
typedef unsigned int __darwin_fsfilcnt_t; /* Used by statvfs and fstatvfs */=

(= gdb) print sizeof(buf.f_bsize)
$2 =3D 8
(gdb) print sizeof= (buf.f_frsize)
$3 =3D 8
<= div>(gdb) print sizeof(buf.= f_blocks)
$4 =3D 4
<= font face=3D"'courier new', monospace">(gdb) print sizeof(buf.f_bfr= ee)
$5 =3D= 4
(gdb) print sizeof(buf= .f_bavail)
$6 =3D 4
(gdb) print sizeof(buf.f_fi= les)
$7 = =3D 4
(gdb= ) print sizeof(buf.f_ffree)
$8 =3D 4
<= div>(gdb) print sizeof(buf.= f_favail)
$9 =3D 4
<= font face=3D"'courier new', monospace">(gdb) print sizeof(buf.f_fsi= d)
$10 =3D= 8
(gdb) print sizeof(buf= .f_flag)
$= 11 =3D 8
(= gdb) print sizeof(buf.f_namemax)
$12 =3D 8
=

=A0
The patch you sent essentially says "statvfs is broken so badly on
MacOS X 10.7 that nobody should ever use it". =A0Is that really right?=
It sounds extreme.


Not saying no one should use it at all. =A0All = I am saying is that when using really large filesystems, then the statvfs s= tructure is insufficient on OSX. =A0Hope this helps.

-Herb

--0016e659f5a2a12a4204a89cd12b-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 22 13:22:47 2011 Received: (at 9140) by debbugs.gnu.org; 22 Jul 2011 17:22:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkJR1-0006H0-7a for submit@debbugs.gnu.org; Fri, 22 Jul 2011 13:22:47 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkJQy-0006Go-Fr for 9140@debbugs.gnu.org; Fri, 22 Jul 2011 13:22:45 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 0C1FB39E80F0; Fri, 22 Jul 2011 10:22:39 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZjK8IwmRZFuk; Fri, 22 Jul 2011 10:22:38 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 2A47239E80FF; Fri, 22 Jul 2011 10:22:38 -0700 (PDT) Message-ID: <4E29B1DD.8030800@cs.ucla.edu> Date: Fri, 22 Jul 2011 10:22:37 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Thunderbird/3.1.11 MIME-Version: 1.0 To: Bug-gnulib Subject: [PATCH 2/3] large-inode: New module Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.1 (---) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.1 (---) Here's another module I'm adding to coreutils. I plan to change coreutils to use it. Another possibility, I suppose, would be to fold it into AC_SYS_LARGEFILE. Herb, can you please try out the effect of this module by appending "#define _DARWIN_USE_64_BIT_INODE 1" to lib/config.h after running 'configure'? Thanks. * MODULES.html.sh: Add it. * modules/large-inode, m4/large-inode.m4: New files. --- ChangeLog | 4 ++++ MODULES.html.sh | 1 + m4/large-inode.m4 | 24 ++++++++++++++++++++++++ modules/large-inode | 22 ++++++++++++++++++++++ 4 files changed, 51 insertions(+), 0 deletions(-) create mode 100644 m4/large-inode.m4 create mode 100644 modules/large-inode diff --git a/ChangeLog b/ChangeLog index 46d8d04..b95e9d6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,9 @@ 2011-07-22 Paul Eggert + large-inode: New module + * MODULES.html.sh: Add it. + * modules/large-inode, m4/large-inode.m4: New files. + extensions: Enable extensions on MacOS X 10.5 and later. * m4/extensions.m4 (AC_USE_SYSTEM_EXTENSIONS): Define _DARWIN_C_SOURCE. diff --git a/MODULES.html.sh b/MODULES.html.sh index bcd8aac..80befa9 100755 --- a/MODULES.html.sh +++ b/MODULES.html.sh @@ -2656,6 +2656,7 @@ func_all_modules () func_module file-set func_module hash-triple func_module i-ring + func_module large-inode func_module same-inode func_end_table diff --git a/m4/large-inode.m4 b/m4/large-inode.m4 new file mode 100644 index 0000000..b41a391 --- /dev/null +++ b/m4/large-inode.m4 @@ -0,0 +1,24 @@ +# Enable large inode numbers on systems normally without them. -*- Autoconf -*- + +# Copyright (C) 2011 Free Software Foundation, Inc. +# This file is free software; the Free Software Foundation +# gives unlimited permission to copy and/or distribute it, +# with or without modifications, as long as this notice is preserved. + +# written by Paul Eggert + +AC_DEFUN([gl_SYS_LARGE_INODE], +[ + dnl Many systems enable large inodes if you enable large offsets. + AC_REQUIRE([AC_SYS_LARGEFILE]) + + dnl Some Mac OS X variants won't access large inode numbers by default. + dnl Defining _DARWIN_USE_64_BIT_INODE fixes this. See + dnl . + dnl + dnl The simplest thing is to define this symbol everywhere. + dnl That helps on the affected systems, and doesn't hurt anywhere. + AC_DEFINE([_DARWIN_USE_64_BIT_INODE], [1], + [Define if you want to use large inode numbers + when running on Mac OS X 10.5 or later.]) +]) diff --git a/modules/large-inode b/modules/large-inode new file mode 100644 index 0000000..de067ac --- /dev/null +++ b/modules/large-inode @@ -0,0 +1,22 @@ +Description: +Use large inode numbers. + +Files: +m4/large-inode.m4 + +Depends-on: + +configure.ac-early: +AC_REQUIRE([gl_SYS_LARGE_INODE]) + +configure.ac: + +Makefile.am: + +Include: + +License: +LGPLv2+ + +Maintainer: +all -- 1.7.4.4 From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 22 13:26:13 2011 Received: (at 9140) by debbugs.gnu.org; 22 Jul 2011 17:26:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkJUL-0006Lq-HG for submit@debbugs.gnu.org; Fri, 22 Jul 2011 13:26:13 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkJUJ-0006Le-V1 for 9140@debbugs.gnu.org; Fri, 22 Jul 2011 13:26:12 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 50E9A39E80FF; Fri, 22 Jul 2011 10:26:06 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x6DxffiqZkx9; Fri, 22 Jul 2011 10:26:05 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 2818839E80F0; Fri, 22 Jul 2011 10:26:05 -0700 (PDT) Message-ID: <4E29B2AC.2000106@cs.ucla.edu> Date: Fri, 22 Jul 2011 10:26:04 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Thunderbird/3.1.11 MIME-Version: 1.0 To: Herb Wartens Subject: Re: bug#9140: Coreutils Bug on OSX 10.7 (Lion) References: <4E289CAC.7030108@cs.ucla.edu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.1 (---) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, Bug-gnulib X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.1 (---) Thanks for the further information about the problem with MacOS X 10.7. Can you please try this patch? If you don't have autotools installed, you can edit 'configure' by hand and install a similar patch there. Thanks. I have pushed this into gnulib as it seems pretty simple. The basic idea is to avoid statvfs on MacOS X because its block counts can't go above 2**31. >From 3d2ecb41c4a3e428e8a455c4f5fef49f50144f0f Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 22 Jul 2011 10:07:18 -0700 Subject: [PATCH 3/3] fsusage: port to MacOS X 10.7 with 4 TiB file systems * m4/fsusage.m4 (gl_FILE_SYSTEM_USAGE): Reject statvfs implementations that use only 32 bits to count blocks. On typical hosts with 1024-byte blocks, this fails with file systems as small as 4 TiB. Problem reported by Herb Wartens and this should also fix a similar problem reported by Tim Spriggs . --- ChangeLog | 8 ++++++++ m4/fsusage.m4 | 18 +++++++++++++----- 2 files changed, 21 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index b95e9d6..b652f25 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,13 @@ 2011-07-22 Paul Eggert + fsusage: port to MacOS X 10.7 with 4 TiB file systems + * m4/fsusage.m4 (gl_FILE_SYSTEM_USAGE): Reject statvfs + implementations that use only 32 bits to count blocks. + On typical hosts with 1024-byte blocks, this fails with file + systems as small as 4 TiB. Problem reported by Herb Wartens + and this should also fix a similar + problem reported by Tim Spriggs . + large-inode: New module * MODULES.html.sh: Add it. * modules/large-inode, m4/large-inode.m4: New files. diff --git a/m4/fsusage.m4 b/m4/fsusage.m4 index 3459e63..41c06bc 100644 --- a/m4/fsusage.m4 +++ b/m4/fsusage.m4 @@ -40,7 +40,7 @@ ac_fsusage_space=no # systems. That system is reported to work fine with STAT_STATFS4 which # is what it gets when this test fails. if test $ac_fsusage_space = no; then - # glibc/{Hurd,kFreeBSD}, MacOS X >= 10.4, FreeBSD >= 5.0, NetBSD >= 3.0, + # glibc/{Hurd,kFreeBSD}, FreeBSD >= 5.0, NetBSD >= 3.0, # OpenBSD >= 4.4, AIX, HP-UX, IRIX, Solaris, Cygwin, Interix, BeOS. AC_CACHE_CHECK([for statvfs function (SVR4)], [fu_cv_sys_stat_statvfs], [AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include @@ -56,8 +56,16 @@ a system call. "Do not use Tru64's statvfs implementation" #endif -#include ]], - [[struct statvfs fsd; statvfs (0, &fsd);]])], +#include +#include + +/* Reject implementations, such as MacOS X 10.7, where f_blocks is a + 32-bit quantity; that commonly limits file systems to 4 TiB, a + ridiculously small limit these days. */ +struct statvfs fsd; +int check_f_blocks_size[sizeof fsd.f_blocks * CHAR_BIT <= 32 ? -1 : 1]; +]], + [[statvfs (0, &fsd);]])], [fu_cv_sys_stat_statvfs=yes], [fu_cv_sys_stat_statvfs=no])]) if test $fu_cv_sys_stat_statvfs = yes; then @@ -94,8 +102,8 @@ if test $ac_fsusage_space = no; then fi if test $ac_fsusage_space = no; then - # glibc/Linux, MacOS X < 10.4, FreeBSD < 5.0, NetBSD < 3.0, OpenBSD < 4.4. - # (glibc/{Hurd,kFreeBSD}, MacOS X >= 10.4, FreeBSD >= 5.0, NetBSD >= 3.0, + # glibc/Linux, MacOS X, FreeBSD < 5.0, NetBSD < 3.0, OpenBSD < 4.4. + # (glibc/{Hurd,kFreeBSD}, FreeBSD >= 5.0, NetBSD >= 3.0, # OpenBSD >= 4.4, AIX, HP-UX, OSF/1, Cygwin already handled above.) # (On IRIX you need to include , not only and # .) -- 1.7.4.4 From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 22 13:48:22 2011 Received: (at 9140) by debbugs.gnu.org; 22 Jul 2011 17:48:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkJpm-0006qs-5Q for submit@debbugs.gnu.org; Fri, 22 Jul 2011 13:48:22 -0400 Received: from mail1.slb.deg.dub.stisp.net ([84.203.253.98]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1QkJpk-0006qh-4n for 9140@debbugs.gnu.org; Fri, 22 Jul 2011 13:48:20 -0400 Received: (qmail 91074 invoked from network); 22 Jul 2011 17:48:14 -0000 Received: from unknown (HELO ?192.168.2.25?) (84.203.137.218) by mail1.slb.deg.dub.stisp.net with SMTP; 22 Jul 2011 17:48:14 -0000 Message-ID: <4E29B749.1030705@draigBrady.com> Date: Fri, 22 Jul 2011 18:45:45 +0100 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 To: Paul Eggert Subject: Re: [PATCH 2/3] large-inode: New module References: <4E29B1DD.8030800@cs.ucla.edu> In-Reply-To: <4E29B1DD.8030800@cs.ucla.edu> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, Bug-gnulib X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 22/07/11 18:22, Paul Eggert wrote: > Here's another module I'm adding to coreutils. > I plan to change coreutils to use it. > Another possibility, I suppose, would be to fold it into > AC_SYS_LARGEFILE. > > Herb, can you please try out the effect of this module by > appending "#define _DARWIN_USE_64_BIT_INODE 1" to lib/config.h > after running 'configure'? Thanks. If it works it would be better in AC_SYS_LARGEFILE (as well) I think. Though the original reporter of this issue said it didn't work. Though I now notice I asked him to put it at the top of df.c rather than somewhere significant to fsusage.c cheers, Pádraig. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 22 14:16:07 2011 Received: (at 9140) by debbugs.gnu.org; 22 Jul 2011 18:16:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkKGd-0007Sg-2i for submit@debbugs.gnu.org; Fri, 22 Jul 2011 14:16:07 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkKGa-0007S7-R4 for 9140@debbugs.gnu.org; Fri, 22 Jul 2011 14:16:05 -0400 Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 038DB6006C; Fri, 22 Jul 2011 20:15:58 +0200 (CEST) From: Jim Meyering To: Paul Eggert Subject: Re: bug#9140: Coreutils Bug on OSX 10.7 (Lion) In-Reply-To: <4E29B2AC.2000106@cs.ucla.edu> (Paul Eggert's message of "Fri, 22 Jul 2011 10:26:04 -0700") References: <4E289CAC.7030108@cs.ucla.edu> <4E29B2AC.2000106@cs.ucla.edu> Date: Fri, 22 Jul 2011 20:15:58 +0200 Message-ID: <87wrfa89lt.fsf@rho.meyering.net> Lines: 30 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, Bug-gnulib , Herb Wartens X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Paul Eggert wrote: > Thanks for the further information about the problem with MacOS X 10.7. > Can you please try this patch? If you don't have autotools installed, > you can edit 'configure' by hand and install a similar patch there. > Thanks. > > I have pushed this into gnulib as it seems pretty simple. The basic > idea is to avoid statvfs on MacOS X because its block counts can't > go above 2**31. > > Subject: [PATCH 3/3] fsusage: port to MacOS X 10.7 with 4 TiB file systems > > * m4/fsusage.m4 (gl_FILE_SYSTEM_USAGE): Reject statvfs > implementations that use only 32 bits to count blocks. > On typical hosts with 1024-byte blocks, this fails with file > systems as small as 4 TiB. Problem reported by Herb Wartens > and this should also fix a similar > problem reported by Tim Spriggs . ... > +/* Reject implementations, such as MacOS X 10.7, where f_blocks is a > + 32-bit quantity; that commonly limits file systems to 4 TiB, a > + ridiculously small limit these days. */ > +struct statvfs fsd; > +int check_f_blocks_size[sizeof fsd.f_blocks * CHAR_BIT <= 32 ? -1 : 1]; > +]], Nice. That looks like it will do the job, and since all statvfs implementations have the f_blocks member, it should be safe. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 22 18:11:08 2011 Received: (at 9140) by debbugs.gnu.org; 22 Jul 2011 22:11:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkNw4-00075x-6v for submit@debbugs.gnu.org; Fri, 22 Jul 2011 18:11:08 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkNw1-00075R-0j for 9140@debbugs.gnu.org; Fri, 22 Jul 2011 18:11:06 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 6256339E80E1; Fri, 22 Jul 2011 15:10:59 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 20788orXlyHK; Fri, 22 Jul 2011 15:10:57 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 31A8A39E80E0; Fri, 22 Jul 2011 15:10:57 -0700 (PDT) Message-ID: <4E29F570.7010705@cs.ucla.edu> Date: Fri, 22 Jul 2011 15:10:56 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Thunderbird/3.1.11 MIME-Version: 1.0 To: =?ISO-8859-1?Q?P=E1draig_Brady?= Subject: Re: [PATCH 2/3] large-inode: New module References: <4E29B1DD.8030800@cs.ucla.edu> <4E29B749.1030705@draigBrady.com> In-Reply-To: <4E29B749.1030705@draigBrady.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.1 (---) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, Bug-gnulib X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.1 (---) On 07/22/11 10:45, P=E1draig Brady wrote: > If it works it would be better in AC_SYS_LARGEFILE (as well) I think. OK, thanks, I pushed this into gnulib. Assuming it works (and I don't see why it'd hurt) I'll push it into autoconf. >From a7df7c7d3f2f32d0cad31f65505cfee939d91f4a Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 22 Jul 2011 15:06:36 -0700 Subject: [PATCH] largefile: new module, replacing large-inode MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit P=E1draig Brady suggested this in . * MODULES.html.sh: Add largefile, remove large-inode. * modules/largefile, m4/largefile.m4: New files. * modules/large-inode, m4/large-inode.m4: Remove. --- ChangeLog | 6 +++ MODULES.html.sh | 2 +- m4/large-inode.m4 | 24 ------------ m4/largefile.m4 | 104 +++++++++++++++++++++++++++++++++++++++++++++= ++++++ modules/large-inode | 22 ----------- modules/largefile | 22 +++++++++++ 6 files changed, 133 insertions(+), 47 deletions(-) delete mode 100644 m4/large-inode.m4 create mode 100644 m4/largefile.m4 delete mode 100644 modules/large-inode create mode 100644 modules/largefile diff --git a/ChangeLog b/ChangeLog index b652f25..c44292e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,11 @@ 2011-07-22 Paul Eggert =20 + largefile: new module, replacing large-inode + P=E1draig Brady suggested this in . + * MODULES.html.sh: Add largefile, remove large-inode. + * modules/largefile, m4/largefile.m4: New files. + * modules/large-inode, m4/large-inode.m4: Remove. + fsusage: port to MacOS X 10.7 with 4 TiB file systems * m4/fsusage.m4 (gl_FILE_SYSTEM_USAGE): Reject statvfs implementations that use only 32 bits to count blocks. diff --git a/MODULES.html.sh b/MODULES.html.sh index 80befa9..6d84587 100755 --- a/MODULES.html.sh +++ b/MODULES.html.sh @@ -2608,6 +2608,7 @@ func_all_modules () func_module filenamecat-lgpl func_module fts func_module isdir + func_module largefile func_module lchmod func_module lchown func_module mkancesdirs @@ -2656,7 +2657,6 @@ func_all_modules () func_module file-set func_module hash-triple func_module i-ring - func_module large-inode func_module same-inode func_end_table =20 diff --git a/m4/large-inode.m4 b/m4/large-inode.m4 deleted file mode 100644 index b41a391..0000000 --- a/m4/large-inode.m4 +++ /dev/null @@ -1,24 +0,0 @@ -# Enable large inode numbers on systems normally without them. -*- Autoc= onf -*- - -# Copyright (C) 2011 Free Software Foundation, Inc. -# This file is free software; the Free Software Foundation -# gives unlimited permission to copy and/or distribute it, -# with or without modifications, as long as this notice is preserved. - -# written by Paul Eggert - -AC_DEFUN([gl_SYS_LARGE_INODE], -[ - dnl Many systems enable large inodes if you enable large offsets. - AC_REQUIRE([AC_SYS_LARGEFILE]) - - dnl Some Mac OS X variants won't access large inode numbers by default= . - dnl Defining _DARWIN_USE_64_BIT_INODE fixes this. See - dnl . - dnl - dnl The simplest thing is to define this symbol everywhere. - dnl That helps on the affected systems, and doesn't hurt anywhere. - AC_DEFINE([_DARWIN_USE_64_BIT_INODE], [1], - [Define if you want to use large inode numbers - when running on Mac OS X 10.5 or later.]) -]) diff --git a/m4/largefile.m4 b/m4/largefile.m4 new file mode 100644 index 0000000..6986244 --- /dev/null +++ b/m4/largefile.m4 @@ -0,0 +1,104 @@ +# Enable large files on systems where this is not the default. + +# Copyright 1992-1996, 1998-2011 Free Software Foundation, Inc. +# This file is free software; the Free Software Foundation +# gives unlimited permission to copy and/or distribute it, +# with or without modifications, as long as this notice is preserved. + +# The following implementation works around a problem in autoconf <=3D 2= .68; +# AC_SYS_LARGEFILE does not configure for large inodes on Mac OS X 10.5. +m4_version_prereq([2.69], [] ,[ + +# _AC_SYS_LARGEFILE_TEST_INCLUDES +# ------------------------------- +m4_define([_AC_SYS_LARGEFILE_TEST_INCLUDES], +[@%:@include + /* Check that off_t can represent 2**63 - 1 correctly. + We can't simply define LARGE_OFF_T to be 9223372036854775807, + since some C++ compilers masquerading as C compilers + incorrectly reject 9223372036854775807. */ +@%:@define LARGE_OFF_T (((off_t) 1 << 62) - 1 + ((off_t) 1 << 62)) + int off_t_is_large[[(LARGE_OFF_T % 2147483629 =3D=3D 721 + && LARGE_OFF_T % 2147483647 =3D=3D 1) + ? 1 : -1]];[]dnl +]) + + +# _AC_SYS_LARGEFILE_MACRO_VALUE(C-MACRO, VALUE, +# CACHE-VAR, +# DESCRIPTION, +# PROLOGUE, [FUNCTION-BODY]) +# -------------------------------------------------------- +m4_define([_AC_SYS_LARGEFILE_MACRO_VALUE], +[AC_CACHE_CHECK([for $1 value needed for large files], [$3], +[while :; do + m4_ifval([$6], [AC_LINK_IFELSE], [AC_COMPILE_IFELSE])( + [AC_LANG_PROGRAM([$5], [$6])], + [$3=3Dno; break]) + m4_ifval([$6], [AC_LINK_IFELSE], [AC_COMPILE_IFELSE])( + [AC_LANG_PROGRAM([@%:@define $1 $2 +$5], [$6])], + [$3=3D$2; break]) + $3=3Dunknown + break +done]) +case $$3 in #( + no | unknown) ;; + *) AC_DEFINE_UNQUOTED([$1], [$$3], [$4]);; +esac +rm -rf conftest*[]dnl +])# _AC_SYS_LARGEFILE_MACRO_VALUE + + +# AC_SYS_LARGEFILE +# ---------------- +# By default, many hosts won't let programs access large files; +# one must use special compiler options to get large-file access to work= . +# For more details about this brain damage please see: +# http://www.unix-systems.org/version2/whatsnew/lfs20mar.html +AC_DEFUN([AC_SYS_LARGEFILE], +[AC_ARG_ENABLE(largefile, + [ --disable-largefile omit support for large files]) +if test "$enable_largefile" !=3D no; then + + AC_CACHE_CHECK([for special C compiler options needed for large files]= , + ac_cv_sys_largefile_CC, + [ac_cv_sys_largefile_CC=3Dno + if test "$GCC" !=3D yes; then + ac_save_CC=3D$CC + while :; do + # IRIX 6.2 and later do not support large files by default, + # so use the C compiler's -n32 option if that helps. + AC_LANG_CONFTEST([AC_LANG_PROGRAM([_AC_SYS_LARGEFILE_TEST_INCLUDES])]) + AC_COMPILE_IFELSE([], [break]) + CC=3D"$CC -n32" + AC_COMPILE_IFELSE([], [ac_cv_sys_largefile_CC=3D' -n32'; break]) + break + done + CC=3D$ac_save_CC + rm -f conftest.$ac_ext + fi]) + if test "$ac_cv_sys_largefile_CC" !=3D no; then + CC=3D$CC$ac_cv_sys_largefile_CC + fi + + _AC_SYS_LARGEFILE_MACRO_VALUE(_FILE_OFFSET_BITS, 64, + ac_cv_sys_file_offset_bits, + [Number of bits in a file offset, on hosts where this is settable.], + [_AC_SYS_LARGEFILE_TEST_INCLUDES]) + if test $ac_cv_sys_file_offset_bits =3D unknown; then + _AC_SYS_LARGEFILE_MACRO_VALUE(_LARGE_FILES, 1, + ac_cv_sys_large_files, + [Define for large files, on AIX-style hosts.], + [_AC_SYS_LARGEFILE_TEST_INCLUDES]) + fi + + AH_VERBATIM([_DARWIN_USE_64_BIT_INODE], +[/* Enable large inode numbers on Mac OS X. */ +#ifndef _DARWIN_USE_64_BIT_INODE +# define _DARWIN_USE_64_BIT_INODE 1 +#endif]) +fi +])# AC_SYS_LARGEFILE + +])# m4_version_prereq 2.69 diff --git a/modules/large-inode b/modules/large-inode deleted file mode 100644 index de067ac..0000000 --- a/modules/large-inode +++ /dev/null @@ -1,22 +0,0 @@ -Description: -Use large inode numbers. - -Files: -m4/large-inode.m4 - -Depends-on: - -configure.ac-early: -AC_REQUIRE([gl_SYS_LARGE_INODE]) - -configure.ac: - -Makefile.am: - -Include: - -License: -LGPLv2+ - -Maintainer: -all diff --git a/modules/largefile b/modules/largefile new file mode 100644 index 0000000..d4a2e4b --- /dev/null +++ b/modules/largefile @@ -0,0 +1,22 @@ +Description: +Use large files. + +Files: +m4/largefile.m4 + +Depends-on: + +configure.ac: +AC_REQUIRE([AC_SYS_LARGEFILE]) + +configure.ac: + +Makefile.am: + +Include: + +License: +LGPLv2+ + +Maintainer: +all --=20 1.7.4.4 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 23 09:55:14 2011 Received: (at 9140) by debbugs.gnu.org; 23 Jul 2011 13:55:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qkcfh-0003wi-OW for submit@debbugs.gnu.org; Sat, 23 Jul 2011 09:55:14 -0400 Received: from mo-p00-ob.rzone.de ([81.169.146.161]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qkcfd-0003uE-Un for 9140@debbugs.gnu.org; Sat, 23 Jul 2011 09:55:12 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1311429302; l=4364; s=domk; d=haible.de; h=Content-Transfer-Encoding:Content-Type:MIME-Version:In-Reply-To: References:Cc:Date:Subject:To:From:X-RZG-CLASS-ID:X-RZG-AUTH; bh=lSAGlBxtd+1rNRchV4mN11p3Woo=; b=Txrw6V26WN0GLBjmnYqp0psdODN7lZeOJqL616+k9Baa6px6JM8qzjKiTt4SFI1QvcI FecNbJmE+AmsKYbwTz0N7GkolWQS/uYJiOghf7NM/s1GEO53e4TVESJfI2ZJBvU/km3L8 nU4Zf1p+JRQx9QhE6dhMTc8rojEI7qzFn0Q= X-RZG-AUTH: :Ln4Re0+Ic/6oZXR1YgKryK8brksyK8dozXDwHXjf9hj/zDNRav445DE8 X-RZG-CLASS-ID: mo00 Received: from linuix.haible.de (dslb-088-068-038-069.pools.arcor-ip.net [88.68.38.69]) by smtp.strato.de (klopstock mo23) (RZmta 26.2) with ESMTPA id I00903n6NDBAzU ; Sat, 23 Jul 2011 15:53:34 +0200 (MEST) From: Bruno Haible To: bug-gnulib@gnu.org Subject: Re: bug#9140: Coreutils Bug on OSX 10.7 (Lion) Date: Sat, 23 Jul 2011 15:53:57 +0200 User-Agent: KMail/1.13.6 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.0; x86_64; ; ) References: <4E29B2AC.2000106@cs.ucla.edu> In-Reply-To: <4E29B2AC.2000106@cs.ucla.edu> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Message-Id: <201107231553.57880.bruno@clisp.org> X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, Paul Eggert , Herb Wartens X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) Paul Eggert wrote: > Subject: [PATCH 3/3] fsusage: port to MacOS X 10.7 with 4 TiB file systems >=20 > * m4/fsusage.m4 (gl_FILE_SYSTEM_USAGE): Reject statvfs > implementations that use only 32 bits to count blocks. But this change has also effects on other platforms than MacOS X 10.7: =2D On glibc/Hurd, the type of f_blocks in 'struct statvfs' is __fsblkcnt64= _t or __fsblkcnt_t, depending on __USE_FILE_OFFSET64. So fsusage.m4 ought to require AC_SYS_LARGEFILE. =2D On MacOS X 10.5, the type of f_blocks is fsblkcnt_t, which is 'unsigned int'. The configure test therefore now fails, STAT_STATFS2_BSIZE gets defined to 1, and fsusage.c calls statfs() instead of statvfs(). And 'struct statfs' contains a f_blocks that has 64 bits if and only if __DARWIN_64_BIT_INO_T is defined. So fsusage.m4 ought to require AC_SYS_LARGEFILE, and a module dependency to 'largefile' is needed, so that it picks up your new AC_SYS_LARGEFILE c= ode. =2D On FreeBSD 6.4, NetBSD 3.0..5.0, OpenBSD 4.9, the type of f_blocks is fsblkcnt_t, which is already a 64-bit integer. So these platforms continue to use statvfs(). =2D On AIX 5.1..7.1, the type of f_blocks is fsblkcnt_t, which is 'unsigned= long', hence usually 32-bit. The configure test therefore now fails, STAT_STATFS2_BSIZE gets defined to 1, and fsusage.c calls statfs() instea= d of statvfs(). But statfs() has a 'fsblkcnt_t f_blocks' as well, so the switch from statvfs() to statfs() buys us nothing. What would bring something (on AIX >=3D 5.2) is to use statvfs64 or statf= s64, which both have a 64-bit f_blocks field. =2D On HP-UX 11.00..11.31, the type of f_blocks is fsblkcnt_t, which is 64-= bit if and only if _APP32_64BIT_OFF_T is defined. By default it is 32-bit, he= nce the configure test therefore now fails, STAT_STATFS2_BSIZE gets defined t= o 1, and fsusage.c calls statfs() instead of statvfs(). But statfs() has an 'int32_t f_blocks', so the switch from statvfs() to statfs() buys us noth= ing. What would bring something is to define _FILE_OFFSET_BITS to 64, which has the effect of enabling _APP32_64BIT_OFF_T. Or alternatively, define _LARGEFILE64_SOURCE and use statvfs64 instead of statvfs. =2D On IRIX 6.5, the type of f_blocks is fsblkcnt_t, which is already a 64-= bit integer, so these platforms continue to use statvfs(). One could define _LARGEFILE64_SOURCE and use statvfs64, but that appears to be not necessa= ry. =2D On Solaris 7..10, the type of f_blocks is fsblkcnt_t, which is 64-bit in 64-bit mode builds (_LP64) or if _FILE_OFFSET_BITS is 64. By default it usually is 32-bit, the configure test therefore now fails, STAT_STATFS4 gets defined to 1, and fsusage.c calls statfs() instead of statvfs(). But statfs() has a 'long f_blocks', so the switch from statvfs() to statf= s() buys us nothing. What would bring something is to define _FILE_OFFSET_BITS to 64. =2D On Cygwin (both 1.5.x and 1.7.5), the type of f_blocks is fsblkcnt_t, w= hich is 'unsigned long', that is, 32-bit. The configure test therefore now fai= ls, STAT_STATFS2_BSIZE gets defined to 1, and fsusage.c calls statfs() instea= d of statvfs(). But statfs() has a 'long f_blocks', so the switch from statvfs= () to statfs() buys us nothing. I don't see an API that supports 64-bit f_blocks on Cygwin. =2D On Interix 3.5, the type of f_blocks is 'unsigned long', which is 32-bi= t. The configure test therefore now fails, and I don't know which API gets u= sed instead: Interix has no statfs. So it appears the patch is killing portability to Interix. =2D On BeOS and Haiku, the type of f_blocks is fsblkcnt_t, which is 'long l= ong', i.e. 64-bit, so these platforms continue to use statvfs(). I will therefore propose 1) To require AC_SYS_LARGEFILE, and a module dependency to 'largefile'. This will make statvfs() use a 64-bit f_blocks on glibc/Hurd, MacOS X >=3D 10.4, HP-UX, Solaris. 2) To undo the patch that introduces check_f_blocks_size, because - on MacOS X 10.7 it is not needed any more after 1), - on AIX and Cywin it causes non-POSIX API to be used for no reason, - it kills portability to Interix 3.5. 3) To make use of statvfs64 on AIX. Bruno =2D-=20 In memoriam Adam Czerniak=F3w From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 23 10:33:14 2011 Received: (at 9140) by debbugs.gnu.org; 23 Jul 2011 14:33:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkdGU-0004xk-FT for submit@debbugs.gnu.org; Sat, 23 Jul 2011 10:33:14 -0400 Received: from mo-p00-ob.rzone.de ([81.169.146.161]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkdGR-0004xW-QH for 9140@debbugs.gnu.org; Sat, 23 Jul 2011 10:33:13 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1311431585; l=2004; s=domk; d=haible.de; h=Content-Transfer-Encoding:Content-Type:MIME-Version:In-Reply-To: References:Cc:Date:Subject:To:From:X-RZG-CLASS-ID:X-RZG-AUTH; bh=wPzW14HNNQINfPJ4zCAgQhmxBYM=; b=BF5kWC10Dg1zcIFOKIe9XkI9/1vQWB6K4WTmPub2OZcLlVOQCDVPu8kTg6f+Nhdf/3b WiZiKLUyT7zyM/UfGlN4fc6v53V+NP5VU7gT/8vx0dJUFr2WL9OHdjF1iTfzDPHcSjwFT atLewdvCIiBwTpLJ0ieJ48tw2ILhZaIX51c= X-RZG-AUTH: :Ln4Re0+Ic/6oZXR1YgKryK8brksyK8dozXDwHXjf9hj/zDNRav445DE8 X-RZG-CLASS-ID: mo00 Received: from linuix.haible.de (dslb-088-068-038-069.pools.arcor-ip.net [88.68.38.69]) by smtp.strato.de (klopstock mo10) (RZmta 26.2) with ESMTPA id 9004b9n6NBTsco ; Sat, 23 Jul 2011 16:32:13 +0200 (MEST) From: Bruno Haible To: bug-gnulib@gnu.org Subject: fsusage: add large volume support on glibc/Hurd, HP-UX 11, Solaris, MacOS X Date: Sat, 23 Jul 2011 16:32:37 +0200 User-Agent: KMail/1.13.6 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.0; x86_64; ; ) References: <4E29B2AC.2000106@cs.ucla.edu> <201107231553.57880.bruno@clisp.org> In-Reply-To: <201107231553.57880.bruno@clisp.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Message-Id: <201107231632.37431.bruno@clisp.org> X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, Paul Eggert , Herb Wartens X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) > 1) To require AC_SYS_LARGEFILE, and a module dependency to 'largefile'. > This will make statvfs() use a 64-bit f_blocks on > glibc/Hurd, MacOS X >=3D 10.4, HP-UX, Solaris. Here's the first proposed patch. I verified that =2D on HP-UX 11.00 and 11.31, Solaris 7 and 10, it causes statvfs() to be u= sed again: checking for statvfs function (SVR4)... no becomes checking for statvfs function (SVR4)... yes Since the check_f_blocks_size is in place, it proves that this causes f_blocks to be 64-bit. =2D on MacOS X 10.5, it causes fsusage.o to call statfs$INODE64 instead of statfs, thus also supporting large volumes. 2011-07-23 Bruno Haible fsusage: Enable large volume support on glibc/Hurd, HP-UX, Solaris, MacOS = X. * m4/fsusage.m4 (gl_FILE_SYSTEM_USAGE): Require AC_SYS_LARGEFILE. * modules/fsusage (Depends-on): Add largefile. =2D-- m4/fsusage.m4.orig Sat Jul 23 16:25:19 2011 +++ m4/fsusage.m4 Sat Jul 23 16:24:57 2011 @@ -1,4 +1,4 @@ =2D# serial 28 +# serial 29 # Obtaining file system usage information. =20 # Copyright (C) 1997-1998, 2000-2001, 2003-2011 Free Software Foundation, = Inc. @@ -29,6 +29,12 @@ =20 AC_DEFUN([gl_FILE_SYSTEM_USAGE], [ +dnl Enable large-file support. This has the effect of changing the size +dnl of field f_blocks in 'struct statvfs' from 32 bit to 64 bit on +dnl glibc/Hurd, HP-UX 11, Solaris (32-bit mode). It also changes the size +dnl of field f_blocks in 'struct statfs' from 32 bit to 64 bit on +dnl MacOS X >=3D 10.5 (32-bit mode). +AC_REQUIRE([AC_SYS_LARGEFILE]) =20 AC_MSG_NOTICE([checking how to get file system space usage]) ac_fsusage_space=3Dno =2D-- modules/fsusage.orig Sat Jul 23 16:25:19 2011 +++ modules/fsusage Sat Jul 23 16:06:17 2011 @@ -7,6 +7,7 @@ m4/fsusage.m4 =20 Depends-on: +largefile stdbool stdint full-read [test $gl_cv_fs_space =3D yes] =2D-=20 In memoriam Adam Czerniak=F3w From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 23 10:54:11 2011 Received: (at 9140) by debbugs.gnu.org; 23 Jul 2011 14:54:11 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qkdak-0005TJ-PK for submit@debbugs.gnu.org; Sat, 23 Jul 2011 10:54:11 -0400 Received: from mo-p00-ob.rzone.de ([81.169.146.160]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qkdag-0005Sn-TY for 9140@debbugs.gnu.org; Sat, 23 Jul 2011 10:54:08 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1311432839; l=2028; s=domk; d=haible.de; h=Content-Transfer-Encoding:Content-Type:MIME-Version:In-Reply-To: References:Cc:Date:Subject:To:From:X-RZG-CLASS-ID:X-RZG-AUTH; bh=x+Gu8V/pvW1fF5jKtow2bioWf7A=; b=HqleB7rMz85zWzFQmhkQdaaRceX4XQR6UxCQZDPmowBHUmEqwVMb1K9RZn3Hzty/QR3 o+k676ymC6RlwuVdpATbGUYZpbY1zdXgp5FfsI4u9fuNlJGSt0aZ7UL+30ZTRiAv8PXAx A2A0Hd1OCQZKEPllURcOWu6G6Z4iYlD7nlc= X-RZG-AUTH: :Ln4Re0+Ic/6oZXR1YgKryK8brksyK8dozXDwHXjf9hj/zDNRav445DE8 X-RZG-CLASS-ID: mo00 Received: from linuix.haible.de (dslb-088-068-038-069.pools.arcor-ip.net [88.68.38.69]) by smtp.strato.de (fruni mo34) (RZmta 26.2) with ESMTPA id j000b6n6NEjYrH ; Sat, 23 Jul 2011 16:53:17 +0200 (MEST) From: Bruno Haible To: bug-gnulib@gnu.org Subject: fsusage: revert unintended change on AIX, Cygwin, Interix Date: Sat, 23 Jul 2011 16:53:40 +0200 User-Agent: KMail/1.13.6 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.0; x86_64; ; ) References: <4E29B2AC.2000106@cs.ucla.edu> <201107231553.57880.bruno@clisp.org> In-Reply-To: <201107231553.57880.bruno@clisp.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Message-Id: <201107231653.41161.bruno@clisp.org> X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, Paul Eggert , Herb Wartens X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) > 2) To undo the patch that introduces check_f_blocks_size, because > - on MacOS X 10.7 it is not needed any more after 1), > - on AIX and Cywin it causes non-POSIX API to be used for no reason, > - it kills portability to Interix 3.5. Slight correction: It is still needed after 1), at least on MacOS X 10.5. But only on MacOS X. So here's the proposed patch 2. Verified on AIX and Cygwin; I don't have access to an Interix machine. 2011-07-23 Bruno Haible fsusage: Restore previous behaviour on AIX, Cygwin, Interix. * m4/fsusage.m4 (gl_FILE_SYSTEM_USAGE): Enforce a 64-bit struct statvfs f_blocks field only on MacOS X. *** m4/fsusage.m4.orig Sat Jul 23 16:44:07 2011 =2D-- m4/fsusage.m4 Sat Jul 23 16:42:32 2011 *************** *** 62,75 **** "Do not use Tru64's statvfs implementation" #endif =20 =2D #include #include =20 =2D /* Reject implementations, such as MacOS X 10.7, where f_blocks is a =2D 32-bit quantity; that commonly limits file systems to 4 TiB, a =2D ridiculously small limit these days. */ struct statvfs fsd; int check_f_blocks_size[sizeof fsd.f_blocks * CHAR_BIT <=3D 32 ? -1 : 1]; ]], [[statvfs (0, &fsd);]])], [fu_cv_sys_stat_statvfs=3Dyes], =2D-- 62,80 ---- "Do not use Tru64's statvfs implementation" #endif =20 #include =20 struct statvfs fsd; +=20 + #if defined __APPLE__ && defined __MACH__ + #include + /* On MacOS X >=3D 10.5, f_blocks in 'struct statvfs' is a 32-bit quantit= y; + that commonly limits file systems to 4 TiB. Whereas f_blocks in + 'struct statfs' is a 64-bit type, thanks to the large-file support + that was enabled above. In this case, don't use statvfs(); use statfs() + instead. */ int check_f_blocks_size[sizeof fsd.f_blocks * CHAR_BIT <=3D 32 ? -1 : 1]; + #endif ]], [[statvfs (0, &fsd);]])], [fu_cv_sys_stat_statvfs=3Dyes], =2D-=20 In memoriam Adam Czerniak=F3w From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 23 11:02:55 2011 Received: (at 9140) by debbugs.gnu.org; 23 Jul 2011 15:02:56 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkdjD-0005gA-7y for submit@debbugs.gnu.org; Sat, 23 Jul 2011 11:02:55 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkdjA-0005fu-Oj for 9140@debbugs.gnu.org; Sat, 23 Jul 2011 11:02:53 -0400 Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id D32A16005C; Sat, 23 Jul 2011 17:02:46 +0200 (CEST) From: Jim Meyering To: Bruno Haible Subject: Re: bug#9140: Coreutils Bug on OSX 10.7 (Lion) In-Reply-To: <201107231553.57880.bruno@clisp.org> (Bruno Haible's message of "Sat, 23 Jul 2011 15:53:57 +0200") References: <4E29B2AC.2000106@cs.ucla.edu> <201107231553.57880.bruno@clisp.org> Date: Sat, 23 Jul 2011 17:02:46 +0200 Message-ID: <87bowl2g6h.fsf@rho.meyering.net> Lines: 44 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, Paul Eggert , bug-gnulib@gnu.org, Herb Wartens X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Bruno Haible wrote: > Paul Eggert wrote: >> Subject: [PATCH 3/3] fsusage: port to MacOS X 10.7 with 4 TiB file systems >> >> * m4/fsusage.m4 (gl_FILE_SYSTEM_USAGE): Reject statvfs >> implementations that use only 32 bits to count blocks. > > But this change has also effects on other platforms than MacOS X 10.7: > > - On glibc/Hurd, the type of f_blocks in 'struct statvfs' is __fsblkcnt64_t or ... > - On MacOS X 10.5, the type of f_blocks is fsblkcnt_t, which is ... > - On FreeBSD 6.4, NetBSD 3.0..5.0, OpenBSD 4.9, the type of f_blocks is ... > - On AIX 5.1..7.1, the type of f_blocks is fsblkcnt_t, which is 'unsigned long', ... > - On HP-UX 11.00..11.31, the type of f_blocks is fsblkcnt_t, which is 64-bit ... > - On IRIX 6.5, the type of f_blocks is fsblkcnt_t, which is already a 64-bit ... > - On Solaris 7..10, the type of f_blocks is fsblkcnt_t, which is 64-bit in ... > - On Cygwin (both 1.5.x and 1.7.5), the type of f_blocks is fsblkcnt_t, which ... > - On Interix 3.5, the type of f_blocks is 'unsigned long', which is 32-bit. ... > - On BeOS and Haiku, the type of f_blocks is fsblkcnt_t, which is 'long long', ... > > I will therefore propose > > 1) To require AC_SYS_LARGEFILE, and a module dependency to 'largefile'. > This will make statvfs() use a 64-bit f_blocks on > glibc/Hurd, MacOS X >= 10.4, HP-UX, Solaris. > > 2) To undo the patch that introduces check_f_blocks_size, because > - on MacOS X 10.7 it is not needed any more after 1), > - on AIX and Cywin it causes non-POSIX API to be used for no reason, > - it kills portability to Interix 3.5. > > 3) To make use of statvfs64 on AIX. Wow. Thanks for all the analysis and testing. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 23 11:05:21 2011 Received: (at 9140) by debbugs.gnu.org; 23 Jul 2011 15:05:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkdlZ-0005jq-HK for submit@debbugs.gnu.org; Sat, 23 Jul 2011 11:05:21 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkdlX-0005je-TU for 9140@debbugs.gnu.org; Sat, 23 Jul 2011 11:05:20 -0400 Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 18F2B6005C; Sat, 23 Jul 2011 17:04:44 +0200 (CEST) From: Jim Meyering To: Bruno Haible Subject: Re: fsusage: add large volume support on glibc/Hurd, HP-UX 11, Solaris, MacOS X In-Reply-To: <201107231632.37431.bruno@clisp.org> (Bruno Haible's message of "Sat, 23 Jul 2011 16:32:37 +0200") References: <4E29B2AC.2000106@cs.ucla.edu> <201107231553.57880.bruno@clisp.org> <201107231632.37431.bruno@clisp.org> Date: Sat, 23 Jul 2011 17:04:44 +0200 Message-ID: <8762mt2g37.fsf@rho.meyering.net> Lines: 59 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, Paul Eggert , bug-gnulib@gnu.org, Herb Wartens X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Bruno Haible wrote: >> 1) To require AC_SYS_LARGEFILE, and a module dependency to 'largefile'. >> This will make statvfs() use a 64-bit f_blocks on >> glibc/Hurd, MacOS X >= 10.4, HP-UX, Solaris. > > Here's the first proposed patch. I verified that > > - on HP-UX 11.00 and 11.31, Solaris 7 and 10, it causes statvfs() to be used > again: > checking for statvfs function (SVR4)... no > becomes > checking for statvfs function (SVR4)... yes > Since the check_f_blocks_size is in place, it proves that this causes > f_blocks to be 64-bit. > > - on MacOS X 10.5, it causes fsusage.o to call statfs$INODE64 instead of > statfs, thus also supporting large volumes. > > > 2011-07-23 Bruno Haible > > fsusage: Enable large volume support on glibc/Hurd, HP-UX, Solaris, MacOS X. > * m4/fsusage.m4 (gl_FILE_SYSTEM_USAGE): Require AC_SYS_LARGEFILE. > * modules/fsusage (Depends-on): Add largefile. > > --- m4/fsusage.m4.orig Sat Jul 23 16:25:19 2011 > +++ m4/fsusage.m4 Sat Jul 23 16:24:57 2011 > @@ -1,4 +1,4 @@ > -# serial 28 > +# serial 29 > # Obtaining file system usage information. > > # Copyright (C) 1997-1998, 2000-2001, 2003-2011 Free Software Foundation, Inc. > @@ -29,6 +29,12 @@ > > AC_DEFUN([gl_FILE_SYSTEM_USAGE], > [ > +dnl Enable large-file support. This has the effect of changing the size > +dnl of field f_blocks in 'struct statvfs' from 32 bit to 64 bit on > +dnl glibc/Hurd, HP-UX 11, Solaris (32-bit mode). It also changes the size > +dnl of field f_blocks in 'struct statfs' from 32 bit to 64 bit on > +dnl MacOS X >= 10.5 (32-bit mode). > +AC_REQUIRE([AC_SYS_LARGEFILE]) > > AC_MSG_NOTICE([checking how to get file system space usage]) > ac_fsusage_space=no > --- modules/fsusage.orig Sat Jul 23 16:25:19 2011 > +++ modules/fsusage Sat Jul 23 16:06:17 2011 > @@ -7,6 +7,7 @@ > m4/fsusage.m4 > > Depends-on: > +largefile > stdbool > stdint > full-read [test $gl_cv_fs_space = yes] Well-documented, tested, and safe-looking. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 23 11:07:06 2011 Received: (at 9140) by debbugs.gnu.org; 23 Jul 2011 15:07:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkdnF-0005mY-Sa for submit@debbugs.gnu.org; Sat, 23 Jul 2011 11:07:06 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkdnD-0005m4-O4 for 9140@debbugs.gnu.org; Sat, 23 Jul 2011 11:07:04 -0400 Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id D56526005C; Sat, 23 Jul 2011 17:06:57 +0200 (CEST) From: Jim Meyering To: Bruno Haible Subject: Re: fsusage: revert unintended change on AIX, Cygwin, Interix In-Reply-To: <201107231653.41161.bruno@clisp.org> (Bruno Haible's message of "Sat, 23 Jul 2011 16:53:40 +0200") References: <4E29B2AC.2000106@cs.ucla.edu> <201107231553.57880.bruno@clisp.org> <201107231653.41161.bruno@clisp.org> Date: Sat, 23 Jul 2011 17:06:57 +0200 Message-ID: <87zkk511f2.fsf@rho.meyering.net> Lines: 24 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, Paul Eggert , bug-gnulib@gnu.org, Herb Wartens X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Bruno Haible wrote: >> 2) To undo the patch that introduces check_f_blocks_size, because >> - on MacOS X 10.7 it is not needed any more after 1), >> - on AIX and Cywin it causes non-POSIX API to be used for no reason, >> - it kills portability to Interix 3.5. > > Slight correction: It is still needed after 1), at least on MacOS X 10.5. > But only on MacOS X. So here's the proposed patch 2. Verified on AIX and > Cygwin; Thanks again. This looks fine. > I don't have access to an Interix machine. No problem. It seems to have so few coreutils/gnulib users that it barely qualifies as a reasonable portability target. > 2011-07-23 Bruno Haible > > fsusage: Restore previous behaviour on AIX, Cygwin, Interix. > * m4/fsusage.m4 (gl_FILE_SYSTEM_USAGE): Enforce a 64-bit struct statvfs > f_blocks field only on MacOS X. ... From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 23 11:25:06 2011 Received: (at 9140) by debbugs.gnu.org; 23 Jul 2011 15:25:06 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qke4e-0006CN-BB for submit@debbugs.gnu.org; Sat, 23 Jul 2011 11:25:04 -0400 Received: from mo-p00-ob.rzone.de ([81.169.146.162]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qke4b-0006Bp-1h for 9140@debbugs.gnu.org; Sat, 23 Jul 2011 11:25:02 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1311434694; l=3312; s=domk; d=haible.de; h=Content-Transfer-Encoding:Content-Type:MIME-Version:In-Reply-To: References:Cc:Date:Subject:To:From:X-RZG-CLASS-ID:X-RZG-AUTH; bh=23FvzkcmSVjNz4OpmHiltWl1BAY=; b=A49RmXf8ciVXQltIcFgPF8qgS2h5cSLEjFkcFUvH73zGcreKEd97lpNEZ/9l3GHZ2Y/ seJSlPJn1/Qf4JcAt9nUBePvm5AoU75ENTccXMbBMoAM/Qn6dKI2LXitxSA1jrgmbULwX 7t3fiffVttplcnzT3IG5z95vu3u77NqNFt0= X-RZG-AUTH: :Ln4Re0+Ic/6oZXR1YgKryK8brksyK8dozXDwHXjf9hj/zDNRav445DE8 X-RZG-CLASS-ID: mo00 Received: from linuix.haible.de (dslb-088-068-038-069.pools.arcor-ip.net [88.68.38.69]) by smtp.strato.de (cohen mo60) (RZmta 26.2) with ESMTPA id x01455n6NBM1L3 ; Sat, 23 Jul 2011 17:24:07 +0200 (MEST) From: Bruno Haible To: bug-gnulib@gnu.org Subject: fsusage: add large volume support on AIX Date: Sat, 23 Jul 2011 17:24:31 +0200 User-Agent: KMail/1.13.6 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.0; x86_64; ; ) References: <4E29B2AC.2000106@cs.ucla.edu> <201107231553.57880.bruno@clisp.org> In-Reply-To: <201107231553.57880.bruno@clisp.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Message-Id: <201107231724.31222.bruno@clisp.org> X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, Paul Eggert , Herb Wartens X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) > 3) To make use of statvfs64 on AIX. Here's the proposed patch for it. As expected we get: - On AIX 5.2, 6.1, 7.1: checking whether to use statvfs64... yes - On AIX 5.1, HP-UX, IRIX, Solaris: checking whether to use statvfs64... no 2011-07-23 Bruno Haible fsusage: Enable large volume support on AIX >=3D 5.2. * m4/fsusage.m4 (gl_FILE_SYSTEM_USAGE): If 'struct statvfs64' has a larger f_blocks field than 'struct statvfs', define STAT_STATVFS64 instead of STAT_STATVFS. * lib/fsusage.c (get_fs_usage) [STAT_STATVFS64]: Use statvfs64. =2D-- lib/fsusage.c.orig Sat Jul 23 17:15:05 2011 +++ lib/fsusage.c Sat Jul 23 17:13:38 2011 @@ -23,7 +23,7 @@ #include #include =20 =2D#if STAT_STATVFS /* POSIX 1003.1-2001 (and later) with XS= I */ +#if STAT_STATVFS || STAT_STATVFS64 /* POSIX 1003.1-2001 (and later) with X= SI */ # include #else /* Don't include backward-compatibility files unless they're needed. @@ -106,6 +106,18 @@ ? PROPAGATE_ALL_ONES (fsd.f_frsize) : PROPAGATE_ALL_ONES (fsd.f_bsize)); =20 +#elif defined STAT_STATVFS64 /* AIX */ + + struct statvfs64 fsd; + + if (statvfs64 (file, &fsd) < 0) + return -1; + + /* f_frsize isn't guaranteed to be supported. */ + fsp->fsu_blocksize =3D (fsd.f_frsize + ? PROPAGATE_ALL_ONES (fsd.f_frsize) + : PROPAGATE_ALL_ONES (fsd.f_bsize)); + #elif defined STAT_STATFS2_FS_DATA /* Ultrix */ =20 struct fs_data fsd; @@ -223,7 +235,7 @@ =20 #endif =20 =2D#if (defined STAT_STATVFS \ +#if (defined STAT_STATVFS || defined STAT_STATVFS64 \ || (!defined STAT_STATFS2_FS_DATA && !defined STAT_READ_FILSYS)) =20 fsp->fsu_blocks =3D PROPAGATE_ALL_ONES (fsd.f_blocks); =2D-- m4/fsusage.m4.orig Sat Jul 23 17:15:05 2011 +++ m4/fsusage.m4 Sat Jul 23 17:12:20 2011 @@ -1,4 +1,4 @@ =2D# serial 29 +# serial 30 # Obtaining file system usage information. =20 # Copyright (C) 1997-1998, 2000-2001, 2003-2011 Free Software Foundation, = Inc. @@ -81,8 +81,32 @@ [fu_cv_sys_stat_statvfs=3Dno])]) if test $fu_cv_sys_stat_statvfs =3D yes; then ac_fsusage_space=3Dyes =2D AC_DEFINE([STAT_STATVFS], [1], =2D [ Define if there is a function named statvfs. (SVR4)]) + # AIX >=3D 5.2 has statvfs64 that has a wider f_blocks field than stat= vfs. + # glibc, HP-UX, IRIX, Solaris have statvfs64 as well, but on these sys= tems + # statvfs with large-file support is already equivalent to statvfs64. + AC_CACHE_CHECK([whether to use statvfs64], + [fu_cv_sys_stat_statvfs64], + [AC_LINK_IFELSE( + [AC_LANG_PROGRAM( + [[#include + #include + struct statvfs64 fsd; + int check_f_blocks_larger_in_statvfs64 + [sizeof (((struct statvfs64 *) 0)->f_blocks) + > sizeof (((struct statvfs *) 0)->f_blocks) + ? 1 : -1]; + ]], + [[statvfs64 (0, &fsd);]])], + [fu_cv_sys_stat_statvfs64=3Dyes], + [fu_cv_sys_stat_statvfs64=3Dno]) + ]) + if test $fu_cv_sys_stat_statvfs64 =3D yes; then + AC_DEFINE([STAT_STATVFS64], [1], + [ Define if statvfs64 should be preferred over statvfs.]) + else + AC_DEFINE([STAT_STATVFS], [1], + [ Define if there is a function named statvfs. (SVR4)]) + fi fi fi =20 =2D-=20 In memoriam Adam Czerniak=F3w From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 23 11:48:07 2011 Received: (at 9140) by debbugs.gnu.org; 23 Jul 2011 15:48:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkeQw-0006j5-Rz for submit@debbugs.gnu.org; Sat, 23 Jul 2011 11:48:07 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkeQu-0006id-I3 for 9140@debbugs.gnu.org; Sat, 23 Jul 2011 11:48:05 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 13C6539E80FF; Sat, 23 Jul 2011 08:47:59 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3pk9HaGTAGdK; Sat, 23 Jul 2011 08:47:58 -0700 (PDT) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 9F00D39E80E1; Sat, 23 Jul 2011 08:47:58 -0700 (PDT) Message-ID: <4E2AED28.1050507@cs.ucla.edu> Date: Sat, 23 Jul 2011 08:47:52 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11 MIME-Version: 1.0 To: Bruno Haible Subject: Re: bug#9140: fsusage: add large volume support on AIX References: <4E29B2AC.2000106@cs.ucla.edu> <201107231553.57880.bruno@clisp.org> <201107231724.31222.bruno@clisp.org> In-Reply-To: <201107231724.31222.bruno@clisp.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, bug-gnulib@gnu.org, Herb Wartens X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) Thanks for all that work in analysis, and porting checking, for statvfs etc. Your patches look good to me too. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 24 06:26:17 2011 Received: (at 9140) by debbugs.gnu.org; 24 Jul 2011 10:26:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qkvt2-0007ut-TV for submit@debbugs.gnu.org; Sun, 24 Jul 2011 06:26:17 -0400 Received: from mo-p00-ob.rzone.de ([81.169.146.161]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qkvsz-0007uh-C4 for 9140@debbugs.gnu.org; Sun, 24 Jul 2011 06:26:14 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1311503167; l=350; s=domk; d=haible.de; h=Content-Transfer-Encoding:Content-Type:MIME-Version:In-Reply-To: References:Cc:Date:Subject:To:From:X-RZG-CLASS-ID:X-RZG-AUTH; bh=ym1Kiv1cIytUlgLXCE21kUy28TM=; b=eFE7jugJwoDcKeTvidLa81kAHq/dOjbijQrZTahCEYDTgj6jFfJlsGlpysZ+8DjaQeg FT1u8WXLLW44etmAadBUXnIGIP/dJc99nKIEiNPxW/bVLKVsxvTOGAFx6so/L9HFyQgf2 5t0Ff0rR/8PytbOV3cRlqH4MAlMaH8wnRLI= X-RZG-AUTH: :Ln4Re0+Ic/6oZXR1YgKryK8brksyK8dozXDwHXjf9hj/zDNRav445DE8 X-RZG-CLASS-ID: mo00 Received: from linuix.haible.de (dslb-088-068-038-069.pools.arcor-ip.net [88.68.38.69]) by smtp.strato.de (jimi mo23) (RZmta 26.2) with ESMTPA id I043d3n6O7KDSq ; Sun, 24 Jul 2011 12:25:49 +0200 (MEST) From: Bruno Haible To: Paul Eggert Subject: Re: bug#9140: fsusage: add large volume support on AIX Date: Sun, 24 Jul 2011 12:26:16 +0200 User-Agent: KMail/1.13.6 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.0; x86_64; ; ) References: <201107231724.31222.bruno@clisp.org> <4E2AED28.1050507@cs.ucla.edu> In-Reply-To: <4E2AED28.1050507@cs.ucla.edu> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201107241226.16655.bruno@clisp.org> X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, bug-gnulib@gnu.org, Herb Wartens X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) Paul Eggert wrote: > Your patches look good to me too. Thanks for the review. I've pushed the 3 patches now. You can add a coreutils/NEWS entry that says: 'df' now supports volumes larger than 4 TiB on MacOS X 10.5 or newer and on AIX 5.2 or newer. Bruno -- In memoriam Ezechiele Ramin From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 24 17:04:51 2011 Received: (at 9140) by debbugs.gnu.org; 24 Jul 2011 21:04:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ql5r1-0001vT-0T for submit@debbugs.gnu.org; Sun, 24 Jul 2011 17:04:51 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ql5qx-0001vH-UT for 9140@debbugs.gnu.org; Sun, 24 Jul 2011 17:04:48 -0400 Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id CCDF16003D; Sun, 24 Jul 2011 23:04:41 +0200 (CEST) From: Jim Meyering To: Bruno Haible Subject: Re: bug#9140: fsusage: add large volume support on AIX In-Reply-To: <201107241226.16655.bruno@clisp.org> (Bruno Haible's message of "Sun, 24 Jul 2011 12:26:16 +0200") References: <201107231724.31222.bruno@clisp.org> <4E2AED28.1050507@cs.ucla.edu> <201107241226.16655.bruno@clisp.org> Date: Sun, 24 Jul 2011 23:04:41 +0200 Message-ID: <87bowj75li.fsf@rho.meyering.net> Lines: 82 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, Paul Eggert , bug-gnulib@gnu.org, Herb Wartens X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Bruno Haible wrote: > Paul Eggert wrote: >> Your patches look good to me too. > > Thanks for the review. I've pushed the 3 patches now. > > You can add a coreutils/NEWS entry that says: > > 'df' now supports volumes larger than 4 TiB on MacOS X 10.5 or newer > and on AIX 5.2 or newer. Thanks. I've done this: >From c29cb31b7ff536d2367dad1dcb19c554a8752233 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 24 Jul 2011 22:52:34 +0200 Subject: [PATCH] df: support partitions larger than 4 TiB on MacOS >= 10.5 & AIX >=5.2 This change derives from improvements to gnulib's fsusage module. * NEWS (Improvements): df now supports disk partitions larger than 4 TiB on MacOS X 10.5 or newer and on AIX 5.2 or newer. Alphabetize entries. * gnulib: Update to latest. --- NEWS | 17 ++++++++++------- gnulib | 2 +- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/NEWS b/NEWS index 2952dc9..0720719 100644 --- a/NEWS +++ b/NEWS @@ -30,6 +30,10 @@ GNU coreutils NEWS -*- outline -*- ** New features + md5sum accepts the new --strict option. With --check, it makes the + tool exit non-zero for any invalid input line, rather than just warning. + This also affects sha1sum, sha224sum, sha384sum and sha512sum. + split accepts a new --filter=CMD option. With it, split filters output through CMD. CMD may use the $FILE environment variable, which is set to the nominal output file name for each invocation of CMD. For example, to @@ -38,22 +42,21 @@ GNU coreutils NEWS -*- outline -*- Note the use of single quotes, not double quotes. That creates files named xaa.xz, xab.xz and xac.xz. - md5sum accepts the new --strict option. With --check, it makes the - tool exit non-zero for any invalid input line, rather than just warning. - This also affects sha1sum, sha224sum, sha384sum and sha512sum. - timeout accepts a new --foreground option, to support commands not started directly from a shell prompt, where the command is interactive or needs to receive signals initiated from the terminal. ** Improvements - shuf outputs small subsets of large permutations much more efficiently. - For example `shuf -i1-$((2**32-1)) -n2` no longer exhausts memory. - cp and ls now support HP-UX 11.11's ACLs, thanks to improved support in gnulib. + df now supports disk partitions larger than 4 TiB on MacOS X 10.5 + or newer and on AIX 5.2 or newer. + + shuf outputs small subsets of large permutations much more efficiently. + For example `shuf -i1-$((2**32-1)) -n2` no longer exhausts memory. + stat -f now recognizes the GPFS, MQUEUE and PSTOREFS file system types. ** Build-related diff --git a/gnulib b/gnulib index bd399f0..bac9647 160000 --- a/gnulib +++ b/gnulib @@ -1 +1 @@ -Subproject commit bd399f07ee4f383fad038efad25a659fcdc0bbb0 +Subproject commit bac964725a412c590498aba68f6b9a8e723ae474 -- 1.7.6.609.gbf6a9 From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 24 17:59:41 2011 Received: (at 9140) by debbugs.gnu.org; 24 Jul 2011 21:59:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ql6i4-0003Cx-8u for submit@debbugs.gnu.org; Sun, 24 Jul 2011 17:59:40 -0400 Received: from mo-p00-ob.rzone.de ([81.169.146.160]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ql6i1-0003Ch-Cc for 9140@debbugs.gnu.org; Sun, 24 Jul 2011 17:59:38 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1311544771; l=2671; s=domk; d=haible.de; h=Content-Transfer-Encoding:Content-Type:MIME-Version:In-Reply-To: References:Cc:Date:Subject:To:From:X-RZG-CLASS-ID:X-RZG-AUTH; bh=Sft3ZhlFI43EZMyjbWeAVI+B3mQ=; b=rnmfqA7WK9DpQnXs6V+3/aNSP6pwN8JrauefkRmmYGLLZuk6UARQExB4wnX0rsQ0hJi N1GoXz87ijLT/HIf7qRdpGeueM3M1YBERgkoU7zbg2oz9+5G3KNDSVAGB284Lrqmrp86S 0l/akQGmLoLVGCyb2IcQzAHVhCPEsuyPt/M= X-RZG-AUTH: :Ln4Re0+Ic/6oZXR1YgKryK8brksyK8dozXDwHXjf9hj/zDNRav445DE8 X-RZG-CLASS-ID: mo00 Received: from linuix.haible.de (dslb-088-068-038-069.pools.arcor-ip.net [88.68.38.69]) by post.strato.de (mrclete mo27) (RZmta 26.2) with ESMTPA id k02963n6OJWB3a ; Sun, 24 Jul 2011 23:59:14 +0200 (MEST) From: Bruno Haible To: bug-gnulib@gnu.org Subject: Re: bug#9140: Coreutils Bug on OSX 10.7 (Lion) Date: Sun, 24 Jul 2011 23:59:42 +0200 User-Agent: KMail/1.13.6 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.0; x86_64; ; ) References: <4E29B2AC.2000106@cs.ucla.edu> In-Reply-To: <4E29B2AC.2000106@cs.ucla.edu> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201107242359.43150.bruno@clisp.org> X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, Paul Eggert , Herb Wartens X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) Paul Eggert wrote: > * m4/fsusage.m4 (gl_FILE_SYSTEM_USAGE): Reject statvfs > implementations that use only 32 bits to count blocks. Dealing with the statvfs() / statfs() calls is one thing. But 'df' also relies on the 'mountlist' module, which on MacOS X uses the function getmntinfo(). This function too exists in two variants getmntinfo getmntinfo$INODE64 equivalent to getmntinfo64 and the first one returns 'struct statfs' entities with 32-bit f_blocks. Likewise there is getfsstat getfsstat$INODE64 equivalent to getfsstat64 Here's an excerpt from the manual page: NAME getmntinfo -- get information about mounted file systems ... int getmntinfo(struct statfs **mntbufp, int flags); int getmntinfo64(struct statfs64 **mntbufp, int flags); ... The getmntinfo() function passes its flags argument transparently to getfsstat(2), while the getmntinfo64() function passes its flags argument transparently to getfsstat64(). See [1][2]. So, if the 'mountlist' modules is used outside of coreutils, it also needs the 'largefile' module, so as to map getmntinfo to getmntinfo$INODE64. Here's a proposed patch. [1] http://developer.apple.com/library/mac/#documentation/Darwin/Reference/ManPages/man3/getmntinfo.3.html [2] http://developer.apple.com/library/mac/#documentation/Darwin/Reference/ManPages/man2/getfsstat.2.html 2011-07-24 Bruno Haible mountlist: Enable large volume support on MacOS X >= 10.5. * m4/ls-mntd-fs.m4 (gl_LIST_MOUNTED_FILE_SYSTEMS): Require AC_SYS_LARGEFILE. * modules/mountlist (Depends-on): Add largefile. --- m4/ls-mntd-fs.m4.orig Sun Jul 24 23:44:01 2011 +++ m4/ls-mntd-fs.m4 Sun Jul 24 22:41:08 2011 @@ -1,4 +1,4 @@ -# serial 29 +# serial 30 # How to list mounted file systems. # Copyright (C) 1998-2004, 2006, 2009-2011 Free Software Foundation, Inc. @@ -26,6 +26,12 @@ # gl_LIST_MOUNTED_FILE_SYSTEMS([ACTION-IF-FOUND[, ACTION-IF-NOT-FOUND]]) AC_DEFUN([gl_LIST_MOUNTED_FILE_SYSTEMS], [ +dnl Enable large-file support. This has the effect of changing the size +dnl of field f_blocks in 'struct statfs' from 32 bit to 64 bit on +dnl MacOS X >= 10.5 (32-bit mode), allowing file systems >= 4 TiB to be +dnl found. +AC_REQUIRE([AC_SYS_LARGEFILE]) + AC_CHECK_FUNCS([listmntent getmntinfo]) AC_CHECK_HEADERS_ONCE([sys/param.h sys/statvfs.h]) --- modules/mountlist.orig Sun Jul 24 23:44:01 2011 +++ modules/mountlist Sun Jul 24 22:30:10 2011 @@ -9,6 +9,7 @@ m4/mountlist.m4 Depends-on: +largefile stdbool stdint strstr-simple -- In memoriam Ezechiele Ramin From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 25 02:56:11 2011 Received: (at 9140) by debbugs.gnu.org; 25 Jul 2011 06:56:11 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QlF5G-0000Xn-Tv for submit@debbugs.gnu.org; Mon, 25 Jul 2011 02:56:11 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QlF5C-0000XJ-NO for 9140@debbugs.gnu.org; Mon, 25 Jul 2011 02:56:08 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 559F639E810E; Sun, 24 Jul 2011 23:55:54 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z-H+ZJnoISNQ; Sun, 24 Jul 2011 23:55:43 -0700 (PDT) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 2F2A139E8100; Sun, 24 Jul 2011 23:55:27 -0700 (PDT) Message-ID: <4E2D1346.3000902@cs.ucla.edu> Date: Sun, 24 Jul 2011 23:55:02 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11 MIME-Version: 1.0 To: Bruno Haible Subject: Re: bug#9140: Coreutils Bug on OSX 10.7 (Lion) References: <4E29B2AC.2000106@cs.ucla.edu> <201107242359.43150.bruno@clisp.org> In-Reply-To: <201107242359.43150.bruno@clisp.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, bug-gnulib@gnu.org, Herb Wartens X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On 07/24/11 14:59, Bruno Haible wrote: > +dnl Enable large-file support. This has the effect of changing the size > +dnl of field f_blocks in 'struct statfs' from 32 bit to 64 bit on > +dnl MacOS X >= 10.5 (32-bit mode), allowing file systems >= 4 TiB to be > +dnl found. > +AC_REQUIRE([AC_SYS_LARGEFILE]) > + > AC_CHECK_FUNCS([listmntent getmntinfo]) > AC_CHECK_HEADERS_ONCE([sys/param.h sys/statvfs.h]) Why is this part of the patch needed? If the mountlist module depends on the largefile module, AC_SYS_LARGEFILE is already guaranteed to be invoked. Please see, for example, my proposed patch in and updated just now, which changes mountlist to depend on largefile, but does not add the AC_REQUIRE (and in fact removes a couple of AC_REQUIRE calls that are no longer needed, in mkstemp.m4 and tempname.m4). From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 08 11:37:43 2011 Received: (at 9140) by debbugs.gnu.org; 8 Aug 2011 15:37:44 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QqRtf-0006JM-9d for submit@debbugs.gnu.org; Mon, 08 Aug 2011 11:37:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QqRtd-0006JE-3q for 9140@debbugs.gnu.org; Mon, 08 Aug 2011 11:37:42 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p78FaVWB004525 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 8 Aug 2011 11:36:31 -0400 Received: from [10.3.113.144] (ovpn-113-144.phx2.redhat.com [10.3.113.144]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p78FaUkL029002; Mon, 8 Aug 2011 11:36:30 -0400 Message-ID: <4E40027D.1050607@redhat.com> Date: Mon, 08 Aug 2011 09:36:29 -0600 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.11 MIME-Version: 1.0 To: Paul Eggert Subject: Re: [PATCH 2/3] large-inode: New module References: <4E29B1DD.8030800@cs.ucla.edu> <4E29B749.1030705@draigBrady.com> <4E29F570.7010705@cs.ucla.edu> In-Reply-To: <4E29F570.7010705@cs.ucla.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id p78FaVWB004525 X-Spam-Score: -10.3 (----------) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, Bug-gnulib , =?ISO-8859-1?Q?P=E1draig_Brady?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -10.3 (----------) On 07/22/2011 04:10 PM, Paul Eggert wrote: > On 07/22/11 10:45, P=E1draig Brady wrote: >> If it works it would be better in AC_SYS_LARGEFILE (as well) I think. > > OK, thanks, I pushed this into gnulib. Assuming it works (and I don't > see why it'd hurt) I'll push it into autoconf. Ouch. This commit broke libvirt 0.9.4, because it unintentionally broke=20 large-file support altogether. It will probably break any other=20 packages that have picked up the latest gnulib in the last few days. > P=E1draig Brady suggested this in . > * MODULES.html.sh: Add largefile, remove large-inode. > * modules/largefile, m4/largefile.m4: New files. > * modules/large-inode, m4/large-inode.m4: Remove. > - > -configure.ac-early: > -AC_REQUIRE([gl_SYS_LARGE_INODE]) > - > -configure.ac: > - > + > +configure.ac: > +AC_REQUIRE([AC_SYS_LARGEFILE]) > + > +configure.ac: > + The first configure.ac should have been configure.ac-early; as a result=20 of the duplicate listing, gnulib-tool completely omits AC_SYS_LARGEFILE=20 from any configure.ac that was using the broken largefile module. Test=20 by looking at './configure --help | grep large' pre- and post-patch.=20 I'm pushing this: diff --git i/ChangeLog w/ChangeLog index 72e7611..3fd0c47 100644 --- i/ChangeLog +++ w/ChangeLog @@ -1,3 +1,8 @@ +2011-08-08 Eric Blake + + largefile: fix typo that regressed large file support + * modules/largefile (configure.ac-early): Fix section name. + 2011-08-06 Karl Berry * MODULES.html.sh (func_all_files): _Noreturn is no longer diff --git i/modules/largefile w/modules/largefile index d4a2e4b..ca10d48 100644 --- i/modules/largefile +++ w/modules/largefile @@ -6,7 +6,7 @@ m4/largefile.m4 Depends-on: -configure.ac: +configure.ac-early: AC_REQUIRE([AC_SYS_LARGEFILE]) configure.ac: --=20 Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 08 11:39:33 2011 Received: (at 9140) by debbugs.gnu.org; 8 Aug 2011 15:39:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QqRvR-0006MJ-1k for submit@debbugs.gnu.org; Mon, 08 Aug 2011 11:39:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QqRvO-0006MA-MK for 9140@debbugs.gnu.org; Mon, 08 Aug 2011 11:39:31 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p78FcRm2026073 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 8 Aug 2011 11:38:27 -0400 Received: from [10.3.113.144] (ovpn-113-144.phx2.redhat.com [10.3.113.144]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p78FcQKK007662; Mon, 8 Aug 2011 11:38:26 -0400 Message-ID: <4E4002F2.3090101@redhat.com> Date: Mon, 08 Aug 2011 09:38:26 -0600 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.11 MIME-Version: 1.0 To: Paul Eggert Subject: Re: bug#9140: [PATCH 2/3] large-inode: New module References: <4E29B1DD.8030800@cs.ucla.edu> <4E29B749.1030705@draigBrady.com> <4E29F570.7010705@cs.ucla.edu> In-Reply-To: <4E29F570.7010705@cs.ucla.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id p78FcRm2026073 X-Spam-Score: -10.3 (----------) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, Bug-gnulib , =?ISO-8859-1?Q?P=E1draig_Brady?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -10.3 (----------) On 07/22/2011 04:10 PM, Paul Eggert wrote: > On 07/22/11 10:45, P=E1draig Brady wrote: >> If it works it would be better in AC_SYS_LARGEFILE (as well) I think. > > OK, thanks, I pushed this into gnulib. Assuming it works (and I don't > see why it'd hurt) I'll push it into autoconf. No problem with me to pushing the AC_SYS_LARGEFILE improvements into=20 autoconf. --=20 Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 08 16:39:04 2011 Received: (at 9140) by debbugs.gnu.org; 8 Aug 2011 20:39:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QqWbI-0007NS-00 for submit@debbugs.gnu.org; Mon, 08 Aug 2011 16:39:04 -0400 Received: from mo-p00-ob.rzone.de ([81.169.146.160]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QqWbD-0007N9-W6 for 9140@debbugs.gnu.org; Mon, 08 Aug 2011 16:39:01 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1312835874; l=471; s=domk; d=haible.de; h=Content-Transfer-Encoding:Content-Type:MIME-Version:In-Reply-To: References:Cc:Date:Subject:To:From:X-RZG-CLASS-ID:X-RZG-AUTH; bh=5cr3P/RXpMqYD1sU19sOFHRj7HQ=; b=SKAXyYzkyQc4Y4/0GDpxpwUeGpsbcNhkUnln1DjjKDjq216CQqu10gsuQ8Iuo3dJb03 VivD3Duv6EfcORqpMULeqceKzY3VlHybLOu4Ev/sLJ6CtzoQ8fOiUmCWcHulvw/rk+9yw XEpLQF/PJXZVaQWX+vDoYZmWpQgTE4Ovrpc= X-RZG-AUTH: :Ln4Re0+Ic/6oZXR1YgKryK8brksyK8dozXDwHXjf9hj/zDNRav445DE8 X-RZG-CLASS-ID: mo00 Received: from linuix.haible.de (dslb-088-068-038-069.pools.arcor-ip.net [88.68.38.69]) by post.strato.de (mrclete mo9) (RZmta 26.2) with ESMTPA id m040c9n78HsiV6 ; Mon, 8 Aug 2011 22:36:59 +0200 (MEST) From: Bruno Haible To: bug-gnulib@gnu.org Subject: Re: [PATCH 2/3] large-inode: New module Date: Mon, 8 Aug 2011 22:38:24 +0200 User-Agent: KMail/1.13.6 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.0; x86_64; ; ) References: <4E29B1DD.8030800@cs.ucla.edu> <4E29F570.7010705@cs.ucla.edu> <4E40027D.1050607@redhat.com> In-Reply-To: <4E40027D.1050607@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201108082238.24574.bruno@clisp.org> X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 9140 Cc: 9140@debbugs.gnu.org, Paul Eggert , Eric Blake X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) Eric Blake wrote: > It will probably break any other > packages that have picked up the latest gnulib in the last few days. Indeed. It broke libiconv-1.14. But fortunately it's not a regression. Large file support in the 'iconv' program would have been an undocumented improvement. Now it's delayed to libiconv-1.15... Thanks for having discovered and fixed this, Eric!! Bruno -- In memoriam Edward Pimental From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 30 04:07:08 2012 Received: (at control) by debbugs.gnu.org; 30 Aug 2012 08:07:08 +0000 Received: from localhost ([127.0.0.1]:57030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T6zmO-0004un-2q for submit@debbugs.gnu.org; Thu, 30 Aug 2012 04:07:08 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33853) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T6zmL-0004uf-2I for control@debbugs.gnu.org; Thu, 30 Aug 2012 04:07:06 -0400 Received: from compute5.internal (compute5.nyi.mail.srv.osa [10.202.2.45]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id ED43A20DA5 for ; Thu, 30 Aug 2012 04:05:55 -0400 (EDT) Received: from web5.nyi.mail.srv.osa ([10.202.2.215]) by compute5.internal (MEProxy); Thu, 30 Aug 2012 04:05:55 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=message-id:from:to:mime-version :content-transfer-encoding:content-type:subject:date; s=smtpout; bh=g3x1YkP2vluBEiAMNfVG/RrTs8w=; b=TZifXzPLwB25W+uO3zOoS/hKp7Oe KhJauDa80k+NMovM0kYUSZt+0p/bpnOh0CKI1A233+hxUgr8wXVw3M1yaiA+SIjp 3lcXH7H2asp6p+g+dl6KDunycJuQGMWel+95+AZrDypuVZfWuzQ8lk/q3aAG3yXQ TT9u7m6/S5244xc= Received: by web5.nyi.mail.srv.osa (Postfix, from userid 99) id BD7B04C0212; Thu, 30 Aug 2012 04:05:55 -0400 (EDT) Message-Id: <1346313955.6848.140661121418585.20DF5764@webmail.messagingengine.com> X-Sasl-Enc: T2AqFlIWN6GQ1vxU9Q18H9U0y8luevpcLNcOSgz5PZxR 1346313955 From: era eriksson To: control@debbugs.gnu.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain X-Mailer: MessagingEngine.com Webmail Interface Subject: Bug maintenance Date: Thu, 30 Aug 2012 11:05:55 +0300 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) forcemerge 6366 10924 merge 7389 7394 tags 7394 + patch merge 7948 7963 7968 retitle 9140 [du] broken on OSX 10.7 (Lion) for >4TB file systems retitle 10003 [df] information differs from GUI retitle 10013 [ls] document origin of name tags 10013 + patch retitle 10054 [cp] 8.13: cp -au may replace newer files [sr #107876] retitle 10877 [sort] too eager to use temp files retitle 11760 [mv] data loss after ctrl-C on ntfs -> ntfs move thanks I also wanted to retitle 10900 but it's too opaque, and should be followed up. I took this out because I'm not sure I was able to summarize it correctly. retitle 10639 [cp] test-copy-acl fails on Solaris 64bit + NFS /* era */ -- If this were a real .signature, it would suck less. Well, maybe not. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 11 18:34:30 2018 Received: (at control) by debbugs.gnu.org; 11 Oct 2018 22:34:30 +0000 Received: from localhost ([127.0.0.1]:45702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAjXK-0004zX-B8 for submit@debbugs.gnu.org; Thu, 11 Oct 2018 18:34:30 -0400 Received: from mail-pg1-f182.google.com ([209.85.215.182]:45621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAjXI-0004zL-9d for control@debbugs.gnu.org; Thu, 11 Oct 2018 18:34:28 -0400 Received: by mail-pg1-f182.google.com with SMTP id t70-v6so4828541pgd.12 for ; Thu, 11 Oct 2018 15:34:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:message-id:date:user-agent:mime-version:content-language :content-transfer-encoding; bh=7apBCEYAVn0WRPO0lUXyhbI1fmL5j8ewFFZTMWbq3yI=; b=toL8k7fQ5KxcbpSCAnSstHi4BG3qCcxWJcN/bt/seLilla0Ue8MSoU9J1v5V6iO3fg Amtg9kpyXCz6IczP+2B5sJYJK3YfFfjxTAGmOxtTrod4ghSW0k15rGSpYxYDiFSlcAsB b+vq/HbVS9N7uvE1FMp1P3qbiMEIDsfLl6k4ET6Al2IcPeFzjjrZ9zwHGa2VJe/ExfXe 3jQYK+A79YMNLDdZUC61eJzXCsccw+t/vFb+7hJkDSgoB+YVi3OxSUwg8JCeiJ7OQyWV 5ZoV8ucVi7kf21B9kSPfhOsY9gPJXdQIdN2I3zwzq+DrwthawKhrBWKjm3NgJcH/itND ft5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=7apBCEYAVn0WRPO0lUXyhbI1fmL5j8ewFFZTMWbq3yI=; b=nuSXC9XJQrXagjzp9W7BnUZ1ommpMMtThBjiA0K4nSj9o4WjsFR3A+T1I38yKP0Fzo a80GuqT/kmd2gJ88NlNpMrUnhTux+WSOZT6sFbPjHet1qbxR/kyeBG+9D3hrvi5hSWA0 tPvm9ZgUek97jmNo/HTOyGsYT7L9WvOcTvbZmJCQO76Uela8KzNPYaRgVOQJVzz465na sR7y8GEOE2qoVSBsmVUSe1wlUlBo3OI4XiIlKUgqew8ofHkd3Hl+Mbbx5l67NR2KDA57 ZddvDznKsR+vGLbgzftMTy7UXhlrFIOgqUwKS/fIz34hApKzdH3ed7ALT7sbC92Nk5DQ euZw== X-Gm-Message-State: ABuFfoizOr8B6DzumAK7s/Z8zthjLcrY02/3IwhW8rDQY8Q2vWkcMPwY fJKVbts5ENDLCy3pJZy+ho5ZQXpS X-Google-Smtp-Source: ACcGV60Jjf/wOacofqXbjwl8/obHA6hjNflkUrX7x5s0ygRZTEYhAlGGdhz8FbeEIziWm+tOq6xQvQ== X-Received: by 2002:a62:8910:: with SMTP id v16-v6mr3401359pfd.106.1539297261732; Thu, 11 Oct 2018 15:34:21 -0700 (PDT) Received: from tomato.housegordon.com (moose.housegordon.com. [184.68.105.38]) by smtp.googlemail.com with ESMTPSA id o12-v6sm12147564pgv.7.2018.10.11.15.34.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Oct 2018 15:34:20 -0700 (PDT) To: control@debbugs.gnu.org From: Assaf Gordon Message-ID: <9feaab7a-6767-723b-785a-b9e39fa507c7@gmail.com> Date: Thu, 11 Oct 2018 16:34:19 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 12656 tags 8824 moreinfo close 8824 tags 8767 + moreinfo close 8767 [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.215.182 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (assafgordon[at]gmail.com) 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.182 listed in wl.mailspike.net] 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) close 12656 tags 8824 moreinfo close 8824 tags 8767 + moreinfo close 8767 tags 8736 wontfix close 8736 tags 8700 wontfix close 8700 close 8616 tags 9101 fixed close 9101 retitle 9129 printf: RFE: reject field width larger than INT_MAX tags 9129 notabug close 9129 tags 9140 fixed close 9140 tags 9207 wontfix close 9207 From unknown Fri Aug 15 12:50:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 09 Nov 2018 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator