GNU bug report logs - #909
not finding etc/charsets/ should give some error/warning

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 909 in the body.
You can then email your comments to 909 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: not finding etc/charsets/ should give some error/warning
Date: Sun, 07 Sep 2008 04:19:28 -0700

Currently if etc/charsets/ is not found at runtime no warning/error
is shown.  Not having that directory results in strange behavior, and we
have had a few instances of such problems reported to the list.

It would be great if some warning/error would be shown if etc/charsets/*
is not found.

Message #8 received at 909 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: 909 <at> debbugs.gnu.org
Subject: Re: bug#909: not finding etc/charsets/ should give some error/warning
Date: Wed, 10 Sep 2008 16:59:59 -0400

Dan Nicolaescu wrote:

> It would be great if some warning/error would be shown if
> etc/charsets/* is not found.

*** charset.c	3 Jun 2008 04:22:55 -0000	1.163
--- charset.c	10 Sep 2008 21:00:06 -0000
***************
*** 2044,2052 ****
  void
  init_charset ()
  {
!   Vcharset_map_path
!     = Fcons (Fexpand_file_name (build_string ("charsets"), Vdata_directory),
! 	     Qnil);
  }
  
  
--- 2044,2055 ----
  void
  init_charset ()
  {
!   Lisp_Object tempdir;
!   tempdir = Fexpand_file_name (build_string ("charsets"), Vdata_directory);
!   if (access (SDATA (tempdir), 0) < 0)
!     dir_warning ("Warning: charsets directory (%s) does not exist.\n",
! 		 tempdir);
! 
!   Vcharset_map_path = Fcons (tempdir, Qnil);
  }
  

Message #13 received at 909 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 909 <at> debbugs.gnu.org
Subject: Re: bug#909: not finding etc/charsets/ should give some error/warning
Date: Wed, 10 Sep 2008 23:37:23 -0700

Glenn Morris <rgm <at> gnu.org> writes:

  > Dan Nicolaescu wrote:
  > 
  > > It would be great if some warning/error would be shown if
  > > etc/charsets/* is not found.
  > 
  > *** charset.c	3 Jun 2008 04:22:55 -0000	1.163
  > --- charset.c	10 Sep 2008 21:00:06 -0000
  > ***************
  > *** 2044,2052 ****
  >   void
  >   init_charset ()
  >   {
  > !   Vcharset_map_path
  > !     = Fcons (Fexpand_file_name (build_string ("charsets"), Vdata_directory),
  > ! 	     Qnil);
  >   }
  >   
  >   
  > --- 2044,2055 ----
  >   void
  >   init_charset ()
  >   {
  > !   Lisp_Object tempdir;
  > !   tempdir = Fexpand_file_name (build_string ("charsets"), Vdata_directory);
  > !   if (access (SDATA (tempdir), 0) < 0)
  > !     dir_warning ("Warning: charsets directory (%s) does not exist.\n",
  > ! 		 tempdir);

Thanks.

How about saying something like "Emacs will not function correctly in
this condition", or something of the sort, to emphasize that the
situation is quite bad?

Message #16 received at 909 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: 909 <at> debbugs.gnu.org
Subject: Re: bug#909: not finding etc/charsets/ should give some error/warning
Date: Thu, 11 Sep 2008 03:11:41 -0400

Dan Nicolaescu wrote:

> How about saying something like "Emacs will not function correctly in
> this condition", or something of the sort, to emphasize that the
> situation is quite bad?

Should it cause an abort?

Message #21 received at 909 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Andreas Schwab <schwab <at> suse.de>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 909 <at> debbugs.gnu.org, Dan Nicolaescu <dann <at> ics.uci.edu>
Subject: Re: bug#909: not finding etc/charsets/ should give some error/warning
Date: Thu, 11 Sep 2008 10:37:05 +0200

Glenn Morris <rgm <at> gnu.org> writes:

> Dan Nicolaescu wrote:
>
>> How about saying something like "Emacs will not function correctly in
>> this condition", or something of the sort, to emphasize that the
>> situation is quite bad?
>
> Should it cause an abort?

It's an external condition that Emacs has no control over (it could be a
temporary NFS problem, for example).  Just aborting does not give any
clue what is wrong.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab <at> suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Message #24 received at 909 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Andreas Schwab <schwab <at> suse.de>
Cc: 909 <at> debbugs.gnu.org, Dan Nicolaescu <dann <at> ics.uci.edu>
Subject: Re: bug#909: not finding etc/charsets/ should give some error/warning
Date: Thu, 11 Sep 2008 12:09:44 -0400

Andreas Schwab wrote:

> It's an external condition that Emacs has no control over (it could be a
> temporary NFS problem, for example).  Just aborting does not give any
> clue what is wrong.

I meant: after a helpful, descriptive error message is printed, should
Emacs continue to run, or is this problem so severe that it should
refuse to start?

Message #29 received at 909-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 909-done <at> debbugs.gnu.org
Cc: Andreas Schwab <schwab <at> suse.de>, Dan Nicolaescu <dann <at> ics.uci.edu>
Subject: Re: bug#909: not finding etc/charsets/ should give some error/warning
Date: Thu, 11 Sep 2008 23:10:59 -0400

I've installed a (louder) warning. Someone can make it exit if they wish.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.