GNU bug report logs - #9087
Crash reading from minibuffer with icomplete-mode

Previous Next

Full log

Message #119 received at 9087 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: rudalics <at> gmx.at, claudio.bley <at> gmail.com, lekktu <at> gmail.com
Cc: 9087 <at> debbugs.gnu.org
Subject: Re: bug#9087: Crash reading from minibuffer with icomplete-mode
Date: Fri, 06 Jan 2012 22:50:30 +0200

> Date: Fri, 06 Jan 2012 21:53:17 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: claudio.bley <at> gmail.com, lekktu <at> gmail.com, 9087 <at> debbugs.gnu.org
> 
> > Date: Fri, 06 Jan 2012 20:45:03 +0100
> > From: martin rudalics <rudalics <at> gmx.at>
> > CC: lekktu <at> gmail.com, claudio.bley <at> gmail.com, 9087 <at> debbugs.gnu.org
> > 
> >  > If you meant this:
> >  >
> >  >   emacs -Q --eval "(setq debug-on-quit t)" -l triggerbug.el
> >  >
> >  > then it doesn't help.
> > 
> > I added
> > 
> > (setq debug-on-quit t)
> > 
> > to triggerbug.el, visit that file with emacs -Q, invoke
> > `emacs-lisp-byte-compile-and-load', and hit a key while I read "now!".
> 
> I see the reason why I couldn't reproduce this: it is only
> reproducible with a byte-compiled triggerbug.elc.  I initially tried
> with triggerbug.el.

I can avoid the crash with the patch below.  But it defers the
throwing until Emacs is done whatever it was doing (in this case,
evaluating byte code).  Is this acceptable?  If not, what can we do to
make the throwing more "immediate"?

Claudio, can you see if this patch gives good results with
ido-find-file?

And why in the world isn't throw-on-input described in the ELisp
manual???


=== modified file 'src/w32fns.c'
--- src/w32fns.c	2012-01-05 09:46:05 +0000
+++ src/w32fns.c	2012-01-06 20:33:25 +0000
@@ -2479,6 +2479,7 @@ signal_user_input (void)
   if (!NILP (Vthrow_on_input))
     {
       Vquit_flag = Vthrow_on_input;
+#if 0
       /* If we're inside a function that wants immediate quits,
 	 do it now.  */
       if (immediate_quit && NILP (Vinhibit_quit))
@@ -2486,6 +2487,7 @@ signal_user_input (void)
 	  immediate_quit = 0;
 	  QUIT;
 	}
+#endif
     }
 }
 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.