From unknown Mon Aug 18 14:15:43 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#9078 <9078@debbugs.gnu.org> To: bug#9078 <9078@debbugs.gnu.org> Subject: Status: coreutils8.12: stat.c uses statbuf->st_blksize uncondtionally Reply-To: bug#9078 <9078@debbugs.gnu.org> Date: Mon, 18 Aug 2025 21:15:43 +0000 retitle 9078 coreutils8.12: stat.c uses statbuf->st_blksize uncondtionally reassign 9078 coreutils submitter 9078 "Joachim Schmitz" severity 9078 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 14 03:16:53 2011 Received: (at submit) by debbugs.gnu.org; 14 Jul 2011 07:16:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhGAH-0000HP-M3 for submit@debbugs.gnu.org; Thu, 14 Jul 2011 03:16:53 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhGAG-0000HD-1Q for submit@debbugs.gnu.org; Thu, 14 Jul 2011 03:16:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QhGA8-00037p-9z for submit@debbugs.gnu.org; Thu, 14 Jul 2011 03:16:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:32837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhGA8-00037l-2G for submit@debbugs.gnu.org; Thu, 14 Jul 2011 03:16:44 -0400 Received: from eggs.gnu.org ([140.186.70.92]:46946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhGA6-0001OJ-3M for bug-coreutils@gnu.org; Thu, 14 Jul 2011 03:16:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QhGA4-00037E-Aa for bug-coreutils@gnu.org; Thu, 14 Jul 2011 03:16:41 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]:56840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhGA3-000376-OZ for bug-coreutils@gnu.org; Thu, 14 Jul 2011 03:16:40 -0400 Received: from DualCore (dsdf-4db52e8d.pool.mediaWays.net [77.181.46.141]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0LkSV9-1RDql31e3v-00bkd3; Thu, 14 Jul 2011 09:16:38 +0200 From: "Joachim Schmitz" To: Subject: coreutils8.12: stat.c uses statbuf->st_blksize uncondtionally Date: Thu, 14 Jul 2011 09:16:33 +0200 Message-ID: <003d01cc41f5$f66fb250$e34f16f0$@schmitz-digital.de> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_NextPart_000_003E_01CC4206.B9F88250" X-Mailer: Microsoft Outlook 14.0 Thread-Index: AcxB9GkWJeVTNjmaSOe02goHUzMaoQ== Content-Language: de X-Provags-ID: V02:K0:rB2wg1+PST1gme6OzHetQt3Hs8Wpb7Vq7LacYyhB0Hy TTWEygNR5IEW6Yqlg7QizErMc1JDDAfOEzVuOJGT8K4yt+TIL4 dLRGfMgBYOhxUiGxleh6uK3TkhDmCdDe3/FO3xnb4GoGwngvqk 6WZtlzvHC2r8O+oFoWND+yf6b1tmRy3xrnGveS1L2LFR4E6y1N 0HsVssNdvIU3wxLv4RQIuyeFi+aoNxWCPY2uuoqE10= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) This is a multipart message in MIME format. ------=_NextPart_000_003E_01CC4206.B9F88250 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi folks stat.c uses statbuf->st_blksize uncondtionally and on HP Nonstop struct stat doesn't have this (nor st_blocks). Shouldn't it be checking for HAVE_STAT_ST_BLOCKS? Bye, Jojo ------=_NextPart_000_003E_01CC4206.B9F88250 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi folks

 

stat.c uses statbuf->st_blksize uncondtionally and on HP = Nonstop struct stat doesn’t have this (nor = st_blocks).

Shouldn’t it be checking for = HAVE_STAT_ST_BLOCKS?

 

Bye, Jojo

------=_NextPart_000_003E_01CC4206.B9F88250-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 14 08:00:55 2011 Received: (at 9078) by debbugs.gnu.org; 14 Jul 2011 12:00:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhKb9-0007SP-2c for submit@debbugs.gnu.org; Thu, 14 Jul 2011 08:00:55 -0400 Received: from mail1.slb.deg.dub.stisp.net ([84.203.253.98]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1QhKb6-0007SB-AL for 9078@debbugs.gnu.org; Thu, 14 Jul 2011 08:00:53 -0400 Received: (qmail 99557 invoked from network); 14 Jul 2011 12:00:45 -0000 Received: from unknown (HELO ?192.168.2.25?) (84.203.137.218) by mail1.slb.deg.dub.stisp.net with SMTP; 14 Jul 2011 12:00:45 -0000 Message-ID: <4E1ED9FF.9020005@draigBrady.com> Date: Thu, 14 Jul 2011 12:58:55 +0100 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 To: Joachim Schmitz Subject: Re: bug#9078: coreutils8.12: stat.c uses statbuf->st_blksize uncondtionally References: <003d01cc41f5$f66fb250$e34f16f0$@schmitz-digital.de> In-Reply-To: <003d01cc41f5$f66fb250$e34f16f0$@schmitz-digital.de> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9078 Cc: 9078@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 14/07/11 08:16, Joachim Schmitz wrote: > Hi folks > > > > stat.c uses statbuf->st_blksize uncondtionally and on HP Nonstop struct stat > doesn't have this (nor st_blocks). > > Shouldn't it be checking for HAVE_STAT_ST_BLOCKS? We should probably be doing: diff --git a/src/stat.c b/src/stat.c index 0ad465e..fffa97f 100644 --- a/src/stat.c +++ b/src/stat.c @@ -951,7 +951,7 @@ print_stat (char *pformat, size_t prefix_len, unsigned int m, out_uint (pformat, prefix_len, ST_NBLOCKS (*statbuf)); break; case 'o': - out_uint (pformat, prefix_len, statbuf->st_blksize); + out_uint (pformat, prefix_len, ST_BLKSIZE(*statbuf)); break; case 'w': { ST_BLKSIZE is defined in: http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=blob;f=lib/stat-size.h;hb=HEAD cheers, Pádraig. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 14 08:48:17 2011 Received: (at 9078) by debbugs.gnu.org; 14 Jul 2011 12:48:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhLKz-00005A-65 for submit@debbugs.gnu.org; Thu, 14 Jul 2011 08:48:17 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhLKx-00004u-5Y for 9078@debbugs.gnu.org; Thu, 14 Jul 2011 08:48:16 -0400 Received: from DualCore (dsdf-4db52e8d.pool.mediaWays.net [77.181.46.141]) by mrelayeu.kundenserver.de (node=mrbap4) with ESMTP (Nemesis) id 0LwZNH-1RYkLf2pY7-018IFU; Thu, 14 Jul 2011 14:48:08 +0200 From: "Joachim Schmitz" To: =?iso-8859-1?Q?'P=E1draig_Brady'?= References: <003d01cc41f5$f66fb250$e34f16f0$@schmitz-digital.de> <4E1ED9FF.9020005@draigBrady.com> In-Reply-To: <4E1ED9FF.9020005@draigBrady.com> Subject: RE: bug#9078: coreutils8.12: stat.c uses statbuf->st_blksize uncondtionally Date: Thu, 14 Jul 2011 14:48:03 +0200 Message-ID: <000001cc4224$467d62a0$d37827e0$@schmitz-digital.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQIjz3lhgS7llAfHTNLD6hKNQ6G7yAGz+pDXlC8JqkA= Content-Language: de X-Provags-ID: V02:K0:AElIhQRYAv6gooJ50/y0CJztAZDFTl1cX/hLoc6PrZB xp6FfjI/PCxMcCcBD1KJ4gQBOcBZZJrZtnC0bh9GPeU5cxY07y JHLfw4qQ1fxSrav8CPydzTksJ192GWfz0DlmFWTIjAj6KO0+03 DITeoNOUdyqJBpXuTaktxDOHUiZvFPMsuMQjPnphRx8coa5MED Hpmd11AkrBbLcST+WQPULgfdMHpJCgtHrqydOWqy5g= X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 9078 Cc: 9078@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) Works for me, thanks! -----Original Message----- From: P=E1draig Brady [mailto:P@draigBrady.com]=20 Sent: Thursday, July 14, 2011 1:59 PM To: Joachim Schmitz Cc: 9078@debbugs.gnu.org Subject: Re: bug#9078: coreutils8.12: stat.c uses statbuf->st_blksize uncondtionally On 14/07/11 08:16, Joachim Schmitz wrote: > Hi folks >=20 > =20 >=20 > stat.c uses statbuf->st_blksize uncondtionally and on HP Nonstop=20 > struct stat doesn't have this (nor st_blocks). >=20 > Shouldn't it be checking for HAVE_STAT_ST_BLOCKS? We should probably be doing: diff --git a/src/stat.c b/src/stat.c index 0ad465e..fffa97f 100644 --- a/src/stat.c +++ b/src/stat.c @@ -951,7 +951,7 @@ print_stat (char *pformat, size_t prefix_len, = unsigned int m, out_uint (pformat, prefix_len, ST_NBLOCKS (*statbuf)); break; case 'o': - out_uint (pformat, prefix_len, statbuf->st_blksize); + out_uint (pformat, prefix_len, ST_BLKSIZE(*statbuf)); break; case 'w': { ST_BLKSIZE is defined in: http://git.sv.gnu.org/gitweb/?p=3Dgnulib.git;a=3Dblob;f=3Dlib/stat-size.h= ;hb=3DHEAD cheers, P=E1draig. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 11:26:37 2011 Received: (at 9078-done) by debbugs.gnu.org; 15 Jul 2011 15:26:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhkHg-0005Ay-MC for submit@debbugs.gnu.org; Fri, 15 Jul 2011 11:26:37 -0400 Received: from mail1.slb.deg.dub.stisp.net ([84.203.253.98]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1QhkHQ-0005AZ-QB for 9078-done@debbugs.gnu.org; Fri, 15 Jul 2011 11:26:19 -0400 Received: (qmail 57641 invoked from network); 15 Jul 2011 15:25:08 -0000 Received: from unknown (HELO ?192.168.2.25?) (84.203.137.218) by mail1.slb.deg.dub.stisp.net with SMTP; 15 Jul 2011 15:25:08 -0000 Message-ID: <4E205B61.60309@draigBrady.com> Date: Fri, 15 Jul 2011 16:23:13 +0100 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 To: Joachim Schmitz Subject: Re: bug#9078: coreutils8.12: stat.c uses statbuf->st_blksize uncondtionally References: <003d01cc41f5$f66fb250$e34f16f0$@schmitz-digital.de> <4E1ED9FF.9020005@draigBrady.com> <000001cc4224$467d62a0$d37827e0$@schmitz-digital.de> In-Reply-To: <000001cc4224$467d62a0$d37827e0$@schmitz-digital.de> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9078-done Cc: 9078-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 14/07/11 13:48, Joachim Schmitz wrote: > Works for me, thanks! pushed. thanks again, Pádraig. From unknown Mon Aug 18 14:15:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 13 Aug 2011 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator