GNU bug report logs - #9077
coreutils-8.12: fiemap.h uses "struct fiemap_extent fm_extents[0];"

Previous Next

Full log

Message #14 received at 9077 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Joachim Schmitz <jojo <at> schmitz-digital.de>, 9077 <at> debbugs.gnu.org
Subject: Re: bug#9077: coreutils-8.12: fiemap.h uses "struct fiemap_extent
	fm_extents[0]; "
Date: Fri, 15 Jul 2011 02:11:08 +0100

On 14/07/11 23:50, Paul Eggert wrote:
> On 07/14/11 04:45, Pádraig Brady wrote:
>> The non standard "zero length array" syntax was copied from
>> the linux kernel headers. Changing this to a C99 flexible array
>> as you suggest, should be fine according to the constraints listed here:
> 
> Won't this break non-GCC compilers that don't support
> C99 flexible arrays?

Yes. But we require C99, and it would be
interesting to see what features we could rely
on going forward.

I had checked with solaris compilers which support
this since 2004 at least.

Though saying that, the single element hack
isn't too bad and might allow some other platform to build
without issue.

> Instead, how about this patch?  If I understand things correctly,
> it should fix the problem on NonStop, and should also work with
> pre-C99 non-GCC compilers.

feel free to push that

cheers,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.