From unknown Tue Jun 17 01:48:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9064: coreutils-8.12 compiler warning Resent-From: "Joachim Schmitz" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 13 Jul 2011 07:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 9064 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 9064@debbugs.gnu.org X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.131054377527566 (code B ref -1); Wed, 13 Jul 2011 07:57:01 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jul 2011 07:56:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QguIp-0007AZ-As for submit@debbugs.gnu.org; Wed, 13 Jul 2011 03:56:15 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QguIm-0007AN-Qn for submit@debbugs.gnu.org; Wed, 13 Jul 2011 03:56:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QguId-0003X7-B0 for submit@debbugs.gnu.org; Wed, 13 Jul 2011 03:56:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:57839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QguIc-0003Wx-VJ for submit@debbugs.gnu.org; Wed, 13 Jul 2011 03:56:03 -0400 Received: from eggs.gnu.org ([140.186.70.92]:35866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QguIa-0003DP-Ei for bug-coreutils@gnu.org; Wed, 13 Jul 2011 03:56:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QguIY-0003Vb-Sc for bug-coreutils@gnu.org; Wed, 13 Jul 2011 03:56:00 -0400 Received: from moutng.kundenserver.de ([212.227.17.8]:57592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QguIY-0003V7-1r for bug-coreutils@gnu.org; Wed, 13 Jul 2011 03:55:58 -0400 Received: from DualCore (dsdf-4db5173c.pool.mediaWays.net [77.181.23.60]) by mrelayeu.kundenserver.de (node=mrbap3) with ESMTP (Nemesis) id 0MfIB0-1QsOVX3Z7q-00OkTi; Wed, 13 Jul 2011 09:55:54 +0200 From: "Joachim Schmitz" Date: Wed, 13 Jul 2011 09:55:51 +0200 Message-ID: <000d01cc4132$49cc7c90$dd6575b0$@schmitz-digital.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AcxBMhGJ6XSbS3N3T7Sqz9wBTfXmOA== Content-Language: de X-Provags-ID: V02:K0:MimT7U8zmW4l1jFZLfP2E+DeURq6mr1xHgduUZ3Lpef 2byi8fUpLRKvzI0itAyDcnBo35msJEsPTfmKckKWY2/y91wjSy 1zCOAy2vzFRwMaXnT1bF/3Ad2uZg19gUp4oSmR/J5fV9QdpGIm 8GGrog28BItoSXenR6562dtP+THtFjwL4eQMgLjkbYzJG97aF9 kveDMdDme8dT7C2pKLpozdehyheDdWs/leD3qrWiSQ= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) I found this in mktemp.c, line344 (well, my compiler found it for me and warned about 'possible use of "=" where "==" was intended'): if (!dry_run && (stdout_closed = true) && close_stream (stdout) != 0) Not sure whether this is bug or feature ;-) Bye, Jojo From unknown Tue Jun 17 01:48:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9064: coreutils-8.12 compiler warning Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 13 Jul 2011 09:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9064 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Joachim Schmitz Cc: 9064@debbugs.gnu.org Received: via spool by 9064-submit@debbugs.gnu.org id=B9064.13105480301481 (code B ref 9064); Wed, 13 Jul 2011 09:08:02 +0000 Received: (at 9064) by debbugs.gnu.org; 13 Jul 2011 09:07:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgvPR-0000Np-EI for submit@debbugs.gnu.org; Wed, 13 Jul 2011 05:07:09 -0400 Received: from mail1.slb.deg.dub.stisp.net ([84.203.253.98]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1QgvPP-0000NN-1L for 9064@debbugs.gnu.org; Wed, 13 Jul 2011 05:07:07 -0400 Received: (qmail 61149 invoked from network); 13 Jul 2011 09:07:00 -0000 Received: from unknown (HELO ?192.168.2.25?) (84.203.137.218) by mail1.slb.deg.dub.stisp.net with SMTP; 13 Jul 2011 09:07:00 -0000 Message-ID: <4E1D5FCB.3080904@draigBrady.com> Date: Wed, 13 Jul 2011 10:05:15 +0100 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 References: <000d01cc4132$49cc7c90$dd6575b0$@schmitz-digital.de> In-Reply-To: <000d01cc4132$49cc7c90$dd6575b0$@schmitz-digital.de> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 13/07/11 08:55, Joachim Schmitz wrote: > I found this in mktemp.c, line344 (well, my compiler found it for me and > warned about 'possible use of "=" where "==" was intended'): > > if (!dry_run && (stdout_closed = true) && close_stream (stdout) != 0) > > Not sure whether this is bug or feature ;-) Well it's a feature. We could reorganize but it would add a few more lines. What compiler (option) is this? Is the warning avoided by using double brackets like ((stdout_closed = true)) cheers, Pádraig. From unknown Tue Jun 17 01:48:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9064: coreutils-8.12 compiler warning Resent-From: "Joachim Schmitz" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 13 Jul 2011 09:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9064 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?'P=C3=A1draig?= Brady' Cc: 9064@debbugs.gnu.org Received: via spool by 9064-submit@debbugs.gnu.org id=B9064.13105483961992 (code B ref 9064); Wed, 13 Jul 2011 09:14:01 +0000 Received: (at 9064) by debbugs.gnu.org; 13 Jul 2011 09:13:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgvVL-0000W5-OG for submit@debbugs.gnu.org; Wed, 13 Jul 2011 05:13:15 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgvVI-0000Vr-Tj for 9064@debbugs.gnu.org; Wed, 13 Jul 2011 05:13:13 -0400 Received: from DualCore (dsdf-4db5173c.pool.mediaWays.net [77.181.23.60]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0MgHB8-1QtWyc2J4Y-00NGD7; Wed, 13 Jul 2011 11:13:04 +0200 From: "Joachim Schmitz" References: <000d01cc4132$49cc7c90$dd6575b0$@schmitz-digital.de> <4E1D5FCB.3080904@draigBrady.com> In-Reply-To: <4E1D5FCB.3080904@draigBrady.com> Date: Wed, 13 Jul 2011 11:13:02 +0200 Message-ID: <000e01cc413d$11c5fbe0$3551f3a0$@schmitz-digital.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQJZadlsqV/0HAnR8qAQBsVub9WkTgJvQ6SCk7wrteA= Content-Language: de X-Provags-ID: V02:K0:V9adUNAwOPqTcUyi2nOQsSZ/LlLx3ACaZg5Z13i1i9E eVlMacBKYbkXJTHw2Ng7e6Zwx5WTHNg5+/0Fj107dFDgeR9BF9 w3Ji5jIE3QNEqTJXThd5uYM9JtEJx0UfnuiTUZGYlSlYV7NEzR P2aEE4bLNvx8cwoAr1sJKJfqldavGgKJuhaqwhBlKUR9ilag3N zNynq66TLJvChFTB94EjDptw8aYZT/vPeYPt1zBfsM= X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) Double backet does not fix this warning. It is the HP NonStop c89 and = c99 compiler without having disabled warnings (all warnings are on by = default) If it isn't a bug, forget about it, or maybe add a comment next to that = line about this. -----Original Message----- From: P=E1draig Brady [mailto:P@draigBrady.com]=20 Sent: Wednesday, July 13, 2011 11:05 AM To: Joachim Schmitz Cc: 9064@debbugs.gnu.org Subject: Re: bug#9064: coreutils-8.12 compiler warning On 13/07/11 08:55, Joachim Schmitz wrote: > I found this in mktemp.c, line344 (well, my compiler found it for me=20 > and warned about 'possible use of "=3D" where "=3D=3D" was intended'): >=20 > if (!dry_run && (stdout_closed =3D true) && close_stream = (stdout)=20 > !=3D 0) >=20 > Not sure whether this is bug or feature ;-) Well it's a feature. We could reorganize but it would add a few more lines. What compiler (option) is this? Is the warning avoided by using double brackets like ((stdout_closed =3D true)) cheers, P=E1draig. From unknown Tue Jun 17 01:48:31 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "Joachim Schmitz" Subject: bug#9064: closed (Re: bug#9064: coreutils-8.12 compiler warning) Message-ID: References: <4E1D663C.4040206@draigBrady.com> <000d01cc4132$49cc7c90$dd6575b0$@schmitz-digital.de> X-Gnu-PR-Message: they-closed 9064 X-Gnu-PR-Package: coreutils Reply-To: 9064@debbugs.gnu.org Date: Wed, 13 Jul 2011 09:35:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1310549702-3863-1" This is a multi-part message in MIME format... ------------=_1310549702-3863-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #9064: coreutils-8.12 compiler warning which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 9064@debbugs.gnu.org. --=20 9064: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D9064 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1310549702-3863-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 9064-done) by debbugs.gnu.org; 13 Jul 2011 09:34:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgvq1-0000zi-1l for submit@debbugs.gnu.org; Wed, 13 Jul 2011 05:34:37 -0400 Received: from mail1.slb.deg.dub.stisp.net ([84.203.253.98]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1Qgvpz-0000zV-1R for 9064-done@debbugs.gnu.org; Wed, 13 Jul 2011 05:34:35 -0400 Received: (qmail 66161 invoked from network); 13 Jul 2011 09:34:28 -0000 Received: from unknown (HELO ?192.168.2.25?) (84.203.137.218) by mail1.slb.deg.dub.stisp.net with SMTP; 13 Jul 2011 09:34:28 -0000 Message-ID: <4E1D663C.4040206@draigBrady.com> Date: Wed, 13 Jul 2011 10:32:44 +0100 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 To: Joachim Schmitz Subject: Re: bug#9064: coreutils-8.12 compiler warning References: <000d01cc4132$49cc7c90$dd6575b0$@schmitz-digital.de> <4E1D5FCB.3080904@draigBrady.com> <000e01cc413d$11c5fbe0$3551f3a0$@schmitz-digital.de> In-Reply-To: <000e01cc413d$11c5fbe0$3551f3a0$@schmitz-digital.de> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9064-done Cc: 9064-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 13/07/11 10:13, Joachim Schmitz wrote: > Double backet does not fix this warning. It is the HP NonStop c89 and c99 > compiler without having disabled warnings (all warnings are on by default) > If it isn't a bug, forget about it, or maybe add a comment next to that line > about this. > > -----Original Message----- > From: Pádraig Brady [mailto:P@draigBrady.com] > Sent: Wednesday, July 13, 2011 11:05 AM > To: Joachim Schmitz > Cc: 9064@debbugs.gnu.org > Subject: Re: bug#9064: coreutils-8.12 compiler warning > > On 13/07/11 08:55, Joachim Schmitz wrote: >> I found this in mktemp.c, line344 (well, my compiler found it for me >> and warned about 'possible use of "=" where "==" was intended'): >> >> if (!dry_run && (stdout_closed = true) && close_stream (stdout) >> != 0) >> >> Not sure whether this is bug or feature ;-) > > Well it's a feature. > We could reorganize but it would add a few more lines. > What compiler (option) is this? > Is the warning avoided by using double brackets like ((stdout_closed = > true)) I also notice SGI's compiler has similar issues http://archive.apache.org/gnats/2528 closing this. cheers, Pádraig. ------------=_1310549702-3863-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Jul 2011 07:56:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QguIp-0007AZ-As for submit@debbugs.gnu.org; Wed, 13 Jul 2011 03:56:15 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QguIm-0007AN-Qn for submit@debbugs.gnu.org; Wed, 13 Jul 2011 03:56:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QguId-0003X7-B0 for submit@debbugs.gnu.org; Wed, 13 Jul 2011 03:56:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:57839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QguIc-0003Wx-VJ for submit@debbugs.gnu.org; Wed, 13 Jul 2011 03:56:03 -0400 Received: from eggs.gnu.org ([140.186.70.92]:35866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QguIa-0003DP-Ei for bug-coreutils@gnu.org; Wed, 13 Jul 2011 03:56:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QguIY-0003Vb-Sc for bug-coreutils@gnu.org; Wed, 13 Jul 2011 03:56:00 -0400 Received: from moutng.kundenserver.de ([212.227.17.8]:57592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QguIY-0003V7-1r for bug-coreutils@gnu.org; Wed, 13 Jul 2011 03:55:58 -0400 Received: from DualCore (dsdf-4db5173c.pool.mediaWays.net [77.181.23.60]) by mrelayeu.kundenserver.de (node=mrbap3) with ESMTP (Nemesis) id 0MfIB0-1QsOVX3Z7q-00OkTi; Wed, 13 Jul 2011 09:55:54 +0200 From: "Joachim Schmitz" To: Subject: RE: coreutils-8.12 compiler warning Date: Wed, 13 Jul 2011 09:55:51 +0200 Message-ID: <000d01cc4132$49cc7c90$dd6575b0$@schmitz-digital.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AcxBMhGJ6XSbS3N3T7Sqz9wBTfXmOA== Content-Language: de X-Provags-ID: V02:K0:MimT7U8zmW4l1jFZLfP2E+DeURq6mr1xHgduUZ3Lpef 2byi8fUpLRKvzI0itAyDcnBo35msJEsPTfmKckKWY2/y91wjSy 1zCOAy2vzFRwMaXnT1bF/3Ad2uZg19gUp4oSmR/J5fV9QdpGIm 8GGrog28BItoSXenR6562dtP+THtFjwL4eQMgLjkbYzJG97aF9 kveDMdDme8dT7C2pKLpozdehyheDdWs/leD3qrWiSQ= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) I found this in mktemp.c, line344 (well, my compiler found it for me and warned about 'possible use of "=" where "==" was intended'): if (!dry_run && (stdout_closed = true) && close_stream (stdout) != 0) Not sure whether this is bug or feature ;-) Bye, Jojo ------------=_1310549702-3863-1-- From unknown Tue Jun 17 01:48:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9064: coreutils-8.12 compiler warning Resent-From: Eric Blake Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 13 Jul 2011 13:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9064 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: Joachim Schmitz , 9064@debbugs.gnu.org Received: via spool by 9064-submit@debbugs.gnu.org id=B9064.131056269925883 (code B ref 9064); Wed, 13 Jul 2011 13:12:02 +0000 Received: (at 9064) by debbugs.gnu.org; 13 Jul 2011 13:11:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgzDz-0006jL-68 for submit@debbugs.gnu.org; Wed, 13 Jul 2011 09:11:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgzDt-0006it-A2 for 9064@debbugs.gnu.org; Wed, 13 Jul 2011 09:11:33 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6DDBNNg005757 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Jul 2011 09:11:23 -0400 Received: from [10.3.113.149] (ovpn-113-149.phx2.redhat.com [10.3.113.149]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p6DDBM93024600; Wed, 13 Jul 2011 09:11:23 -0400 Message-ID: <4E1D997A.5090702@redhat.com> Date: Wed, 13 Jul 2011 07:11:22 -0600 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.11 MIME-Version: 1.0 References: <000d01cc4132$49cc7c90$dd6575b0$@schmitz-digital.de> <4E1D5FCB.3080904@draigBrady.com> In-Reply-To: <4E1D5FCB.3080904@draigBrady.com> X-Enigmail-Version: 1.1.2 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigCE8CCC5F3D33BAF92845253A" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Spam-Score: -10.3 (----------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -10.3 (----------) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigCE8CCC5F3D33BAF92845253A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 07/13/2011 03:05 AM, P=E1draig Brady wrote: > On 13/07/11 08:55, Joachim Schmitz wrote: >> I found this in mktemp.c, line344 (well, my compiler found it for me a= nd >> warned about 'possible use of "=3D" where "=3D=3D" was intended'): >> >> if (!dry_run && (stdout_closed =3D true) && close_stream (stdout= ) !=3D 0) >> >> Not sure whether this is bug or feature ;-) >=20 > Well it's a feature. > We could reorganize but it would add a few more lines. Does this avoid the warning? if (!dry_run && ((stdout_closed =3D true), close_stream (stdout) !=3D 0))= That is, using the comma operator rather than an always-true conditional since we always want the assignment to occur at that part of the expressi= on? --=20 Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org --------------enigCE8CCC5F3D33BAF92845253A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJOHZl6AAoJEKeha0olJ0Nq/IcIAIRcVQDItOvZJweCXKnEIqUJ pIT9MfrJr8JCJdBr2rbNh2qJvCj2pW0ZJu4C9h3Sisx8ab8yDaYxgXhqEOA02pzJ nyFGPSqV5IxUOjXVTem8+N82PaEW+vKdc0MXIYlcbR5WGm+ORonqITSvZi8Ap9IV mIpDWem/fhqbpis/Ie/qWvX+Bl84ugv5ZWoRE8UQwb8ZQIjGTDuI0+E25lkRY/Sr ti+dyllZQO/3aYpKPh/o8kJEveD+C7XtleHY9soJxhn61E5ZmEXPRtq5cF6A6Vev phDprMNPabus45nA1HTAFIvj2S60LWVvhMPXKDQPsGJ2yrEofjJsxTNJCM+jXeE= =qfNz -----END PGP SIGNATURE----- --------------enigCE8CCC5F3D33BAF92845253A-- From unknown Tue Jun 17 01:48:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9064: coreutils-8.12 compiler warning Resent-From: "Joachim Schmitz" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 13 Jul 2011 13:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9064 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: "'Eric Blake'" , =?UTF-8?Q?'P=C3=A1draig?= Brady' Cc: 9064@debbugs.gnu.org Received: via spool by 9064-submit@debbugs.gnu.org id=B9064.13105649023232 (code B ref 9064); Wed, 13 Jul 2011 13:49:02 +0000 Received: (at 9064) by debbugs.gnu.org; 13 Jul 2011 13:48:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgznU-0000pw-Qt for submit@debbugs.gnu.org; Wed, 13 Jul 2011 09:48:20 -0400 Received: from moutng.kundenserver.de ([212.227.17.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgznP-0000pf-8d for 9064@debbugs.gnu.org; Wed, 13 Jul 2011 09:48:15 -0400 Received: from DualCore (dsdf-4db5173c.pool.mediaWays.net [77.181.23.60]) by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis) id 0MCwZH-1Qq2DY0YRH-009FYS; Wed, 13 Jul 2011 15:48:03 +0200 From: "Joachim Schmitz" References: <000d01cc4132$49cc7c90$dd6575b0$@schmitz-digital.de> <4E1D5FCB.3080904@draigBrady.com> <4E1D997A.5090702@redhat.com> In-Reply-To: <4E1D997A.5090702@redhat.com> Date: Wed, 13 Jul 2011 15:48:00 +0200 Message-ID: <001d01cc4163$7b43a420$71caec60$@schmitz-digital.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQJZadlsqV/0HAnR8qAQBsVub9WkTgJvQ6SCApv1U6WTp5lTYA== Content-Language: de X-Provags-ID: V02:K0:hF52Bk3sFdP8N95QVQGDtzl5URRZH9xy2EUz+P/tiEk d/AcC68zTjtXCm8dHTd5ci1Qee2XSWEvNflaD7HPLidFurnoZd Gb/AWIHHNaGnB9FhmsW/qQH+Q6iSA6EfsmW9dw2uMRoThDxNxD 1GKqc4kb9J/wauw3bxYGrmN0Va8nYmTMSQgbAX+CrP5Z5WdSqD NGNbDUspzL5XKa6lttF7XDDMQvmw+Y0cOEzyPpl4oE= X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.2 (---) That does indeed silence my compiler and is showing the intention pretty clear -----Original Message----- From: Eric Blake [mailto:eblake@redhat.com]=20 Sent: Wednesday, July 13, 2011 3:11 PM To: P=E1draig Brady Cc: Joachim Schmitz; 9064@debbugs.gnu.org Subject: Re: bug#9064: coreutils-8.12 compiler warning On 07/13/2011 03:05 AM, P=E1draig Brady wrote: > On 13/07/11 08:55, Joachim Schmitz wrote: >> I found this in mktemp.c, line344 (well, my compiler found it for me=20 >> and warned about 'possible use of "=3D" where "=3D=3D" was = intended'): >> >> if (!dry_run && (stdout_closed =3D true) && close_stream = (stdout)=20 >> !=3D 0) >> >> Not sure whether this is bug or feature ;-) >=20 > Well it's a feature. > We could reorganize but it would add a few more lines. Does this avoid the warning? if (!dry_run && ((stdout_closed =3D true), close_stream (stdout) !=3D = 0)) That is, using the comma operator rather than an always-true conditional since we always want the assignment to occur at that part of the = expression? --=20 Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org From unknown Tue Jun 17 01:48:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9064: coreutils-8.12 compiler warning Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 13 Jul 2011 14:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9064 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Eric Blake Cc: Joachim Schmitz , 9064@debbugs.gnu.org Received: via spool by 9064-submit@debbugs.gnu.org id=B9064.131056683313683 (code B ref 9064); Wed, 13 Jul 2011 14:21:01 +0000 Received: (at 9064) by debbugs.gnu.org; 13 Jul 2011 14:20:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh0Ij-0003Ye-FM for submit@debbugs.gnu.org; Wed, 13 Jul 2011 10:20:33 -0400 Received: from mail1.slb.deg.dub.stisp.net ([84.203.253.98]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1Qh0Ih-0003YR-Ke for 9064@debbugs.gnu.org; Wed, 13 Jul 2011 10:20:32 -0400 Received: (qmail 20817 invoked from network); 13 Jul 2011 14:20:25 -0000 Received: from unknown (HELO ?192.168.2.25?) (84.203.137.218) by mail1.slb.deg.dub.stisp.net with SMTP; 13 Jul 2011 14:20:25 -0000 Message-ID: <4E1DA940.9070700@draigBrady.com> Date: Wed, 13 Jul 2011 15:18:40 +0100 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 References: <000d01cc4132$49cc7c90$dd6575b0$@schmitz-digital.de> <4E1D5FCB.3080904@draigBrady.com> <4E1D997A.5090702@redhat.com> In-Reply-To: <4E1D997A.5090702@redhat.com> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 13/07/11 14:11, Eric Blake wrote: > On 07/13/2011 03:05 AM, Pádraig Brady wrote: >> On 13/07/11 08:55, Joachim Schmitz wrote: >>> I found this in mktemp.c, line344 (well, my compiler found it for me and >>> warned about 'possible use of "=" where "==" was intended'): >>> >>> if (!dry_run && (stdout_closed = true) && close_stream (stdout) != 0) >>> >>> Not sure whether this is bug or feature ;-) >> >> Well it's a feature. >> We could reorganize but it would add a few more lines. > > Does this avoid the warning? > > if (!dry_run && ((stdout_closed = true), close_stream (stdout) != 0)) > > That is, using the comma operator rather than an always-true conditional > since we always want the assignment to occur at that part of the expression? +1 for this version From unknown Tue Jun 17 01:48:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9064: [PATCH] coreutils-8.12 compiler warning Resent-From: "Voelker, Bernhard" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 14 Jul 2011 07:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9064 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady , Eric Blake Cc: Joachim Schmitz , "9064@debbugs.gnu.org" <9064@debbugs.gnu.org> Received: via spool by 9064-submit@debbugs.gnu.org id=B9064.13106291192911 (code B ref 9064); Thu, 14 Jul 2011 07:39:01 +0000 Received: (at 9064) by debbugs.gnu.org; 14 Jul 2011 07:38:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhGVH-0000kq-1m for submit@debbugs.gnu.org; Thu, 14 Jul 2011 03:38:38 -0400 Received: from mail27.messagelabs.com ([193.109.254.147]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1QhGVA-0000kY-Qw for 9064@debbugs.gnu.org; Thu, 14 Jul 2011 03:38:33 -0400 X-VirusChecked: Checked X-Env-Sender: bernhard.voelker@siemens-enterprise.com X-Msg-Ref: server-4.tower-27.messagelabs.com!1310629092!35290109!1 X-StarScan-Version: 6.2.17; banners=-,-,- X-Originating-IP: [62.134.46.9] Received: (qmail 25188 invoked from network); 14 Jul 2011 07:38:12 -0000 Received: from unknown (HELO senmx11-mx) (62.134.46.9) by server-4.tower-27.messagelabs.com with SMTP; 14 Jul 2011 07:38:12 -0000 Received: from MCHP064A.global-ad.net (unknown [172.29.37.63]) by senmx11-mx (Server) with ESMTP id 5CB641EB83ED; Thu, 14 Jul 2011 09:38:22 +0200 (CEST) Received: from MCHP058A.global-ad.net ([172.29.37.57]) by MCHP064A.global-ad.net ([172.29.37.63]) with mapi; Thu, 14 Jul 2011 09:38:22 +0200 From: "Voelker, Bernhard" Date: Thu, 14 Jul 2011 09:38:21 +0200 Thread-Topic: bug#9064: [PATCH] coreutils-8.12 compiler warning Thread-Index: AcxBaJx4Klc779q7RTe0hx5m6yb+VQAj308Q Message-ID: <7856072A9D04C24B82DFE2B1112FE38A08FE214E33@MCHP058A.global-ad.net> References: <000d01cc4132$49cc7c90$dd6575b0$@schmitz-digital.de> <4E1D5FCB.3080904@draigBrady.com> <4E1D997A.5090702@redhat.com> <4E1DA940.9070700@draigBrady.com> In-Reply-To: <4E1DA940.9070700@draigBrady.com> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: de-DE, en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Spam-Score: -5.4 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.4 (-----) P=E1draig Brady wrote: >On 13/07/11 14:11, Eric Blake wrote: >> On 07/13/2011 03:05 AM, P=E1draig Brady wrote: >>> On 13/07/11 08:55, Joachim Schmitz wrote: >>>> I found this in mktemp.c, line344 (well, my compiler found it for me a= nd >>>> warned about 'possible use of "=3D" where "=3D=3D" was intended'): >>>> >>>> if (!dry_run && (stdout_closed =3D true) && close_stream (stdout= ) !=3D 0) >>>> >>>> Not sure whether this is bug or feature ;-) >>> >>> Well it's a feature. >>> We could reorganize but it would add a few more lines. >>=20 >> Does this avoid the warning? >>=20 >> if (!dry_run && ((stdout_closed =3D true), close_stream (stdout) !=3D 0)= ) >>=20 >> That is, using the comma operator rather than an always-true conditional >> since we always want the assignment to occur at that part of the express= ion? > > +1 for this version As Joachim wrote (off-ML) that his compiler didn't complain about the other, similar place in src/stat.c, the following patch doesn't touch that one (as my first patch did: http://debbugs.gnu.org/9064#19). >From 2fc0d6282d304a76241eb66f0f0627fb189e3ec9 Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Thu, 14 Jul 2011 09:19:55 +0200 Subject: [PATCH] maint: fix warning 'possible use of "=3D" where "=3D=3D" w= as intended' * src/mktemp.c: maint: avoid warning by using the comma operator rather than an always-true conditional (as suggested by Eric Blake). Reported by Joachim Schmitz in http://debbugs.gnu.org/9064. --- src/mktemp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mktemp.c b/src/mktemp.c index 2fe22b7..e592176 100644 --- a/src/mktemp.c +++ b/src/mktemp.c @@ -344,7 +344,7 @@ main (int argc, char **argv) puts (dest_name); /* If we created a file, but then failed to output the file name, we should clean up the mess before failing. */ - if (!dry_run && (stdout_closed =3D true) && close_stream (stdout) != =3D 0) + if (!dry_run && ((stdout_closed =3D true), close_stream (stdout) != =3D 0)) { int saved_errno =3D errno; remove (dest_name); --=20 1.7.5.1 Have a nice day, Berny= From unknown Tue Jun 17 01:48:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9064: [PATCH] coreutils-8.12 compiler warning Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 14 Jul 2011 11:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9064 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: "Voelker, Bernhard" Cc: Joachim Schmitz , Eric Blake , "9064@debbugs.gnu.org" <9064@debbugs.gnu.org> Received: via spool by 9064-submit@debbugs.gnu.org id=B9064.131064129920273 (code B ref 9064); Thu, 14 Jul 2011 11:02:02 +0000 Received: (at 9064) by debbugs.gnu.org; 14 Jul 2011 11:01:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhJfm-0005Gw-Ps for submit@debbugs.gnu.org; Thu, 14 Jul 2011 07:01:39 -0400 Received: from mail1.slb.deg.dub.stisp.net ([84.203.253.98]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1QhJfj-0005Gj-Ew for 9064@debbugs.gnu.org; Thu, 14 Jul 2011 07:01:36 -0400 Received: (qmail 88492 invoked from network); 14 Jul 2011 11:01:28 -0000 Received: from unknown (HELO ?192.168.2.25?) (84.203.137.218) by mail1.slb.deg.dub.stisp.net with SMTP; 14 Jul 2011 11:01:28 -0000 Message-ID: <4E1ECC1B.6020102@draigBrady.com> Date: Thu, 14 Jul 2011 11:59:39 +0100 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 References: <000d01cc4132$49cc7c90$dd6575b0$@schmitz-digital.de> <4E1D5FCB.3080904@draigBrady.com> <4E1D997A.5090702@redhat.com> <4E1DA940.9070700@draigBrady.com> <7856072A9D04C24B82DFE2B1112FE38A08FE214E33@MCHP058A.global-ad.net> In-Reply-To: <7856072A9D04C24B82DFE2B1112FE38A08FE214E33@MCHP058A.global-ad.net> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 14/07/11 08:38, Voelker, Bernhard wrote: > * src/mktemp.c: maint: avoid warning by using the comma operator > rather than an always-true conditional (as suggested by Eric Blake). > Reported by Joachim Schmitz in http://debbugs.gnu.org/9064. pushed. cheers, Pádraig.