From unknown Sat Aug 16 20:56:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#9031 <9031@debbugs.gnu.org> To: bug#9031 <9031@debbugs.gnu.org> Subject: Status: Unused vars etc. in chartab.c, composite.c, gtkutil.c Reply-To: bug#9031 <9031@debbugs.gnu.org> Date: Sun, 17 Aug 2025 03:56:40 +0000 retitle 9031 Unused vars etc. in chartab.c, composite.c, gtkutil.c reassign 9031 emacs submitter 9031 Paul Eggert severity 9031 minor tag 9031 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 09 02:36:49 2011 Received: (at submit) by debbugs.gnu.org; 9 Jul 2011 06:36:50 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QfR9l-0005wW-2K for submit@debbugs.gnu.org; Sat, 09 Jul 2011 02:36:49 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QfR9h-0005wJ-UK for submit@debbugs.gnu.org; Sat, 09 Jul 2011 02:36:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QfR9a-0005oV-A2 for submit@debbugs.gnu.org; Sat, 09 Jul 2011 02:36:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:43226) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QfR9Z-0005o9-VP for submit@debbugs.gnu.org; Sat, 09 Jul 2011 02:36:38 -0400 Received: from eggs.gnu.org ([140.186.70.92]:43758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QfR9Y-0007m1-3T for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2011 02:36:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QfR9V-0005nQ-L2 for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2011 02:36:36 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:59385) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QfR5X-0005V6-Cu for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2011 02:32:29 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 55F8639E8116 for ; Fri, 8 Jul 2011 23:32:26 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zYeY2a32td6q for ; Fri, 8 Jul 2011 23:32:25 -0700 (PDT) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 7273C39E80F2 for ; Fri, 8 Jul 2011 23:32:25 -0700 (PDT) Message-ID: <4E17F5F8.7060200@cs.ucla.edu> Date: Fri, 08 Jul 2011 23:32:24 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110516 Thunderbird/3.1.10 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: Unused vars etc. in chartab.c, composite.c, gtkutil.c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) This patch fixes some minor problems on the Emacs trunk. Normally I'd just install this, but we're in a feature freeze now and this patch doesn't fix any actual bugs, so I'm filing a bug report instead, to record the issues. # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: eggert@cs.ucla.edu-20110709062840-jdrk1zrclfflltae # target_branch: bzr+ssh://eggert@bzr.savannah.gnu.org/emacs/trunk # testament_sha1: 935c16305b271d2f38af33043c16de6e23c306ca # timestamp: 2011-07-08 23:28:47 -0700 # base_revision_id: sdl.web@gmail.com-20110709031157-d7vix3jz1gpb29bw # # Begin patch === modified file 'src/ChangeLog' --- src/ChangeLog 2011-07-08 20:39:30 +0000 +++ src/ChangeLog 2011-07-09 06:28:40 +0000 @@ -1,5 +1,12 @@ 2011-07-08 Paul Eggert + Fix minor problems found by static checking. + * chartab.c (char_table_set_range, map_sub_char_table) + (uniprop_table_uncompress): Remove unused locals. + (uniprop_table): Now static. + * composite.c (_work_char): Remove unused static var. + * gtkutil.c (qttip_cb): Remove stray no-effect statement. + Use pthread_sigmask, not sigprocmask (Bug#9010). sigprocmask is portable only for single-threaded applications, and Emacs can be multi-threaded when it uses GTK. === modified file 'src/chartab.c' --- src/chartab.c 2011-07-07 04:16:52 +0000 +++ src/chartab.c 2011-07-09 06:28:40 +0000 @@ -485,7 +485,6 @@ char_table_set_range (Lisp_Object table, int from, int to, Lisp_Object val) { struct Lisp_Char_Table *tbl = XCHAR_TABLE (table); - Lisp_Object *contents = tbl->contents; if (from == to) char_table_set (table, from, val); @@ -759,8 +758,6 @@ Lisp_Object function, Lisp_Object table, Lisp_Object arg, Lisp_Object val, Lisp_Object range, Lisp_Object top) { - /* Pointer to the elements of TABLE. */ - Lisp_Object *contents; /* Depth of TABLE. */ int depth; /* Minimum and maxinum characters covered by TABLE. */ @@ -777,14 +774,12 @@ struct Lisp_Sub_Char_Table *tbl = XSUB_CHAR_TABLE (table); depth = XINT (tbl->depth); - contents = tbl->contents; min_char = XINT (tbl->min_char); max_char = min_char + chartab_chars[depth - 1] - 1; } else { depth = 0; - contents = XCHAR_TABLE (table)->contents; min_char = 0; max_char = MAX_CHAR; } @@ -1143,7 +1138,6 @@ Lisp_Object sub = make_sub_char_table (3, min_char, Qnil); struct Lisp_Sub_Char_Table *subtbl = XSUB_CHAR_TABLE (sub); const unsigned char *p, *pend; - int i; XSUB_CHAR_TABLE (table)->contents[idx] = sub; p = SDATA (val), pend = p + SBYTES (val); @@ -1316,7 +1310,7 @@ function may load a Lisp file and thus may cause garbage-collection. */ -Lisp_Object +static Lisp_Object uniprop_table (Lisp_Object prop) { Lisp_Object val, table, result; === modified file 'src/composite.c' --- src/composite.c 2011-07-07 16:18:25 +0000 +++ src/composite.c 2011-07-09 06:28:40 +0000 @@ -967,7 +967,6 @@ } static Lisp_Object _work_val; -static int _work_char; /* 1 iff the character C is composable. Characters of general category Z? or C? are not composable except for ZWNJ and ZWJ. */ === modified file 'src/gtkutil.c' --- src/gtkutil.c 2011-07-08 17:57:55 +0000 +++ src/gtkutil.c 2011-07-09 06:28:40 +0000 @@ -647,7 +647,6 @@ /* Change stupid Gtk+ default line wrapping. */ p = gtk_widget_get_parent (x->ttip_lbl); list = gtk_container_get_children (GTK_CONTAINER (p)); - iter; for (iter = list; iter; iter = g_list_next (iter)) { GtkWidget *w = GTK_WIDGET (iter->data); # Begin bundle IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWeoOTFQABHpfgAAwUHf/91sH 0AC////wYAf99dikKUFEaHR0AAUCGpEyaaM9U0ZpMmho09TTJhMjQwhhJIIYJoRiVPU8jKeUGg0a aMmmIOYAAAAAAAAAAGJFT/VTwBT00j1MgDIaPUyD0RoA5gAAAAAAAAAAKkkBExGmmjIGpphNTE0m 1GTTR5RAyujahbZcL/mRiMY+gvwE7KK46KZmEAYi+mDO5Z0mOeWxa9GjHPRa1sbsHBdwvvaMX0Kp 1FGIIpEJJAJY+pN0Iuap4SwYimt4OqVzO3BXGSLrF7Peqzcptkyqe8t6gP3O8eMcB7/qfIfAwXif U7GT+7FKTWuYvw0MB/yxrdPDt7eHbWGL+qwOxoLY8b/0GHlYj1k9fKqwZ0/27nBjjVVWD/w2HOpK 6r7y0qQ8lPLrs6ZM13VPZ6PB1h/biF6jrrTrk+EIQyLbG56JzmHDizlb5IF6QJVQLCdpomHPVWjo vke3K0N9O+p11yYROku4xNKmVRJWONLmmUZ5rExvkKwwqJK/tUWdliRwCsT8xks0DNijLlj6BkED luKbCfOd4JaRCXmfl0PdFCWL+wbeJnT2hVCVgTTBXoUTcUKln5Q4xlDnsXaOpUxBUIOYco/SHAED Uf3qJobwXU8CufO+HEam2mXn+vFg6nlV1gXXkuQIhwGc7PBw8Xf1u90fmWOJOvjqrLo4ksqJOLA6 SdmWBiQNO6ccUomBm+MqIwglzvIq8fORgCYOR+eR0XJ2jUmgvMbwqaUGMDTKUrxydNLLAUSVVg/o iqUTFZ0bF80OphWlfu1Ya2DBr1WYVa/iutYiZhN2RDOpA7/0U+gVrsGMYyBNm9BxeQKsiMBiDgT+ jQkbmeM1sFtSskuBaHShHXpc6eSVvRKZHOUdUpjaXsRwN/Cbzk2NdtyzF8+s230VHuIa1eWgbQx1 b7gUIl0un3gvCdLlLyLkzuxMktXpBiYcMTN2yv3TalOpCJQ4GglaDrcl7Sxy5zZax1zVkkl+ON2y 7rys9jg05KdDG2PVsaFMFeWNtTLcSAoX7EXFAXrfgulLOCiZ7RzcUYvSCcEXMNyVyBYnrJGW5lvN PbMbUvAzLWDLFiY8s/FiLtoPQsBI7MClIk8qYD5ZA84HlzHAiQ672aq1bVbmO323NMprZSa5uWWb drZy9fSR9hlqcxbbS3Upoc1ka3FTNdmuSywpkylsE2tEM8FOp7psdk01VU4Wqqe5Vqjl+5XJlCdp zuOEzJEIBIbZGoHl2NBmH6wYHA6BQHNgVQChT6/G5cMn0UpS5/l6QmjInc9G+uFs27b18a9+iLlD nysTQ2tsPOY/r7N5m/bJupUzbbPyo0pKi+ZKVD8Mn05miPXoaZ5vd8ny7G/3zns9+K/k683Nhztc n4sPs8V8zJ6v1T5yHKLTiCQMmATzpiA1h5Q6KTGRqP02CAOiUEorAQXYCA3OWg/RxXX1Zta+/Obj ZCcScTnaGnmrY/qE0TXleujW7vd29u8wb+lVmiTjpaRql7sZo++6/jyeLwas/ixa3T3bfNN8/Qmh lCfCifvm+p9/VLouDyX5ogoA2p/VfZ9kvAaPGu8pdTie5kcckD2h+wOXZU6lnR1FQo3Ptobp9Ljb pfHgb1njCayXW8sSdva1abOh1fH4vM9ntYstFFv6erTtnjyst0f0uPhzqk8H5Txff6vJR7JQ3+eb 8fDVInyfNm0m/FcjNF70efW83y+F7ft67+DjE+VPD5Wk1LMubH0YLmY2ErY6kzW7icj1P1MicLTo VKfScL2uS1nOqoUd0ifw2Qn2nPOrU9vau588Lcibf+3RLVHrvGt5TdUK6X1+b7o9bMXmlRwncSxv 1w10er7+LpYOpGby+3SfNH4xjmfhfLj0/uauolnpT7zv1U7ieNLX90LGZ0xx/h7jvnIdG1FLDRCY HQUKSxM7+DwJpeC9g0JPePbYYSe8ybozL3Y5zB2tLBMWKXSXMbLX+FwyLmsxha95XS6UpvYRivfT kTSkuoYFk6e5mTnblcrLdcTJH7LpMm+Htrc0bb0qOm5vT8s7O7U3sjfd2LFDhMk/nF15a8IupmvM 30NRPPo9mzUo7Si0OTyMDYOwLAS1LHiaCnQn5AnpYlOYvFgkKaUxxpNzW73fCfExvZOed/AtrVOV KqxxRrixom2pVL/maU3OqjQpUKeehd4XcpOnf8Fngc38+OLGEwMHsLo1DiThE6YwZtzaMVzfUNDs jcZN0foaoc6fay2rRYbHSw6hwkij3LLld0J0OTe3Pia9h06ec2xeu+RM0wTgj3m3uwejbK0UTnbp NxNm+Ppz5ybCNjcoOD3JXp/a/nGqJHsBf+LuSKcKEh1ByYqA From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 01:21:37 2011 Received: (at 9031-done) by debbugs.gnu.org; 10 Jul 2011 05:21:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QfmSX-0007Uv-MP for submit@debbugs.gnu.org; Sun, 10 Jul 2011 01:21:37 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QfmSU-0007Ug-T9 for 9031-done@debbugs.gnu.org; Sun, 10 Jul 2011 01:21:35 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id CE23B39E80F9 for <9031-done@debbugs.gnu.org>; Sat, 9 Jul 2011 22:21:28 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Yzctat7N-giP for <9031-done@debbugs.gnu.org>; Sat, 9 Jul 2011 22:21:28 -0700 (PDT) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 7146039E80F2 for <9031-done@debbugs.gnu.org>; Sat, 9 Jul 2011 22:21:28 -0700 (PDT) Message-ID: <4E1936D7.4030302@cs.ucla.edu> Date: Sat, 09 Jul 2011 22:21:27 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110516 Thunderbird/3.1.10 MIME-Version: 1.0 To: 9031-done@debbugs.gnu.org Subject: Installed rest of patch Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 9031-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) I see that I was too cautious, in that some of my patch was derived independently and installed into the trunk as part of bzr 105059. I just now installed the rest of the patch and am marking this bug report as done. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 07:38:34 2011 Received: (at 9031) by debbugs.gnu.org; 10 Jul 2011 11:38:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QfsLK-0008Ff-3o for submit@debbugs.gnu.org; Sun, 10 Jul 2011 07:38:34 -0400 Received: from mail-pz0-f44.google.com ([209.85.210.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QfsLH-0008FQ-G8; Sun, 10 Jul 2011 07:38:32 -0400 Received: by pzk5 with SMTP id 5so2542502pzk.3 for ; Sun, 10 Jul 2011 04:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=pE/PlR/8Ymm1aoEliUY2DBEczveLavuSCbXyigeuBHM=; b=uYX98D3/lNUCxfgScKsS/mBD4ad5kz7yc0RAdtksCQmN0d3fEJm+IAePn99lucieJF GImqmgTEvnGo1Q+TlB3onVs286PWatE+xq0n4l3Wb/t03MnTSZpUplaU8e94ms12TC8r UVM6Tt/IXHQqwyeC7z6N6si1+sjXCtUitlXs8= Received: by 10.142.120.1 with SMTP id s1mr1483720wfc.252.1310297905173; Sun, 10 Jul 2011 04:38:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.144.4 with HTTP; Sun, 10 Jul 2011 04:37:45 -0700 (PDT) In-Reply-To: <4E1936D7.4030302@cs.ucla.edu> References: <4E17F5F8.7060200@cs.ucla.edu> <4E1936D7.4030302@cs.ucla.edu> From: Juanma Barranquero Date: Sun, 10 Jul 2011 13:37:45 +0200 Message-ID: Subject: Re: bug#9031: Installed rest of patch To: 9031@debbugs.gnu.org, eggert@cs.ucla.edu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 9031 Cc: 9031-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On Sun, Jul 10, 2011 at 07:21, Paul Eggert wrote: > I see that I was too cautious Removing dead code and unused variables is not a new feature, and we haven't even started pretest yet as there have been no pretest releases. =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 11 08:49:31 2011 Received: (at 9031) by debbugs.gnu.org; 11 Jul 2011 12:49:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgFvW-0004t3-C0 for submit@debbugs.gnu.org; Mon, 11 Jul 2011 08:49:30 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgFvT-0004sg-1f; Mon, 11 Jul 2011 08:49:28 -0400 Received: from cpe-66-108-39-217.nyc.res.rr.com ([66.108.39.217]:46481 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QgFvM-0002B2-Ay; Mon, 11 Jul 2011 08:49:20 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 2E5A7660D5; Mon, 11 Jul 2011 08:49:19 -0400 (EDT) From: Stefan Monnier To: Juanma Barranquero Subject: Re: bug#9031: Installed rest of patch Message-ID: References: <4E17F5F8.7060200@cs.ucla.edu> <4E1936D7.4030302@cs.ucla.edu> Date: Mon, 11 Jul 2011 08:49:19 -0400 In-Reply-To: (Juanma Barranquero's message of "Sun, 10 Jul 2011 13:37:45 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 9031 Cc: 9031-done@debbugs.gnu.org, 9031@debbugs.gnu.org, eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) >> I see that I was too cautious > Removing dead code and unused variables is not a new feature, and we > haven't even started pretest yet as there have been no pretest > releases. At the same time, we're in feature freeze, which means we want to limit code changes to bug fixes because we'd rather not add more bugs at this stage. So it's better to keep code cleanups for later (you could try to install them in the `pending' branch, but such code cleanups are likely to generate merge conflicts). Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 11 09:09:49 2011 Received: (at 9031-done) by debbugs.gnu.org; 11 Jul 2011 13:09:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgGFA-0005KG-UN for submit@debbugs.gnu.org; Mon, 11 Jul 2011 09:09:49 -0400 Received: from mail-pz0-f44.google.com ([209.85.210.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgGF9-0005K3-Fh for 9031-done@debbugs.gnu.org; Mon, 11 Jul 2011 09:09:48 -0400 Received: by pzk5 with SMTP id 5so3319041pzk.3 for <9031-done@debbugs.gnu.org>; Mon, 11 Jul 2011 06:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=I+yXqLm+XBYZA5O+VhmVgnSsN1Bu0pJZELs6/yaFMag=; b=p3wxFI3wf1KnGPPj3RAYFLiZtY9IMouKJ1GZkEzylCoCi2Jp/UBAbPwR23aqvpvygQ XTcTLRPPZO2HXTcTj/FJ2FtpE5Caf51PX37eY+jqj8f2g8R+tpyn46hltlsPKurRSTGz MTg429Tsdp8lNDxbadMQ6ugxgezYW9vddVyIU= Received: by 10.142.120.1 with SMTP id s1mr2051366wfc.252.1310389781356; Mon, 11 Jul 2011 06:09:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.144.4 with HTTP; Mon, 11 Jul 2011 06:09:00 -0700 (PDT) In-Reply-To: References: <4E17F5F8.7060200@cs.ucla.edu> <4E1936D7.4030302@cs.ucla.edu> From: Juanma Barranquero Date: Mon, 11 Jul 2011 15:09:00 +0200 Message-ID: Subject: Re: bug#9031: Installed rest of patch To: Stefan Monnier Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 9031-done Cc: 9031-done@debbugs.gnu.org, eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On Mon, Jul 11, 2011 at 14:49, Stefan Monnier wr= ote: > So it's better to keep code cleanups for later Oh, I agree, but Paul's cleanup was removing a few unused variables. That kind of change shouldn't even cause merge conflicts, or only trivially fixable ones. Certainly large scale cleanups are best left for another time. That said, you're the boss. =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 11 13:26:06 2011 Received: (at 9031) by debbugs.gnu.org; 11 Jul 2011 17:26:06 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgKFC-0006ir-5w for submit@debbugs.gnu.org; Mon, 11 Jul 2011 13:26:06 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgKF9-0006iN-KF for 9031@debbugs.gnu.org; Mon, 11 Jul 2011 13:26:04 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 751F639E80F7; Mon, 11 Jul 2011 10:25:57 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hmFEtuDn6-x3; Mon, 11 Jul 2011 10:25:56 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id DE69B39E80F0; Mon, 11 Jul 2011 10:25:56 -0700 (PDT) Message-ID: <4E1B3224.5050804@cs.ucla.edu> Date: Mon, 11 Jul 2011 10:25:56 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Thunderbird/3.1.11 MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#9031: Installed rest of patch References: <4E17F5F8.7060200@cs.ucla.edu> <4E1936D7.4030302@cs.ucla.edu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.1 (---) X-Debbugs-Envelope-To: 9031 Cc: Juanma Barranquero , 9031@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.1 (---) On 07/11/11 05:49, Stefan Monnier wrote: > it's better to keep code cleanups for later This particular fix is both a code cleanup and a bug fix. The latter, because often compilers complain about unused local variables, and we'd rather have Emacs builds that don't have useless chatter and generate bug reports that waste everybody's time later. Compiler warnings are a judgment call. Pacifying every compiler would be a never-ending task, and we shouldn't try to do that. But this particular case is a trivial and obviously-safe change, and it fixes GCC warnings about code that was introduced after the feature freeze. The (admittedly minor) benefit of such a change surely exceeds its cost. I'd prefer it if, when one builds Emacs, one gets no more compile-time diagnostics than one did when the feature freeze was introduced. This shouldn't be an absolute goal and it shouldn't stand in the way of more-important issues, but surely it's not an unreasonable aspiration. > you could > try to install them in the `pending' branch, but such code cleanups are > likely to generate merge conflicts Does this advice mean that code cleanups should not be installed anywhere now, not even in the 'pending' branch? I ask because I have some integer-overflow-and-signedness-related cleanups and bug-fixes in my private copy that should really get incorporated at some point. (Sorry, I don't know the current practice with regards to the 'pending' branch; maybe 'pending' should be documented somewhere under admin/?) From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 12 00:51:18 2011 Received: (at 9031) by debbugs.gnu.org; 12 Jul 2011 04:51:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgUwH-0003wk-O3 for submit@debbugs.gnu.org; Tue, 12 Jul 2011 00:51:18 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgUwD-0003wW-Kv for 9031@debbugs.gnu.org; Tue, 12 Jul 2011 00:51:15 -0400 Received: from cpe-66-108-39-217.nyc.res.rr.com ([66.108.39.217]:44683 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QgUw6-0003Lo-0i; Tue, 12 Jul 2011 00:51:06 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 301BD660D5; Tue, 12 Jul 2011 00:51:04 -0400 (EDT) From: Stefan Monnier To: Paul Eggert Subject: Re: bug#9031: Installed rest of patch Message-ID: References: <4E17F5F8.7060200@cs.ucla.edu> <4E1936D7.4030302@cs.ucla.edu> <4E1B3224.5050804@cs.ucla.edu> Date: Tue, 12 Jul 2011 00:51:04 -0400 In-Reply-To: <4E1B3224.5050804@cs.ucla.edu> (Paul Eggert's message of "Mon, 11 Jul 2011 10:25:56 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 9031 Cc: Juanma Barranquero , 9031@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) >> it's better to keep code cleanups for later > This particular fix is both a code cleanup and a bug fix. Yes, it was OK. I just felt that Juanma's answer was a bit too much on the "we're not yet in pretest" side, so I wanted to compensate by reminding people that we should think of fixing bugs now, not cleaning things up. >> you could try to install them in the `pending' branch, but such code >> cleanups are likely to generate merge conflicts > Does this advice mean that code cleanups should not be installed > anywhere now, not even in the 'pending' branch? You can install them there, but that branch is really meant to be a repository of patches that will get merged to trunk in some distant future. Code that touches a lot of code is likely to encounter merge conflicts when we get to that distant future. And changes which need to apply to "all places where foo happens" are even more likely to be out-of-date when we get to that distant future. > I ask because I have some integer-overflow-and-signedness-related > cleanups and bug-fixes in my private copy that should really get > incorporated at some point. Put them somewhere. But I suspect that it'll be easier to re-do them than to merge the current patch several months from now, so it's probably important to store somewhere the "how did I come up with this patch" along with the patch. > (Sorry, I don't know the current practice with regards to the > 'pending' branch; maybe 'pending' should be documented somewhere > under admin/?) It's "documented" in http://bzr.savannah.gnu.org/r/emacs/README. We don't really want to encourage people to use it too much, since the focus should instead move to fixing bugs. But sometimes it's easier to install the patch somewhere than to try to mark some bug report as "it's got a patch and the patch is good to go, we just have to wait for the trunk to open up again before we can install it". Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 12 01:36:25 2011 Received: (at 9031) by debbugs.gnu.org; 12 Jul 2011 05:36:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgVdw-000505-IT for submit@debbugs.gnu.org; Tue, 12 Jul 2011 01:36:25 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgVdu-0004zq-D8 for 9031@debbugs.gnu.org; Tue, 12 Jul 2011 01:36:23 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 21F0A39E80F8; Mon, 11 Jul 2011 22:36:16 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jhmDqqY+1f-t; Mon, 11 Jul 2011 22:36:15 -0700 (PDT) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 4388239E80F0; Mon, 11 Jul 2011 22:36:15 -0700 (PDT) Message-ID: <4E1BDD4E.60605@cs.ucla.edu> Date: Mon, 11 Jul 2011 22:36:14 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110516 Thunderbird/3.1.10 MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#9031: Installed rest of patch References: <4E17F5F8.7060200@cs.ucla.edu> <4E1936D7.4030302@cs.ucla.edu> <4E1B3224.5050804@cs.ucla.edu> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 9031 Cc: Juanma Barranquero , 9031@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) >> I ask because I have some integer-overflow-and-signedness-related >> cleanups and bug-fixes in my private copy... > Put them somewhere. But I suspect that it'll be easier to re-do them > than to merge the current patch several months from now, so it's > probably important to store somewhere the "how did I come up with this > patch" along with the patch. Unfortunately the answer to "how did I come up with this patch?" is, "I read the Emacs source code carefully and found dozens of problems". It was done all by hand. As the patch in question should be entirely a bug-fix patch, and should not add any features or establish any new dependencies on system functions, I'm hoping that it will be preferable to put it on the trunk now rather than months from now. But we can cross that bridge once the patch is ready and you have a chance to look at it. It sounds like an Emacs bug report is the next step to take in publishing the patch, so I'll work on putting that together. I had hoped to do a complete sweep of the Emacs source code before publishing the patch, but given the above it sounds like I should publish what I have now, as there's little sense finding and fixing more bugs if I'll have to do it all over again in 2012. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 12 07:08:08 2011 Received: (at 9031) by debbugs.gnu.org; 12 Jul 2011 11:08:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgaox-0007Xp-Pw for submit@debbugs.gnu.org; Tue, 12 Jul 2011 07:08:07 -0400 Received: from mail-pz0-f44.google.com ([209.85.210.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgaov-0007XM-Ut for 9031@debbugs.gnu.org; Tue, 12 Jul 2011 07:08:06 -0400 Received: by pzk5 with SMTP id 5so4013885pzk.3 for <9031@debbugs.gnu.org>; Tue, 12 Jul 2011 04:08:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=QTsc2PVgwMFQpunUuKS8POO7Q73hVNSM8x5+rjqx69Y=; b=F+TQTAs8OM4SrjBiCvayP5p63rq2R/T800UQ03UwoZn6WBIr1lnq2LO94GhrD8bk61 CvmY8WHO0xmcjpy1LkJp/s18mZNUN7UEMeGdByCK6lfcLeRaImCUXDTvDwEk0fGX95lh XudmEBNJ/ZZC6dQmDQBwNN5ssuBeCzHW4oUVo= Received: by 10.143.90.11 with SMTP id s11mr674520wfl.366.1310468880185; Tue, 12 Jul 2011 04:08:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.144.4 with HTTP; Tue, 12 Jul 2011 04:07:20 -0700 (PDT) In-Reply-To: References: <4E17F5F8.7060200@cs.ucla.edu> <4E1936D7.4030302@cs.ucla.edu> <4E1B3224.5050804@cs.ucla.edu> From: Juanma Barranquero Date: Tue, 12 Jul 2011 13:07:20 +0200 Message-ID: Subject: Re: bug#9031: Installed rest of patch To: Stefan Monnier Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 9031 Cc: 9031@debbugs.gnu.org, Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On Tue, Jul 12, 2011 at 06:51, Stefan Monnier wr= ote: > Yes, it was OK. =C2=A0I just felt that Juanma's answer was a bit too much > on the "we're not yet in pretest" side, so I wanted to compensate by > reminding people that we should think of fixing bugs now, not cleaning > things up. Believe it or not, I'm quite conservative with respect to pretests. But... a formal announcemente about which state are we just now and when do we expect to release the first pretest tarball would be welcome. =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 12 11:45:11 2011 Received: (at 9031) by debbugs.gnu.org; 12 Jul 2011 15:45:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgf95-0004Bj-Kc for submit@debbugs.gnu.org; Tue, 12 Jul 2011 11:45:11 -0400 Received: from vm-emlprdomr-02.its.yale.edu ([130.132.50.143]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgf93-0004BX-MK for 9031@debbugs.gnu.org; Tue, 12 Jul 2011 11:45:10 -0400 Received: from furball (dhcp128036014025.central.yale.edu [128.36.14.25]) (authenticated bits=0) by vm-emlprdomr-02.its.yale.edu (8.14.4/8.14.4) with ESMTP id p6CFiuh1021495 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 12 Jul 2011 11:44:56 -0400 From: Chong Yidong To: Juanma Barranquero Subject: Re: bug#9031: Installed rest of patch References: <4E17F5F8.7060200@cs.ucla.edu> <4E1936D7.4030302@cs.ucla.edu> <4E1B3224.5050804@cs.ucla.edu> Date: Tue, 12 Jul 2011 11:44:56 -0400 In-Reply-To: (Juanma Barranquero's message of "Tue, 12 Jul 2011 13:07:20 +0200") Message-ID: <871uxvo64n.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.143 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 9031 Cc: 9031@debbugs.gnu.org, Paul Eggert , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Juanma Barranquero writes: > But... a formal announcemente about which state are we just now and > when do we expect to release the first pretest tarball would > be welcome. That depends on the bidi changes. From unknown Sat Aug 16 20:56:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 10 Aug 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator