From unknown Tue Jun 17 20:20:28 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#8987 <8987@debbugs.gnu.org> To: bug#8987 <8987@debbugs.gnu.org> Subject: Status: 24.0.50; texinfo-insert-menu inserts unnecessary trailing spaces Reply-To: bug#8987 <8987@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:20:28 +0000 retitle 8987 24.0.50; texinfo-insert-menu inserts unnecessary trailing spac= es reassign 8987 emacs submitter 8987 emacs18@gmail.com severity 8987 minor tag 8987 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 02 14:42:38 2011 Received: (at submit) by debbugs.gnu.org; 2 Jul 2011 18:42:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qd59K-0006ct-EM for submit@debbugs.gnu.org; Sat, 02 Jul 2011 14:42:38 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qd59H-0006cg-UP for submit@debbugs.gnu.org; Sat, 02 Jul 2011 14:42:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qd59B-0002ji-VZ for submit@debbugs.gnu.org; Sat, 02 Jul 2011 14:42:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:34970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qd59B-0002je-U9 for submit@debbugs.gnu.org; Sat, 02 Jul 2011 14:42:29 -0400 Received: from eggs.gnu.org ([140.186.70.92]:53203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qd59A-0008ER-PC for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2011 14:42:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qd599-0002jS-Tz for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2011 14:42:28 -0400 Received: from mail-pz0-f41.google.com ([209.85.210.41]:49931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qd599-0002jM-PM for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2011 14:42:27 -0400 Received: by pzk4 with SMTP id 4so351665pzk.0 for ; Sat, 02 Jul 2011 11:42:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:from:to:subject:reply-to:date:message-id:mime-version :content-type; bh=HG6DNrauTFwYxS4+gl6MZwB2Qvz28F4SmyX+N64Dwz8=; b=VwLzZ+QGR0gMi7dcBsx79oOd3EeRW8HK4oqTATXdcPiNuH12gs1i/pD/NTYazhCVve eqwUhoihh0Vg03ZJhjlDr3zYwQEFaCUTB09vZtwHVCqtdwmBnd6/HaSc9kbJppHMnhBO IvgygG3VWPqjkCoLe3xzM/ilp68ftkMT4b/R0= Received: by 10.68.41.168 with SMTP id g8mr5601263pbl.512.1309632146182; Sat, 02 Jul 2011 11:42:26 -0700 (PDT) Received: from kimr-laptop (static-50-53-5-59.bvtn.or.frontiernet.net [50.53.5.59]) by mx.google.com with ESMTPS id k4sm2768065pbl.59.2011.07.02.11.42.24 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 02 Jul 2011 11:42:25 -0700 (PDT) From: emacs18@gmail.com From: Richard Kim To: bug-gnu-emacs@gnu.org Subject: 24.0.50; texinfo-insert-menu inserts unnecessary trailing spaces Date: Sat, 02 Jul 2011 11:42:23 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: emacs18@gmail.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) texinfo-all-menus-update is a command that updates all menus within a texinfo buffer. This command calls texinfo-insert-menu in turn to update each menu. The problem with the latter is that it inserts unnecessary white spaces at the end of most menu items following double-colon. For example see bzr version 104838 of emacs trunk checked in on July 1, 2011 where someone checked in cc-mode.texi with trailing white spaces. This problem has existed for many years. I know, because I suffered through it many times myself. So I looked for a solution and it seems like making one line change should fix this as shown below. In emacs-lisp empty string evaluates to boolean true unlike python, so that one cannot simply test boolean value of a string to detect empty string verses non-empty string. It looks like testing the (length) being greater than 0 seems to get the job done. === modified file 'lisp/textmodes/texnfo-upd.el' --- lisp/textmodes/texnfo-upd.el 2011-01-25 04:08:28 +0000 +++ lisp/textmodes/texnfo-upd.el 2011-07-02 18:30:47 +0000 @@ -687,7 +687,7 @@ (insert (format "%s: %s." (car node-part) (cdr node-part))))) ;; Insert the description, if present. - (when (cdr menu) + (when (> (length (cdr menu)) 0) ;; Move to right place. (indent-to texinfo-column-for-description 2) ;; Insert description. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 03 12:12:35 2011 Received: (at control) by debbugs.gnu.org; 3 Jul 2011 16:12:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdPHe-0003NV-5b for submit@debbugs.gnu.org; Sun, 03 Jul 2011 12:12:34 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdPHc-0003NH-Tr for control@debbugs.gnu.org; Sun, 03 Jul 2011 12:12:33 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QdPHN-0002bR-NC for control@debbugs.gnu.org; Sun, 03 Jul 2011 18:12:17 +0200 Date: Sun, 03 Jul 2011 18:12:17 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #8987 X-MailScanner-ID: 1QdPHN-0002bR-NC X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1310314337.78868@7v/sOrtOCZ3sulYqZbpYaQ X-Spam-Status: No X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) tags 8987 fixed close 8987 24.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 03 12:30:16 2011 Received: (at 8987) by debbugs.gnu.org; 3 Jul 2011 16:30:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdPYi-0004sO-7i for submit@debbugs.gnu.org; Sun, 03 Jul 2011 12:30:16 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdPYg-0004hq-7Q for 8987@debbugs.gnu.org; Sun, 03 Jul 2011 12:30:10 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QdPYS-0002te-Pi; Sun, 03 Jul 2011 18:29:56 +0200 From: Lars Magne Ingebrigtsen To: emacs18@gmail.com Subject: Re: 24.0.50; texinfo-insert-menu inserts unnecessary trailing spaces In-Reply-To: (emacs's message of "Sat, 02 Jul 2011 11:42:23 -0700") Date: Sun, 03 Jul 2011 18:12:14 +0200 Message-ID: References: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Oval's _Oh_: "Hey" X-Hashcash: 1:23:110703:emacs18@gmail.com::Fa23XejwDVW3kVv3:0000000000000000000000000000000000000000000009Rn X-Hashcash: 1:23:110703:8987@debbugs.gnu.org::JTaaeKh6eATUEG83:00000000000000000000000000000000000000000Pc9c MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QdPYS-0002te-Pi X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1310315396.9439@FngEqoPUJDSQnz9yeFfAVg X-Spam-Status: No X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 8987 Cc: 8987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) emacs18@gmail.com, Richard Kim writes: > In emacs-lisp empty string evaluates to boolean true unlike python, > so that one cannot simply test boolean value of a string to detect > empty string verses non-empty string. It looks like testing the > (length) being greater than 0 seems to get the job done. Thanks for the patch; I've applied it to Emacs 24. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Tue Jun 17 20:20:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 01 Aug 2011 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator