GNU bug report logs - #8977
Parse error: Compile coreutils 8.9 with gcc 2.95.3

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8977 in the body.
You can then email your comments to 8977 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wolfgang Steinwender <wolfgang <at> psysteme.de>
To: bug-coreutils <at> gnu.org
Subject: Parse error: Compile coreutils 8.9 with gcc 2.95.3
Date: Fri, 01 Jul 2011 10:43:54 +0200

Hi,

compiling coreutils 8.9 with gcc 2.95.3:

heap.c: In function `heap_remove_top':
heap.c:99: parse error before `void'
heap.c:103: `top' undeclared (first use in this function)
heap.c:103: (Each undeclared identifier is reported only once
heap.c:103: for each function it appears in.)

I hat to change this:

void *
heap_remove_top (struct heap *heap)
{
  if (heap->count == 0)
    return NULL;

  void *top = heap->array[1];
  heap->array[1] = heap->array[heap->count--];
  heapify_down (heap->array, heap->count, 1, heap->compare);

  return top;
}

to this:

void *
heap_remove_top (struct heap *heap)
{
  void* top;

  if (heap->count == 0)
    return NULL;

  top = heap->array[1];
  heap->array[1] = heap->array[heap->count--];
  heapify_down (heap->array, heap->count, 1, heap->compare);

  return top;
}


The problem is also in the latest git version.

Thanks,
W. Steinwender

Message #8 received at 8977 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Wolfgang Steinwender <wolfgang <at> psysteme.de>
Cc: 8977 <at> debbugs.gnu.org
Subject: Re: bug#8977: Parse error: Compile coreutils 8.9 with gcc 2.95.3
Date: Fri, 01 Jul 2011 11:47:32 -0600

[Message part 1 (text/plain, inline)]

On 07/01/2011 02:43 AM, Wolfgang Steinwender wrote:
> Hi,
> 
> compiling coreutils 8.9 with gcc 2.95.3:

Thanks for the report.  However, this is not a bug in coreutils, since
we explicitly document in the "Pre-C99 build failure" section in README
the minimum compiler that we are willing to support.

> {
>   if (heap->count == 0)
>     return NULL;
> 
>   void *top = heap->array[1];

The declaration-after-statement construct is required by C99 (now more
than 10 years old), and supported as an extension by a number of C89
compilers.  Your problem is that gcc 2.95.3 is SOOOO old that it does
not understand this extension.

-- 
Eric Blake   eblake <at> redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Message #15 received at 8977 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Wolfgang Steinwender <wolfgang <at> psysteme.de>
Cc: 8977 <at> debbugs.gnu.org
Subject: Re: bug#8977: Parse error: Compile coreutils 8.9 with gcc 2.95.3
Date: Fri, 01 Jul 2011 22:16:33 +0100

On 01/07/11 09:43, Wolfgang Steinwender wrote:
> Hi,
> 
> compiling coreutils 8.9 with gcc 2.95.3:
> 
> heap.c: In function `heap_remove_top':
> heap.c:99: parse error before `void'
> heap.c:103: `top' undeclared (first use in this function)
> heap.c:103: (Each undeclared identifier is reported only once
> heap.c:103: for each function it appears in.)


heap.c is one of the files we might like to have
c89 support with, as it may be moved to gnulib.

I'm a bit confused though.
Did the rest of coreutils compile without issue?
Similar code is used in many places.

Also as a matter of interest, what system is this?

cheers,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.