GNU bug report logs - #8942
23.3; emacsclient doesn't exit when called Emacs function is quited.

Previous Next

Package: emacs;

Reported by: "Remi Vanicat" <vanicat <at> debian.org>

Date: Mon, 27 Jun 2011 16:33:02 UTC

Severity: normal

Found in version 23.3

Done: Juanma Barranquero <lekktu <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #23 received at 8942 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: Remi Vanicat <vanicat <at> debian.org>, 8942 <at> debbugs.gnu.org
Subject: Re: bug#8942: 23.3;
	emacsclient doesn't exit when called Emacs function is quited.
Date: Mon, 04 Jul 2011 14:43:31 -0400
>> So if you want to remove with-local-quit, you need to add a let-binding
>> of inhibit-quit to nil within your condition-case.

> No, I don't have a particular interest in removing with-local-quit. As
> I said, this

> === modified file 'lisp/server.el'
> --- lisp/server.el      2011-07-04 01:04:29 +0000
> +++ lisp/server.el      2011-07-04 18:04:02 +0000
> @@ -1153,7 +1153,7 @@
>                               "When done with a buffer, type
> \\[server-edit]")))))
>            (when (and frame (null tty-name))
>              (server-unselect-display frame)))
> -      (error (server-return-error proc err)))))
> +      ((error quit) (server-return-error proc err)))))

>  (defun server-return-error (proc err)
>    (ignore-errors


> is more than enough to fix the bug.

Good.

> The question is if you still want to show the user some feedback about
> the fact that he quit the emacsclient eval, and how to do so.

Ah, yes, that could be useful.

> (message "Quit") perhaps? :-)

OK, although we could also be a bit more informative that the quit
interrupted an emacsclient command, like "Quit emacsclient request".


        Stefan




This bug report was last modified 14 years and 23 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.