GNU bug report logs - #8927
24.0.50; Flaw in C-x v u

Previous Next

Full log

View this message in rfc822 format

From: Óscar Fuentes <ofv <at> wanadoo.es>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 8927 <at> debbugs.gnu.org, rms <at> gnu.org
Subject: bug#8927: 24.0.50; Flaw in C-x v u
Date: Sun, 26 Jun 2011 14:17:02 +0200

Chong Yidong <cyd <at> stupidchicken.com> writes:

>> C-x v u should preserve the previous contents of *vc-diff*.
>
> I've checked in a fix to avoid clobbering an existing vc-diff buffer
> when vc-revert shows a diff temporarily.
>
> I agree with Glenn, though, that showing a vc-diff buffer for this
> operation is not a good idea.  Apart from the problems he mentioned, the
> diff is not useful anyway, since there is no way to scroll the window
> during the yes-nor-no prompt.

C-M-v works fine here, and it is posible to select the other windows
with C-x o or with the mouse while the prompt is active. I'm using an
old version (2010-11-11) maybe yes-or-no changed since?

> I added a new option vc-revert-show-diff to control whether vc-revert
> should show a diff, and made it default to nil.

FWIW, I agree with Dan.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.