From unknown Wed Aug 20 03:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8927: 24.0.50; Flaw in C-x v u Resent-From: Richard Stallman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Jun 2011 09:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8927 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 8927@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: rms@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.130890826418377 (code B ref -1); Fri, 24 Jun 2011 09:38:01 +0000 Received: (at submit) by debbugs.gnu.org; 24 Jun 2011 09:37:44 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qa2pb-0004mM-Kf for submit@debbugs.gnu.org; Fri, 24 Jun 2011 05:37:44 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qa2pY-0004m9-Va for submit@debbugs.gnu.org; Fri, 24 Jun 2011 05:37:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qa2pS-000462-GJ for submit@debbugs.gnu.org; Fri, 24 Jun 2011 05:37:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:56239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qa2pS-00045y-7a for submit@debbugs.gnu.org; Fri, 24 Jun 2011 05:37:34 -0400 Received: from eggs.gnu.org ([140.186.70.92]:35992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qa2pP-0000eq-Sn for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2011 05:37:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qa2pN-00045V-U3 for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2011 05:37:31 -0400 Received: from fencepost.gnu.org ([140.186.70.10]:46911) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qa2pN-00045R-KM for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2011 05:37:29 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Qa2pM-00042w-5T; Fri, 24 Jun 2011 05:37:28 -0400 Date: Fri, 24 Jun 2011 05:37:28 -0400 Message-Id: Content-Type: text/plain; charset=ISO-8859-15 From: Richard Stallman X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.6 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) I did C-x v = to see the changes in a file, then reverted the file with C-x v u so I could install and commit those changes one by one. Unfortunately, C-x v u deleted the *vc-diff* buffer and made this fail. C-x v u should not delete the *vc-diff* buffer. In GNU Emacs 24.0.50.1 (mips64el-unknown-linux-gnu, GTK+ Version 2.12.12) of 2011-06-10 on theobromine2 Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Mail Minor modes in effect: diff-auto-refine-mode: t shell-dirtrack-mode: t gpm-mouse-mode: t display-battery-mode: t tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Recent input: SPC v SPC - SPC DEL DEL = SPC t o SPC s e e SPC t h e SPC c h a n g e s SPC i n SPC a SPC f i l e , SPC t h e n SPC r e v e r t e d RET t h e SPC f i l e SPC w i t h SPC C - x SPC v SPC u SPC s o SPC I SPC c o u l d SPC i n s t a l l SPC a m d SPC DEL DEL DEL n d SPC c o m m i t SPC t h o s e SPC c h a n g e s RET o n e SPC b y SPC o n e . ESC q RET RET U n f o r t u n a t e l y , SPC C - x SPC v SPC u SPC d e l e t e d SPC t h e SPC * v c - d i f f * SPC b u f f e r SPC a n d SPC m a d e SPC t h i s SPC f a i l . RET RET C - x SPC v SPC u SPC s h o u l d SPC n o t SPC d e l e t e SPC t h e SPC * v c - d i f f * SPC b u f f e r . C-a C-p C-p C-p C-p C-p C-@ C-u C-n C-n C-n ESC w C-x m C-g ESC x r e o o r t DEL DEL DEL DEL p o r t SPC e m a c s TAB RET Recent messages: Quit Mark set There are unresolved conflicts in this file Mark set Saving file /home/rms/emacs-bzr/trunk/lisp/ChangeLog... Wrote /home/rms/emacs-bzr/trunk/lisp/ChangeLog Type C-h for help. Quit [2 times] Auto-saving...done Mark set Quit Load-path shadows: None found. Features: (shadow emacsbug smerge-mode ansi-color diff expect rmailedit mh-e mh-compat mh-acros cl mh-buffers mh-loaddefs gnus gnus-ems nnheader gnus-util time-date wid-edit cal-move cal-menu calendar cal-loaddefs mule-util log-edit pcvs-util add-log parse-time vc-cvs sgml-mode ispell derived byte-opt bytecomp byte-compile cconv macroexp debug compare-w whitespace diff-mode easy-mmode vc ediff-merg ediff-diff ediff-wind ediff-help ediff-util ediff-mult ediff-init ediff vc-dispatcher dired-aux vc-bzr find-func help-fns warnings ind-util rmailout kmacro quail help-mode view dabbrev shell pcomplete grep compile multi-isearch newcomment qp mailalias rmailmm message sendmail format-spec mml mml-sec mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader mail-parse rfc2231 rmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils dired t-mouse battery paren cus-start cus-load mailcrypt rfc822 comint regexp-opt ring easymenu mailcrypt-init tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) -- Dr Richard Stallman President, Free Software Foundation 51 Franklin St Boston MA 02110 USA www.fsf.org, www.gnu.org Skype: No way! That's nonfree (freedom-denying) software. Use free telephony http://directory.fsf.org/category/tel/ From unknown Wed Aug 20 03:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8927: 24.0.50; Flaw in C-x v u Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Jun 2011 21:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8927 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: rms@gnu.org Cc: 8927@debbugs.gnu.org Received: via spool by 8927-submit@debbugs.gnu.org id=B8927.130894917814766 (code B ref 8927); Fri, 24 Jun 2011 21:00:03 +0000 Received: (at 8927) by debbugs.gnu.org; 24 Jun 2011 20:59:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QaDTW-0003q7-18 for submit@debbugs.gnu.org; Fri, 24 Jun 2011 16:59:38 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QaDTU-0003px-DX for 8927@debbugs.gnu.org; Fri, 24 Jun 2011 16:59:36 -0400 Received: from localhost ([127.0.0.1]:58134) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaDTO-00021p-3A; Fri, 24 Jun 2011 16:59:30 -0400 From: Glenn Morris References: X-Spook: SP4 Agfa EuroFed Croatian bluebird mania Indigo ASIO X-Ran: tNCmaX{,w,7()tC.F|_D!?p6qk~D)uJc`YLbzJMV"H7)&k$?2&w,j_7WY9k1A@L(Y (Richard Stallman's message of "Fri, 24 Jun 2011 05:37:28 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Richard Stallman wrote: > I did C-x v = to see the changes in a file, then reverted the file > with C-x v u so I could install and commit those changes one by one. > > Unfortunately, C-x v u deleted the *vc-diff* buffer and made this fail. > > C-x v u should not delete the *vc-diff* buffer. On a related note, it has always annoyed me that vc-revert unconditionally always shows me the diff of the file in question before letting me revert. Basically every time I use vc-revert, I have already checked the diff beforehand, so all this does is introduce an annoying delay when the backend is slow to produce a diff. I'm not aware of a command-line VCS that show you the diff when you run its revert command, so I don't see why Emacs should do so. Anyway, that's why it kills your *vc-diff* buffer - because it assumes it has just created it. The fix for your problem would presumably be for vc-revert to only kill the buffer if it did not exist beforehand. But personally I still wish it would not always insist on showing me the diff. From unknown Wed Aug 20 03:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8927: 24.0.50; Flaw in C-x v u Resent-From: Richard Stallman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Jun 2011 21:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8927 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 8927@debbugs.gnu.org Reply-To: rms@gnu.org Received: via spool by 8927-submit@debbugs.gnu.org id=B8927.130903890822304 (code B ref 8927); Sat, 25 Jun 2011 21:56:01 +0000 Received: (at 8927) by debbugs.gnu.org; 25 Jun 2011 21:55:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qaaol-0005nh-ET for submit@debbugs.gnu.org; Sat, 25 Jun 2011 17:55:07 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qaaoj-0005nD-5T for 8927@debbugs.gnu.org; Sat, 25 Jun 2011 17:55:05 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Qaaoc-0001s0-4X; Sat, 25 Jun 2011 17:54:58 -0400 Date: Sat, 25 Jun 2011 17:54:58 -0400 Message-Id: Content-Type: text/plain; charset=ISO-8859-15 From: Richard Stallman In-reply-to: (message from Glenn Morris on Fri, 24 Jun 2011 16:59:29 -0400) References: X-Spam-Score: -6.6 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Anyway, that's why it kills your *vc-diff* buffer - because it assumes it has just created it. The fix for your problem would presumably be for vc-revert to only kill the buffer if it did not exist beforehand. C-x v u should preserve the previous contents of *vc-diff*. -- Dr Richard Stallman President, Free Software Foundation 51 Franklin St Boston MA 02110 USA www.fsf.org, www.gnu.org Skype: No way! That's nonfree (freedom-denying) software. Use free telephony http://directory.fsf.org/category/tel/ From unknown Wed Aug 20 03:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8927: 24.0.50; Flaw in C-x v u Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jun 2011 04:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8927 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: rms@gnu.org Cc: Glenn Morris , 8927@debbugs.gnu.org Received: via spool by 8927-submit@debbugs.gnu.org id=B8927.130906131930318 (code B ref 8927); Sun, 26 Jun 2011 04:09:01 +0000 Received: (at 8927) by debbugs.gnu.org; 26 Jun 2011 04:08:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QageE-0007sx-2R for submit@debbugs.gnu.org; Sun, 26 Jun 2011 00:08:38 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QageC-0007sm-59 for 8927@debbugs.gnu.org; Sun, 26 Jun 2011 00:08:36 -0400 Received: from cyd by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Qagdy-0004EM-Ot; Sun, 26 Jun 2011 00:08:22 -0400 From: Chong Yidong References: Date: Sun, 26 Jun 2011 00:08:22 -0400 In-Reply-To: (Richard Stallman's message of "Sat, 25 Jun 2011 17:54:58 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.6 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Richard Stallman writes: > Anyway, that's why it kills your *vc-diff* buffer - because it assumes > it has just created it. The fix for your problem would presumably be for > vc-revert to only kill the buffer if it did not exist beforehand. > > C-x v u should preserve the previous contents of *vc-diff*. I've checked in a fix to avoid clobbering an existing vc-diff buffer when vc-revert shows a diff temporarily. I agree with Glenn, though, that showing a vc-diff buffer for this operation is not a good idea. Apart from the problems he mentioned, the diff is not useful anyway, since there is no way to scroll the window during the yes-nor-no prompt. I added a new option vc-revert-show-diff to control whether vc-revert should show a diff, and made it default to nil. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 26 00:09:02 2011 Received: (at control) by debbugs.gnu.org; 26 Jun 2011 04:09:03 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qagec-0007ts-Cn for submit@debbugs.gnu.org; Sun, 26 Jun 2011 00:09:02 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qagea-0007tK-Te for control@debbugs.gnu.org; Sun, 26 Jun 2011 00:09:01 -0400 Received: from cyd by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1QageV-0004GO-M8 for control@debbugs.gnu.org; Sun, 26 Jun 2011 00:08:55 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 8927 Date: Sun, 26 Jun 2011 00:08:55 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) close 8927 thanks From unknown Wed Aug 20 03:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8927: 24.0.50; Flaw in C-x v u Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jun 2011 05:40:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8927 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Chong Yidong Cc: 8927@debbugs.gnu.org, rms@gnu.org Received: via spool by 8927-submit@debbugs.gnu.org id=B8927.130906674523555 (code B ref 8927); Sun, 26 Jun 2011 05:40:03 +0000 Received: (at 8927) by debbugs.gnu.org; 26 Jun 2011 05:39:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qai3k-00067s-Ti for submit@debbugs.gnu.org; Sun, 26 Jun 2011 01:39:05 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qai3i-00067O-5P for 8927@debbugs.gnu.org; Sun, 26 Jun 2011 01:39:02 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Qai3b-0000qN-Fg; Sun, 26 Jun 2011 01:38:55 -0400 From: Dan Nicolaescu References: Date: Sun, 26 Jun 2011 01:38:55 -0400 In-Reply-To: (Chong Yidong's message of "Sun, 26 Jun 2011 00:08:22 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.5 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) Chong Yidong writes: > Richard Stallman writes: > >> Anyway, that's why it kills your *vc-diff* buffer - because it assumes >> it has just created it. The fix for your problem would presumably be for >> vc-revert to only kill the buffer if it did not exist beforehand. >> >> C-x v u should preserve the previous contents of *vc-diff*. > > I've checked in a fix to avoid clobbering an existing vc-diff buffer > when vc-revert shows a diff temporarily. > > I agree with Glenn, though, that showing a vc-diff buffer for this > operation is not a good idea. Apart from the problems he mentioned, the > diff is not useful anyway, since there is no way to scroll the window > during the yes-nor-no prompt. I added a new option vc-revert-show-diff > to control whether vc-revert should show a diff, and made it default to > nil. I strongly disagree with this change of a long standing behavior. Showing the diff is an good visual aid in checking that the user indeed intends to revert that file. It's not that hard to type C-x v u in the wrong window if one has many windows opened, and the files have similar names. C-x v u is destructive, it's easy to lose data, so it seems that it would be much better to err on the side of caution. Can't RMS' original complaint be solved by making vc-revert use a *vc revert diff* buffer instead of just *vc diff*? From unknown Wed Aug 20 03:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8927: 24.0.50; Flaw in C-x v u Resent-From: Romain Francoise Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jun 2011 09:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8927 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dan Nicolaescu Cc: Chong Yidong , 8927@debbugs.gnu.org, rms@gnu.org Received: via spool by 8927-submit@debbugs.gnu.org id=B8927.130908077526025 (code B ref 8927); Sun, 26 Jun 2011 09:33:01 +0000 Received: (at 8927) by debbugs.gnu.org; 26 Jun 2011 09:32:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qali3-0006lh-Fv for submit@debbugs.gnu.org; Sun, 26 Jun 2011 05:32:55 -0400 Received: from smtp6-g21.free.fr ([212.27.42.6]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qali0-0006lT-RI for 8927@debbugs.gnu.org; Sun, 26 Jun 2011 05:32:54 -0400 Received: from silenus.orebokech.com (unknown [82.67.41.165]) by smtp6-g21.free.fr (Postfix) with ESMTP id 1C118822F7; Sun, 26 Jun 2011 11:32:41 +0200 (CEST) Received: by silenus.orebokech.com (Postfix, from userid 1000) id C61522E00FD; Sun, 26 Jun 2011 11:32:40 +0200 (CEST) From: Romain Francoise Organization: orebokech dot com References: X-Face: }9mYu,e_@+e!`Z-P5kVXa3\_b:hdJ"B)ww[&=b<2=awG:GOIM (Dan Nicolaescu's message of "Sun, 26 Jun 2011 01:38:55 -0400") Message-ID: <871uyhym2v.fsf@silenus.orebokech.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Dan Nicolaescu writes: > I strongly disagree with this change of a long standing behavior. FWIW, me too. > Showing the diff is an good visual aid in checking that the user indeed > intends to revert that file. It's not that hard to type C-x v u in the > wrong window if one has many windows opened, and the files have similar > names. Yes. And if you use vc-dir, you may not have the file opened at all. Also, it's not true that the diff buffer cannot be scrolled from the yes-or-no prompt as Chong mentioned earlier in this thread, `scroll-other-window' and `scroll-other-window-down' work as expected. From unknown Wed Aug 20 03:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8927: 24.0.50; Flaw in C-x v u Resent-From: =?UTF-8?Q?=C3=93scar?= Fuentes Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jun 2011 12:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8927 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Chong Yidong Cc: 8927@debbugs.gnu.org, rms@gnu.org Received: via spool by 8927-submit@debbugs.gnu.org id=B8927.13090906357664 (code B ref 8927); Sun, 26 Jun 2011 12:18:02 +0000 Received: (at 8927) by debbugs.gnu.org; 26 Jun 2011 12:17:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QaoH5-0001zY-HV for submit@debbugs.gnu.org; Sun, 26 Jun 2011 08:17:15 -0400 Received: from impaqm1.telefonica.net ([213.4.138.17] helo=telefonica.net) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QaoH0-0001zL-SQ for 8927@debbugs.gnu.org; Sun, 26 Jun 2011 08:17:13 -0400 Received: from IMPmailhost1.adm.correo ([10.20.102.38]) by IMPaqm1.telefonica.net with bizsmtp id 0c8T1h00e0piX6q01cH5VJ; Sun, 26 Jun 2011 14:17:05 +0200 Received: from qcore ([83.59.4.72]) by IMPmailhost1.adm.correo with BIZ IMP id 0cH21h00M1ZDhMP1hcH3yv; Sun, 26 Jun 2011 14:17:05 +0200 X-Brightmail-Tracker: AAAAAA== X-original-sender: 981711563@telefonica.net From: =?UTF-8?Q?=C3=93scar?= Fuentes References: Date: Sun, 26 Jun 2011 14:17:02 +0200 In-Reply-To: (Chong Yidong's message of "Sun, 26 Jun 2011 00:08:22 -0400") Message-ID: <87aad4vlc1.fsf@wanadoo.es> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.0 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) Chong Yidong writes: >> C-x v u should preserve the previous contents of *vc-diff*. > > I've checked in a fix to avoid clobbering an existing vc-diff buffer > when vc-revert shows a diff temporarily. > > I agree with Glenn, though, that showing a vc-diff buffer for this > operation is not a good idea. Apart from the problems he mentioned, the > diff is not useful anyway, since there is no way to scroll the window > during the yes-nor-no prompt. C-M-v works fine here, and it is posible to select the other windows with C-x o or with the mouse while the prompt is active. I'm using an old version (2010-11-11) maybe yes-or-no changed since? > I added a new option vc-revert-show-diff to control whether vc-revert > should show a diff, and made it default to nil. FWIW, I agree with Dan. From unknown Wed Aug 20 03:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8927: 24.0.50; Flaw in C-x v u Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jun 2011 13:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8927 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 8927@debbugs.gnu.org, rms@gnu.org Received: via spool by 8927-submit@debbugs.gnu.org id=B8927.130909381420995 (code B ref 8927); Sun, 26 Jun 2011 13:11:02 +0000 Received: (at 8927) by debbugs.gnu.org; 26 Jun 2011 13:10:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qap6K-0005Sa-VR for submit@debbugs.gnu.org; Sun, 26 Jun 2011 09:10:13 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qap6I-0005SO-Vy for 8927@debbugs.gnu.org; Sun, 26 Jun 2011 09:10:11 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAJEuB05MCqDH/2dsb2JhbABTp0Z4iHTAHYYwBJ4RhCk X-IronPort-AV: E=Sophos;i="4.65,428,1304308800"; d="scan'208";a="117142981" Received: from 76-10-160-199.dsl.teksavvy.com (HELO pastel.home) ([76.10.160.199]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 26 Jun 2011 09:10:05 -0400 Received: by pastel.home (Postfix, from userid 20848) id 760E258FD6; Sun, 26 Jun 2011 09:10:04 -0400 (EDT) From: Stefan Monnier Message-ID: References: Date: Sun, 26 Jun 2011 09:10:04 -0400 In-Reply-To: (Glenn Morris's message of "Fri, 24 Jun 2011 16:59:29 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > it has just created it. The fix for your problem would presumably be for > vc-revert to only kill the buffer if it did not exist beforehand. Right, that's the least we can do. > But personally I still wish it would not always insist on showing me > the diff. I'd agree. It should still prompt for confirmation, of course, at which point the user can go get the diff if there's any doubt. Stefan From unknown Wed Aug 20 03:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8927: 24.0.50; Flaw in C-x v u Resent-From: Richard Stallman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jun 2011 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8927 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Chong Yidong Cc: 8927@debbugs.gnu.org Reply-To: rms@gnu.org Received: via spool by 8927-submit@debbugs.gnu.org id=B8927.130910509810661 (code B ref 8927); Sun, 26 Jun 2011 16:19:02 +0000 Received: (at 8927) by debbugs.gnu.org; 26 Jun 2011 16:18:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qas2L-0002lu-DB for submit@debbugs.gnu.org; Sun, 26 Jun 2011 12:18:17 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qas2J-0002lh-Gi for 8927@debbugs.gnu.org; Sun, 26 Jun 2011 12:18:16 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Qas2D-0000r5-It; Sun, 26 Jun 2011 12:18:09 -0400 Date: Sun, 26 Jun 2011 12:18:09 -0400 Message-Id: Content-Type: text/plain; charset=ISO-8859-15 From: Richard Stallman In-reply-to: (message from Chong Yidong on Sun, 26 Jun 2011 00:08:22 -0400) References: X-Spam-Score: -6.6 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Thanks. -- Dr Richard Stallman President, Free Software Foundation 51 Franklin St Boston MA 02110 USA www.fsf.org, www.gnu.org Skype: No way! That's nonfree (freedom-denying) software. Use free telephony http://directory.fsf.org/category/tel/ From unknown Wed Aug 20 03:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8927: 24.0.50; Flaw in C-x v u Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jun 2011 19:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8927 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Romain Francoise Cc: Dan Nicolaescu , 8927@debbugs.gnu.org, rms@gnu.org Received: via spool by 8927-submit@debbugs.gnu.org id=B8927.1309116779561 (code B ref 8927); Sun, 26 Jun 2011 19:33:02 +0000 Received: (at 8927) by debbugs.gnu.org; 26 Jun 2011 19:32:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qav4k-00008y-LI for submit@debbugs.gnu.org; Sun, 26 Jun 2011 15:32:58 -0400 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qav4j-00008n-C5 for 8927@debbugs.gnu.org; Sun, 26 Jun 2011 15:32:57 -0400 Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p5QJWpxk007383 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 26 Jun 2011 15:32:51 -0400 Received: by furball (Postfix, from userid 1000) id 019801605B7; Sun, 26 Jun 2011 15:32:50 -0400 (EDT) From: Chong Yidong References: <871uyhym2v.fsf@silenus.orebokech.com> Date: Sun, 26 Jun 2011 15:32:50 -0400 In-Reply-To: <871uyhym2v.fsf@silenus.orebokech.com> (Romain Francoise's message of "Sun, 26 Jun 2011 11:32:40 +0200") Message-ID: <87boxkmlr1.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Romain Francoise writes: > Also, it's not true that the diff buffer cannot be scrolled from the > yes-or-no prompt as Chong mentioned earlier in this thread, > `scroll-other-window' and `scroll-other-window-down' work as expected. Ah yes, forgot about that; I seldom use that functionality. Since several are opposed, I guess it's wise to keep the old behavior. If someone feels strongly about a change, we can discuss on emacs-devel. Otherwise, we at least have an option to prevent the diff from being shown. From unknown Wed Aug 20 03:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8927: 24.0.50; Flaw in C-x v u In-Reply-To: Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jun 2011 21:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8927 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 8927@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13091251006352 (code B ref -1); Sun, 26 Jun 2011 21:52:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 Jun 2011 21:51:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QaxEx-0001eP-SZ for submit@debbugs.gnu.org; Sun, 26 Jun 2011 17:51:40 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QaxEv-0001eD-S8 for submit@debbugs.gnu.org; Sun, 26 Jun 2011 17:51:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QaxEp-0005Jn-Ha for submit@debbugs.gnu.org; Sun, 26 Jun 2011 17:51:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:49783) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaxEp-0005Jj-8d for submit@debbugs.gnu.org; Sun, 26 Jun 2011 17:51:31 -0400 Received: from eggs.gnu.org ([140.186.70.92]:52527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaxEn-0005s7-VZ for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2011 17:51:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QaxEm-0005JZ-3P for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2011 17:51:29 -0400 Received: from lo.gmane.org ([80.91.229.12]:54171) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaxEl-0005JP-MA for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2011 17:51:27 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QaxEj-0005Cp-GJ for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2011 23:51:25 +0200 Received: from 43.77.197.77.rev.sfr.net ([77.197.77.43]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 26 Jun 2011 23:51:25 +0200 Received: from thierry.volpiatto by 43.77.197.77.rev.sfr.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 26 Jun 2011 23:51:25 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Thierry Volpiatto Date: Sun, 26 Jun 2011 23:51:11 +0200 Lines: 25 Message-ID: <87hb7cqn1s.fsf@gmail.com> References: <871uyhym2v.fsf@silenus.orebokech.com> <87boxkmlr1.fsf@stupidchicken.com> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 43.77.197.77.rev.sfr.net User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:i1gPUn8muqTkHgr6OC63eXsT05c= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) Chong Yidong writes: > Romain Francoise writes: > >> Also, it's not true that the diff buffer cannot be scrolled from the >> yes-or-no prompt as Chong mentioned earlier in this thread, >> `scroll-other-window' and `scroll-other-window-down' work as expected. > > Ah yes, forgot about that; I seldom use that functionality. Sorry, i don't follow here, for me scrolling-other-window or whatever is not possible from a yes-or-no-p prompt. I can do only yes or no (as expected). Did i miss something? BTW I have a version ov vc-revert that: "C-v: scroll-up, M-v: scroll-down, RET:revert, c:cancel" If interested let me know. -- A+ Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997 From unknown Wed Aug 20 03:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8927: 24.0.50; Flaw in C-x v u Resent-From: =?UTF-8?Q?=C3=93scar?= Fuentes Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jun 2011 22:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8927 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Thierry Volpiatto Cc: 8927@debbugs.gnu.org Received: via spool by 8927-submit@debbugs.gnu.org id=B8927.130912615210822 (code B ref 8927); Sun, 26 Jun 2011 22:10:02 +0000 Received: (at 8927) by debbugs.gnu.org; 26 Jun 2011 22:09:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QaxVw-0002oV-AD for submit@debbugs.gnu.org; Sun, 26 Jun 2011 18:09:12 -0400 Received: from impaqm2.telefonica.net ([213.4.138.18] helo=telefonica.net) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QaxVt-0002oE-5x for 8927@debbugs.gnu.org; Sun, 26 Jun 2011 18:09:11 -0400 Received: from IMPmailhost6.adm.correo ([10.20.102.127]) by IMPaqm2.telefonica.net with bizsmtp id 0m5g1h00C2kvMAa3Mm92Dl; Mon, 27 Jun 2011 00:09:02 +0200 Received: from qcore ([83.59.4.72]) by IMPmailhost6.adm.correo with BIZ IMP id 0m911h0041ZDhMP1mm91Sb; Mon, 27 Jun 2011 00:09:02 +0200 X-Brightmail-Tracker: AAAAAA== X-original-sender: 981711563@telefonica.net From: =?UTF-8?Q?=C3=93scar?= Fuentes References: <871uyhym2v.fsf@silenus.orebokech.com> <87boxkmlr1.fsf@stupidchicken.com> <87hb7cqn1s.fsf@gmail.com> Date: Mon, 27 Jun 2011 00:09:00 +0200 In-Reply-To: <87hb7cqn1s.fsf@gmail.com> (Thierry Volpiatto's message of "Sun, 26 Jun 2011 23:51:11 +0200") Message-ID: <8739iwutxf.fsf@wanadoo.es> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.0 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) Thierry Volpiatto writes: >>> Also, it's not true that the diff buffer cannot be scrolled from the >>> yes-or-no prompt as Chong mentioned earlier in this thread, >>> `scroll-other-window' and `scroll-other-window-down' work as expected. >> >> Ah yes, forgot about that; I seldom use that functionality. > > Sorry, i don't follow here, for me scrolling-other-window or whatever is > not possible from a yes-or-no-p prompt. > I can do only yes or no (as expected). > Did i miss something? scroll-other-window is bound to C-M-v, which works from the minibuffer. [snip] From unknown Wed Aug 20 03:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8927: 24.0.50; Flaw in C-x v u Resent-From: Richard Stallman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jun 2011 23:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8927 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: rgm@gnu.org, 8927@debbugs.gnu.org Reply-To: rms@gnu.org Received: via spool by 8927-submit@debbugs.gnu.org id=B8927.130913045231555 (code B ref 8927); Sun, 26 Jun 2011 23:21:01 +0000 Received: (at 8927) by debbugs.gnu.org; 26 Jun 2011 23:20:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QaydH-0008Cu-N0 for submit@debbugs.gnu.org; Sun, 26 Jun 2011 19:20:51 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QaydF-0008Ci-FR for 8927@debbugs.gnu.org; Sun, 26 Jun 2011 19:20:50 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Qayd9-0006BF-IT; Sun, 26 Jun 2011 19:20:43 -0400 Date: Sun, 26 Jun 2011 19:20:43 -0400 Message-Id: Content-Type: text/plain; charset=ISO-8859-15 From: Richard Stallman In-reply-to: (message from Stefan Monnier on Sun, 26 Jun 2011 09:10:04 -0400) References: X-Spam-Score: -6.6 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) > it has just created it. The fix for your problem would presumably be for > vc-revert to only kill the buffer if it did not exist beforehand. Right, that's the least we can do. If C-x v u does make and show a diff, it should do that in a different buffer, so as to preserve the old contents of *vc-diff*. Keeping that buffer but wiping its contents does not fix the problem. -- Dr Richard Stallman President, Free Software Foundation 51 Franklin St Boston MA 02110 USA www.fsf.org, www.gnu.org Skype: No way! That's nonfree (freedom-denying) software. Use free telephony http://directory.fsf.org/category/tel/ From unknown Wed Aug 20 03:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8927: 24.0.50; Flaw in C-x v u Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Jun 2011 04:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8927 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?=C3=93scar?= Fuentes Cc: 8927@debbugs.gnu.org Received: via spool by 8927-submit@debbugs.gnu.org id=B8927.130915017726650 (code B ref 8927); Mon, 27 Jun 2011 04:50:03 +0000 Received: (at 8927) by debbugs.gnu.org; 27 Jun 2011 04:49:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qb3lQ-0006vn-9C for submit@debbugs.gnu.org; Mon, 27 Jun 2011 00:49:36 -0400 Received: from mail-wy0-f172.google.com ([74.125.82.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qb3lN-0006va-Ip for 8927@debbugs.gnu.org; Mon, 27 Jun 2011 00:49:34 -0400 Received: by wyj26 with SMTP id 26so3025057wyj.3 for <8927@debbugs.gnu.org>; Sun, 26 Jun 2011 21:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=BFGtcALGXFerylUi6gOI3eXQMWgmbicjBQcRqSph+8Y=; b=wZqCpeMBi33oRw3ZxGXs2WhGvq6AhjeSq25eMe4DFgrWnVXxmjYR/kAnaQ9gX4mhyd mXDKrusRwGtLjIhY7LHbFb5k/3T2yHs3n7h2U1pvuqu81RZV4f/zbUkxpKHsFJ3ZfMJ+ 64pCv1+9LRP3gflFHLL7iVf3a7ocY1Hj0b8i4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type:content-transfer-encoding; b=atjYob2qsQ7UuelWGlmI6+jTVmx+l6oWyghL2TFN8KSCXlP6tpBYRMW5IkoQrrRe0r BeBFcfM9ROo6L8ZMaS+p4J0KO0+Ad6a4gnuG6zEuuCzQjkfJJv7LlxRxYBkGwsbVGCsn XKih+cXFRVA0mQyJBsSFhawgE/AmxOdc1xUhs= Received: by 10.216.238.32 with SMTP id z32mr527810weq.33.1309150166261; Sun, 26 Jun 2011 21:49:26 -0700 (PDT) Received: from thierry-MM061 (43.77.197.77.rev.sfr.net [77.197.77.43]) by mx.google.com with ESMTPS id g2sm2548463weg.14.2011.06.26.21.49.24 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 26 Jun 2011 21:49:25 -0700 (PDT) From: Thierry Volpiatto References: <871uyhym2v.fsf@silenus.orebokech.com> <87boxkmlr1.fsf@stupidchicken.com> <87hb7cqn1s.fsf@gmail.com> <8739iwutxf.fsf@wanadoo.es> Date: Mon, 27 Jun 2011 06:49:21 +0200 In-Reply-To: <8739iwutxf.fsf@wanadoo.es> ("=?UTF-8?Q?=C3=93scar?= Fuentes"'s message of "Mon, 27 Jun 2011 00:09:00 +0200") Message-ID: <87aad33mlq.fsf@gmail.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) =C3=93scar Fuentes writes: > Thierry Volpiatto writes: > >>>> Also, it's not true that the diff buffer cannot be scrolled from the >>>> yes-or-no prompt as Chong mentioned earlier in this thread, >>>> `scroll-other-window' and `scroll-other-window-down' work as expected. >>> >>> Ah yes, forgot about that; I seldom use that functionality. >> >> Sorry, i don't follow here, for me scrolling-other-window or whatever is >> not possible from a yes-or-no-p prompt. >> I can do only yes or no (as expected). >> Did i miss something? > > scroll-other-window is bound to C-M-v, which works from the minibuffer. I know C-M-v, but it doesn't work from the minibuffer in a y-or-n-p case. I guess some external library break this because it is working with emacs -Q. --=20 A+ Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997=20 From unknown Wed Aug 20 03:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8927: 24.0.50; Flaw in C-x v u In-Reply-To: Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Jun 2011 06:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8927 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 8927@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.130915706524707 (code B ref -1); Mon, 27 Jun 2011 06:45:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Jun 2011 06:44:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qb5YW-0006QS-LQ for submit@debbugs.gnu.org; Mon, 27 Jun 2011 02:44:24 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qb5YU-0006QG-3C for submit@debbugs.gnu.org; Mon, 27 Jun 2011 02:44:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qb5YN-00033D-Ju for submit@debbugs.gnu.org; Mon, 27 Jun 2011 02:44:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:53291) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qb5YN-000338-Ax for submit@debbugs.gnu.org; Mon, 27 Jun 2011 02:44:15 -0400 Received: from eggs.gnu.org ([140.186.70.92]:44536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qb5YL-0004i5-OG for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2011 02:44:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qb5YJ-00032R-26 for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2011 02:44:13 -0400 Received: from lo.gmane.org ([80.91.229.12]:54029) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qb5YI-000329-M1 for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2011 02:44:10 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Qb5YG-0007KS-RS for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2011 08:44:08 +0200 Received: from 43.77.197.77.rev.sfr.net ([77.197.77.43]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 27 Jun 2011 08:44:08 +0200 Received: from thierry.volpiatto by 43.77.197.77.rev.sfr.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 27 Jun 2011 08:44:08 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Thierry Volpiatto Date: Mon, 27 Jun 2011 08:43:57 +0200 Lines: 31 Message-ID: <87wrg7ojte.fsf@gmail.com> References: <871uyhym2v.fsf@silenus.orebokech.com> <87boxkmlr1.fsf@stupidchicken.com> <87hb7cqn1s.fsf@gmail.com> <8739iwutxf.fsf@wanadoo.es> <87aad33mlq.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 43.77.197.77.rev.sfr.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:30VXKGEASuzABjZODnZDB8H4dAE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) Thierry Volpiatto writes: > Óscar Fuentes writes: > >> Thierry Volpiatto writes: >> >>>>> Also, it's not true that the diff buffer cannot be scrolled from the >>>>> yes-or-no prompt as Chong mentioned earlier in this thread, >>>>> `scroll-other-window' and `scroll-other-window-down' work as expected. >>>> >>>> Ah yes, forgot about that; I seldom use that functionality. >>> >>> Sorry, i don't follow here, for me scrolling-other-window or whatever is >>> not possible from a yes-or-no-p prompt. >>> I can do only yes or no (as expected). >>> Did i miss something? >> >> scroll-other-window is bound to C-M-v, which works from the minibuffer. > I know C-M-v, but it doesn't work from the minibuffer in a y-or-n-p case. > I guess some external library break this because it is working with > emacs -Q. This is the culprit: (fset 'yes-or-no-p 'y-or-n-p) that was since a long time in my .emacs. -- A+ Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997 From unknown Wed Aug 20 03:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8927: 24.0.50; Flaw in C-x v u In-Reply-To: Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Jun 2011 06:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8927 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 8927@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.130915790428788 (code B ref -1); Mon, 27 Jun 2011 06:59:01 +0000 Received: (at submit) by debbugs.gnu.org; 27 Jun 2011 06:58:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qb5m3-0007UH-2M for submit@debbugs.gnu.org; Mon, 27 Jun 2011 02:58:23 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qb5m0-0007U4-1I for submit@debbugs.gnu.org; Mon, 27 Jun 2011 02:58:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qb5lt-0004ya-Ng for submit@debbugs.gnu.org; Mon, 27 Jun 2011 02:58:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:40526) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qb5lt-0004yW-De for submit@debbugs.gnu.org; Mon, 27 Jun 2011 02:58:13 -0400 Received: from eggs.gnu.org ([140.186.70.92]:59729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qb5lr-0006m8-Kx for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2011 02:58:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qb5lp-0004yE-IR for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2011 02:58:11 -0400 Received: from lo.gmane.org ([80.91.229.12]:35351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qb5lp-0004y4-3j for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2011 02:58:09 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Qb5ln-0003bF-Ax for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2011 08:58:07 +0200 Received: from 43.77.197.77.rev.sfr.net ([77.197.77.43]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 27 Jun 2011 08:58:07 +0200 Received: from thierry.volpiatto by 43.77.197.77.rev.sfr.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 27 Jun 2011 08:58:07 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Thierry Volpiatto Date: Mon, 27 Jun 2011 08:57:55 +0200 Lines: 42 Message-ID: <87sjqvoj64.fsf@gmail.com> References: <871uyhym2v.fsf@silenus.orebokech.com> <87boxkmlr1.fsf@stupidchicken.com> <87hb7cqn1s.fsf@gmail.com> <8739iwutxf.fsf@wanadoo.es> <87aad33mlq.fsf@gmail.com> <87wrg7ojte.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 43.77.197.77.rev.sfr.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:zzPqR7epGlN6gRAIpidISOTm03o= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) Thierry Volpiatto writes: > Thierry Volpiatto writes: > >> Óscar Fuentes writes: >> >>> Thierry Volpiatto writes: >>> >>>>>> Also, it's not true that the diff buffer cannot be scrolled from the >>>>>> yes-or-no prompt as Chong mentioned earlier in this thread, >>>>>> `scroll-other-window' and `scroll-other-window-down' work as expected. >>>>> >>>>> Ah yes, forgot about that; I seldom use that functionality. >>>> >>>> Sorry, i don't follow here, for me scrolling-other-window or whatever is >>>> not possible from a yes-or-no-p prompt. >>>> I can do only yes or no (as expected). >>>> Did i miss something? >>> >>> scroll-other-window is bound to C-M-v, which works from the minibuffer. >> I know C-M-v, but it doesn't work from the minibuffer in a y-or-n-p case. >> I guess some external library break this because it is working with >> emacs -Q. > This is the culprit: > > (fset 'yes-or-no-p 'y-or-n-p) > > that was since a long time in my .emacs. NOTE: yes-or-no-p: yes-or-no-p is a built-in function in `fns.c'. It support scrolling y-or-n-p: y-or-n-p is a compiled Lisp function in `subr.el'. It doesn't support scrolling. -- A+ Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997