From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 05:00:10 2011 Received: (at submit) by debbugs.gnu.org; 21 Jun 2011 09:00:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QYwoX-0006XN-4M for submit@debbugs.gnu.org; Tue, 21 Jun 2011 05:00:10 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QYvfa-0001lx-9v for submit@debbugs.gnu.org; Tue, 21 Jun 2011 03:46:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QYvfT-0002cQ-VR for submit@debbugs.gnu.org; Tue, 21 Jun 2011 03:46:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:59864) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYvfT-0002cK-O2 for submit@debbugs.gnu.org; Tue, 21 Jun 2011 03:46:39 -0400 Received: from eggs.gnu.org ([140.186.70.92]:35709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYvfQ-0005Xx-Il for bug-coreutils@gnu.org; Tue, 21 Jun 2011 03:46:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QYvfO-0002bH-97 for bug-coreutils@gnu.org; Tue, 21 Jun 2011 03:46:36 -0400 Received: from moutng.kundenserver.de ([212.227.17.9]:61325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYvfN-0002aF-HU for bug-coreutils@gnu.org; Tue, 21 Jun 2011 03:46:34 -0400 Received: from [192.168.2.108] (p57B26E51.dip.t-dialin.net [87.178.110.81]) by mrelayeu.kundenserver.de (node=mreu3) with ESMTP (Nemesis) id 0LgBEG-1RMbxa0Wc0-00nh9M; Tue, 21 Jun 2011 09:46:30 +0200 Message-ID: <4E004C55.9000006@bernhard-voelker.de> Date: Tue, 21 Jun 2011 09:46:29 +0200 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110414 SUSE/3.1.10 Thunderbird/3.1.10 MIME-Version: 1.0 To: bug-coreutils@gnu.org Subject: tests/ls/stat-free-color: fails on OpenSuSE 11.4 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:PQgxfy3yVZ60G73TX9NTl+2OFuBi8XpJGV+p2/4u5Kj KUSL2c2yrUCUr1xy+QevUw+f0dDjEITj3w7PTv4wwmzu9SZlE6 x3pBOwsDwdS0PB84TufYzyvNZW4Fj1TT6dSi9JR77F2txlqXGE BgnQQ3uzYK/pI0aCk7aQj8knAbPlhL4Ag3dZCpIepVy9Qx8TDW hHgRbpcLG50O7+zCKmpOU76DF1hIIy+t9nabjaFxx0= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 21 Jun 2011 05:00:03 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Hi, `make check` of coreutils.git (latest commit is 18bd9ce40ae05d52543fc9c5a5fdf4f82d13068d) on an OpenSuSE 11.4 host fails (everything else was ok/skipped): FAIL: ls/stat-free-color (exit: 1) ================================== ++ initial_cwd_=/home/berny/coreutils/tests ++ fail=0 +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /home/berny/coreutils/tests gt-stat-free-color.XXXX +++ case $# in +++ destdir_=/home/berny/coreutils/tests +++ template_=gt-stat-free-color.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ case $template_ in ++++ unset TMPDIR ++++ mktemp -d -t -p /home/berny/coreutils/tests gt-stat-free-color.XXXX +++ d=/home/berny/coreutils/tests/gt-stat-free-color.07ux +++ case $d in +++ test -d /home/berny/coreutils/tests/gt-stat-free-color.07ux ++++ ls -dgo /home/berny/coreutils/tests/gt-stat-free-color.07ux ++++ tr S - +++ perms='drwx------ 2 4096 Jun 21 09:24 /home/berny/coreutils/tests/gt-stat-free-color.07ux' +++ case $perms in +++ test 0 = 0 +++ echo /home/berny/coreutils/tests/gt-stat-free-color.07ux +++ return ++ test_dir_=/home/berny/coreutils/tests/gt-stat-free-color.07ux ++ cd /home/berny/coreutils/tests/gt-stat-free-color.07ux ++ gl_init_sh_nl_=' ' ++ IFS=' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ../src + test 1 '!=' 0 + path_dir_=../src + case $path_dir_ in ++ cd /home/berny/coreutils/tests/../src ++ echo /home/berny/coreutils/src + abs_path_dir_=/home/berny/coreutils/src + case $abs_path_dir_ in + PATH=/home/berny/coreutils/src:/home/berny/coreutils/src:/usr/lib64/mpi/gcc/openmpi/bin:/home/berny/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/X11R6/bin:/usr/games:/usr/lib64/jvm/jre/bin + create_exe_shims_ /home/berny/coreutils/src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + print_ver_ ls + test yes = yes + local i + for i in '$*' + env ls --version ls (GNU coreutils) 8.12.99-18bd Copyright (C) 2011 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Richard M. Stallman and David MacKenzie. + require_strace_ stat + test 1 = 1 + strace -V + strace -qe stat echo + require_dirent_d_type_ + python + python /home/berny/coreutils/tests/d_type-check + for i in 1 2 3 + ln -s nowhere dangle-1 + for i in 1 2 3 + ln -s nowhere dangle-2 + for i in 1 2 3 + ln -s nowhere dangle-3 + cat ++ dircolors -b color-without-stat + eval 'LS_COLORS='\''rs=0:di=01;34:ln=01;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=00:su=00:sg=00:ca=00:tw=00:ow=00:st=00:ex=00:mh=00:'\'';' export LS_COLORS ++ LS_COLORS='rs=0:di=01;34:ln=01;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=00:su=00:sg=00:ca=00:tw=00:ow=00:st=00:ex=00:mh=00:' ++ export LS_COLORS + strace -o log -e stat,lstat,stat64,lstat64 ls --color=always . color-without-stat dangle-1 dangle-2 dangle-3 log ++ wc -l + n_lines=5 + case $n_lines in + fail=1 + Exit 1 + set +e + exit 1 + exit 1 + remove_tmp_ + __st=1 + cleanup_ + : + cd /home/berny/coreutils/tests + chmod -R u+rwx /home/berny/coreutils/tests/gt-stat-free-color.07ux + rm -rf /home/berny/coreutils/tests/gt-stat-free-color.07ux + exit 1 How can I help? Have a nice day, Berny From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 09:41:56 2011 Received: (at 8909) by debbugs.gnu.org; 21 Jun 2011 13:41:56 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QZ1DI-0002tx-0v for submit@debbugs.gnu.org; Tue, 21 Jun 2011 09:41:56 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QZ1DG-0002ti-2j for 8909@debbugs.gnu.org; Tue, 21 Jun 2011 09:41:55 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 43736600E1; Tue, 21 Jun 2011 15:41:47 +0200 (CEST) From: Jim Meyering To: Bernhard Voelker Subject: Re: bug#8909: tests/ls/stat-free-color: fails on OpenSuSE 11.4 In-Reply-To: <4E004C55.9000006@bernhard-voelker.de> (Bernhard Voelker's message of "Tue, 21 Jun 2011 09:46:29 +0200") References: <4E004C55.9000006@bernhard-voelker.de> Date: Tue, 21 Jun 2011 15:41:47 +0200 Message-ID: <8739j3z4h0.fsf@rho.meyering.net> Lines: 48 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: 8909 Cc: 8909@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Bernhard Voelker wrote: ... > LS_COLORS='rs=0:di=01;34:ln=01;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=00:su=00:sg=00:ca=00:tw=00:ow=00:st=00:ex=00:mh=00:' > ++ export LS_COLORS > + strace -o log -e stat,lstat,stat64,lstat64 ls --color=always . > color-without-stat > dangle-1 > dangle-2 > dangle-3 > log > ++ wc -l > + n_lines=5 > + case $n_lines in > + fail=1 ... > How can I help? Thanks for testing and the report. If you apply the patch below and rerun the test like this, make check -C tests TESTS=ls/stat-free-color VERBOSE=yes then the offending strace output should help understand where the extra stat calls are coming from. For reference, I get this single call on Fedora 15: stat(".", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0 diff --git a/tests/ls/stat-free-color b/tests/ls/stat-free-color index b1c4744..a1f6418 100755 --- a/tests/ls/stat-free-color +++ b/tests/ls/stat-free-color @@ -55,7 +55,7 @@ n_lines=$(wc -l < log) # Expect one or two stat calls. case $n_lines in 1|2) ;; - *) fail=1 ;; + *) fail=1; cat log;; esac Exit $fail -------------------------- It might be useful to see the entire strace output, too. To get that, remove the "-e stat,lstat,stat64,lstat64" argument from the strace invocation, and rerun the test. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 10:06:12 2011 Received: (at 8909) by debbugs.gnu.org; 21 Jun 2011 14:06:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QZ1al-00055F-Az for submit@debbugs.gnu.org; Tue, 21 Jun 2011 10:06:12 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QZ1ad-00054c-N0 for 8909@debbugs.gnu.org; Tue, 21 Jun 2011 10:06:09 -0400 Received: from [192.168.2.108] (p57B26E51.dip.t-dialin.net [87.178.110.81]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0M6PCF-1RXCj11mH5-00xhPG; Tue, 21 Jun 2011 16:05:56 +0200 Message-ID: <4E00A543.5060403@bernhard-voelker.de> Date: Tue, 21 Jun 2011 16:05:55 +0200 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110414 SUSE/3.1.10 Thunderbird/3.1.10 MIME-Version: 1.0 To: Jim Meyering Subject: Re: bug#8909: tests/ls/stat-free-color: fails on OpenSuSE 11.4 References: <4E004C55.9000006@bernhard-voelker.de> <8739j3z4h0.fsf@rho.meyering.net> In-Reply-To: <8739j3z4h0.fsf@rho.meyering.net> Content-Type: multipart/mixed; boundary="------------060304000404010301090008" X-Provags-ID: V02:K0:ZjAX6XTy1IRb6Nbfe0iiL0BAsCPXDBXxCKRZDksIEr5 wJkTB3U6NxzQl6LvQxjw1c1uz1u/sy2fFzbzYLrxbSdclqvr8V WKSFZDHVRuMTzwI4D1HC7uI+e6qG6gzK9HdZMYr79jzUM32rd5 2TykP3h8OlelrpcCPAh/XNW4WGiXPqMtxpQhx172kLw/f+7sAB OcZzJjeiFK3lje2/IA1Qtb8L4nuMM5zsAFK5mY26vA= X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: 8909 Cc: 8909@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) This is a multi-part message in MIME format. --------------060304000404010301090008 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 06/21/2011 03:41 PM, Jim Meyering wrote: > Bernhard Voelker wrote: > ... >> LS_COLORS='rs=0:di=01;34:ln=01;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=00:su=00:sg=00:ca=00:tw=00:ow=00:st=00:ex=00:mh=00:' >> ++ export LS_COLORS >> + strace -o log -e stat,lstat,stat64,lstat64 ls --color=always . >> color-without-stat >> dangle-1 >> dangle-2 >> dangle-3 >> log >> ++ wc -l >> + n_lines=5 >> + case $n_lines in >> + fail=1 > ... >> How can I help? > > Thanks for testing and the report. > If you apply the patch below and rerun the test like this, > > make check -C tests TESTS=ls/stat-free-color VERBOSE=yes > > then the offending strace output should help understand where > the extra stat calls are coming from. > > For reference, I get this single call on Fedora 15: > > stat(".", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0 > > diff --git a/tests/ls/stat-free-color b/tests/ls/stat-free-color > index b1c4744..a1f6418 100755 > --- a/tests/ls/stat-free-color > +++ b/tests/ls/stat-free-color > @@ -55,7 +55,7 @@ n_lines=$(wc -l< log) > # Expect one or two stat calls. > case $n_lines in > 1|2) ;; > - *) fail=1 ;; > + *) fail=1; cat log;; > esac > > Exit $fail > > -------------------------- > > It might be useful to see the entire strace output, too. > To get that, remove the "-e stat,lstat,stat64,lstat64" argument > from the strace invocation, and rerun the test. The output of both runs is attached. stat("/usr/lib64/mpi/gcc/openmpi/lib64") and friends is the culprit. I can't remember to have anything un-OpenSuSE-11.4-like in my toolchain. To me it seems that the test should count the difference of the number of stat,lstat,stat64,lstat64 calls when run a) as a dummy: ls --color=always --help and b) for ".": ls --color=always . Have a nice day, Berny --------------060304000404010301090008 Content-Type: text/plain; name="ls.stat-free-color.all.out" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="ls.stat-free-color.all.out" make: Entering directory `/media/sdb5/berny/coreutils/tests' make check-TESTS make[1]: Entering directory `/media/sdb5/berny/coreutils/tests' make[2]: Entering directory `/media/sdb5/berny/coreutils/tests' FAIL: ls/stat-free-color ====================================================== GNU coreutils 8.12.99-18bd: tests/test-suite.log ====================================================== 1 of 1 test failed. .. contents:: :depth: 2 FAIL: ls/stat-free-color (exit: 1) ================================== ++ initial_cwd_=/media/sdb5/berny/coreutils/tests ++ fail=0 +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /media/sdb5/berny/coreutils/tests gt-stat-free-color.XXXX +++ case $# in +++ destdir_=/media/sdb5/berny/coreutils/tests +++ template_=gt-stat-free-color.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ case $template_ in ++++ unset TMPDIR ++++ mktemp -d -t -p /media/sdb5/berny/coreutils/tests gt-stat-free-color.XXXX +++ d=/media/sdb5/berny/coreutils/tests/gt-stat-free-color.2L9D +++ case $d in +++ test -d /media/sdb5/berny/coreutils/tests/gt-stat-free-color.2L9D ++++ ls -dgo /media/sdb5/berny/coreutils/tests/gt-stat-free-color.2L9D ++++ tr S - +++ perms='drwx------ 2 4096 Jun 21 15:51 /media/sdb5/berny/coreutils/tests/gt-stat-free-color.2L9D' +++ case $perms in +++ test 0 = 0 +++ echo /media/sdb5/berny/coreutils/tests/gt-stat-free-color.2L9D +++ return ++ test_dir_=/media/sdb5/berny/coreutils/tests/gt-stat-free-color.2L9D ++ cd /media/sdb5/berny/coreutils/tests/gt-stat-free-color.2L9D ++ gl_init_sh_nl_=' ' ++ IFS=' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ../src + test 1 '!=' 0 + path_dir_=../src + case $path_dir_ in ++ cd /media/sdb5/berny/coreutils/tests/../src ++ echo /media/sdb5/berny/coreutils/src + abs_path_dir_=/media/sdb5/berny/coreutils/src + case $abs_path_dir_ in + PATH=/media/sdb5/berny/coreutils/src:/home/berny/coreutils/src:/usr/lib64/mpi/gcc/openmpi/bin:/home/berny/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/X11R6/bin:/usr/games:/usr/lib64/jvm/jre/bin + create_exe_shims_ /media/sdb5/berny/coreutils/src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + print_ver_ ls + test yes = yes + local i + for i in '$*' + env ls --version ls (GNU coreutils) 8.12.99-18bd Copyright (C) 2011 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Richard M. Stallman and David MacKenzie. + require_strace_ stat + test 1 = 1 + strace -V + strace -qe stat echo + require_dirent_d_type_ + python + python /home/berny/coreutils/tests/d_type-check + for i in 1 2 3 + ln -s nowhere dangle-1 + for i in 1 2 3 + ln -s nowhere dangle-2 + for i in 1 2 3 + ln -s nowhere dangle-3 + cat ++ dircolors -b color-without-stat + eval 'LS_COLORS='\''rs=0:di=01;34:ln=01;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=00:su=00:sg=00:ca=00:tw=00:ow=00:st=00:ex=00:mh=00:'\'';' export LS_COLORS ++ LS_COLORS='rs=0:di=01;34:ln=01;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=00:su=00:sg=00:ca=00:tw=00:ow=00:st=00:ex=00:mh=00:' ++ export LS_COLORS + strace -o log ls --color=always . color-without-stat dangle-1 dangle-2 dangle-3 log ++ wc -l + n_lines=81 + case $n_lines in + fail=1 + cat log execve("/media/sdb5/berny/coreutils/src/ls", ["ls", "--color=always", "."], [/* 112 vars */]) = 0 brk(0) = 0x61e000 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fe74c75f000 access("/etc/ld.so.preload", R_OK) = -1 ENOENT (No such file or directory) open("/usr/lib64/mpi/gcc/openmpi/lib64/tls/x86_64/librt.so.1", O_RDONLY) = -1 ENOENT (No such file or directory) stat("/usr/lib64/mpi/gcc/openmpi/lib64/tls/x86_64", 0x7fffaa485600) = -1 ENOENT (No such file or directory) open("/usr/lib64/mpi/gcc/openmpi/lib64/tls/librt.so.1", O_RDONLY) = -1 ENOENT (No such file or directory) stat("/usr/lib64/mpi/gcc/openmpi/lib64/tls", 0x7fffaa485600) = -1 ENOENT (No such file or directory) open("/usr/lib64/mpi/gcc/openmpi/lib64/x86_64/librt.so.1", O_RDONLY) = -1 ENOENT (No such file or directory) stat("/usr/lib64/mpi/gcc/openmpi/lib64/x86_64", 0x7fffaa485600) = -1 ENOENT (No such file or directory) open("/usr/lib64/mpi/gcc/openmpi/lib64/librt.so.1", O_RDONLY) = -1 ENOENT (No such file or directory) stat("/usr/lib64/mpi/gcc/openmpi/lib64", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0 open("/etc/ld.so.cache", O_RDONLY) = 3 fstat(3, {st_mode=S_IFREG|0644, st_size=115701, ...}) = 0 mmap(NULL, 115701, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7fe74c742000 close(3) = 0 open("/lib64/librt.so.1", O_RDONLY) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\340\"\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0755, st_size=47329, ...}) = 0 mmap(NULL, 2133008, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7fe74c33a000 fadvise64(3, 0, 2133008, POSIX_FADV_WILLNEED) = 0 mprotect(0x7fe74c342000, 2093056, PROT_NONE) = 0 mmap(0x7fe74c541000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x7000) = 0x7fe74c541000 close(3) = 0 open("/usr/lib64/mpi/gcc/openmpi/lib64/libc.so.6", O_RDONLY) = -1 ENOENT (No such file or directory) open("/lib64/libc.so.6", O_RDONLY) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\20\355\1\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0755, st_size=1725484, ...}) = 0 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fe74c741000 mmap(NULL, 3591144, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7fe74bfcd000 fadvise64(3, 0, 3591144, POSIX_FADV_WILLNEED) = 0 mprotect(0x7fe74c131000, 2093056, PROT_NONE) = 0 mmap(0x7fe74c330000, 20480, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x163000) = 0x7fe74c330000 mmap(0x7fe74c335000, 19432, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7fe74c335000 close(3) = 0 open("/usr/lib64/mpi/gcc/openmpi/lib64/libpthread.so.0", O_RDONLY) = -1 ENOENT (No such file or directory) open("/lib64/libpthread.so.0", O_RDONLY) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0 Z\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0755, st_size=135934, ...}) = 0 mmap(NULL, 2212736, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7fe74bdb0000 fadvise64(3, 0, 2212736, POSIX_FADV_WILLNEED) = 0 mprotect(0x7fe74bdc7000, 2097152, PROT_NONE) = 0 mmap(0x7fe74bfc7000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x17000) = 0x7fe74bfc7000 mmap(0x7fe74bfc9000, 13184, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7fe74bfc9000 close(3) = 0 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fe74c740000 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fe74c73f000 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fe74c73e000 arch_prctl(ARCH_SET_FS, 0x7fe74c73f700) = 0 mprotect(0x7fe74bfc7000, 4096, PROT_READ) = 0 mprotect(0x7fe74c330000, 16384, PROT_READ) = 0 mprotect(0x7fe74c541000, 4096, PROT_READ) = 0 mprotect(0x61b000, 4096, PROT_READ) = 0 mprotect(0x7fe74c760000, 4096, PROT_READ) = 0 munmap(0x7fe74c742000, 115701) = 0 set_tid_address(0x7fe74c73f9d0) = 8611 set_robust_list(0x7fe74c73f9e0, 0x18) = 0 futex(0x7fffaa485e5c, FUTEX_WAKE_PRIVATE, 1) = 0 futex(0x7fffaa485e5c, FUTEX_WAIT_BITSET_PRIVATE|FUTEX_CLOCK_REALTIME, 1, NULL, 7fe74c73f700) = -1 EAGAIN (Resource temporarily unavailable) rt_sigaction(SIGRTMIN, {0x7fe74bdb54a0, [], SA_RESTORER|SA_SIGINFO, 0x7fe74bdbf2d0}, NULL, 8) = 0 rt_sigaction(SIGRT_1, {0x7fe74bdb5530, [], SA_RESTORER|SA_RESTART|SA_SIGINFO, 0x7fe74bdbf2d0}, NULL, 8) = 0 rt_sigprocmask(SIG_UNBLOCK, [RTMIN RT_1], NULL, 8) = 0 getrlimit(RLIMIT_STACK, {rlim_cur=8192*1024, rlim_max=RLIM_INFINITY}) = 0 brk(0) = 0x61e000 brk(0x63f000) = 0x63f000 ioctl(1, SNDCTL_TMR_TIMEBASE or TCGETS, 0x7fffaa4859e0) = -1 ENOTTY (Inappropriate ioctl for device) ioctl(1, TIOCGWINSZ, 0x7fffaa485e00) = -1 ENOTTY (Inappropriate ioctl for device) ioctl(1, TIOCGPGRP, [32743]) = -1 ENOTTY (Inappropriate ioctl for device) stat(".", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0 open(".", O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC) = 3 fcntl(3, F_GETFD) = 0x1 (flags FD_CLOEXEC) getdents64(3, /* 7 entries */, 32768) = 208 getdents64(3, /* 0 entries */, 32768) = 0 close(3) = 0 fstat(1, {st_mode=S_IFREG|0644, st_size=3248, ...}) = 0 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fe74c75e000 write(1, "color-without-stat\n\33[0m\33[01;36md"..., 90) = 90 close(1) = 0 munmap(0x7fe74c75e000, 4096) = 0 close(2) = 0 exit_group(0) = ? + Exit 1 + set +e + exit 1 + exit 1 + remove_tmp_ + __st=1 + cleanup_ + : + cd /media/sdb5/berny/coreutils/tests + chmod -R u+rwx /media/sdb5/berny/coreutils/tests/gt-stat-free-color.2L9D + rm -rf /media/sdb5/berny/coreutils/tests/gt-stat-free-color.2L9D + exit 1 ====================================== 1 of 1 test failed See tests/test-suite.log Please report to bug-coreutils@gnu.org ====================================== make[2]: *** [test-suite.log] Error 1 make[2]: Leaving directory `/media/sdb5/berny/coreutils/tests' make[1]: *** [check-TESTS] Error 2 make[1]: Leaving directory `/media/sdb5/berny/coreutils/tests' make: *** [check-am] Error 2 make: Leaving directory `/media/sdb5/berny/coreutils/tests' --------------060304000404010301090008 Content-Type: text/plain; name="ls.stat-free-color.out" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="ls.stat-free-color.out" make: Entering directory `/media/sdb5/berny/coreutils/tests' make check-TESTS make[1]: Entering directory `/media/sdb5/berny/coreutils/tests' make[2]: Entering directory `/media/sdb5/berny/coreutils/tests' FAIL: ls/stat-free-color ====================================================== GNU coreutils 8.12.99-18bd: tests/test-suite.log ====================================================== 1 of 1 test failed. .. contents:: :depth: 2 FAIL: ls/stat-free-color (exit: 1) ================================== ++ initial_cwd_=/media/sdb5/berny/coreutils/tests ++ fail=0 +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /media/sdb5/berny/coreutils/tests gt-stat-free-color.XXXX +++ case $# in +++ destdir_=/media/sdb5/berny/coreutils/tests +++ template_=gt-stat-free-color.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ case $template_ in ++++ unset TMPDIR ++++ mktemp -d -t -p /media/sdb5/berny/coreutils/tests gt-stat-free-color.XXXX +++ d=/media/sdb5/berny/coreutils/tests/gt-stat-free-color.096N +++ case $d in +++ test -d /media/sdb5/berny/coreutils/tests/gt-stat-free-color.096N ++++ ls -dgo /media/sdb5/berny/coreutils/tests/gt-stat-free-color.096N ++++ tr S - +++ perms='drwx------ 2 4096 Jun 21 15:50 /media/sdb5/berny/coreutils/tests/gt-stat-free-color.096N' +++ case $perms in +++ test 0 = 0 +++ echo /media/sdb5/berny/coreutils/tests/gt-stat-free-color.096N +++ return ++ test_dir_=/media/sdb5/berny/coreutils/tests/gt-stat-free-color.096N ++ cd /media/sdb5/berny/coreutils/tests/gt-stat-free-color.096N ++ gl_init_sh_nl_=' ' ++ IFS=' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ../src + test 1 '!=' 0 + path_dir_=../src + case $path_dir_ in ++ cd /media/sdb5/berny/coreutils/tests/../src ++ echo /media/sdb5/berny/coreutils/src + abs_path_dir_=/media/sdb5/berny/coreutils/src + case $abs_path_dir_ in + PATH=/media/sdb5/berny/coreutils/src:/home/berny/coreutils/src:/usr/lib64/mpi/gcc/openmpi/bin:/home/berny/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/X11R6/bin:/usr/games:/usr/lib64/jvm/jre/bin + create_exe_shims_ /media/sdb5/berny/coreutils/src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + print_ver_ ls + test yes = yes + local i + for i in '$*' + env ls --version ls (GNU coreutils) 8.12.99-18bd Copyright (C) 2011 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Richard M. Stallman and David MacKenzie. + require_strace_ stat + test 1 = 1 + strace -V + strace -qe stat echo + require_dirent_d_type_ + python + python /home/berny/coreutils/tests/d_type-check + for i in 1 2 3 + ln -s nowhere dangle-1 + for i in 1 2 3 + ln -s nowhere dangle-2 + for i in 1 2 3 + ln -s nowhere dangle-3 + cat ++ dircolors -b color-without-stat + eval 'LS_COLORS='\''rs=0:di=01;34:ln=01;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=00:su=00:sg=00:ca=00:tw=00:ow=00:st=00:ex=00:mh=00:'\'';' export LS_COLORS ++ LS_COLORS='rs=0:di=01;34:ln=01;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=00:su=00:sg=00:ca=00:tw=00:ow=00:st=00:ex=00:mh=00:' ++ export LS_COLORS + strace -o log -e stat,lstat,stat64,lstat64 ls --color=always . color-without-stat dangle-1 dangle-2 dangle-3 log ++ wc -l + n_lines=5 + case $n_lines in + fail=1 + cat log stat("/usr/lib64/mpi/gcc/openmpi/lib64/tls/x86_64", 0x7fffa2b83bf0) = -1 ENOENT (No such file or directory) stat("/usr/lib64/mpi/gcc/openmpi/lib64/tls", 0x7fffa2b83bf0) = -1 ENOENT (No such file or directory) stat("/usr/lib64/mpi/gcc/openmpi/lib64/x86_64", 0x7fffa2b83bf0) = -1 ENOENT (No such file or directory) stat("/usr/lib64/mpi/gcc/openmpi/lib64", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0 stat(".", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0 + Exit 1 + set +e + exit 1 + exit 1 + remove_tmp_ + __st=1 + cleanup_ + : + cd /media/sdb5/berny/coreutils/tests + chmod -R u+rwx /media/sdb5/berny/coreutils/tests/gt-stat-free-color.096N + rm -rf /media/sdb5/berny/coreutils/tests/gt-stat-free-color.096N + exit 1 ====================================== 1 of 1 test failed See tests/test-suite.log Please report to bug-coreutils@gnu.org ====================================== make[2]: *** [test-suite.log] Error 1 make[2]: Leaving directory `/media/sdb5/berny/coreutils/tests' make[1]: *** [check-TESTS] Error 2 make[1]: Leaving directory `/media/sdb5/berny/coreutils/tests' make: *** [check-am] Error 2 make: Leaving directory `/media/sdb5/berny/coreutils/tests' --------------060304000404010301090008-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 10:16:53 2011 Received: (at 8909) by debbugs.gnu.org; 21 Jun 2011 14:16:53 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QZ1l7-00065e-3h for submit@debbugs.gnu.org; Tue, 21 Jun 2011 10:16:53 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QZ1l5-00065R-4D for 8909@debbugs.gnu.org; Tue, 21 Jun 2011 10:16:52 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 9038F60201; Tue, 21 Jun 2011 16:16:45 +0200 (CEST) From: Jim Meyering To: Bernhard Voelker Subject: Re: bug#8909: tests/ls/stat-free-color: fails on OpenSuSE 11.4 In-Reply-To: <4E00A543.5060403@bernhard-voelker.de> (Bernhard Voelker's message of "Tue, 21 Jun 2011 16:05:55 +0200") References: <4E004C55.9000006@bernhard-voelker.de> <8739j3z4h0.fsf@rho.meyering.net> <4E00A543.5060403@bernhard-voelker.de> Date: Tue, 21 Jun 2011 16:16:45 +0200 Message-ID: <87r56nxoaa.fsf@rho.meyering.net> Lines: 118 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: 8909 Cc: 8909@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Bernhard Voelker wrote: > On 06/21/2011 03:41 PM, Jim Meyering wrote: >> Bernhard Voelker wrote: >> ... >>> LS_COLORS='rs=0:di=01;34:ln=01;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=00:su=00:sg=00:ca=00:tw=00:ow=00:st=00:ex=00:mh=00:' >>> ++ export LS_COLORS >>> + strace -o log -e stat,lstat,stat64,lstat64 ls --color=always . >>> color-without-stat >>> dangle-1 >>> dangle-2 >>> dangle-3 >>> log >>> ++ wc -l >>> + n_lines=5 >>> + case $n_lines in >>> + fail=1 >> ... >>> How can I help? >> >> Thanks for testing and the report. >> If you apply the patch below and rerun the test like this, >> >> make check -C tests TESTS=ls/stat-free-color VERBOSE=yes >> >> then the offending strace output should help understand where >> the extra stat calls are coming from. >> >> For reference, I get this single call on Fedora 15: >> >> stat(".", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0 >> >> diff --git a/tests/ls/stat-free-color b/tests/ls/stat-free-color >> index b1c4744..a1f6418 100755 >> --- a/tests/ls/stat-free-color >> +++ b/tests/ls/stat-free-color >> @@ -55,7 +55,7 @@ n_lines=$(wc -l< log) >> # Expect one or two stat calls. >> case $n_lines in >> 1|2) ;; >> - *) fail=1 ;; >> + *) fail=1; cat log;; >> esac >> >> Exit $fail >> >> -------------------------- >> >> It might be useful to see the entire strace output, too. >> To get that, remove the "-e stat,lstat,stat64,lstat64" argument >> from the strace invocation, and rerun the test. > > The output of both runs is attached. > stat("/usr/lib64/mpi/gcc/openmpi/lib64") and friends is the culprit. Thanks. > I can't remember to have anything un-OpenSuSE-11.4-like in my toolchain. > > To me it seems that the test should count the difference of the > number of stat,lstat,stat64,lstat64 calls when run > a) as a dummy: ls --color=always --help > and > b) for ".": ls --color=always . That would be more robust. Do you feel like writing the patch? ... > + cat log > execve("/media/sdb5/berny/coreutils/src/ls", ["ls", "--color=always", > "."], [/* 112 vars */]) = 0 > brk(0) = 0x61e000 > mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, > 0) = 0x7fe74c75f000 > access("/etc/ld.so.preload", R_OK) = -1 ENOENT (No such file or directory) > open("/usr/lib64/mpi/gcc/openmpi/lib64/tls/x86_64/librt.so.1", > O_RDONLY) = -1 ENOENT (No such file or directory) > stat("/usr/lib64/mpi/gcc/openmpi/lib64/tls/x86_64", 0x7fffaa485600) = > -1 ENOENT (No such file or directory) > open("/usr/lib64/mpi/gcc/openmpi/lib64/tls/librt.so.1", O_RDONLY) = -1 > ENOENT (No such file or directory) > stat("/usr/lib64/mpi/gcc/openmpi/lib64/tls", 0x7fffaa485600) = -1 > ENOENT (No such file or directory) > open("/usr/lib64/mpi/gcc/openmpi/lib64/x86_64/librt.so.1", O_RDONLY) = > -1 ENOENT (No such file or directory) > stat("/usr/lib64/mpi/gcc/openmpi/lib64/x86_64", 0x7fffaa485600) = -1 > ENOENT (No such file or directory) > open("/usr/lib64/mpi/gcc/openmpi/lib64/librt.so.1", O_RDONLY) = -1 > ENOENT (No such file or directory) > stat("/usr/lib64/mpi/gcc/openmpi/lib64", {st_mode=S_IFDIR|0755, > st_size=4096, ...}) = 0 > open("/etc/ld.so.cache", O_RDONLY) = 3 > fstat(3, {st_mode=S_IFREG|0644, st_size=115701, ...}) = 0 > mmap(NULL, 115701, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7fe74c742000 > close(3) = 0 > open("/lib64/librt.so.1", O_RDONLY) = 3 > read(3, > "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\340\"\0\0\0\0\0\0"..., > 832) = 832 > fstat(3, {st_mode=S_IFREG|0755, st_size=47329, ...}) = 0 > mmap(NULL, 2133008, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, > 0) = 0x7fe74c33a000 > fadvise64(3, 0, 2133008, POSIX_FADV_WILLNEED) = 0 > mprotect(0x7fe74c342000, 2093056, PROT_NONE) = 0 > mmap(0x7fe74c541000, 8192, PROT_READ|PROT_WRITE, > MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x7000) = 0x7fe74c541000 > close(3) = 0 > open("/usr/lib64/mpi/gcc/openmpi/lib64/libc.so.6", O_RDONLY) = -1 > ENOENT (No such file or directory) > open("/lib64/libc.so.6", O_RDONLY) = 3 > read(3, > "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\20\355\1\0\0\0\0\0"..., > 832) = 832 > fstat(3, {st_mode=S_IFREG|0755, st_size=1725484, ...}) = 0 > mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, > 0) = 0x7fe74c741000 > mmap(NULL, 3591144, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, > 0) = 0x7fe74bfcd000 From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 10:51:46 2011 Received: (at 8909) by debbugs.gnu.org; 21 Jun 2011 14:51:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QZ2Ir-0008RK-Ta for submit@debbugs.gnu.org; Tue, 21 Jun 2011 10:51:46 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QZ2Ip-0008R5-W1 for 8909@debbugs.gnu.org; Tue, 21 Jun 2011 10:51:45 -0400 Received: from [192.168.2.108] (p57B26E51.dip.t-dialin.net [87.178.110.81]) by mrelayeu.kundenserver.de (node=mrbap3) with ESMTP (Nemesis) id 0Ls9b5-1RcdXT2Y63-013uYw; Tue, 21 Jun 2011 16:51:37 +0200 Message-ID: <4E00AFF7.5040206@bernhard-voelker.de> Date: Tue, 21 Jun 2011 16:51:35 +0200 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110414 SUSE/3.1.10 Thunderbird/3.1.10 MIME-Version: 1.0 To: Jim Meyering Subject: Re: bug#8909: tests/ls/stat-free-color: fails on OpenSuSE 11.4 References: <4E004C55.9000006@bernhard-voelker.de> <8739j3z4h0.fsf@rho.meyering.net> <4E00A543.5060403@bernhard-voelker.de> <87r56nxoaa.fsf@rho.meyering.net> In-Reply-To: <87r56nxoaa.fsf@rho.meyering.net> Content-Type: multipart/mixed; boundary="------------050506020904080501010807" X-Provags-ID: V02:K0:QKQGcbCT8Z4VhxlcrAxNFSDqXUygeKfCPZpqPAKN78r SJgCpvoMgYYwHG7dNVrRgrZFIhsPLb+14QtuLhs+0Ps2lD5ZH2 krrAvrHyG8061WXz28U7vKucNNbuWWtoQ+m1p/DqnrSgMc2l+4 O2ML9lO97IAdqGKsA2mFHFHQNbIPusupqUSFuJoi/7lh9TdSrv nVGF+q+puAR4puzxJjCs7uWkifBgaFYooTHE3Bzh8M= X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 8909 Cc: 8909@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) This is a multi-part message in MIME format. --------------050506020904080501010807 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 06/21/2011 04:16 PM, Jim Meyering wrote: > Bernhard Voelker wrote: >> On 06/21/2011 03:41 PM, Jim Meyering wrote: >>> It might be useful to see the entire strace output, too. >>> To get that, remove the "-e stat,lstat,stat64,lstat64" argument >>> from the strace invocation, and rerun the test. >> >> The output of both runs is attached. >> stat("/usr/lib64/mpi/gcc/openmpi/lib64") and friends is the culprit. > > Thanks. > >> I can't remember to have anything un-OpenSuSE-11.4-like in my toolchain. >> >> To me it seems that the test should count the difference of the >> number of stat,lstat,stat64,lstat64 calls when run >> a) as a dummy: ls --color=always --help >> and >> b) for ".": ls --color=always . > > That would be more robust. > Do you feel like writing the patch? Attached try #1 and the log. I'm not sure about x-platform calculation, but I guess n_lines=$(expr $n_lines - $n_lines_help) is okay - actually I saw it somewhere else in tests/. Have a nice day, Berny --------------050506020904080501010807 Content-Type: text/x-patch; name="ls.stat-free-color.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="ls.stat-free-color.diff" >From 3a6e0abab8eaa92922ce4cb1cfdfda278ccde8a6 Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Tue, 21 Jun 2011 16:26:50 +0200 Subject: [PATCH] tests: ls/stat-free-color: count only the number of stat calls compared to --help * tests/ls/stat-free-color: The system may do additional stat calls upon loading (seen on OpenSuSE-11.4). Count only the number of stat calls compared to --help. --- tests/ls/stat-free-color | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/tests/ls/stat-free-color b/tests/ls/stat-free-color index b1c4744..03ef6e1 100755 --- a/tests/ls/stat-free-color +++ b/tests/ls/stat-free-color @@ -49,9 +49,15 @@ MULTIHARDLINK 00 EOF eval $(dircolors -b color-without-stat) +# The system may do additional *stat*()s upon loading. +# Count the difference compared to a dummy "--help" call. +strace -o log -e stat,lstat,stat64,lstat64 ls --color=always --help >/dev/null 2>&1 || fail=1 +n_lines_help=$(wc -l < log) strace -o log -e stat,lstat,stat64,lstat64 ls --color=always . || fail=1 n_lines=$(wc -l < log) +n_lines=$(expr $n_lines - $n_lines_help) + # Expect one or two stat calls. case $n_lines in 1|2) ;; -- 1.7.3.4 --------------050506020904080501010807 Content-Type: text/x-log; name="stat-free-color.log" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="stat-free-color.log" PASS: ls/stat-free-color (exit: 0) ================================== ++ initial_cwd_=/media/sdb5/berny/coreutils/tests ++ fail=0 +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /media/sdb5/berny/coreutils/tests gt-stat-free-color.XXXX +++ case $# in +++ destdir_=/media/sdb5/berny/coreutils/tests +++ template_=gt-stat-free-color.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ case $template_ in ++++ unset TMPDIR ++++ mktemp -d -t -p /media/sdb5/berny/coreutils/tests gt-stat-free-color.XXXX +++ d=/media/sdb5/berny/coreutils/tests/gt-stat-free-color.knck +++ case $d in +++ test -d /media/sdb5/berny/coreutils/tests/gt-stat-free-color.knck ++++ ls -dgo /media/sdb5/berny/coreutils/tests/gt-stat-free-color.knck ++++ tr S - +++ perms='drwx------ 2 4096 Jun 21 16:25 /media/sdb5/berny/coreutils/tests/gt-stat-free-color.knck' +++ case $perms in +++ test 0 = 0 +++ echo /media/sdb5/berny/coreutils/tests/gt-stat-free-color.knck +++ return ++ test_dir_=/media/sdb5/berny/coreutils/tests/gt-stat-free-color.knck ++ cd /media/sdb5/berny/coreutils/tests/gt-stat-free-color.knck ++ gl_init_sh_nl_=' ' ++ IFS=' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ../src + test 1 '!=' 0 + path_dir_=../src + case $path_dir_ in ++ cd /media/sdb5/berny/coreutils/tests/../src ++ echo /media/sdb5/berny/coreutils/src + abs_path_dir_=/media/sdb5/berny/coreutils/src + case $abs_path_dir_ in + PATH=/media/sdb5/berny/coreutils/src:/home/berny/coreutils/src:/usr/lib64/mpi/gcc/openmpi/bin:/home/berny/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/X11R6/bin:/usr/games:/usr/lib64/jvm/jre/bin + create_exe_shims_ /media/sdb5/berny/coreutils/src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + print_ver_ ls + test yes = yes + local i + for i in '$*' + env ls --version ls (GNU coreutils) 8.12.99-18bd Copyright (C) 2011 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Richard M. Stallman and David MacKenzie. + require_strace_ stat + test 1 = 1 + strace -V + strace -qe stat echo + require_dirent_d_type_ + python + python /home/berny/coreutils/tests/d_type-check + for i in 1 2 3 + ln -s nowhere dangle-1 + for i in 1 2 3 + ln -s nowhere dangle-2 + for i in 1 2 3 + ln -s nowhere dangle-3 + cat ++ dircolors -b color-without-stat + eval 'LS_COLORS='\''rs=0:di=01;34:ln=01;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=00:su=00:sg=00:ca=00:tw=00:ow=00:st=00:ex=00:mh=00:'\'';' export LS_COLORS ++ LS_COLORS='rs=0:di=01;34:ln=01;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=00:su=00:sg=00:ca=00:tw=00:ow=00:st=00:ex=00:mh=00:' ++ export LS_COLORS + strace -o log -e stat,lstat,stat64,lstat64 ls --color=always --help ++ wc -l + n_lines_help=4 + strace -o log -e stat,lstat,stat64,lstat64 ls --color=always . color-without-stat dangle-1 dangle-2 dangle-3 log ++ wc -l + n_lines=5 ++ expr 5 - 4 + n_lines=1 + case $n_lines in + Exit 0 + set +e + exit 0 + exit 0 + remove_tmp_ + __st=0 + cleanup_ + : + cd /media/sdb5/berny/coreutils/tests + chmod -R u+rwx /media/sdb5/berny/coreutils/tests/gt-stat-free-color.knck + rm -rf /media/sdb5/berny/coreutils/tests/gt-stat-free-color.knck + exit 0 --------------050506020904080501010807-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 22 10:10:04 2011 Received: (at 8909-done) by debbugs.gnu.org; 22 Jun 2011 14:10:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QZO84-0004nf-6u for submit@debbugs.gnu.org; Wed, 22 Jun 2011 10:10:04 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QZO80-0004n7-PS for 8909-done@debbugs.gnu.org; Wed, 22 Jun 2011 10:10:02 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 5BD126012D; Wed, 22 Jun 2011 16:09:54 +0200 (CEST) From: Jim Meyering To: Bernhard Voelker Subject: Re: bug#8909: tests/ls/stat-free-color: fails on OpenSuSE 11.4 In-Reply-To: <4E00AFF7.5040206@bernhard-voelker.de> (Bernhard Voelker's message of "Tue, 21 Jun 2011 16:51:35 +0200") References: <4E004C55.9000006@bernhard-voelker.de> <8739j3z4h0.fsf@rho.meyering.net> <4E00A543.5060403@bernhard-voelker.de> <87r56nxoaa.fsf@rho.meyering.net> <4E00AFF7.5040206@bernhard-voelker.de> Date: Wed, 22 Jun 2011 16:09:54 +0200 Message-ID: <87ipryrm8d.fsf@rho.meyering.net> Lines: 117 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: 8909-done Cc: 8909-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Bernhard Voelker wrote: > On 06/21/2011 04:16 PM, Jim Meyering wrote: >> Bernhard Voelker wrote: >>> On 06/21/2011 03:41 PM, Jim Meyering wrote: >>>> It might be useful to see the entire strace output, too. >>>> To get that, remove the "-e stat,lstat,stat64,lstat64" argument >>>> from the strace invocation, and rerun the test. >>> >>> The output of both runs is attached. >>> stat("/usr/lib64/mpi/gcc/openmpi/lib64") and friends is the culprit. >> >> Thanks. >> >>> I can't remember to have anything un-OpenSuSE-11.4-like in my toolchain. >>> >>> To me it seems that the test should count the difference of the >>> number of stat,lstat,stat64,lstat64 calls when run >>> a) as a dummy: ls --color=always --help >>> and >>> b) for ".": ls --color=always . >> >> That would be more robust. >> Do you feel like writing the patch? > > Attached try #1 and the log. > > I'm not sure about x-platform calculation, but I guess > n_lines=$(expr $n_lines - $n_lines_help) > is okay - actually I saw it somewhere else in tests/. > > Have a nice day, > Berny > >>>From 3a6e0abab8eaa92922ce4cb1cfdfda278ccde8a6 Mon Sep 17 00:00:00 2001 > From: Bernhard Voelker > Date: Tue, 21 Jun 2011 16:26:50 +0200 > Subject: [PATCH] tests: ls/stat-free-color: count only the number of stat calls compared to --help > > * tests/ls/stat-free-color: The system may do additional stat calls upon loading > (seen on OpenSuSE-11.4). Count only the number of stat calls compared to --help. > --- > tests/ls/stat-free-color | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/tests/ls/stat-free-color b/tests/ls/stat-free-color > index b1c4744..03ef6e1 100755 > --- a/tests/ls/stat-free-color > +++ b/tests/ls/stat-free-color > @@ -49,9 +49,15 @@ MULTIHARDLINK 00 > EOF > eval $(dircolors -b color-without-stat) > > +# The system may do additional *stat*()s upon loading. > +# Count the difference compared to a dummy "--help" call. > +strace -o log -e stat,lstat,stat64,lstat64 ls --color=always --help >/dev/null 2>&1 || fail=1 > +n_lines_help=$(wc -l < log) > strace -o log -e stat,lstat,stat64,lstat64 ls --color=always . || fail=1 > n_lines=$(wc -l < log) > > +n_lines=$(expr $n_lines - $n_lines_help) > + > # Expect one or two stat calls. > case $n_lines in > 1|2) ;; Thank you. I've made some small adjustments including file name and variable name changes. Also, I've tightened up the test to expect exactly one stat-like call: (Since I've changed your commit, I'll wait for an ACK before pushing it) And I've marked this issue as "done". >From 376b19410eb57f36f711750ca75ed30dc1ebddce Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Tue, 21 Jun 2011 16:26:50 +0200 Subject: [PATCH] tests: stat-free-color: do not count stat calls before main * tests/ls/stat-free-color: The system may perform additional stat calls upon loading (seen on OpenSuSE-11.4). Count only the number of stat calls compared to --help. This also reduces back to "1" the number of expected calls, effectively reverting part of 2011-06-01 commit, ccf2d9a4. --- tests/ls/stat-free-color | 15 ++++++++++++--- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/tests/ls/stat-free-color b/tests/ls/stat-free-color index b1c4744..1288560 100755 --- a/tests/ls/stat-free-color +++ b/tests/ls/stat-free-color @@ -49,13 +49,22 @@ MULTIHARDLINK 00 EOF eval $(dircolors -b color-without-stat) +# The system may perform additional stat-like calls before main. +# To avoid counting those, first get a baseline count by running +# ls with only the --help option. Then, compare that with the +# invocation under test. +strace -o log-help -e stat,lstat,stat64,lstat64 ls --help >/dev/null || fail=1 +n_lines_help=$(wc -l < log-help) + strace -o log -e stat,lstat,stat64,lstat64 ls --color=always . || fail=1 n_lines=$(wc -l < log) +n_stat=$(expr $n_lines - $n_lines_help) + # Expect one or two stat calls. -case $n_lines in - 1|2) ;; - *) fail=1 ;; +case $n_stat in + 1) ;; + *) fail=1; head -n30 log* ;; esac Exit $fail -- 1.7.6.rc2.302.gc2115 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 22 10:21:27 2011 Received: (at 8909-done) by debbugs.gnu.org; 22 Jun 2011 14:21:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QZOJ5-0005pw-It for submit@debbugs.gnu.org; Wed, 22 Jun 2011 10:21:27 -0400 Received: from moutng.kundenserver.de ([212.227.17.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QZOJ3-0005pk-Nf for 8909-done@debbugs.gnu.org; Wed, 22 Jun 2011 10:21:26 -0400 Received: from oxltgw16.schlund.de (oxltgw16.schlund.de [172.19.158.54]) by mrelayeu.kundenserver.de (node=mrbap2) with ESMTP (Nemesis) id 0LaJMk-1RL3nd0inW-00lPJY; Wed, 22 Jun 2011 16:21:11 +0200 Date: Wed, 22 Jun 2011 16:21:11 +0200 (CEST) From: "mail@bernhard-voelker.de" To: Jim Meyering Message-ID: <19237164.181185.1308752471153.JavaMail.open-xchange@oxltgw16.schlund.de> In-Reply-To: <87ipryrm8d.fsf@rho.meyering.net> References: <4E004C55.9000006@bernhard-voelker.de> <8739j3z4h0.fsf@rho.meyering.net> <4E00A543.5060403@bernhard-voelker.de> <87r56nxoaa.fsf@rho.meyering.net> <4E00AFF7.5040206@bernhard-voelker.de> <87ipryrm8d.fsf@rho.meyering.net> Subject: Re: bug#8909: tests/ls/stat-free-color: fails on OpenSuSE 11.4 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_181184_322741266.1308752471002" X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v6.20.0-Rev11 X-Provags-ID: V02:K0:+pNwnechzbXOOkn5lLeTx9SukePucUIF1esSaQNVomk pZ27YzZwUrWlA4jyO4PcmgP/KvsVl3xWu1sTSbUwl7ASOSMjPj tFDkBZpbycjf5dwU5SWZkaQRwQ3XCFtsQI4PGT2UHoSfCXsa8d IbsroF0vDR52bOUTIJsukW1/r1pnLaKyK8ySV9o+CvDBwvoDXP +dKqKI4om3vUS36+XMeEe4px1QirJkje43j7t8VHBU= X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8909-done Cc: 8909-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) ------=_Part_181184_322741266.1308752471002 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =C2=A0 On June 22, 2011 at 4:09 PM Jim Meyering wrote: > Thank you. > I've made some small adjustments including file name and variable name > changes. > Also, I've tightened up the test to expect exactly one stat-like call: > (Since I've changed your commit, I'll wait for an ACK before pushing it) > And I've marked this issue as "done".=C2=A0 Hi Jim, =C2=A0 thank you. ACK. This looks good - although I didn't have the chance to repeat this=C2=A0test on OpenSuSE-11.4 today. =C2=A0 Berny ------=_Part_181184_322741266.1308752471002 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

 

On June 22, 2011 at 4:09 PM Jim Meyering <jim@meyering.net> wrote:

> Thank you.
> I've made some small adjustments including file name and variable name changes.
> Also, I've tightened up the test to expect exactly one stat-like call:
> (Since I've changed your commit, I'll wait for an ACK before pushing it)
> And I've marked this issue as "done".

 

Hi Jim,

 

thank you. ACK.

This looks good - although I didn't have the chance to repeat

this test on OpenSuSE-11.4 today.

 

Berny

------=_Part_181184_322741266.1308752471002-- From unknown Wed Jun 18 23:17:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 21 Jul 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator