From unknown Sun Jun 22 00:59:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8887: Automake patches for custom test drivers' support break coreutils testsuite (was: Re: [PATCH v4 1/3] parallel-tests: add auxiliary script 'pt-driver', refactor) Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 17 Jun 2011 21:10:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8887 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: "Ralf Wildenhues" Cc: 8887@debbugs.gnu.org, automake-patches@gnu.org X-Debbugs-Original-Cc: bug-coreutils@gnu.org, automake-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.130834499423588 (code B ref -1); Fri, 17 Jun 2011 21:10:03 +0000 Received: (at submit) by debbugs.gnu.org; 17 Jun 2011 21:09:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QXgIc-00068P-9k for submit@debbugs.gnu.org; Fri, 17 Jun 2011 17:09:54 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QXgIZ-00068C-Rx for submit@debbugs.gnu.org; Fri, 17 Jun 2011 17:09:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QXgIT-0003aA-49 for submit@debbugs.gnu.org; Fri, 17 Jun 2011 17:09:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:34901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXgIT-0003a5-04 for submit@debbugs.gnu.org; Fri, 17 Jun 2011 17:09:45 -0400 Received: from eggs.gnu.org ([140.186.70.92]:50490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXgIQ-0005Oa-G7 for bug-coreutils@gnu.org; Fri, 17 Jun 2011 17:09:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QXgIO-0003Zj-CO for bug-coreutils@gnu.org; Fri, 17 Jun 2011 17:09:42 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:54249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXgIJ-0003Yq-Mk; Fri, 17 Jun 2011 17:09:35 -0400 Received: by wyf19 with SMTP id 19so2470226wyf.0 for ; Fri, 17 Jun 2011 14:09:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; bh=KmFVrD3Qb0kDHaRaqz3hEje83P0637c9YtPcwbieiAc=; b=LRDzXkKZqKIHn4AOaH15CS6Z+fNJIiwgFCcKGqdKSRGoSFu05m0ZuUWIUNfn5Svpc6 PFbLP4HiWmRx6o0vcfOdU3hFkH/NbaRQR1d1vXkoAzrrzuP88a37wf0imcRu1dHf+88x nSv1Lp7upyA6l1b5EwDptl0N0BwY+bROcYqvM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; b=e/xefLL9RYgUtE8tPNHEtBvZxtfB+rBp0ky1AcV+rzUOInki38jWASvEaTcfPIjx/x cRGKwrDrwHlzWsBpW9W4Jt9iGqHCC7vCKNiEfurDgXO4voLkMDA+X0So2+ZrLtnDsq+x gcHBZAPXXzOzwavGNWH+4o8LH8DG9/wSBJ1dk= Received: by 10.227.172.206 with SMTP id m14mr2693567wbz.29.1308344974310; Fri, 17 Jun 2011 14:09:34 -0700 (PDT) Received: from bigio.localnet (host92-48-dynamic.58-82-r.retail.telecomitalia.it [82.58.48.92]) by mx.google.com with ESMTPS id o19sm1243893wbh.38.2011.06.17.14.09.32 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 17 Jun 2011 14:09:33 -0700 (PDT) From: Stefano Lattarini Date: Fri, 17 Jun 2011 23:09:22 +0200 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: <201104291121.07627.stefano.lattarini@gmail.com> <201106161000.32191.stefano.lattarini@gmail.com> <20110617062122.316800@gmx.net> In-Reply-To: <20110617062122.316800@gmx.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201106172309.23048.stefano.lattarini@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.1 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) [Adding bug-coreutils] Reference: On Friday 17 June 2011, Ralf Wildenhues wrote: > I generally like the direction this is taking. The point of best > separation between which code goes into Makefile.in and which into > the driver scripts can be fine-tuned when we have more than one such > script. > > Actually, yes, before deciding on this for real I really do want to see > a nontrivial other driver script. There is no point in hardcoding > too much in several driver scripts if it all needs to be the same > anyway. > > Please measure the time overhead your changes introduce into the current > code, for a trivial testsuite (say, 50 tests running 'true'), and a > nontrivial one like Automake's and one with faster tests. > I've tried the coreutils testsuite and ... Ouch! That gets broken by my patches :-( That's due to the overly complex TESTS_ENVIRONMENT employed by conreutils' tests/Makefile.am: TESTS_ENVIRONMENT = \ . $(srcdir)/lang-default; \ tmp__=$${TMPDIR-/tmp}; \ test -d "$$tmp__" && test -w "$$tmp__" || tmp__=.; \ . $(srcdir)/envvar-check; \ TMPDIR=$$tmp__; export TMPDIR; \ shell_or_perl_() { \ if grep '^\#!/usr/bin/perl' "$$1" > /dev/null; then \ if $(PERL) -e 'use warnings' > /dev/null 2>&1; then \ grep '^\#!/usr/bin/perl -T' "$$1" > /dev/null && T_=T || T_=; \ $(PERL) -w$$T_ -I$(srcdir) -MCoreutils -MCuSkip \ -M"CuTmpdir qw($$f)" -- "$$1"; \ else \ echo 1>&2 "$$tst: configure did not find a usable version of Perl," \ "so skipping this test"; \ (exit 77); \ fi; \ else \ $(SHELL) "$$1"; \ fi; \ }; \ export \ VERSION='$(VERSION)' \ LOCALE_FR='$(LOCALE_FR)' \ LOCALE_FR_UTF8='$(LOCALE_FR_UTF8)' \ abs_top_builddir='$(abs_top_builddir)' \ abs_top_srcdir='$(abs_top_srcdir)' \ abs_srcdir='$(abs_srcdir)' \ built_programs="`cat .built-programs`" \ host_os=$(host_os) \ host_triplet='$(host_triplet)' \ srcdir='$(srcdir)' \ top_srcdir='$(top_srcdir)' \ CONFIG_HEADER='$(abs_top_builddir)/$(CONFIG_INCLUDE)' \ CU_TEST_NAME=`basename '$(abs_srcdir)'`,`echo $$tst|sed 's,^\./,,;s,/,-,g'` \ CC='$(CC)' \ AWK='$(AWK)' \ EGREP='$(EGREP)' \ EXEEXT='$(EXEEXT)' \ MAKE=$(MAKE) \ PACKAGE_BUGREPORT='$(PACKAGE_BUGREPORT)' \ PACKAGE_VERSION=$(PACKAGE_VERSION) \ PERL='$(PERL)' \ PREFERABLY_POSIX_SHELL='$(PREFERABLY_POSIX_SHELL)' \ REPLACE_GETCWD=$(REPLACE_GETCWD) \ ; test -d /usr/xpg4/bin && PATH='/usr/xpg4/bin$(PATH_SEPARATOR)'"$$PATH"; \ PATH='$(abs_top_builddir)/src$(PATH_SEPARATOR)'"$$PATH" \ ; shell_or_perl_ 9>&2 In order to work with the upcoming new Automake testsuite harness, coreutils have two possibilities: 1. move the `shell_or_perl_' subroutine's functionality into a real acript, and define the LOG_COMPILER to point to it; or 2. add a `.pl' extension to the perl test scripts, and define PL_LOG_COMPILER appropriately (might be a little tricky, considering the hops that the `shell_or_perl_' subroutine goes through in order to get the flags and imports right). I should have have an FSF copyright assignement in place for coreutils too, so I can volounteer to write a fix for this situation, if no one wants to beat me. Regards, Stefano From unknown Sun Jun 22 00:59:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8887: Automake patches for custom test drivers' support break coreutils testsuite Resent-From: Jim Meyering Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 18 Jun 2011 06:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8887 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: Stefano Lattarini Cc: Ralf.Wildenhues@gmx.de, 8887@debbugs.gnu.org, automake-patches@gnu.org X-Debbugs-Original-Cc: Ralf Wildenhues , bug-coreutils@gnu.org, automake-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.130837928322040 (code B ref -1); Sat, 18 Jun 2011 06:42:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Jun 2011 06:41:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QXpDe-0005jR-Go for submit@debbugs.gnu.org; Sat, 18 Jun 2011 02:41:22 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QXpDc-0005jD-7A for submit@debbugs.gnu.org; Sat, 18 Jun 2011 02:41:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QXpDV-0004Jv-UQ for submit@debbugs.gnu.org; Sat, 18 Jun 2011 02:41:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:38361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXpDV-0004Jr-Or for submit@debbugs.gnu.org; Sat, 18 Jun 2011 02:41:13 -0400 Received: from eggs.gnu.org ([140.186.70.92]:45228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXpDT-000834-Sf for bug-coreutils@gnu.org; Sat, 18 Jun 2011 02:41:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QXpDS-0004JU-Jv for bug-coreutils@gnu.org; Sat, 18 Jun 2011 02:41:11 -0400 Received: from mx.meyering.net ([82.230.74.64]:50299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXpDP-0004J3-RX; Sat, 18 Jun 2011 02:41:07 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id CD21C6008E; Sat, 18 Jun 2011 08:41:06 +0200 (CEST) From: Jim Meyering In-Reply-To: <201106172309.23048.stefano.lattarini@gmail.com> (Stefano Lattarini's message of "Fri, 17 Jun 2011 23:09:22 +0200") References: <201104291121.07627.stefano.lattarini@gmail.com> <201106161000.32191.stefano.lattarini@gmail.com> <20110617062122.316800@gmx.net> <201106172309.23048.stefano.lattarini@gmail.com> Date: Sat, 18 Jun 2011 08:41:06 +0200 Message-ID: <871uyrfxq5.fsf@rho.meyering.net> Lines: 65 MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.0 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) Stefano Lattarini wrote: > [Adding bug-coreutils] > > Reference: > > > On Friday 17 June 2011, Ralf Wildenhues wrote: >> I generally like the direction this is taking. The point of best >> separation between which code goes into Makefile.in and which into >> the driver scripts can be fine-tuned when we have more than one such >> script. >> >> Actually, yes, before deciding on this for real I really do want to see >> a nontrivial other driver script. There is no point in hardcoding >> too much in several driver scripts if it all needs to be the same >> anyway. >> >> Please measure the time overhead your changes introduce into the current >> code, for a trivial testsuite (say, 50 tests running 'true'), and a >> nontrivial one like Automake's and one with faster tests. >> > I've tried the coreutils testsuite and ... Ouch! That gets broken > by my patches :-( Thank you for trying with coreutils before committing them. > That's due to the overly complex TESTS_ENVIRONMENT employed by > conreutils' tests/Makefile.am: > > TESTS_ENVIRONMENT = \ > . $(srcdir)/lang-default; \ > tmp__=$${TMPDIR-/tmp}; \ > test -d "$$tmp__" && test -w "$$tmp__" || tmp__=.; \ > . $(srcdir)/envvar-check; \ > TMPDIR=$$tmp__; export TMPDIR; \ > shell_or_perl_() { \ > if grep '^\#!/usr/bin/perl' "$$1" > /dev/null; then \ > if $(PERL) -e 'use warnings' > /dev/null 2>&1; then \ > grep '^\#!/usr/bin/perl -T' "$$1" > /dev/null && T_=T || T_=; \ > $(PERL) -w$$T_ -I$(srcdir) -MCoreutils -MCuSkip \ > -M"CuTmpdir qw($$f)" -- "$$1"; \ > else \ > echo 1>&2 "$$tst: configure did not find a usable version of Perl," \ ... > > In order to work with the upcoming new Automake testsuite harness, coreutils > have two possibilities: > 1. move the `shell_or_perl_' subroutine's functionality into a real acript, > and define the LOG_COMPILER to point to it; or > 2. add a `.pl' extension to the perl test scripts, and define PL_LOG_COMPILER > appropriately (might be a little tricky, considering the hops that the > `shell_or_perl_' subroutine goes through in order to get the flags and > imports right). 1) sounds preferable. > I should have have an FSF copyright assignement in place for coreutils too, Confirmed. > so I can volounteer to write a fix for this situation, if no one wants to > beat me. I won't say "no" ;-) Thanks for volunteering. From unknown Sun Jun 22 00:59:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8887: Automake patches for custom test drivers' support break coreutils testsuite Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 18 Jun 2011 08:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8887 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: Jim Meyering Cc: Ralf.Wildenhues@gmx.de, 8887@debbugs.gnu.org, automake-patches@gnu.org X-Debbugs-Original-Cc: Ralf Wildenhues , bug-coreutils@gnu.org, automake-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.130838545618702 (code B ref -1); Sat, 18 Jun 2011 08:25:01 +0000 Received: (at submit) by debbugs.gnu.org; 18 Jun 2011 08:24:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QXqpD-0004ra-Qh for submit@debbugs.gnu.org; Sat, 18 Jun 2011 04:24:16 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QXqp6-0004rK-L9 for submit@debbugs.gnu.org; Sat, 18 Jun 2011 04:24:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QXqp0-0003dC-7U for submit@debbugs.gnu.org; Sat, 18 Jun 2011 04:24:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:57274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXqp0-0003d8-5z for submit@debbugs.gnu.org; Sat, 18 Jun 2011 04:24:02 -0400 Received: from eggs.gnu.org ([140.186.70.92]:44933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXqoy-0008Px-Og for bug-coreutils@gnu.org; Sat, 18 Jun 2011 04:24:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QXqox-0003cn-Ds for bug-coreutils@gnu.org; Sat, 18 Jun 2011 04:24:00 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:53973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXqox-0003ch-9a; Sat, 18 Jun 2011 04:23:59 -0400 Received: by wwf22 with SMTP id 22so349014wwf.30 for ; Sat, 18 Jun 2011 01:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; bh=Yf7zZWdeuOJ/U9b+VRtqF25SKcpuD/PGCar4HnvXh/0=; b=eMtLzjJr46zI4j1G6UylrD9ao4P3h1pIZKyw0LEC1ClD1Ev9mPP1gffnxFRXEX7FY5 p/PLNIzWnCDA0s/BtYOTRKUPGOjGWNnP5G7REJUXOiVSJOX6NSNt0SuVfm7YlueOOuyG X1nPOcJeVWrhJj2PXj4+FomCFxkHACAcl/oQY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; b=uH1OmZilWvCjJgURGFV9cMD2ZGcI/nrfKgJwmD0WgBTwrPw0PzoGG5JbLrxyi7u7yX 8ERbuYUL1u7K/D6h9ayATIsQCbGbNFTM4rUhyw4ZU3yxzXizVjoZoNU9t8oJ6I6bvvxn RyB1iDP/EWUkopzxkiKTGWn8D/ljk8qXDUw+8= Received: by 10.227.32.73 with SMTP id b9mr2920205wbd.86.1308385437288; Sat, 18 Jun 2011 01:23:57 -0700 (PDT) Received: from bigio.localnet (host49-96-dynamic.4-87-r.retail.telecomitalia.it [87.4.96.49]) by mx.google.com with ESMTPS id en1sm1532243wbb.52.2011.06.18.01.23.53 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 18 Jun 2011 01:23:54 -0700 (PDT) From: Stefano Lattarini Date: Sat, 18 Jun 2011 10:23:42 +0200 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: <201104291121.07627.stefano.lattarini@gmail.com> <201106172309.23048.stefano.lattarini@gmail.com> <871uyrfxq5.fsf@rho.meyering.net> In-Reply-To: <871uyrfxq5.fsf@rho.meyering.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201106181023.43630.stefano.lattarini@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.9 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.9 (----) On Saturday 18 June 2011, Jim Meyering wrote: > Stefano Lattarini wrote: > > [Adding bug-coreutils] > > > > Reference: > > > > > > On Friday 17 June 2011, Ralf Wildenhues wrote: > >> I generally like the direction this is taking. The point of best > >> separation between which code goes into Makefile.in and which into > >> the driver scripts can be fine-tuned when we have more than one such > >> script. > >> > >> Actually, yes, before deciding on this for real I really do want to see > >> a nontrivial other driver script. There is no point in hardcoding > >> too much in several driver scripts if it all needs to be the same > >> anyway. > >> > >> Please measure the time overhead your changes introduce into the current > >> code, for a trivial testsuite (say, 50 tests running 'true'), and a > >> nontrivial one like Automake's and one with faster tests. > >> > > I've tried the coreutils testsuite and ... Ouch! That gets broken > > by my patches :-( > > Thank you for trying with coreutils before committing them. > Note that they'll be commmited to a dedicated branch before being merged into master, so even if you're using the developement version of automake with coreutils you should be safe even in case of other breakage (that is, until the merge to master takes place). > > That's due to the overly complex TESTS_ENVIRONMENT employed by > > conreutils' tests/Makefile.am: > > > > TESTS_ENVIRONMENT = \ > > . $(srcdir)/lang-default; \ > > tmp__=$${TMPDIR-/tmp}; \ > > test -d "$$tmp__" && test -w "$$tmp__" || tmp__=.; \ > > . $(srcdir)/envvar-check; \ > > TMPDIR=$$tmp__; export TMPDIR; \ > > shell_or_perl_() { \ > > if grep '^\#!/usr/bin/perl' "$$1" > /dev/null; then \ > > if $(PERL) -e 'use warnings' > /dev/null 2>&1; then \ > > grep '^\#!/usr/bin/perl -T' "$$1" > /dev/null && T_=T || T_=; \ > > $(PERL) -w$$T_ -I$(srcdir) -MCoreutils -MCuSkip \ > > -M"CuTmpdir qw($$f)" -- "$$1"; \ > > else \ > > echo 1>&2 "$$tst: configure did not find a usable version of Perl," \ > ... > > > > In order to work with the upcoming new Automake testsuite harness, coreutils > > have two possibilities: > > 1. move the `shell_or_perl_' subroutine's functionality into a real acript, > > and define the LOG_COMPILER to point to it; or > > 2. add a `.pl' extension to the perl test scripts, and define PL_LOG_COMPILER > > appropriately (might be a little tricky, considering the hops that the > > `shell_or_perl_' subroutine goes through in order to get the flags and > > imports right). > > 1) sounds preferable. > But it has a serious drawback: the redirection `9>&2' placed at the end of TESTS_ENVIRONMENT will be rendered useless by the final exec done in the new `shell_or_perl' script (at least for with shells using the `cloexec' flag on fds > 2); this will bring back the problems fixed by commit `v8.12-82-g6b68745' :-( So I now think we should go with solution (2). > > I should have have an FSF copyright assignement in place for coreutils too, > > Confirmed. > > > so I can volounteer to write a fix for this situation, if no one wants to > > beat me. > > I won't say "no" ;-) > Thanks for volunteering. > Regards, Stefano From unknown Sun Jun 22 00:59:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8887: Automake patches for custom test drivers' support break coreutils testsuite Resent-From: Jim Meyering Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 18 Jun 2011 11:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8887 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: Stefano Lattarini Cc: Ralf.Wildenhues@gmx.de, 8887@debbugs.gnu.org, automake-patches@gnu.org X-Debbugs-Original-Cc: Ralf Wildenhues , bug-coreutils@gnu.org, automake-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13083965034749 (code B ref -1); Sat, 18 Jun 2011 11:29:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Jun 2011 11:28:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QXthP-0001EX-DQ for submit@debbugs.gnu.org; Sat, 18 Jun 2011 07:28:23 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QXthM-0001EK-H2 for submit@debbugs.gnu.org; Sat, 18 Jun 2011 07:28:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QXthG-0007rt-Dx for submit@debbugs.gnu.org; Sat, 18 Jun 2011 07:28:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:45136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXthG-0007rn-6n for submit@debbugs.gnu.org; Sat, 18 Jun 2011 07:28:14 -0400 Received: from eggs.gnu.org ([140.186.70.92]:37383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXthE-0006cp-Gc for bug-coreutils@gnu.org; Sat, 18 Jun 2011 07:28:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QXthD-0007rR-4s for bug-coreutils@gnu.org; Sat, 18 Jun 2011 07:28:12 -0400 Received: from mx.meyering.net ([82.230.74.64]:41519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXth9-0007qb-Sn; Sat, 18 Jun 2011 07:28:08 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 08D046008E; Sat, 18 Jun 2011 13:28:05 +0200 (CEST) From: Jim Meyering In-Reply-To: <201106181023.43630.stefano.lattarini@gmail.com> (Stefano Lattarini's message of "Sat, 18 Jun 2011 10:23:42 +0200") References: <201104291121.07627.stefano.lattarini@gmail.com> <201106172309.23048.stefano.lattarini@gmail.com> <871uyrfxq5.fsf@rho.meyering.net> <201106181023.43630.stefano.lattarini@gmail.com> Date: Sat, 18 Jun 2011 13:28:05 +0200 Message-ID: <87pqmbe5ve.fsf@rho.meyering.net> Lines: 23 MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.0 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) Stefano Lattarini wrote: >> ... >> > >> > In order to work with the upcoming new Automake testsuite harness, coreutils >> > have two possibilities: >> > 1. move the `shell_or_perl_' subroutine's functionality into a real acript, >> > and define the LOG_COMPILER to point to it; or >> > 2. add a `.pl' extension to the perl test scripts, and define PL_LOG_COMPILER >> > appropriately (might be a little tricky, considering the hops that the >> > `shell_or_perl_' subroutine goes through in order to get the flags and >> > imports right). >> >> 1) sounds preferable. >> > But it has a serious drawback: the redirection `9>&2' placed at the end > of TESTS_ENVIRONMENT will be rendered useless by the final exec done > in the new `shell_or_perl' script (at least for with shells using the > `cloexec' flag on fds > 2); this will bring back the problems fixed by > commit `v8.12-82-g6b68745' :-( > > So I now think we should go with solution (2). Ok. From unknown Sun Jun 22 00:59:56 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stefano Lattarini Subject: bug#8887: closed (Re: [PATCH 1/2] tests: make test runner a script, not a shell function) Message-ID: References: <87sjpy6l55.fsf@rho.meyering.net> <201106172309.23048.stefano.lattarini@gmail.com> X-Gnu-PR-Message: they-closed 8887 X-Gnu-PR-Package: coreutils X-Gnu-PR-Keywords: patch Reply-To: 8887@debbugs.gnu.org Date: Fri, 22 Jul 2011 21:50:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1311371404-22008-1" This is a multi-part message in MIME format... ------------=_1311371404-22008-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #8887: Automake patches for custom test drivers' support break coreutils te= stsuite (was: Re: [PATCH v4 1/3] parallel-tests: add auxiliary script 'pt-d= river', refactor) which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 8887@debbugs.gnu.org. --=20 8887: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D8887 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1311371404-22008-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 8887-done) by debbugs.gnu.org; 22 Jul 2011 21:49:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkNbS-0005iW-8N for submit@debbugs.gnu.org; Fri, 22 Jul 2011 17:49:50 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QkNbQ-0005iH-BN for 8887-done@debbugs.gnu.org; Fri, 22 Jul 2011 17:49:48 -0400 Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id BB343600AC; Fri, 22 Jul 2011 23:49:42 +0200 (CEST) From: Jim Meyering To: Stefano Lattarini Subject: Re: [PATCH 1/2] tests: make test runner a script, not a shell function In-Reply-To: <87r56p8t59.fsf@rho.meyering.net> (Jim Meyering's message of "Sun, 19 Jun 2011 22:26:26 +0200") References: <201104291121.07627.stefano.lattarini@gmail.com> <87pqmbe5ve.fsf@rho.meyering.net> <201106181941.12662.stefano.lattarini@gmail.com> <201106182018.10934.stefano.lattarini@gmail.com> <87r56p8t59.fsf@rho.meyering.net> Date: Fri, 22 Jul 2011 23:49:42 +0200 Message-ID: <87sjpy6l55.fsf@rho.meyering.net> Lines: 14 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: 8887-done Cc: 8887-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Jim Meyering wrote: > Stefano Lattarini wrote: >> Subject: [PATCH 2/2] tests: avoid extra forks in the testsuite >> >> * tests/shell-or-perl: Prefer the `read' builtin over `grep' to >> look at the shebang line of test scripts. Since `read' is a >> special builtin, it might abort the whole program upon failures, >> so add extra sanity checks, verifying that the test script exists >> and is readable, before trying to read from it. ... > > Thank you. I pushed that as-is. And am marking this as "done". ------------=_1311371404-22008-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Jun 2011 21:09:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QXgIc-00068P-9k for submit@debbugs.gnu.org; Fri, 17 Jun 2011 17:09:54 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QXgIZ-00068C-Rx for submit@debbugs.gnu.org; Fri, 17 Jun 2011 17:09:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QXgIT-0003aA-49 for submit@debbugs.gnu.org; Fri, 17 Jun 2011 17:09:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:34901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXgIT-0003a5-04 for submit@debbugs.gnu.org; Fri, 17 Jun 2011 17:09:45 -0400 Received: from eggs.gnu.org ([140.186.70.92]:50490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXgIQ-0005Oa-G7 for bug-coreutils@gnu.org; Fri, 17 Jun 2011 17:09:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QXgIO-0003Zj-CO for bug-coreutils@gnu.org; Fri, 17 Jun 2011 17:09:42 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:54249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXgIJ-0003Yq-Mk; Fri, 17 Jun 2011 17:09:35 -0400 Received: by wyf19 with SMTP id 19so2470226wyf.0 for ; Fri, 17 Jun 2011 14:09:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; bh=KmFVrD3Qb0kDHaRaqz3hEje83P0637c9YtPcwbieiAc=; b=LRDzXkKZqKIHn4AOaH15CS6Z+fNJIiwgFCcKGqdKSRGoSFu05m0ZuUWIUNfn5Svpc6 PFbLP4HiWmRx6o0vcfOdU3hFkH/NbaRQR1d1vXkoAzrrzuP88a37wf0imcRu1dHf+88x nSv1Lp7upyA6l1b5EwDptl0N0BwY+bROcYqvM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; b=e/xefLL9RYgUtE8tPNHEtBvZxtfB+rBp0ky1AcV+rzUOInki38jWASvEaTcfPIjx/x cRGKwrDrwHlzWsBpW9W4Jt9iGqHCC7vCKNiEfurDgXO4voLkMDA+X0So2+ZrLtnDsq+x gcHBZAPXXzOzwavGNWH+4o8LH8DG9/wSBJ1dk= Received: by 10.227.172.206 with SMTP id m14mr2693567wbz.29.1308344974310; Fri, 17 Jun 2011 14:09:34 -0700 (PDT) Received: from bigio.localnet (host92-48-dynamic.58-82-r.retail.telecomitalia.it [82.58.48.92]) by mx.google.com with ESMTPS id o19sm1243893wbh.38.2011.06.17.14.09.32 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 17 Jun 2011 14:09:33 -0700 (PDT) From: Stefano Lattarini To: "Ralf Wildenhues" Subject: Automake patches for custom test drivers' support break coreutils testsuite (was: Re: [PATCH v4 1/3] parallel-tests: add auxiliary script 'pt-driver', refactor) Date: Fri, 17 Jun 2011 23:09:22 +0200 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: <201104291121.07627.stefano.lattarini@gmail.com> <201106161000.32191.stefano.lattarini@gmail.com> <20110617062122.316800@gmx.net> In-Reply-To: <20110617062122.316800@gmx.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201106172309.23048.stefano.lattarini@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: submit Cc: bug-coreutils@gnu.org, automake-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) [Adding bug-coreutils] Reference: On Friday 17 June 2011, Ralf Wildenhues wrote: > I generally like the direction this is taking. The point of best > separation between which code goes into Makefile.in and which into > the driver scripts can be fine-tuned when we have more than one such > script. > > Actually, yes, before deciding on this for real I really do want to see > a nontrivial other driver script. There is no point in hardcoding > too much in several driver scripts if it all needs to be the same > anyway. > > Please measure the time overhead your changes introduce into the current > code, for a trivial testsuite (say, 50 tests running 'true'), and a > nontrivial one like Automake's and one with faster tests. > I've tried the coreutils testsuite and ... Ouch! That gets broken by my patches :-( That's due to the overly complex TESTS_ENVIRONMENT employed by conreutils' tests/Makefile.am: TESTS_ENVIRONMENT = \ . $(srcdir)/lang-default; \ tmp__=$${TMPDIR-/tmp}; \ test -d "$$tmp__" && test -w "$$tmp__" || tmp__=.; \ . $(srcdir)/envvar-check; \ TMPDIR=$$tmp__; export TMPDIR; \ shell_or_perl_() { \ if grep '^\#!/usr/bin/perl' "$$1" > /dev/null; then \ if $(PERL) -e 'use warnings' > /dev/null 2>&1; then \ grep '^\#!/usr/bin/perl -T' "$$1" > /dev/null && T_=T || T_=; \ $(PERL) -w$$T_ -I$(srcdir) -MCoreutils -MCuSkip \ -M"CuTmpdir qw($$f)" -- "$$1"; \ else \ echo 1>&2 "$$tst: configure did not find a usable version of Perl," \ "so skipping this test"; \ (exit 77); \ fi; \ else \ $(SHELL) "$$1"; \ fi; \ }; \ export \ VERSION='$(VERSION)' \ LOCALE_FR='$(LOCALE_FR)' \ LOCALE_FR_UTF8='$(LOCALE_FR_UTF8)' \ abs_top_builddir='$(abs_top_builddir)' \ abs_top_srcdir='$(abs_top_srcdir)' \ abs_srcdir='$(abs_srcdir)' \ built_programs="`cat .built-programs`" \ host_os=$(host_os) \ host_triplet='$(host_triplet)' \ srcdir='$(srcdir)' \ top_srcdir='$(top_srcdir)' \ CONFIG_HEADER='$(abs_top_builddir)/$(CONFIG_INCLUDE)' \ CU_TEST_NAME=`basename '$(abs_srcdir)'`,`echo $$tst|sed 's,^\./,,;s,/,-,g'` \ CC='$(CC)' \ AWK='$(AWK)' \ EGREP='$(EGREP)' \ EXEEXT='$(EXEEXT)' \ MAKE=$(MAKE) \ PACKAGE_BUGREPORT='$(PACKAGE_BUGREPORT)' \ PACKAGE_VERSION=$(PACKAGE_VERSION) \ PERL='$(PERL)' \ PREFERABLY_POSIX_SHELL='$(PREFERABLY_POSIX_SHELL)' \ REPLACE_GETCWD=$(REPLACE_GETCWD) \ ; test -d /usr/xpg4/bin && PATH='/usr/xpg4/bin$(PATH_SEPARATOR)'"$$PATH"; \ PATH='$(abs_top_builddir)/src$(PATH_SEPARATOR)'"$$PATH" \ ; shell_or_perl_ 9>&2 In order to work with the upcoming new Automake testsuite harness, coreutils have two possibilities: 1. move the `shell_or_perl_' subroutine's functionality into a real acript, and define the LOG_COMPILER to point to it; or 2. add a `.pl' extension to the perl test scripts, and define PL_LOG_COMPILER appropriately (might be a little tricky, considering the hops that the `shell_or_perl_' subroutine goes through in order to get the flags and imports right). I should have have an FSF copyright assignement in place for coreutils too, so I can volounteer to write a fix for this situation, if no one wants to beat me. Regards, Stefano ------------=_1311371404-22008-1--