GNU bug report logs - #888
23.0.60; window height 2 too small (after splitting)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 888 in the body.
You can then email your comments to 888 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <emacs-pretest-bug <at> gnu.org>
Subject: 23.0.60; window height 2 too small (after splitting)
Date: Thu, 4 Sep 2008 09:27:53 -0700

emacs -Q
 
Manually resize the frame so that it is only a few lines high.
 
Do almost anything that would normally display another buffer, whether
in the same window or by splitting the window. For example, do C-h f
display buffer or do C-x C-b.
 
You get an error message with the subject line, and no buffer is
displayed. In fact, I tried to send a bug report with the same small
frame size, and the *mail* buffer got filled with (only) the error
message.
 
This is worse than useless, and represents a regression. If the window
cannot be split for some reason, then Emacs should do as it did
before: either use the same window or create a new frame.
 

In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-08-29 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
-fno-crossjumping'
 

Message #10 received at 888 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 888 <at> debbugs.gnu.org
Subject: Re: bug#888: 23.0.60; window height 2 too small (after splitting)
Date: Thu, 04 Sep 2008 19:39:45 +0200

> emacs -Q
>  
> Manually resize the frame so that it is only a few lines high.
>  
> Do almost anything that would normally display another buffer, whether
> in the same window or by splitting the window. For example, do C-h f
> display buffer or do C-x C-b.
>  
> You get an error message with the subject line, and no buffer is
> displayed. In fact, I tried to send a bug report with the same small
> frame size, and the *mail* buffer got filled with (only) the error
> message.
>  
> This is worse than useless, and represents a regression. If the window
> cannot be split for some reason, then Emacs should do as it did
> before: either use the same window or create a new frame.

Sorry.  I have to wrap this part in a condition-case.  `split-window'
is too severe here.

Thanks for the report!

martin

Message #15 received at 888 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 888 <at> debbugs.gnu.org
Subject: Re: bug#888: 23.0.60; window height 2 too small (after splitting)
Date: Fri, 05 Sep 2008 09:22:54 +0200

> Manually resize the frame so that it is only a few lines high.
>  
> Do almost anything that would normally display another buffer, whether
> in the same window or by splitting the window. For example, do C-h f
> display buffer or do C-x C-b.
>  
> You get an error message with the subject line, and no buffer is
> displayed. In fact, I tried to send a bug report with the same small
> frame size, and the *mail* buffer got filled with (only) the error
> message.
>  
> This is worse than useless, and represents a regression. If the window
> cannot be split for some reason, then Emacs should do as it did
> before: either use the same window or create a new frame.

I checked in a fix.  Please try again.

martin

Message #20 received at 888 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'martin rudalics'" <rudalics <at> gmx.at>
Cc: <888 <at> debbugs.gnu.org>
Subject: RE: bug#888: 23.0.60; window height 2 too small (after splitting)
Date: Fri, 5 Sep 2008 00:26:49 -0700

> > Manually resize the frame so that it is only a few lines high.
> >  
> > Do almost anything that would normally display another 
> buffer, whether
> > in the same window or by splitting the window. For example, do C-h f
> > display buffer or do C-x C-b.
> >  
> > You get an error message with the subject line, and no buffer is
> > displayed. In fact, I tried to send a bug report with the same small
> > frame size, and the *mail* buffer got filled with (only) the error
> > message.
> >  
> > This is worse than useless, and represents a regression. If 
> > the window cannot be split for some reason, then Emacs should do as it did
> > before: either use the same window or create a new frame.
> 
> I checked in a fix.  Please try again.

I can't until I get another Windows binary - probably in about a month. But I'm
sure you DTRT - thanks!

Message #25 received at 888 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 888 <at> debbugs.gnu.org
Subject: Re: bug#888: 23.0.60; window height 2 too small (after splitting)
Date: Fri, 05 Sep 2008 09:31:37 +0200

> I can't until I get another Windows binary - probably in about a month. But I'm
> sure you DTRT - thanks!

Why wait?  All you have to do is put an `and' before the penultimate
line in `window--try-to-split-window' like this (modulo some mangled
tabs):

	       ;; If WINDOW is the only window on its frame and not the
	       ;; minibuffer window, attempt to split it vertically
	       ;; disregarding the value of `split-height-threshold'.
	       (let ((split-height-threshold 0))
		 (and (window--splittable-p window)
		      (split-window window))))))))

martin

Message #30 received at 888-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: 888-done <at> debbugs.gnu.org
Cc: "Drew Adams" <drew.adams <at> oracle.com>
Subject: Re: bug#888: 23.0.60; window height 2 too small (after splitting)
Date: Sun, 07 Sep 2008 12:05:13 +0200

Fixed as

2008-09-05  Martin Rudalics  <rudalics <at> gmx.at>

	* window.el (window--try-to-split-window): Don't split when window
	is not splittable in last disjunct.  (Bug#888)

Thanks

Message #35 received at 888 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'martin rudalics'" <rudalics <at> gmx.at>
Cc: <888 <at> debbugs.gnu.org>
Subject: RE: bug#888: 23.0.60; window height 2 too small (after splitting)
Date: Sun, 7 Sep 2008 07:07:48 -0700

Yes, thanks. It works now.  - Drew

> put an `and' before the penultimate line in `window--try-to-split-window'
> like this (modulo some mangled tabs):
> 
> 	       ;; If WINDOW is the only window on its frame and not the
> 	       ;; minibuffer window, attempt to split it vertically
> 	       ;; disregarding the value of `split-height-threshold'.
> 	       (let ((split-height-threshold 0))
> 		 (and (window--splittable-p window)
> 		      (split-window window))))))))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.