From unknown Fri Aug 15 14:17:06 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#8870 <8870@debbugs.gnu.org> To: bug#8870 <8870@debbugs.gnu.org> Subject: Status: Package installer corrupts image & zip files Reply-To: bug#8870 <8870@debbugs.gnu.org> Date: Fri, 15 Aug 2025 21:17:06 +0000 retitle 8870 Package installer corrupts image & zip files reassign 8870 emacs submitter 8870 Jambunathan K severity 8870 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 15 12:03:38 2011 Received: (at submit) by debbugs.gnu.org; 15 Jun 2011 16:03:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QWsZ6-0007XD-BY for submit@debbugs.gnu.org; Wed, 15 Jun 2011 12:03:37 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QWr8n-0005UC-Me for submit@debbugs.gnu.org; Wed, 15 Jun 2011 10:32:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QWr8g-0004tR-QN for submit@debbugs.gnu.org; Wed, 15 Jun 2011 10:32:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:42375) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWr8g-0004tJ-95 for submit@debbugs.gnu.org; Wed, 15 Jun 2011 10:32:14 -0400 Received: from eggs.gnu.org ([140.186.70.92]:52832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWr8e-0003ea-9K for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2011 10:32:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QWr8c-0004sd-9T for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2011 10:32:11 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:28720 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWr8c-0004sR-23 for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2011 10:32:10 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqoFAMHB+E1FpY1I/2dsb2JhbABSmAyORHi3EIc2OYhqhiYEiiaTGYQb X-IronPort-AV: E=Sophos;i="4.65,370,1304308800"; d="scan'208";a="116351648" Received: from 69-165-141-72.dsl.teksavvy.com (HELO ceviche.home) ([69.165.141.72]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 15 Jun 2011 10:32:08 -0400 Received: by ceviche.home (Postfix, from userid 20848) id F01C7660F1; Wed, 15 Jun 2011 11:32:07 -0300 (ART) From: Jambunathan K To: bug-gnu-emacs@gnu.org Subject: Package installer corrupts image & zip files Message-ID: References: <81vcw73e1k.fsf@gmail.com> Date: Wed, 15 Jun 2011 10:32:07 -0400 In-Reply-To: <81vcw73e1k.fsf@gmail.com> (Jambunathan K.'s message of "Wed, 15 Jun 2011 10:07:59 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 15 Jun 2011 12:03:35 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) [ Use M-x report-emacs-bug rather than a [BUG] tag in the subject line. ] Would it be possible to address the following bug before my OpenDocumentText exporter lands in elpa? I will also file a formal bug report in few hours. Summary: I distribute an image file (png) and a OpenOffice extension (oxt) file as part of the bundle. These files are getting mangled by the package installer. Steps for reproduction: 1. Update package-archives to point to my archive --8<---------------cut here---------------start------------->8--- (setq package-archives '(("gnu" . "http://elpa.gnu.org/packages/") ("org-odt" . "http://repo.or.cz/w/org-mode/org-jambu.git/blob_plain/HEAD:/packages/"))) --8<---------------cut here---------------end--------------->8--- 2. Install the org-odt package. 3. Visit the following files: ~/.emacs.d/elpa/org-odt-20110613/contrib/odt/files/org-mode-unicorn.png ~/.emacs.d/elpa/org-odt-20110613/contrib/odt/BasicODConverter-0.8.0.oxt Note that the above two files are corrupt. (oxt file is a zip archive) 4. Visit these files in the downloaded tar. Note that they are sane. Jambunathan K. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 15 14:01:51 2011 Received: (at 8870) by debbugs.gnu.org; 15 Jun 2011 18:01:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QWuPX-0001op-HN for submit@debbugs.gnu.org; Wed, 15 Jun 2011 14:01:51 -0400 Received: from mail-pv0-f172.google.com ([74.125.83.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QWuPV-0001od-VM for 8870@debbugs.gnu.org; Wed, 15 Jun 2011 14:01:50 -0400 Received: by pvh18 with SMTP id 18so508296pvh.3 for <8870@debbugs.gnu.org>; Wed, 15 Jun 2011 11:01:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:message-id:user-agent :mime-version:content-type; bh=KMQTlPHs3ntfGMCv8s+6VkaoB0FKxlacdS9TchKnuJo=; b=SxcZiWzUAaqFuaiHtzYhQ0yWq4FBfdeDH5mFZ2HkV1wCqZbmvd+i+qXd8f981hFNv4 Poa7ExpGzjYSXll/dhwvUc8xucvuFn0Ka5W4Wd/RJeLpr5HsN1OyJ0Iw3RNEfOFfdi2D YrWvIT0LtUco6tc+7oofo0o1n8rMjLiGJ/E2k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; b=AHBiDnLkvZ+2X/QMX9hXaD8db8lMOPDw8NoqHQzTGaOsjGFDqa7DJfPbKfS43AH7f6 z8sFRJnfHOeuN/q7YVr2RbpaprYhT5QmahmcDFw04WkHfEH2PVJCp1ThX+9Ow4LVG558 85Jn4oSjwsCu7zw9BZy7j2vOKJd9qYSPyVfrM= Received: by 10.68.50.166 with SMTP id d6mr16633pbo.333.1308160903874; Wed, 15 Jun 2011 11:01:43 -0700 (PDT) Received: from JAMBU-NETBOOK ([115.241.32.107]) by mx.google.com with ESMTPS id y2sm381822pbi.35.2011.06.15.11.01.41 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 15 Jun 2011 11:01:43 -0700 (PDT) From: Jambunathan K To: 8870@debbugs.gnu.org Subject: Additional Info Date: Wed, 15 Jun 2011 23:31:25 +0530 Message-ID: <81fwnb6kju.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 8870 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) Many Thanks to whoever filed this bug report on behalf of me. ,---- Emacs Version | GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2011-06-13 on 3249CTO `---- ,---- tar Version | tar (GNU tar) 1.23 | Packaged by Cygwin (1.23-1) | Copyright (C) 2010 Free Software Foundation, Inc. | License GPLv3+: GNU GPL version 3 or later . | This is free software: you are free to change and redistribute it. | There is NO WARRANTY, to the extent permitted by law. | | Written by John Gilmore and Jay Fenlason. `---- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 17:56:16 2011 Received: (at 8870) by debbugs.gnu.org; 18 Jun 2011 21:56:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QY3V1-0005CB-Rb for submit@debbugs.gnu.org; Sat, 18 Jun 2011 17:56:16 -0400 Received: from vm-emlprdomr-02.its.yale.edu ([130.132.50.143]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QY3V0-0005Bz-FP for 8870@debbugs.gnu.org; Sat, 18 Jun 2011 17:56:14 -0400 Received: from furball (dhcp128036226133.central.yale.edu [128.36.226.133]) (authenticated bits=0) by vm-emlprdomr-02.its.yale.edu (8.14.4/8.14.4) with ESMTP id p5ILu9Cb032423 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 18 Jun 2011 17:56:09 -0400 Received: by furball (Postfix, from userid 1000) id B99C916041A; Sat, 18 Jun 2011 17:56:08 -0400 (EDT) From: Chong Yidong To: Jambunathan K Subject: Re: bug#8870: Package installer corrupts image & zip files References: <81vcw73e1k.fsf@gmail.com> Date: Sat, 18 Jun 2011 17:56:08 -0400 In-Reply-To: (Jambunathan K.'s message of "Wed, 15 Jun 2011 10:32:07 -0400") Message-ID: <8762o22493.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.143 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 8870 Cc: 8870@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Jambunathan K writes: > I distribute an image file (png) and a OpenOffice extension (oxt) file > as part of the bundle. These files are getting mangled by the package > installer. I can't reproduce this, either with the org-odt package at your URL, nor with a simple multi-file package containing a gif and a png file. It's possible this is some kind of Windows problem related to tar mode. Can you trying visiting the tar file in Emacs, and see if the image is untarred correctly? C-x C-f org-odt-XXXX.tar C-s .png RET RET Is the image displayed correctly here? From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 00:47:18 2011 Received: (at 8870) by debbugs.gnu.org; 19 Jun 2011 04:47:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QY9uo-0001tE-42 for submit@debbugs.gnu.org; Sun, 19 Jun 2011 00:47:18 -0400 Received: from mail-pz0-f44.google.com ([209.85.210.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QY9ul-0001t0-7j for 8870@debbugs.gnu.org; Sun, 19 Jun 2011 00:47:15 -0400 Received: by pzk5 with SMTP id 5so2739813pzk.3 for <8870@debbugs.gnu.org>; Sat, 18 Jun 2011 21:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-type; bh=m+5501bhYe1EzcBQT60C/ZBKVoS3+5eUrh0zk3/JytE=; b=LH3Y42RbnOHouAkSn5Lh0jA7QybJAAkc0gXabr+k8ty8wGDCrII9MlcJsrF+k2Dg6s B2TnBZ+Ut7XZoV3av3UeQ1sf84l+R3opnnZLCaQ/8L4Dl0KXDT3a4rLR/NR1Yb4Ic+PD 2FJVOdB6wPdloL5tChMWuZfm8VFIPZLaR3A84= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; b=KjHdi0S1XWUGJPMgjEANuJdesjGQJ8ORm4NS1+b9v/X+vmjQMmAKKAu6m7Ozt+XYFB 9vAxXtljX7KvtBceYlO70+7iWkZNliIEKifOg06CzovYP/mkqykjpG3eJ0cNzv+MsZlm 1/LUCSaFX3x41eqn2BX+yfpP/8VHMheQuUYX0= Received: by 10.68.12.228 with SMTP id b4mr1156605pbc.273.1308458829222; Sat, 18 Jun 2011 21:47:09 -0700 (PDT) Received: from JAMBU-NETBOOK ([115.242.166.204]) by mx.google.com with ESMTPS id i7sm2424268pbj.10.2011.06.18.21.47.05 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 18 Jun 2011 21:47:07 -0700 (PDT) From: Jambunathan K To: Chong Yidong Subject: Re: bug#8870: Package installer corrupts image & zip files In-Reply-To: <8762o22493.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 18 Jun 2011 17:56:08 -0400") References: <81vcw73e1k.fsf@gmail.com> <8762o22493.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (windows-nt) Date: Sun, 19 Jun 2011 10:17:52 +0530 Message-ID: <81mxhebf5z.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 8870 Cc: 8870@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) Chong Yidong writes: > Jambunathan K writes: > >> I distribute an image file (png) and a OpenOffice extension (oxt) file >> as part of the bundle. These files are getting mangled by the package >> installer. > > I can't reproduce this, either with the org-odt package at your URL, nor > with a simple multi-file package containing a gif and a png file. > > It's possible this is some kind of Windows problem related to tar mode. > Can you trying visiting the tar file in Emacs, and see if the image is > untarred correctly? > > C-x C-f org-odt-XXXX.tar > C-s .png RET > RET > > Is the image displayed correctly here? The above sequence (which uses tar-extract) DTRT. 1 Hint for the final fix ------------------------- tar-untar-buffer needs to use the right coding system for extraction. For example, the following "stupid change" in `tar-untar-buffer' fixes the original bug. (let ((coding-system-for-write 'no-conversion)) (write-region start end name)) 2 Observation -------------- 1. Visiting the png file embedded within the original tar file is OK 2. Visiting the png file in the ~/.emacs.d/elpa/org-odt-YYYYMMDD/contrib/odt/files/org-mode-unicorn.png is NOT OK. 3 Analysis ----------- 3.1 Behaviour of tar-untar-buffer ================================== 1. `package-install-file' uses `tar-untar-buffer' for extraction. 2. `tar-untar-buffer' invokes `write-region' and an immediate query for `last-coding-system-used' reports "raw-text-dos" for the png file. 3.2 Behaviour of tar-extract ============================= 1. `tar-extract' uses `decode-coding-region' with coding set to `no-conversion' for the png file. The coding is decided by a prior call to `set-auto-coding'. I would assume that a value of `no-conversion' is picked from the following entry in `auto-coding-alist'. ("\\.\\(jpe?g\\|png\\|gif\\|tiff?\\|p[bpgn]m\\)\\'" . no-conversion) Jambunathan K. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 26 17:01:58 2011 Received: (at 8870) by debbugs.gnu.org; 26 Jun 2011 21:01:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QawSs-0006it-NW for submit@debbugs.gnu.org; Sun, 26 Jun 2011 17:01:58 -0400 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QawSq-0006ii-4v for 8870@debbugs.gnu.org; Sun, 26 Jun 2011 17:01:56 -0400 Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p5QL1oJi020087 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 26 Jun 2011 17:01:50 -0400 Received: by furball (Postfix, from userid 1000) id C790D16076C; Sun, 26 Jun 2011 17:01:49 -0400 (EDT) From: Chong Yidong To: Jambunathan K Subject: Re: bug#8870: Package installer corrupts image & zip files References: <81vcw73e1k.fsf@gmail.com> <8762o22493.fsf@stupidchicken.com> <81mxhebf5z.fsf@gmail.com> Date: Sun, 26 Jun 2011 17:01:49 -0400 In-Reply-To: <81mxhebf5z.fsf@gmail.com> (Jambunathan K.'s message of "Sun, 19 Jun 2011 10:17:52 +0530") Message-ID: <87ei2gux1e.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8870 Cc: 8870@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Jambunathan K writes: > tar-untar-buffer needs to use the right coding system for > extraction. Could you verify that a standalone `M-x tar-untar-buffer' (called outside of package.el) also exhibits the bug? If so, I think setting coding-system-for-write to no-conversion is probably the correct fix, indeed. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 27 15:04:13 2011 Received: (at 8870) by debbugs.gnu.org; 27 Jun 2011 19:04:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QbH6S-0001xy-MX for submit@debbugs.gnu.org; Mon, 27 Jun 2011 15:04:13 -0400 Received: from mail-pv0-f172.google.com ([74.125.83.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QbH6Q-0001xk-3f for 8870@debbugs.gnu.org; Mon, 27 Jun 2011 15:04:10 -0400 Received: by pvh18 with SMTP id 18so3070539pvh.3 for <8870@debbugs.gnu.org>; Mon, 27 Jun 2011 12:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=62q6BaSLeD2J8Ac86iLI0umz3sIG2GKCedCUw1TWj1k=; b=xuaVpZiCJQZp2bOBbk/Wx9YlToN3tbErguPtW7VGkgpVsqj76gHEdQ2ER2rDe2D820 FmA/3+0As5MRzIhX2U1FidOMZ+LlaE0zQJ6m5r2JEAxw4UfQj6PN4HJSPnl9PS0tKAHc McrZHmO3Z0hwCzMfHS429FMLMLVGpgl5QCABQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=m6gTaIktpLbRvEcIF1TzK0XQ8nZ5SDHADCleYVWR+PdQhCAACInwSKIg5UL8I3f+4I rUclVwzWo996RLVxl0WMa2eog0DLTsIR5EXI9cydMhMpT36QSpg2mJBUryhLSi0MWHy7 sOFfknQxNDaGSQtGY+MsVbjxr+g+8TpK2MHwA= Received: by 10.68.12.65 with SMTP id w1mr3588211pbb.294.1309201444008; Mon, 27 Jun 2011 12:04:04 -0700 (PDT) Received: from JAMBU-NETBOOK ([122.164.39.239]) by mx.google.com with ESMTPS id b8sm4498705pbj.62.2011.06.27.12.04.01 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 27 Jun 2011 12:04:03 -0700 (PDT) From: Jambunathan K To: Chong Yidong Subject: Re: bug#8870: Package installer corrupts image & zip files References: <81vcw73e1k.fsf@gmail.com> <8762o22493.fsf@stupidchicken.com> <81mxhebf5z.fsf@gmail.com> <87ei2gux1e.fsf@stupidchicken.com> Date: Tue, 28 Jun 2011 00:33:55 +0530 In-Reply-To: <87ei2gux1e.fsf@stupidchicken.com> (Chong Yidong's message of "Sun, 26 Jun 2011 17:01:49 -0400") Message-ID: <81vcvrxfj8.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 8870 Cc: 8870@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) Chong Yidong writes: > Jambunathan K writes: > >> tar-untar-buffer needs to use the right coding system for >> extraction. > > Could you verify that a standalone `M-x tar-untar-buffer' (called > outside of package.el) also exhibits the bug? Yes, the standalone `M-x tar-untar-buffer' ALSO corrupts the zip and png files. > If so, I think setting coding-system-for-write to no-conversion is > probably the correct fix, indeed. Could you please apply this fix then? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 27 17:12:54 2011 Received: (at 8870) by debbugs.gnu.org; 27 Jun 2011 21:12:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QbJ70-0002VO-Go for submit@debbugs.gnu.org; Mon, 27 Jun 2011 17:12:54 -0400 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QbJ6x-0002V9-4S for 8870@debbugs.gnu.org; Mon, 27 Jun 2011 17:12:51 -0400 Received: from furball (dhcp128036014060.central.yale.edu [128.36.14.60]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p5RLCj9B012253 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 27 Jun 2011 17:12:45 -0400 From: Chong Yidong To: Jambunathan K Subject: Re: bug#8870: Package installer corrupts image & zip files References: <81vcw73e1k.fsf@gmail.com> <8762o22493.fsf@stupidchicken.com> <81mxhebf5z.fsf@gmail.com> <87ei2gux1e.fsf@stupidchicken.com> <81vcvrxfj8.fsf@gmail.com> Date: Mon, 27 Jun 2011 17:12:44 -0400 In-Reply-To: <81vcvrxfj8.fsf@gmail.com> (Jambunathan K.'s message of "Tue, 28 Jun 2011 00:33:55 +0530") Message-ID: <87tybb2d2r.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 8870 Cc: 8870@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Jambunathan K writes: > Chong Yidong writes: > >> Jambunathan K writes: >> >>> tar-untar-buffer needs to use the right coding system for >>> extraction. >> >> Could you verify that a standalone `M-x tar-untar-buffer' (called >> outside of package.el) also exhibits the bug? > > Yes, the standalone `M-x tar-untar-buffer' ALSO corrupts the zip and png > files. Thanks for checking. I've committed the change. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 27 17:13:07 2011 Received: (at control) by debbugs.gnu.org; 27 Jun 2011 21:13:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QbJ7C-0002W9-Ud for submit@debbugs.gnu.org; Mon, 27 Jun 2011 17:13:07 -0400 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QbJ7B-0002Vb-Nv for control@debbugs.gnu.org; Mon, 27 Jun 2011 17:13:05 -0400 Received: from furball (dhcp128036014060.central.yale.edu [128.36.14.60]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p5RLCxVA012332 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Mon, 27 Jun 2011 17:12:59 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 8870 Date: Mon, 27 Jun 2011 17:12:58 -0400 Message-ID: <87ei2fdllx.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 8870 thanks From unknown Fri Aug 15 14:17:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 26 Jul 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator