GNU bug report logs - #886
23.0.60; Info-mouse-follow-nearest-node fails

Previous Next

Package: emacs;

Reported by: Stephen Berman <stephen.berman <at> gmx.net>

Date: Thu, 4 Sep 2008 14:40:05 UTC

Severity: normal

Tags: patch

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 886 in the body.
You can then email your comments to 886 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#886; Package emacs. Full text and rfc822 format available.

Acknowledgement sent to Stephen Berman <stephen.berman <at> gmx.net>:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. Full text and rfc822 format available.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.60; Info-mouse-follow-nearest-node fails
Date: Thu, 04 Sep 2008 16:31:06 +0200
1. emacs -Q
2. C-h i m gnus RET
3. Click with mouse-1 (or mouse-2) on any of the links under "Other
   related manuals", i.e. Message, Emacs-MIME, Sieve, PGG, SASL: nothing
   happens.

Typing 'RET' on any of these links, in contrast, DTRT, i.e. goes to the
respective node.  Clicking mouse-1 on any of the other links also DTRT.
The following patch fixes the problem for me:

*** emacs/lisp/info.el.~1.542.~	2008-09-04 16:16:19.000000000 +0200
--- emacs/lisp/info.el	2008-09-04 16:22:24.000000000 +0200
***************
*** 3099,3105 ****
  At end of the node's text, moves to the next node, or up if none."
    (interactive "e")
    (mouse-set-point click)
!   (and (not (Info-try-follow-nearest-node))
         (save-excursion (forward-line 1) (eobp))
         (Info-next-preorder)))
  
--- 3099,3105 ----
  At end of the node's text, moves to the next node, or up if none."
    (interactive "e")
    (mouse-set-point click)
!   (and (not (Info-follow-nearest-node))
         (save-excursion (forward-line 1) (eobp))
         (Info-next-preorder)))
  



In GNU Emacs 23.0.60.1 (i686-pc-linux-gnu, GTK+ Version 2.12.0)
 of 2008-08-29 on escher
Windowing system distributor `The X.Org Foundation', version 11.0.70200000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=local
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t




Tags added: patch Request was from Glenn Morris <rgm <at> gnu.org> to control <at> emacsbugs.donarmstrong.com. (Thu, 04 Sep 2008 17:00:04 GMT) Full text and rfc822 format available.

Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. Full text and rfc822 format available.

Notification sent to Stephen Berman <stephen.berman <at> gmx.net>:
bug acknowledged by developer. Full text and rfc822 format available.

Message #12 received at 886-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 886-done <at> debbugs.gnu.org
Subject: Re: bug#886: 23.0.60; Info-mouse-follow-nearest-node fails
Date: Tue, 09 Sep 2008 22:30:54 -0400
Many thanks; applied.

2008-09-10  Stephen Berman  <stephen.berman <at> gmx.net>

    * info.el (Info-mouse-follow-nearest-node): Follow links
      to different manuals.  (Bug#886)




Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#886; Package emacs. Full text and rfc822 format available.

Acknowledgement sent to martin rudalics <rudalics <at> gmx.at>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. Full text and rfc822 format available.

Message #17 received at 886 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: 886 <at> debbugs.gnu.org
Cc: Glenn Morris <rgm <at> gnu.org>, Stephen Berman <stephen.berman <at> gmx.net>
Subject: Re: bug#886: 23.0.60; Info-mouse-follow-nearest-node fails
Date: Mon, 15 Sep 2008 10:34:01 +0200
The fix seems to have the following side-effect: In my .emacs I bind

  (define-key Info-mode-map [mouse-1] 'Info-mouse-follow-nearest-node)

Now when I use mouse-1 to just "select" the Info-window I usually get

  Info-follow-nearest-node: Point neither on reference nor in menu item description

which is annoying :-(

martin





Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#886; Package emacs. Full text and rfc822 format available.

Acknowledgement sent to Stephen Berman <stephen.berman <at> gmx.net>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. Full text and rfc822 format available.

Message #22 received at 886 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 886 <at> debbugs.gnu.org
Subject: Re: bug#886: 23.0.60; Info-mouse-follow-nearest-node fails
Date: Mon, 15 Sep 2008 11:25:46 +0200
On Mon, 15 Sep 2008 10:34:01 +0200 martin rudalics <rudalics <at> gmx.at> wrote:

> The fix seems to have the following side-effect: In my .emacs I bind
>
>   (define-key Info-mode-map [mouse-1] 'Info-mouse-follow-nearest-node)

> Now when I use mouse-1 to just "select" the Info-window I usually get
>
>   Info-follow-nearest-node: Point neither on reference nor in menu item description
>
> which is annoying :-(
>
> martin

Does the following patch fix it?

*** emacs/lisp/info.el.~1.544.~	2008-09-11 11:49:36.000000000 +0200
--- emacs/lisp/info.el	2008-09-15 11:22:53.000000000 +0200
***************
*** 3123,3129 ****
  	    (Info-goto-node
  	     (Info-extract-menu-item (match-string-no-properties 1)) fork)
  	    t)))
!       (error "Point neither on reference nor in menu item description")))
  
  ;; Common subroutine.
  (defun Info-try-follow-nearest-node (&optional fork)
--- 3123,3130 ----
  	    (Info-goto-node
  	     (Info-extract-menu-item (match-string-no-properties 1)) fork)
  	    t)))
!       (unless (eq this-command 'Info-mouse-follow-nearest-node)
! 	(error "Point neither on reference nor in menu item description"))))
  
  ;; Common subroutine.
  (defun Info-try-follow-nearest-node (&optional fork)


Steve Berman




Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#886; Package emacs. Full text and rfc822 format available.

Acknowledgement sent to martin rudalics <rudalics <at> gmx.at>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. Full text and rfc822 format available.

Message #27 received at 886 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 886 <at> debbugs.gnu.org
Subject: Re: bug#886: 23.0.60; Info-mouse-follow-nearest-node fails
Date: Mon, 15 Sep 2008 14:11:38 +0200
> Does the following patch fix it?
>
> *** emacs/lisp/info.el.~1.544.~	2008-09-11 11:49:36.000000000 +0200
> --- emacs/lisp/info.el	2008-09-15 11:22:53.000000000 +0200
> ***************
> *** 3123,3129 ****
>   	    (Info-goto-node
>   	     (Info-extract-menu-item (match-string-no-properties 1)) fork)
>   	    t)))
> !       (error "Point neither on reference nor in menu item description")))
>
>   ;; Common subroutine.
>   (defun Info-try-follow-nearest-node (&optional fork)
> --- 3123,3130 ----
>   	    (Info-goto-node
>   	     (Info-extract-menu-item (match-string-no-properties 1)) fork)
>   	    t)))
> !       (unless (eq this-command 'Info-mouse-follow-nearest-node)
> ! 	(error "Point neither on reference nor in menu item description"))))
>
>   ;; Common subroutine.
>   (defun Info-try-follow-nearest-node (&optional fork)

Yes - the following seems simpler:

!       (eq this-command 'Info-mouse-follow-nearest-node)
! 	(error "Point neither on reference nor in menu item description")))

I'm not sure though whether we should raise an error for mouse-2 clicks.
But I also fail to understand why we should raise an error at all.

martin




Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#886; Package emacs. Full text and rfc822 format available.

Acknowledgement sent to Stephen Berman <stephen.berman <at> gmx.net>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. Full text and rfc822 format available.

Message #32 received at 886 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 886 <at> debbugs.gnu.org
Subject: Re: bug#886: 23.0.60; Info-mouse-follow-nearest-node fails
Date: Mon, 15 Sep 2008 15:48:24 +0200
On Mon, 15 Sep 2008 14:11:38 +0200 martin rudalics <rudalics <at> gmx.at> wrote:

>> Does the following patch fix it?
>>
>> *** emacs/lisp/info.el.~1.544.~	2008-09-11 11:49:36.000000000 +0200
>> --- emacs/lisp/info.el	2008-09-15 11:22:53.000000000 +0200
>> ***************
>> *** 3123,3129 ****
>>   	    (Info-goto-node
>>   	     (Info-extract-menu-item (match-string-no-properties 1)) fork)
>>   	    t)))
>> !       (error "Point neither on reference nor in menu item description")))
>>
>>   ;; Common subroutine.
>>   (defun Info-try-follow-nearest-node (&optional fork)
>> --- 3123,3130 ----
>>   	    (Info-goto-node
>>   	     (Info-extract-menu-item (match-string-no-properties 1)) fork)
>>   	    t)))
>> !       (unless (eq this-command 'Info-mouse-follow-nearest-node)
>> ! 	(error "Point neither on reference nor in menu item description"))))
>>
>>   ;; Common subroutine.
>>   (defun Info-try-follow-nearest-node (&optional fork)
>
> Yes - the following seems simpler:
>
> !       (eq this-command 'Info-mouse-follow-nearest-node)
> ! 	(error "Point neither on reference nor in menu item description")))

Oops, yes of course.

> I'm not sure though whether we should raise an error for mouse-2 clicks.
> But I also fail to understand why we should raise an error at all.

I agree an error here is unnecessary and it would be better to remove
it.  I doubt any existing code depends on it.

Steve Berman




Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#886; Package emacs. Full text and rfc822 format available.

Acknowledgement sent to martin rudalics <rudalics <at> gmx.at>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. Full text and rfc822 format available.

Message #37 received at 886 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 886 <at> debbugs.gnu.org
Subject: Re: bug#886: 23.0.60; Info-mouse-follow-nearest-node fails
Date: Wed, 17 Sep 2008 08:54:21 +0200
> I agree an error here is unnecessary and it would be better to remove
> it.  I doubt any existing code depends on it.

I checked in a fix which doesn't raise an error when mouse-1 is involved.

Thanks, martin





bug archived. Request was from Debbugs Internal Request <don <at> donarmstrong.com> to internal_control <at> emacsbugs.donarmstrong.com. (Wed, 15 Oct 2008 14:24:03 GMT) Full text and rfc822 format available.

This bug report was last modified 16 years and 246 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.