GNU bug report logs - #8853
24.0.50; regression: doc string of `special-display-popup-frame'

Previous Next

Full log

View this message in rfc822 format

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Chong Yidong'" <cyd <at> stupidchicken.com>, "'martin rudalics'" <rudalics <at> gmx.at>
Cc: 8853 <at> debbugs.gnu.org
Subject: bug#8853: 24.0.50; regression: doc string of `special-display-popup-frame'
Date: Wed, 29 Jun 2011 09:58:00 -0700

> >> This regression was introduced in release 23.1.  Prior to 
> >> that release, the doc string said, correctly,
> >> "If ARGS is a list whose car is a symbol, use (car ARGS) 
> >> as a function to do the work.  Pass it BUFFER as first arg,
> >> and (cdr ARGS) as the rest of its args."

What's important here is "as the _rest_ of its args".

> >> Now it says, incorrectly, "If ARGS is a list whose car
> >> is a symbol, use (car ARGS) as a function to do the work.
> >> Pass it BUFFER as first argument, and (cdr ARGS) as second."
> >>
> >> If ARGS is a list whose car is a symbol `f', then
> >> `special-display-popup-frame' invokes `f', passing it as
> >> arguments, BUFFER followed by all of the elements in
> >> (cdr ARGS).  The arity of `f' is the length of ARGS, not
> >> just 2.  We do not pass `f' (cdr ARGS) as a second argument.
> >
> > Indeed.  Could someone please restore the old doc-string in 
> > Emacs 23?
> 
> Fixed.

No, I do not see this fixed in the latest Windows build of Emacs 24:

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2011-06-27 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt --cflags
-Ic:/build/include'

It still says: "Pass it BUFFER as first argument, and (cdr ARGS) as second."

The point of the bug fix should be to replace "as second" by "as the rest of its
args" or equivalent.  Thx.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.