Subject: bug#8846: coreutils-8.12 on HP-UX 11.31: 3 of 365 tests failed

From: Jim Meyering <[email-masked]>
Date: Mon, 13 Jun 2011 12:35:03 +0200

Stefano Lattarini wrote:

> Hello Jim.
>
> Just a minor nit, since your fix will have to be ported to automake's
> `tests/defs' too ...
...
>> diff --git a/tests/init.sh b/tests/init.sh
>> index 14f2e26..7a701f6 100644
>> --- a/tests/init.sh
>> +++ b/tests/init.sh
>> @@ -74,7 +74,7 @@ Exit () { set +e; (exit $1); exit $1; }
>>  # the reason for skip/failure to console, rather than to the .log files.
>>  : ${stderr_fileno_=2}
>>
>> -warn_ () { echo "$@" 1>&$stderr_fileno_; }
>> +warn_ () { eval 'echo "'"$@"'" 1>&'"$stderr_fileno_"; }
>>
> Wouldn't it be simpler, and potentially more correct, to use simply:
>
>  warn_ () { eval 'echo "$@" 1>&'"$stderr_fileno_"; }
>
> With your new implementation, I see this on Debian with bash and dash:
>
>  $ stderr_fileno_=2; warn_ () { eval 'echo "'"$@"'" 1>&'"$stderr_fileno_"; }
>  $ $ warn_ '$HOME'
>  /home/stefano
>
> which is not intended behaviour IMHO.

Hah!  Thank you for the prompt fix.
That's more than a minor nit ;-)
I'm glad you caught my error.