From unknown Sun Jun 22 11:48:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8845: build failure on HP-UX 11.31 Resent-From: Bruno Haible Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 13 Jun 2011 08:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8845 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 8845@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.130795502231202 (code B ref -1); Mon, 13 Jun 2011 08:51:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jun 2011 08:50:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QW2qk-00087D-Di for submit@debbugs.gnu.org; Mon, 13 Jun 2011 04:50:22 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QW2qg-00086z-Pg for submit@debbugs.gnu.org; Mon, 13 Jun 2011 04:50:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QW2qZ-0000yC-V8 for submit@debbugs.gnu.org; Mon, 13 Jun 2011 04:50:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:38744) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QW2qY-0000xu-W7 for submit@debbugs.gnu.org; Mon, 13 Jun 2011 04:50:11 -0400 Received: from eggs.gnu.org ([140.186.70.92]:39536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QW2qV-0004yr-4y for bug-coreutils@gnu.org; Mon, 13 Jun 2011 04:50:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QW2qS-0000t5-SU for bug-coreutils@gnu.org; Mon, 13 Jun 2011 04:50:06 -0400 Received: from mo-p00-ob.rzone.de ([81.169.146.160]:11557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QW2qR-0000sa-Vu for bug-coreutils@gnu.org; Mon, 13 Jun 2011 04:50:04 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1307955001; l=1337; s=domk; d=haible.de; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Date:Subject:To: From:X-RZG-CLASS-ID:X-RZG-AUTH; bh=hK7AdjwxemdlvoA+bm1gRU4++2c=; b=HtpOPR8AVoGPEr1Ey6EGChZjElb/MXnayoQltpSv8U/J78da73fVhgAS7oZC4IV6i5k w7xKTHaM4layk9bSJOtsssaO/nT1jfeY415Rz2dhrJtjDwuBnWJu64vpWRDzOpT+P0U1L 0OdVpbGicn9WnoJ1MYv1PfCY1EeLjk4NxPk= X-RZG-AUTH: :Ln4Re0+Ic/6oZXR1YgKryK8brksyK8dozXDwHXjf9hj/zDNRbP444xzQwQ== X-RZG-CLASS-ID: mo00 Received: from linuix.haible.de (dslb-088-068-058-108.pools.arcor-ip.net [88.68.58.108]) by post.strato.de (jimi mo54) (RZmta 25.18) with ESMTPA id N01d3bn5D7ACjW ; Mon, 13 Jun 2011 10:50:01 +0200 (MEST) From: Bruno Haible Date: Mon, 13 Jun 2011 10:49:57 +0200 User-Agent: KMail/1.9.9 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <201106131049.58729.bruno@clisp.org> X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.4 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) Trying to compile coreutils-8.12 on HP-UX 11.31 with cc, I get this build failure: CC file-set.o cc: "file-set.h", line 9: error 1000: Unexpected symbol: "2". cc: "file-set.h", line 7: error 1670: Illegal attribute nonnull specified. gmake[4]: *** [file-set.o] Error 1 Here's a possible patch that fixes it. 2011-06-13 Bruno Haible Update after __attibute__ is no longer defined by gnulib. * lib/file-set.h (record_file): Use __attribute__ only with compiler versions that support it. *** lib/file-set.h.bak Sun Apr 24 17:21:45 2011 =2D-- lib/file-set.h Mon Jun 13 08:39:59 2011 *************** *** 6,12 **** =20 extern void record_file (Hash_table *ht, char const *file, struct stat const *stats) ! __attribute__ ((nonnull (2, 3))); =20 extern bool seen_file (Hash_table const *ht, char const *file, struct stat const *stats); =2D-- 6,15 ---- =20 extern void record_file (Hash_table *ht, char const *file, struct stat const *stats) ! #if defined __GNUC__ && ((__GNUC__ =3D=3D 3 && __GNUC_MINOR__ >=3D 3) || = __GNUC__ > 3) ! __attribute__ ((nonnull (2, 3))) ! #endif ! ; =20 extern bool seen_file (Hash_table const *ht, char const *file, struct stat const *stats); =2D-=20 In memoriam Anna G=C3=B6ldi From unknown Sun Jun 22 11:48:24 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Bruno Haible Subject: bug#8845: closed (Re: bug#8845: build failure on HP-UX 11.31) Message-ID: References: <87d3iihyp4.fsf@rho.meyering.net> <201106131049.58729.bruno@clisp.org> X-Gnu-PR-Message: they-closed 8845 X-Gnu-PR-Package: coreutils Reply-To: 8845@debbugs.gnu.org Date: Mon, 13 Jun 2011 09:24:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1307957042-1782-1" This is a multi-part message in MIME format... ------------=_1307957042-1782-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #8845: build failure on HP-UX 11.31 which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 8845@debbugs.gnu.org. --=20 8845: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D8845 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1307957042-1782-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 8845-done) by debbugs.gnu.org; 13 Jun 2011 09:23:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QW3N6-0000SN-Vw for submit@debbugs.gnu.org; Mon, 13 Jun 2011 05:23:49 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QW3N0-0000S2-Fi for 8845-done@debbugs.gnu.org; Mon, 13 Jun 2011 05:23:47 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 06EA06019A; Mon, 13 Jun 2011 11:23:35 +0200 (CEST) From: Jim Meyering To: Bruno Haible Subject: Re: bug#8845: build failure on HP-UX 11.31 In-Reply-To: <201106131049.58729.bruno@clisp.org> (Bruno Haible's message of "Mon, 13 Jun 2011 10:49:57 +0200") References: <201106131049.58729.bruno@clisp.org> Date: Mon, 13 Jun 2011 11:23:35 +0200 Message-ID: <87d3iihyp4.fsf@rho.meyering.net> Lines: 75 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 8845-done Cc: 8845-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) Bruno Haible wrote: > Trying to compile coreutils-8.12 on HP-UX 11.31 with cc, I get this build > failure: > > CC file-set.o > cc: "file-set.h", line 9: error 1000: Unexpected symbol: "2". > cc: "file-set.h", line 7: error 1670: Illegal attribute nonnull specified. > gmake[4]: *** [file-set.o] Error 1 > > > Here's a possible patch that fixes it. > > > 2011-06-13 Bruno Haible > > Update after __attibute__ is no longer defined by gnulib. > * lib/file-set.h (record_file): Use __attribute__ only with compiler > versions that support it. Thanks for reporting/fixing that, Bruno. I've adjusted the log slightly. Since it still has your name on it, I'll wait for an explicit "ok" before pushing. Or you may. I like to put the affected module name in the one-line summary and think it's worthwhile to mention the build failure and affected system in the log, too. >From d223e25b27f262a3478fd181f50b2952540f2571 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Mon, 13 Jun 2011 11:19:42 +0200 Subject: [PATCH] file-set.h: guard __attibute__ use, now that it's not always defined * lib/file-set.h (record_file): Use __attribute__ only with compiler versions that support it. This fixes a coreutils build failure with CC=cc on HP-UX 11.31. --- ChangeLog | 7 +++++++ lib/file-set.h | 5 ++++- 2 files changed, 11 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 7af3f05..f496314 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2011-06-13 Bruno Haible + + file-set.h: guard __attibute__ use, now that it's not always defined + * lib/file-set.h (record_file): Use __attribute__ only with compiler + versions that support it. This fixes a coreutils build failure with + CC=cc on HP-UX 11.31. + 2011-06-12 Bruno Haible acl: Add support for HP-UX >= 11.11 JFS ACLs. diff --git a/lib/file-set.h b/lib/file-set.h index 28d42fe..4e47d95 100644 --- a/lib/file-set.h +++ b/lib/file-set.h @@ -6,7 +6,10 @@ extern void record_file (Hash_table *ht, char const *file, struct stat const *stats) - __attribute__ ((nonnull (2, 3))); +#if defined __GNUC__ && ((__GNUC__ == 3 && __GNUC_MINOR__ >= 3) || __GNUC__ > 3) + __attribute__ ((nonnull (2, 3))) +#endif +; extern bool seen_file (Hash_table const *ht, char const *file, struct stat const *stats); -- 1.7.6.rc0.293.g40857 ------------=_1307957042-1782-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Jun 2011 08:50:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QW2qk-00087D-Di for submit@debbugs.gnu.org; Mon, 13 Jun 2011 04:50:22 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QW2qg-00086z-Pg for submit@debbugs.gnu.org; Mon, 13 Jun 2011 04:50:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QW2qZ-0000yC-V8 for submit@debbugs.gnu.org; Mon, 13 Jun 2011 04:50:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:38744) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QW2qY-0000xu-W7 for submit@debbugs.gnu.org; Mon, 13 Jun 2011 04:50:11 -0400 Received: from eggs.gnu.org ([140.186.70.92]:39536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QW2qV-0004yr-4y for bug-coreutils@gnu.org; Mon, 13 Jun 2011 04:50:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QW2qS-0000t5-SU for bug-coreutils@gnu.org; Mon, 13 Jun 2011 04:50:06 -0400 Received: from mo-p00-ob.rzone.de ([81.169.146.160]:11557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QW2qR-0000sa-Vu for bug-coreutils@gnu.org; Mon, 13 Jun 2011 04:50:04 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1307955001; l=1337; s=domk; d=haible.de; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Date:Subject:To: From:X-RZG-CLASS-ID:X-RZG-AUTH; bh=hK7AdjwxemdlvoA+bm1gRU4++2c=; b=HtpOPR8AVoGPEr1Ey6EGChZjElb/MXnayoQltpSv8U/J78da73fVhgAS7oZC4IV6i5k w7xKTHaM4layk9bSJOtsssaO/nT1jfeY415Rz2dhrJtjDwuBnWJu64vpWRDzOpT+P0U1L 0OdVpbGicn9WnoJ1MYv1PfCY1EeLjk4NxPk= X-RZG-AUTH: :Ln4Re0+Ic/6oZXR1YgKryK8brksyK8dozXDwHXjf9hj/zDNRbP444xzQwQ== X-RZG-CLASS-ID: mo00 Received: from linuix.haible.de (dslb-088-068-058-108.pools.arcor-ip.net [88.68.58.108]) by post.strato.de (jimi mo54) (RZmta 25.18) with ESMTPA id N01d3bn5D7ACjW ; Mon, 13 Jun 2011 10:50:01 +0200 (MEST) From: Bruno Haible To: bug-coreutils@gnu.org Subject: build failure on HP-UX 11.31 Date: Mon, 13 Jun 2011 10:49:57 +0200 User-Agent: KMail/1.9.9 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <201106131049.58729.bruno@clisp.org> X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) Trying to compile coreutils-8.12 on HP-UX 11.31 with cc, I get this build failure: CC file-set.o cc: "file-set.h", line 9: error 1000: Unexpected symbol: "2". cc: "file-set.h", line 7: error 1670: Illegal attribute nonnull specified. gmake[4]: *** [file-set.o] Error 1 Here's a possible patch that fixes it. 2011-06-13 Bruno Haible Update after __attibute__ is no longer defined by gnulib. * lib/file-set.h (record_file): Use __attribute__ only with compiler versions that support it. *** lib/file-set.h.bak Sun Apr 24 17:21:45 2011 =2D-- lib/file-set.h Mon Jun 13 08:39:59 2011 *************** *** 6,12 **** =20 extern void record_file (Hash_table *ht, char const *file, struct stat const *stats) ! __attribute__ ((nonnull (2, 3))); =20 extern bool seen_file (Hash_table const *ht, char const *file, struct stat const *stats); =2D-- 6,15 ---- =20 extern void record_file (Hash_table *ht, char const *file, struct stat const *stats) ! #if defined __GNUC__ && ((__GNUC__ =3D=3D 3 && __GNUC_MINOR__ >=3D 3) || = __GNUC__ > 3) ! __attribute__ ((nonnull (2, 3))) ! #endif ! ; =20 extern bool seen_file (Hash_table const *ht, char const *file, struct stat const *stats); =2D-=20 In memoriam Anna G=C3=B6ldi ------------=_1307957042-1782-1-- From unknown Sun Jun 22 11:48:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8845: build failure on HP-UX 11.31 Resent-From: Eric Blake Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 13 Jun 2011 14:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8845 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 8845@debbugs.gnu.org, jim@meyering.net Received: via spool by 8845-submit@debbugs.gnu.org id=B8845.13079760707977 (code B ref 8845); Mon, 13 Jun 2011 14:42:01 +0000 Received: (at 8845) by debbugs.gnu.org; 13 Jun 2011 14:41:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QW8KD-00024b-Nr for submit@debbugs.gnu.org; Mon, 13 Jun 2011 10:41:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QW8KA-000247-8R for 8845@debbugs.gnu.org; Mon, 13 Jun 2011 10:41:07 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5DEf0NJ001037 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 13 Jun 2011 10:41:00 -0400 Received: from [10.3.113.141] (ovpn-113-141.phx2.redhat.com [10.3.113.141]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p5DEexkI005597; Mon, 13 Jun 2011 10:41:00 -0400 Message-ID: <4DF6217B.2070702@redhat.com> Date: Mon, 13 Jun 2011 08:40:59 -0600 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110419 Red Hat/3.1.10-1.el6_0 Mnenhy/0.8.3 Thunderbird/3.1.10 MIME-Version: 1.0 References: <201106131049.58729.bruno@clisp.org> <87d3iihyp4.fsf@rho.meyering.net> In-Reply-To: <87d3iihyp4.fsf@rho.meyering.net> X-Enigmail-Version: 1.1.2 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigF646F622B4214F577F356535" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Spam-Score: -10.3 (----------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -10.3 (----------) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF646F622B4214F577F356535 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/13/2011 03:23 AM, Jim Meyering wrote: > +++ b/lib/file-set.h > @@ -6,7 +6,10 @@ >=20 > extern void record_file (Hash_table *ht, char const *file, > struct stat const *stats) > - __attribute__ ((nonnull (2, 3))); > +#if defined __GNUC__ && ((__GNUC__ =3D=3D 3 && __GNUC_MINOR__ >=3D 3) = || __GNUC__ > 3) > + __attribute__ ((nonnull (2, 3))) > +#endif > +; I'm not a fan of in-declaration #ifdefs; can we rewrite this to: #if defined __GNUC__ && ((__GNUC__ =3D=3D 3 && __GNUC_MINOR__ >=3D 3) || __GNUC__ > 3) # define ATTRIBUTE_NONNULL(a) __attribute__ ((nonnull (a))) #else # define ATTRIBUTE_NONNULL(a) /* ignored */ #endif extern void record_file (Hash_table *ht, char const *file, struct stat const *stats) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3); --=20 Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org --------------enigF646F622B4214F577F356535 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Red Hat - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJN9iF7AAoJEKeha0olJ0NqvdUH/3DE4AXHwVu7vgBNz6Nf9rjO Wq0gBiQJ+fhLvM6NdxNmdWJxHoLabLL9gvZeEGu1/O/EU4FfWFvCEz2pPelhWnju xPDuzwLjXr3k7GYti3S2HOVuCNC/jhieX7GW0RQlT4b4i8U9Y2pSWyklklPd798J 35vnYgw+reZ9h9IANAqzlpddVmcFqy+kVMiDMD+BRFf53fe9nUK4hsv9rVbXqOXL gvgjy6xTIxdPgn4/6+73kEmwXxCkknLvsk77hejxpxD/2puVQyvqubWGYETt1yfJ Hf3flI9+RHPZ6a+cYb1UtkJnOFAYb6GRGtmHwET508rBpCEt411GoBXqYj1+9mg= =SdQS -----END PGP SIGNATURE----- --------------enigF646F622B4214F577F356535-- From unknown Sun Jun 22 11:48:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8845: build failure on HP-UX 11.31 Resent-From: Jim Meyering Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 13 Jun 2011 15:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8845 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Eric Blake Cc: 8845@debbugs.gnu.org Received: via spool by 8845-submit@debbugs.gnu.org id=B8845.130797722411609 (code B ref 8845); Mon, 13 Jun 2011 15:01:01 +0000 Received: (at 8845) by debbugs.gnu.org; 13 Jun 2011 15:00:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QW8cq-000318-Lq for submit@debbugs.gnu.org; Mon, 13 Jun 2011 11:00:24 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QW8co-0002q2-67 for 8845@debbugs.gnu.org; Mon, 13 Jun 2011 11:00:22 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id B59186036E; Mon, 13 Jun 2011 17:00:16 +0200 (CEST) From: Jim Meyering In-Reply-To: <4DF6217B.2070702@redhat.com> (Eric Blake's message of "Mon, 13 Jun 2011 08:40:59 -0600") References: <201106131049.58729.bruno@clisp.org> <87d3iihyp4.fsf@rho.meyering.net> <4DF6217B.2070702@redhat.com> Date: Mon, 13 Jun 2011 17:00:16 +0200 Message-ID: <87tybtepz3.fsf@rho.meyering.net> Lines: 30 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) Eric Blake wrote: > On 06/13/2011 03:23 AM, Jim Meyering wrote: >> +++ b/lib/file-set.h >> @@ -6,7 +6,10 @@ >> >> extern void record_file (Hash_table *ht, char const *file, >> struct stat const *stats) >> - __attribute__ ((nonnull (2, 3))); >> +#if defined __GNUC__ && ((__GNUC__ == 3 && __GNUC_MINOR__ >= 3) || __GNUC__ > 3) >> + __attribute__ ((nonnull (2, 3))) >> +#endif >> +; > > I'm not a fan of in-declaration #ifdefs; can we rewrite this to: > > #if defined __GNUC__ && ((__GNUC__ == 3 && __GNUC_MINOR__ >= 3) || > __GNUC__ > 3) > # define ATTRIBUTE_NONNULL(a) __attribute__ ((nonnull (a))) > #else > # define ATTRIBUTE_NONNULL(a) /* ignored */ > #endif > > extern void record_file (Hash_table *ht, char const *file, > struct stat const *stats) > ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3); I feel the same way, but that definition would impinge on the name space of any application that includes file-set.h. IMHO, in this case, name-space cleanliness trumps aesthetics, especially in a header file that will rarely be read by a human.