GNU bug report logs - #8838
tty-run-terminal-initialization fails

Previous Next

Full log

View this message in rfc822 format

From: Glenn Morris <rgm <at> gnu.org>
To: 8838 <at> debbugs.gnu.org
Subject: bug#8838: tty-run-terminal-initialization fails
Date: Tue, 14 Jun 2011 13:16:40 -0400

Ted Zlatanov wrote:

> On Sun, 12 Jun 2011 17:42:59 -0500 Ted Zlatanov <tzz <at> lifelogs.com> wrote: 
>
> TZ> I disagree with replacing `when' with `if' in the case of just one
> TZ> clause, which you did in several places.  Rather than simplifying the
> TZ> code, it complicates reading it IMO.  Since `when' is a macro I think
> TZ> any performance gains are minor.
>
> Glenn, can you reply to this please?  If `when' should be discouraged,
> tell me so, otherwise I'm not sure why you changed it.

Oh, sorry. Just personal preference. I don't see the point of using:

(when
  single-form)

since it expands to

(if
  (progn
    single-form))

which seems like a waste of a progn to me. (Maybe the compiler optimizes
it away though, I don't actually know.)

In this case, I think I was just put in an anti-when mood by things of
the form:

(when a
  (when b
   ...))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.