From unknown Fri Sep 05 09:10:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8802: cperl-write-tags function in cperl-mode.el hard coded tags-file-name Resent-From: Dove Young Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jun 2011 12:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8802 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 8802@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.130727700816307 (code B ref -1); Sun, 05 Jun 2011 12:31:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Jun 2011 12:30:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QTCT1-0004Ex-JZ for submit@debbugs.gnu.org; Sun, 05 Jun 2011 08:30:08 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QT48o-00009D-Db for submit@debbugs.gnu.org; Sat, 04 Jun 2011 23:36:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QT48h-0006xF-JK for submit@debbugs.gnu.org; Sat, 04 Jun 2011 23:36:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:60236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QT48h-0006wp-7w for submit@debbugs.gnu.org; Sat, 04 Jun 2011 23:36:35 -0400 Received: from eggs.gnu.org ([140.186.70.92]:47867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QT48f-0001LC-Iy for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2011 23:36:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QT48d-0006t0-OM for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2011 23:36:33 -0400 Received: from mail-gx0-f169.google.com ([209.85.161.169]:40449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QT48d-0006r0-AL for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2011 23:36:31 -0400 Received: by gxk23 with SMTP id 23so1463927gxk.0 for ; Sat, 04 Jun 2011 20:36:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:from:date:message-id:subject:to :content-type; bh=KUOVW+Lb9TSgb3SkG1+pJBk2mI1XaB5SWjqDctJFzAw=; b=pVOHW5RJ0ilDGZ/1rv1yr4LcLXN+K/k4GScCDcjGiWOHO+NMklD/rGQqUJ6srTc7Rg 4IqH13ZdZF+KFu1OdnygjczkNyMNR2ztgeawS8C9YIxqq31jPZAyKOUyHXCNklLRsvRq hiOUrhpgec2xkTVCay1OvzxWgdWqGrkoO2o9M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=NB/8OAu7tJy3LNmIWqGQCbcX8QOwdyFL9yHri7JR4zW8rCp4OIa0DV6psMo/+tNQ2M L+6HKn7puHX2fcr7TwyD37iZQqWFudTHlP+tUc1d8CkDbj5g6HaIKMTYWoYwCf5S3Fvq 3NExsrgrioZPaFo7tx0LzhKg/CFlNyRzUE+tA= Received: by 10.150.138.9 with SMTP id l9mr3068715ybd.236.1307244990160; Sat, 04 Jun 2011 20:36:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.151.156.1 with HTTP; Sat, 4 Jun 2011 20:36:10 -0700 (PDT) From: Dove Young Date: Sun, 5 Jun 2011 11:36:10 +0800 Message-ID: Content-Type: multipart/alternative; boundary=000e0cd56a1a45e02404a4eeb1cc X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.9 (-----) X-Mailman-Approved-At: Sun, 05 Jun 2011 08:30:06 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) --000e0cd56a1a45e02404a4eeb1cc Content-Type: text/plain; charset=ISO-8859-1 The original code reads like this (defun cperl-write-tags (&optional file erase recurse dir inbuffer noxs topdir) ;; If INBUFFER, do not select buffer, and do not save ;; If ERASE is `ignore', do not erase, and do not try to delete old info. (require 'etags) (if file nil (setq file (if dir default-directory (buffer-file-name))) (if (and (not dir) (buffer-modified-p)) (error "Save buffer first!"))) (or topdir (setq topdir default-directory)) (let ((tags-file-name "TAGS") (case-fold-search (eq system-type 'emx)) xs rel tm) ... ... ... ... This line (let ((tags-file-name "TAGS") hard coded the tags-file-name to "TAGS". This way is very bad. It prevents any users to customise their own tags files. For example in my environment I have to customise tags file names. I use pde-mode (Perl Development Environment) in my daily work. it leverage cperl-mode but would generate tags files base on Perl syntax. It is quite different than what etags would do. This kind of tags file cannot be used in any other features, such as speedbar, etc. So the reasonable way is to store this kind of tags into separate files. But it cannot because of the hard code in cperl-mode.el . So would I suggest to re-factory cperl-mode.el and change "TAGS" to a variable? Like following: (defvar cperl-tags-file-name "TAGS" "TAGS file name" (defun cperl-write-tags (&optional file erase recurse dir inbuffer noxs topdir) ;; If INBUFFER, do not select buffer, and do not save ;; If ERASE is `ignore', do not erase, and do not try to delete old info. (require 'etags) (if file nil (setq file (if dir default-directory (buffer-file-name))) (if (and (not dir) (buffer-modified-p)) (error "Save buffer first!"))) (or topdir (setq topdir default-directory)) (let ((tags-file-name cperl-tags-file-name) (case-fold-search (eq system-type 'emx)) xs rel tm) ... ... ... ... In this way, I can customise it by set cperl-tags-file-name in other value to avoid to break any other features: (setq cperl-tags-file-name "PDE-TAGS") -- M-x Thinks --000e0cd56a1a45e02404a4eeb1cc Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable The original code reads like this


(defun cperl-write-tags (&= optional file erase recurse dir inbuffer noxs topdir)
=A0 ;; If INBUFFER= , do not select buffer, and do not save
=A0 ;; If ERASE is `ignore',= do not erase, and do not try to delete old info.
=A0 (require 'etags)
=A0 (if file nil
=A0=A0=A0 (setq file (if di= r default-directory (buffer-file-name)))
=A0=A0=A0 (if (and (not dir) (b= uffer-modified-p)) (error "Save buffer first!")))
=A0 (or topd= ir
=A0=A0=A0=A0=A0 (setq topdir default-directory))
=A0 (let ((tags-file-name "TAGS")
=A0=A0=A0 (case-fold-search = (eq system-type 'emx))
=A0=A0=A0 xs rel tm)
... ... ... ...
This line (let ((tags-file-name "TAGS") hard coded the tags-fi= le-name to "TAGS".=A0 This way is very bad. It prevents any users= to customise their own tags files. For example in my environment I have to= customise tags file names.

I use pde-mode (Perl Development Environment) in my daily work. it leve= rage cperl-mode but would generate tags files base on Perl syntax. It is qu= ite different than what etags would do. This kind of tags file cannot be us= ed in any other features, such as speedbar, etc. So the reasonable way is t= o store this kind of tags into separate files. But it cannot because of the= hard code in cperl-mode.el .


So would I suggest to re-factory cperl-mode.el and change "TAG= S" to a variable? Like following:

(defvar cperl-tags-file-name = "TAGS" "TAGS file name"

(defun cperl-write-tags = (&optional file erase recurse dir inbuffer noxs topdir)
=A0 ;; If INBUFFER, do not select buffer, and do not save
=A0 ;; If ERAS= E is `ignore', do not erase, and do not try to delete old info.
=A0 = (require 'etags)
=A0 (if file nil
=A0=A0=A0 (setq file (if dir de= fault-directory (buffer-file-name)))
=A0=A0=A0 (if (and (not dir) (buffer-modified-p)) (error "Save buffer = first!")))
=A0 (or topdir
=A0=A0=A0=A0=A0 (setq topdir default-d= irectory))
=A0 (let ((tags-file-name cperl-tags-file-name)
=A0=A0=A0 = (case-fold-search (eq system-type 'emx))
=A0=A0=A0 xs rel tm)
... ... ... ...

In this way, I can customise= it by set cperl-tags-file-name in other value to avoid to break any other = features:

(setq cperl-tags-file-name "PDE-TAGS")

--
M-x Thinks

--000e0cd56a1a45e02404a4eeb1cc-- From unknown Fri Sep 05 09:10:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8802: cperl-write-tags function in cperl-mode.el hard coded tags-file-name Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2011 17:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8802 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dove Young Cc: Chong Yidong , 8802@debbugs.gnu.org, Stefan Monnier Received: via spool by 8802-submit@debbugs.gnu.org id=B8802.130997252123642 (code B ref 8802); Wed, 06 Jul 2011 17:16:02 +0000 Received: (at 8802) by debbugs.gnu.org; 6 Jul 2011 17:15:21 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeVh2-00069D-Q1 for submit@debbugs.gnu.org; Wed, 06 Jul 2011 13:15:21 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeVh0-0005zl-Mq for 8802@debbugs.gnu.org; Wed, 06 Jul 2011 13:15:19 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QeVgo-0007Nh-6A; Wed, 06 Jul 2011 19:15:06 +0200 From: Lars Magne Ingebrigtsen In-Reply-To: (Dove Young's message of "Sun, 5 Jun 2011 11:36:10 +0800") Date: Wed, 06 Jul 2011 19:14:59 +0200 Message-ID: References: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Demdike Stare's _Tryptych (3): Voices Of Dust_: "Past Is Past" X-Hashcash: 1:23:110706:8802@debbugs.gnu.org::Yno30NJ64rZczVnz:000000000000000000000000000000000000000002FcS X-Hashcash: 1:23:110706:dove.young@gmail.com::MhU8e4I/MD/4ik9N:00000000000000000000000000000000000000000DBCa MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QeVgo-0007Nh-6A X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1310577306.44149@AB+tkKqjXUdfDIc9ktX1jw X-Spam-Status: No X-Spam-Score: -2.8 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) Dove Young writes: > So would I suggest to re-factory cperl-mode.el and change "TAGS" to a > variable? Like following: > > (defvar cperl-tags-file-name "TAGS" "TAGS file name" That sounds like a reasonable request to me, but Emacs is in a feature freeze at the moment, and I'm not sure adding stuff like this is "allowed" during the freeze. Stefan, Chong? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Fri Sep 05 09:10:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8802: cperl-write-tags function in cperl-mode.el hard coded tags-file-name Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2011 18:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8802 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Magne Ingebrigtsen Cc: Dove Young , Chong Yidong , 8802@debbugs.gnu.org Received: via spool by 8802-submit@debbugs.gnu.org id=B8802.13099761642215 (code B ref 8802); Wed, 06 Jul 2011 18:17:02 +0000 Received: (at 8802) by debbugs.gnu.org; 6 Jul 2011 18:16:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeWdn-0000Zg-Us for submit@debbugs.gnu.org; Wed, 06 Jul 2011 14:16:04 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeWdl-0000Z6-Jn for 8802@debbugs.gnu.org; Wed, 06 Jul 2011 14:16:02 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAIalFE5FxIV4/2dsb2JhbABTqAd4iHrDPIY3BJ5rhC8 X-IronPort-AV: E=Sophos;i="4.65,488,1304308800"; d="scan'208";a="120700774" Received: from 69-196-133-120.dsl.teksavvy.com (HELO ceviche.home) ([69.196.133.120]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 06 Jul 2011 14:15:55 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 835FD660D9; Wed, 6 Jul 2011 14:15:55 -0400 (EDT) From: Stefan Monnier Message-ID: References: Date: Wed, 06 Jul 2011 14:15:55 -0400 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Wed, 06 Jul 2011 19:14:59 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) >> So would I suggest to re-factory cperl-mode.el and change "TAGS" to a >> variable? Like following: >> (defvar cperl-tags-file-name "TAGS" "TAGS file name" > That sounds like a reasonable request to me, but Emacs is in a feature > freeze at the moment, and I'm not sure adding stuff like this is > "allowed" during the freeze. I'd rather that such a change be installed in Ilya's upstream version first. We already have plenty of merge problems because of patches he rejected. BTW, the recent change to use define-derived-mode introduced a problem where the cperl-mode-hook gets called twice, so I think we had better revert it. Stefan From unknown Fri Sep 05 09:10:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8802: cperl-write-tags function in cperl-mode.el hard coded tags-file-name Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2011 18:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8802 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Dove Young , Chong Yidong , 8802@debbugs.gnu.org Received: via spool by 8802-submit@debbugs.gnu.org id=B8802.13099765012769 (code B ref 8802); Wed, 06 Jul 2011 18:22:01 +0000 Received: (at 8802) by debbugs.gnu.org; 6 Jul 2011 18:21:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeWjF-0000ib-CJ for submit@debbugs.gnu.org; Wed, 06 Jul 2011 14:21:41 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeWjC-0000iO-R5 for 8802@debbugs.gnu.org; Wed, 06 Jul 2011 14:21:39 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QeWix-0008OF-MY; Wed, 06 Jul 2011 20:21:23 +0200 From: Lars Magne Ingebrigtsen In-Reply-To: (Stefan Monnier's message of "Wed, 06 Jul 2011 14:15:55 -0400") Date: Wed, 06 Jul 2011 20:21:19 +0200 Message-ID: References: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Demdike Stare's _Tryptych (2): Liberation Through Hearing_: "Regolith" X-Hashcash: 1:23:110706:cyd@stupidchicken.com::OVx6ICADo7GmbOOt:00000000000000000000000000000000000000002o6t X-Hashcash: 1:23:110706:monnier@iro.umontreal.ca::4mkK99HfCEfrxHkC:00000000000000000000000000000000000009tv6 X-Hashcash: 1:23:110706:8802@debbugs.gnu.org::tN0iW2Y8BQuNpJGX:00000000000000000000000000000000000000000waHR X-Hashcash: 1:23:110706:dove.young@gmail.com::iM//PyHSLZXRFMvG:000000000000000000000000000000000000000017pGS MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QeWix-0008OF-MY X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1310581284.10079@bZRcayVgwhN+G22gYwwT6w X-Spam-Status: No X-Spam-Score: -2.8 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) Stefan Monnier writes: > I'd rather that such a change be installed in Ilya's upstream > version first. We already have plenty of merge problems because of > patches he rejected. Right. Would forwarding the report to Ilya and closing the bug report in debbugs be the right thing to do? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Fri Sep 05 09:10:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8802: cperl-write-tags function in cperl-mode.el hard coded tags-file-name Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2011 19:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8802 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Magne Ingebrigtsen Cc: Dove Young , Chong Yidong , 8802@debbugs.gnu.org, Stefan Monnier Received: via spool by 8802-submit@debbugs.gnu.org id=B8802.130998095214057 (code B ref 8802); Wed, 06 Jul 2011 19:36:01 +0000 Received: (at 8802) by debbugs.gnu.org; 6 Jul 2011 19:35:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeXt1-0003ee-UL for submit@debbugs.gnu.org; Wed, 06 Jul 2011 15:35:52 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeXsz-0003eJ-M1 for 8802@debbugs.gnu.org; Wed, 06 Jul 2011 15:35:50 -0400 Received: from localhost ([127.0.0.1]:49319) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QeXss-0002mk-MC; Wed, 06 Jul 2011 15:35:42 -0400 From: Glenn Morris References: X-Spook: Mena arrangements insurgency COSCO pre-emptive ASPIC X-Ran: QSt6cLu@4?/hzs2a*YL*/I5PO8%H9S5.K=V'|i:[*Fs.,Wv^K9DgoSkr#%)%sT@.1net)_ X-Hue: black X-Attribution: GM Date: Wed, 06 Jul 2011 15:35:42 -0400 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Wed, 06 Jul 2011 20:21:19 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) Lars Magne Ingebrigtsen wrote: > Stefan Monnier writes: > >> I'd rather that such a change be installed in Ilya's upstream >> version first. We already have plenty of merge problems because of >> patches he rejected. This always makes me wonder: what is the point of having a file in Emacs where modifying it is not allowed (or at least, is strongly discouraged)? Why not move it to GNU ELPA? It's not like there isn't another perl mode in Emacs, which is actually used by default. > Right. Would forwarding the report to Ilya and closing the bug report > in debbugs be the right thing to do? Debbugs has the ability to mark a report as forwarded, see http://debbugs.gnu.org/Developer.html#forward Such reports are not usually closed. From unknown Fri Sep 05 09:10:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8802: cperl-write-tags function in cperl-mode.el hard coded tags-file-name Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2011 19:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8802 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: Dove Young , Lars Magne Ingebrigtsen , 8802@debbugs.gnu.org, Chong Yidong , Ilya Zakharevich Received: via spool by 8802-submit@debbugs.gnu.org id=B8802.130998192515820 (code B ref 8802); Wed, 06 Jul 2011 19:53:02 +0000 Received: (at 8802) by debbugs.gnu.org; 6 Jul 2011 19:52:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeY8h-000477-TX for submit@debbugs.gnu.org; Wed, 06 Jul 2011 15:52:04 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeY8f-00046e-Hx for 8802@debbugs.gnu.org; Wed, 06 Jul 2011 15:52:02 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAM27FE5FxIV4/2dsb2JhbABTqAd4iHrDL4Y3BJ5rhC8 X-IronPort-AV: E=Sophos;i="4.65,488,1304308800"; d="scan'208";a="120712856" Received: from 69-196-133-120.dsl.teksavvy.com (HELO pastel.home) ([69.196.133.120]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 06 Jul 2011 15:51:55 -0400 Received: by pastel.home (Postfix, from userid 20848) id DB065592B6; Wed, 6 Jul 2011 15:51:54 -0400 (EDT) From: Stefan Monnier Message-ID: References: Date: Wed, 06 Jul 2011 15:51:54 -0400 In-Reply-To: (Glenn Morris's message of "Wed, 06 Jul 2011 15:35:42 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) >>> I'd rather that such a change be installed in Ilya's upstream >>> version first. We already have plenty of merge problems because of >>> patches he rejected. > This always makes me wonder: what is the point of having a file in Emacs > where modifying it is not allowed (or at least, is strongly > discouraged)? Why not move it to GNU ELPA? It's not like there isn't > another perl mode in Emacs, which is actually used by default. Good point. But AFAIK it does have a fairly large number of users. Chong, Ilya, what do you guys think? Stefan From unknown Fri Sep 05 09:10:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8802: cperl-write-tags function in cperl-mode.el hard coded tags-file-name Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2011 19:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8802 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Glenn Morris , Chong Yidong , 8802@debbugs.gnu.org, Ilya Zakharevich , Dove Young Received: via spool by 8802-submit@debbugs.gnu.org id=B8802.130998207616119 (code B ref 8802); Wed, 06 Jul 2011 19:55:01 +0000 Received: (at 8802) by debbugs.gnu.org; 6 Jul 2011 19:54:36 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeYBA-0004Bw-Fm for submit@debbugs.gnu.org; Wed, 06 Jul 2011 15:54:36 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeYB7-0004Bh-JK for 8802@debbugs.gnu.org; Wed, 06 Jul 2011 15:54:35 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QeYAv-0001SN-Nx; Wed, 06 Jul 2011 21:54:21 +0200 From: Lars Magne Ingebrigtsen In-Reply-To: (Stefan Monnier's message of "Wed, 06 Jul 2011 15:51:54 -0400") Date: Wed, 06 Jul 2011 21:54:18 +0200 Message-ID: References: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEUKBwb6+fjBubmEeXzk 3901LS3////+//6vJLFVAAACPElEQVQ4jY2SzY7bIBDHkSIegC2Kr82Ae07APAB4ml6tsPMAqSL7 7FUVv34HnKhOV5U6SiwzP/7zaRGb8dWuqpqIzf0vsMzs1+KzIrkElsFST/zfX0c13uvrWELdn+A8 jrqAZ44KErKpBpP3sZyn+amgrss3Z3tvzjXTLNRaFLj37naC3rn7Q7GC5OmSOY53rX1R/HJd5z6C Mc5/ew2FMaafNuGh37+AZpmjfWuiOl/vLwARUtRosbmuimUFap7U3Ci1L63NGwXYK4ACOwLaBBsF 4g2T0rjn/hNuwGeb/gXG/wDT9sp0L2Cdr7GbXU6cfJlrSzr40/R2foClAK2YTH07ZKDsyp6mceEN zghRcSQaZBBC5nFKTpfVxmRQ72+B/CDY8ll7x1cFtwoaf3xQxmMB4tST9FEL5PFgij2RqwrhPHEq ZGAZ2J5yW/0ih0DkLQO2BCZfvgvpOY9nhcxQgXHQUg5COh9kyNAKKgpPrXNcFHGt5LPvMBGDBNkD +EB5kPxiQjDlxIrER8icUOxSueFNORUQHJS2SQjgHDkrbUJegTfDILmLneFcmct5gJ3zA1Fp72KI iAMeL9wghlL+UIHktIQGhksqs2JwHPI6Qn52CWQZCX55KmT9CedMtgUceQqcgwNxBZLbB3NBFLat AUoKyTI5dNyWAyugxF6B4CflORUAAtZhV7+kYXeIdd4gTPWX4JWcVNQp/QE5VCDooDeAw5Si6gX+ ZDDVUG11ruvmaQHgA3wVW6ug+P1vcHAWHT4yL7cAAAAASUVORK5CYII= X-Now-Playing: The Slits's _The John Peel Sessions_: "Love And Romance" X-Hashcash: 1:23:110706:rgm@gnu.org::LXL/w3JgMaKxWPP8:000000BJ8y X-Hashcash: 1:23:110706:ilyaz@cpan.org::nGWK4zWaJ2flTDcl:000GBfg X-Hashcash: 1:23:110706:cyd@stupidchicken.com::KQ+xwRTOwZ2+yQrt:0000000000000000000000000000000000000000Kzep X-Hashcash: 1:23:110706:dove.young@gmail.com::6kWytinQfEwmfXQb:00000000000000000000000000000000000000000NVJA X-Hashcash: 1:23:110706:monnier@iro.umontreal.ca::8uJMKfT/O8TczUoJ:0000000000000000000000000000000000000ai58 X-Hashcash: 1:23:110706:8802@debbugs.gnu.org::8B6c9A4Ut10EP7sQ:00000000000000000000000000000000000000000h+Cs MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QeYAv-0001SN-Nx X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1310586862.07191@1qrOhP00sZecVWgh78HTFw X-Spam-Status: No X-Spam-Score: -2.8 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) Stefan Monnier writes: > Good point. But AFAIK it does have a fairly large number of users. > Chong, Ilya, what do you guys think? cperl-mode has lots and lots of users, I think. This would break their Emacs 24 work flow significantly, in my opinion. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Fri Sep 05 09:10:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8802: cperl-write-tags function in cperl-mode.el hard coded tags-file-name Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Nov 2020 05:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8802 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Dove Young , Lars Magne Ingebrigtsen , 8802@debbugs.gnu.org, Chong Yidong Received: via spool by 8802-submit@debbugs.gnu.org id=B8802.160576319212283 (code B ref 8802); Thu, 19 Nov 2020 05:20:02 +0000 Received: (at 8802) by debbugs.gnu.org; 19 Nov 2020 05:19:52 +0000 Received: from localhost ([127.0.0.1]:37665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfcMK-0003C3-JU for submit@debbugs.gnu.org; Thu, 19 Nov 2020 00:19:52 -0500 Received: from mail-ed1-f52.google.com ([209.85.208.52]:39500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfcME-0003BL-RV for 8802@debbugs.gnu.org; Thu, 19 Nov 2020 00:19:49 -0500 Received: by mail-ed1-f52.google.com with SMTP id e18so4491802edy.6 for <8802@debbugs.gnu.org>; Wed, 18 Nov 2020 21:19:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=HEMYhVW/7zfU9H0PMAtN0PpqErDeaLXqJt7CPRr3ujc=; b=uUc1tc0WTDEO5uyE6RyWiW0a+lzZWXtNtprni2rNKExepjJ/feo+PhxIupQYhOHvJH 8Rfj7JyiU9X34/SbvcA5dH3cDlnC854oHD+tke1XYl1mTQdt4VkONCyATTwv1mGaVL0z 7qTbMrqFpfZhevC5jH0EY9RC86vb7RjY4z3YQEV2OUKmoDMDA9RU5w90DTYTqdKIuoQI o0rQNeO30GrfudptSfbHF8hOXCN7xPW61mvVNDOqv8b7QZpLvykhcl1j0csHZthRPw+Z nwb/AMplIdmnQ+O6ai2SivQXe4D5wcAHwxyfFqeIMG78rnsdOUbpPtr5hl1BsVz9rpqH gkBg== X-Gm-Message-State: AOAM533lbluDQ/XKhaZt7lBLXwUzrJ+5zmh/nrnWLWZRji+wmVIyx5b4 JXmiCpEdrdgngAhIa1rNl72HmLkWH2KJu1j7TDU= X-Google-Smtp-Source: ABdhPJy82MG7mDnmhOJF3233dSI6cBpi4vEok0kXZGk5KZgFiLfEly1a8VxoeIz9pcLVFNYNnXzo18Pgl6FWRjqUygU= X-Received: by 2002:aa7:d888:: with SMTP id u8mr29814870edq.210.1605763181288; Wed, 18 Nov 2020 21:19:41 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 18 Nov 2020 21:19:40 -0800 From: Stefan Kangas In-Reply-To: (Stefan Monnier's message of "Wed, 06 Jul 2011 14:15:55 -0400") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Wed, 18 Nov 2020 21:19:40 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 8802 + fixed close 8802 28.1 thanks Stefan Monnier writes: >>> So would I suggest to re-factory cperl-mode.el and change "TAGS" to a >>> variable? Like following: >>> (defvar cperl-tags-file-name "TAGS" "TAGS file name" > >> That sounds like a reasonable request to me, but Emacs is in a feature >> freeze at the moment, and I'm not sure adding stuff like this is >> "allowed" during the freeze. > > I'd rather that such a change be installed in Ilya's upstream > version first. We already have plenty of merge problems because of > patches he rejected. So given that the above merge problems are no longer a concern, I've now added such a variable on master. I'm therefore also closing this bug report.