From unknown Tue Aug 19 23:11:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8799: 23.3; iswitchb Resent-From: Stephen Eglen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jun 2011 09:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 8799@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.130718053318286 (code B ref -1); Sat, 04 Jun 2011 09:43:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jun 2011 09:42:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSnMz-0004kt-AI for submit@debbugs.gnu.org; Sat, 04 Jun 2011 05:42:13 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSnMx-0004kh-Sj for submit@debbugs.gnu.org; Sat, 04 Jun 2011 05:42:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QSnMs-0008QM-4S for submit@debbugs.gnu.org; Sat, 04 Jun 2011 05:42:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:39174) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSnMs-0008QH-30 for submit@debbugs.gnu.org; Sat, 04 Jun 2011 05:42:06 -0400 Received: from eggs.gnu.org ([140.186.70.92]:60925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSnMq-0002MP-Ml for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2011 05:42:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QSnMp-0008PX-Qc for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2011 05:42:04 -0400 Received: from ppsw-51.csi.cam.ac.uk ([131.111.8.151]:60840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSnMp-0008P8-KH for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2011 05:42:03 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from cpc28-cmbg15-2-0-cust3.5-4.cable.virginmedia.com ([86.27.189.4]:51187 helo=localhost) by ppsw-51.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.158]:587) with esmtpsa (PLAIN:sje30) (TLSv1:DHE-RSA-AES256-SHA:256) id 1QSnMo-0004Am-Xm (Exim 4.72) for bug-gnu-emacs@gnu.org (return-path ); Sat, 04 Jun 2011 10:42:02 +0100 From: Stephen Eglen X-Mailer: MH-E 8.2; nmh 1.3; GNU Emacs 23.3.1 Date: Sat, 04 Jun 2011 10:42:00 +0100 Message-Id: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.6 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) The following bug report was sent to me by Trevor Spiteri (thank you!). ---------------------------------------------------------------------- The documentation for iswitchb-window-buffer-p states that it should return nil if BUFFER is visible in the current frame. Sometimes this does not happen. Suppose I am in a frame with two windows, one for buffer1 and the other for buffer2, and I am currently in the window for buffer1. If I type: C-x b b u f f e r 2 this works correctly, iswitchb-window-buffer-p returns nil, and consequently both windows will show buffer2. If instead of I use C-j, that is, I am in the window for buffer1 and buffer2 is in the other window, and I type: C-x b b u f f e r 2 C-j iswitchb-window-buffer-p does not return nil, and consequently not both windows will show buffer2, but the window for buffer2 becomes the current window. To fix this, in the defun for iswitchb-window-buffer-p, the line (if (memq buffer blist) should be changed to: (if (member buffer blist) What I guess is happening is that using , buffer is a string obtained from the list of buffers, so it is eq to the corresponding element in blist. When C-j is used, buffer is taken from user input, and is thus not eq to the corresponding element in blist. Although it is not eq, it is still equal, so changing memq to member fixes the issue. ---------------------------------------------------------------------- From unknown Tue Aug 19 23:11:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8799: 23.3; iswitchb Resent-From: Deniz Dogan Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jun 2011 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Eglen Cc: 8799@debbugs.gnu.org Received: via spool by 8799-submit@debbugs.gnu.org id=B8799.130720051116398 (code B ref 8799); Sat, 04 Jun 2011 15:16:02 +0000 Received: (at 8799) by debbugs.gnu.org; 4 Jun 2011 15:15:11 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSsZC-0004GQ-Rj for submit@debbugs.gnu.org; Sat, 04 Jun 2011 11:15:11 -0400 Received: from ch-smtp04.sth.basefarm.net ([80.76.153.5]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSsZ9-0004Fy-GW for 8799@debbugs.gnu.org; Sat, 04 Jun 2011 11:15:08 -0400 Received: from c80-216-105-155.bredband.comhem.se ([80.216.105.155]:56699 helo=[192.168.0.10]) by ch-smtp04.sth.basefarm.net with esmtp (Exim 4.76) (envelope-from ) id 1QSsYY-0001Tk-G4; Sat, 04 Jun 2011 17:14:32 +0200 Message-ID: <4DEA4BC6.7020405@dogan.se> Date: Sat, 04 Jun 2011 17:14:14 +0200 From: Deniz Dogan User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: 80.216.105.155 X-Scan-Result: No virus found in message 1QSsYY-0001Tk-G4. X-Scan-Signature: ch-smtp04.sth.basefarm.net 1QSsYY-0001Tk-G4 cd8a1e03ee946431df299552864c1eb3 X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On 2011-06-04 11:42, Stephen Eglen wrote: > The following bug report was sent to me by Trevor Spiteri (thank you!). > > ---------------------------------------------------------------------- > The documentation for iswitchb-window-buffer-p states that it should > return nil if BUFFER is visible in the current frame. Sometimes this > does not happen. > > Suppose I am in a frame with two windows, one for buffer1 and the other > for buffer2, and I am currently in the window for buffer1. If I type: > C-x b b u f f e r 2 > this works correctly, iswitchb-window-buffer-p returns nil, and > consequently both windows will show buffer2. > > If instead of I use C-j, that is, I am in the window for > buffer1 and buffer2 is in the other window, and I type: > C-x b b u f f e r 2 C-j > iswitchb-window-buffer-p does not return nil, and consequently not both > windows will show buffer2, but the window for buffer2 becomes the > current window. > > To fix this, in the defun for iswitchb-window-buffer-p, the line > > (if (memq buffer blist) > > should be changed to: > > (if (member buffer blist) > > What I guess is happening is that using, buffer is a string > obtained from the list of buffers, so it is eq to the corresponding > element in blist. When C-j is used, buffer is taken from user input, and > is thus not eq to the corresponding element in blist. Although it is not > eq, it is still equal, so changing memq to member fixes the issue. > ---------------------------------------------------------------------- > > > I have pushed a fix for this to emacs-trunk, but I afterwards realized I should have pushed it to emacs-23. Could someone knowledgeable fix this for me? Thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 15:14:15 2011 Received: (at control) by debbugs.gnu.org; 4 Jun 2011 19:14:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSwIZ-0000xO-Ly for submit@debbugs.gnu.org; Sat, 04 Jun 2011 15:14:15 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSwIX-0000xD-Nf for control@debbugs.gnu.org; Sat, 04 Jun 2011 15:14:14 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1QSwIS-0000kQ-Dh for control@debbugs.gnu.org; Sat, 04 Jun 2011 15:14:08 -0400 Date: Sat, 04 Jun 2011 15:14:08 -0400 Message-Id: Subject: control message for bug 8799 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) fixed 8799 24.1 From unknown Tue Aug 19 23:11:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8799: 23.3; iswitchb Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Aug 2011 03:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Deniz Dogan Cc: 8799@debbugs.gnu.org, Stephen Eglen Received: via spool by 8799-submit@debbugs.gnu.org id=B8799.131389652924939 (code B ref 8799); Sun, 21 Aug 2011 03:16:01 +0000 Received: (at 8799) by debbugs.gnu.org; 21 Aug 2011 03:15:29 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QuyVU-0006UB-E3 for submit@debbugs.gnu.org; Sat, 20 Aug 2011 23:15:29 -0400 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QuyVS-0006TN-9w for 8799@debbugs.gnu.org; Sat, 20 Aug 2011 23:15:26 -0400 Received: from furball (dhcp-128-36-14-148.central.yale.edu [128.36.14.148]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p7L3D8Ww001489 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 20 Aug 2011 23:13:09 -0400 From: Chong Yidong References: <4DEA4BC6.7020405@dogan.se> Date: Sat, 20 Aug 2011 23:13:08 -0400 In-Reply-To: <4DEA4BC6.7020405@dogan.se> (Deniz Dogan's message of "Sat, 04 Jun 2011 17:14:14 +0200") Message-ID: <87mxf3v4mz.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Deniz Dogan writes: > I have pushed a fix for this to emacs-trunk, but I afterwards realized > I should have pushed it to emacs-23. Could someone knowledgeable fix > this for me? Sure, done. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 20 23:15:38 2011 Received: (at control) by debbugs.gnu.org; 21 Aug 2011 03:15:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QuyVe-0006UW-7V for submit@debbugs.gnu.org; Sat, 20 Aug 2011 23:15:38 -0400 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QuyVc-0006UP-Nk for control@debbugs.gnu.org; Sat, 20 Aug 2011 23:15:37 -0400 Received: from furball (dhcp-128-36-14-148.central.yale.edu [128.36.14.148]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p7L3DMSo018106 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Sat, 20 Aug 2011 23:13:22 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 8799 Date: Sat, 20 Aug 2011 23:13:21 -0400 Message-ID: <87d3fzfodq.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 8799 thanks