From unknown Tue Jun 24 22:34:22 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#8795 <8795@debbugs.gnu.org> To: bug#8795 <8795@debbugs.gnu.org> Subject: Status: 24.0.50; `completion-try-completion' addition of METADATA arg Reply-To: bug#8795 <8795@debbugs.gnu.org> Date: Wed, 25 Jun 2025 05:34:22 +0000 retitle 8795 24.0.50; `completion-try-completion' addition of METADATA arg reassign 8795 emacs submitter 8795 "Drew Adams" severity 8795 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 03 13:45:23 2011 Received: (at submit) by debbugs.gnu.org; 3 Jun 2011 17:45:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSYR1-0000TK-2G for submit@debbugs.gnu.org; Fri, 03 Jun 2011 13:45:23 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSYQz-0000T9-Ki for submit@debbugs.gnu.org; Fri, 03 Jun 2011 13:45:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QSYQp-0006X0-RW for submit@debbugs.gnu.org; Fri, 03 Jun 2011 13:45:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:47672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSYQp-0006Ww-IN for submit@debbugs.gnu.org; Fri, 03 Jun 2011 13:45:11 -0400 Received: from eggs.gnu.org ([140.186.70.92]:55684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSYQn-00029p-US for bug-gnu-emacs@gnu.org; Fri, 03 Jun 2011 13:45:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QSYQm-0006Vq-H6 for bug-gnu-emacs@gnu.org; Fri, 03 Jun 2011 13:45:09 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:45099) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSYQl-0006UN-IG for bug-gnu-emacs@gnu.org; Fri, 03 Jun 2011 13:45:08 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p53Hj4Dr030188 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 3 Jun 2011 17:45:06 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p53Hj4lH020904 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 3 Jun 2011 17:45:04 GMT Received: from abhmt014.oracle.com (abhmt014.oracle.com [141.146.116.23]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p53Hiw7M029738 for ; Fri, 3 Jun 2011 12:44:58 -0500 Received: from dradamslap1 (/10.159.59.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 03 Jun 2011 10:44:58 -0700 From: "Drew Adams" To: Subject: 24.0.50; `completion-try-completion' addition of METADATA arg Date: Fri, 3 Jun 2011 10:44:58 -0700 Message-ID: <30D5A7793376489C883B10B9D1DFA392@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcwiFfSJWkUMBNe3TiCw6kLtNvzjZA== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6090 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090204.4DE91DA2.0087:SCFMA922111,ss=1,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) 1. The addition of arg METADATA, without making it optional, breaks existing code that calls the function with only the first four args. What value of METADATA should be passed to get the equivalent of the behavior prior to the addition of this arg? nil? How about making this arg optional, so user code does not need to special-case Emacs 24 wrt Emacs 23? 2. The METADATA arg is not even described in the doc string. Users have no way to know how to fix the code this breaks. Please describe the arg in the doc string. In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2011-05-31 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.5) --no-opt --cflags -Ic:/build/include' From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 03 15:27:26 2011 Received: (at 8795) by debbugs.gnu.org; 3 Jun 2011 19:27:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSa1l-0002tt-ML for submit@debbugs.gnu.org; Fri, 03 Jun 2011 15:27:25 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSa1k-0002td-3q for 8795@debbugs.gnu.org; Fri, 03 Jun 2011 15:27:24 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p53JRG4l024785 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <8795@debbugs.gnu.org>; Fri, 3 Jun 2011 19:27:18 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p53JRFMO004367 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <8795@debbugs.gnu.org>; Fri, 3 Jun 2011 19:27:16 GMT Received: from abhmt019.oracle.com (abhmt019.oracle.com [141.146.116.28]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p53JR9qD023782 for <8795@debbugs.gnu.org>; Fri, 3 Jun 2011 14:27:10 -0500 Received: from dradamslap1 (/10.159.59.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 03 Jun 2011 12:27:09 -0700 From: "Drew Adams" To: <8795@debbugs.gnu.org> References: <30D5A7793376489C883B10B9D1DFA392@us.oracle.com> Subject: RE: bug#8795: 24.0.50; `completion-try-completion' addition of METADATA arg Date: Fri, 3 Jun 2011 12:27:09 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <30D5A7793376489C883B10B9D1DFA392@us.oracle.com> Thread-Index: AcwiFfSJWkUMBNe3TiCw6kLtNvzjZAADjWug X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6090 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.4DE93596.0074:SCFMA922111,ss=1,fgs=0 X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: 8795 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) Same problem for `completion-all-completions'. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 06 10:49:27 2011 Received: (at 8795) by debbugs.gnu.org; 6 Jun 2011 14:49:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QTb7O-0008S5-L9 for submit@debbugs.gnu.org; Mon, 06 Jun 2011 10:49:27 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QTb7K-0008Rr-F6 for 8795@debbugs.gnu.org; Mon, 06 Jun 2011 10:49:23 -0400 Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:37677 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QTb7E-0003ph-QN; Mon, 06 Jun 2011 10:49:17 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 3AAC866189; Mon, 6 Jun 2011 11:49:13 -0300 (ART) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#8795: 24.0.50; `completion-try-completion' addition of METADATA arg Message-ID: References: <30D5A7793376489C883B10B9D1DFA392@us.oracle.com> Date: Mon, 06 Jun 2011 11:49:13 -0300 In-Reply-To: <30D5A7793376489C883B10B9D1DFA392@us.oracle.com> (Drew Adams's message of "Fri, 3 Jun 2011 10:44:58 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 8795 Cc: 8795@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) > 1. The addition of arg METADATA, without making it optional, breaks > existing code that calls the function with only the first four args. Indeed, it was meant as an internal function, tho clearly it was never fully internal since icomplete uses it. I'll see how I can fix it, but in the mean time, could you tell me how you use it (I can guess the"where" is "icicles")? Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 06 11:30:13 2011 Received: (at 8795) by debbugs.gnu.org; 6 Jun 2011 15:30:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QTbkr-0001ml-8z for submit@debbugs.gnu.org; Mon, 06 Jun 2011 11:30:13 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QTbko-0001mK-Na for 8795@debbugs.gnu.org; Mon, 06 Jun 2011 11:30:11 -0400 Received: from rtcsinet22.oracle.com (rtcsinet22.oracle.com [66.248.204.30]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p56FU0Jf003387 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 6 Jun 2011 15:30:02 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by rtcsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p56FTwRk014314 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 6 Jun 2011 15:29:59 GMT Received: from abhmt021.oracle.com (abhmt021.oracle.com [141.146.116.30]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p56FTrUH024144; Mon, 6 Jun 2011 10:29:53 -0500 Received: from dradamslap1 (/130.35.179.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 06 Jun 2011 08:29:51 -0700 From: "Drew Adams" To: "'Stefan Monnier'" References: <30D5A7793376489C883B10B9D1DFA392@us.oracle.com> Subject: RE: bug#8795: 24.0.50; `completion-try-completion' addition of METADATA arg Date: Mon, 6 Jun 2011 08:29:51 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcwkWgXO9oHkGitlTYC147WtjcSqaAAAJgTQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6090 In-Reply-To: X-Source-IP: rtcsinet22.oracle.com [66.248.204.30] X-CT-RefId: str=0001.0A090207.4DECF27B.0136:SCFSTAT5015188,ss=1,fgs=0 X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 8795 Cc: 8795@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) > > 1. The addition of arg METADATA, without making it optional, breaks > > existing code that calls the function with only the first four args. > > Indeed, it was meant as an internal function, tho clearly it was never > fully internal since icomplete uses it. > > I'll see how I can fix it, but in the mean time, could you tell me how > you use it (I can guess the "where" is "icicles")? I use it here: 1. icomplete+.el http://www.emacswiki.org/emacs/icomplete%2b.el in the Emacs 23+ definition of `icomplete-completions': (let* ((mdata (and (fboundp 'completion--field-metadata) (completion--field-metadata (field-beginning)))) (most-try (if (fboundp 'completion--field-metadata) ; Emacs 24 (completion-try-completion name comps nil (length name) mdata) (completion-try-completion name comps nil (length name)))) ... 2. icicles-fn.el http://www.emacswiki.org/emacs/icicles-fn.el in the definitions of `icicle-completion-(all|try)-completion(s)': (let* ((mdata (and (fboundp 'completion--field-metadata) (or metadata (completion--field-metadata (field-beginning))))) (res (if (fboundp 'completion--field-metadata) ; Emacs 24 (completion-all-completions string table pred point mdata) (completion-all-completions string table pred point)))) ... [similarly for `...try...'] Functions `icicle-completion-(all|try)-completion(s)' are used by functions `icicle-unsorted(-file-name)-prefix-candidates', `icicle-prefix-any(-file-name)-candidates-p' (in the same file). Here is a typical use: (if (icicle-not-basic-prefix-completion-p) (icicle-completion-try-completion input minibuffer-completion-table minibuffer-completion-predicate (length input) (and (fboundp 'completion--field-metadata) (completion--field-metadata ; Emacs 24 (field-beginning)))) (try-completion input minibuffer-completion-table minibuffer-completion-predicate)) `icicle-not-basic-prefix-completion-p' returns non-nil if the user chooses to take advantage of Emacs 23+ `completion-styles' etc. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 20 16:17:02 2011 Received: (at 8795-done) by debbugs.gnu.org; 20 Jun 2011 20:17:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QYku5-0001Qe-O0 for submit@debbugs.gnu.org; Mon, 20 Jun 2011 16:17:02 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QYku3-0001QJ-NE for 8795-done@debbugs.gnu.org; Mon, 20 Jun 2011 16:17:00 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvgHAGmq/01FxL0s/2dsb2JhbABTmBuOSXiIc8AVhioEnVmEIg X-IronPort-AV: E=Sophos;i="4.65,396,1304308800"; d="scan'208";a="116718018" Received: from 69-196-189-44.dsl.teksavvy.com (HELO pastel.home) ([69.196.189.44]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 20 Jun 2011 16:16:53 -0400 Received: by pastel.home (Postfix, from userid 20848) id 039BD59011; Mon, 20 Jun 2011 16:16:52 -0400 (EDT) From: Stefan Monnier To: 8795-done@debbugs.gnu.org Subject: Re: bug#8795: 24.0.50; `completion-try-completion' addition of METADATA arg Message-ID: References: <30D5A7793376489C883B10B9D1DFA392@us.oracle.com> Date: Mon, 20 Jun 2011 16:16:52 -0400 In-Reply-To: <30D5A7793376489C883B10B9D1DFA392@us.oracle.com> (Drew Adams's message of "Fri, 3 Jun 2011 10:44:58 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 8795-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > 1. The addition of arg METADATA, without making it optional, breaks > existing code that calls the function with only the first four args. It's now optional, Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 20 16:48:33 2011 Received: (at 8795-done) by debbugs.gnu.org; 20 Jun 2011 20:48:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QYlOa-0003jW-VO for submit@debbugs.gnu.org; Mon, 20 Jun 2011 16:48:33 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QYlOX-0003jJ-IW for 8795-done@debbugs.gnu.org; Mon, 20 Jun 2011 16:48:30 -0400 Received: from rtcsinet21.oracle.com (rtcsinet21.oracle.com [66.248.204.29]) by rcsinet10.oracle.com (Switch-3.4.4/Switch-3.4.2) with ESMTP id p5KKmLSg012698 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 20 Jun 2011 20:48:23 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by rtcsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p5KKmJeG020406 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 20 Jun 2011 20:48:20 GMT Received: from abhmt017.oracle.com (abhmt017.oracle.com [141.146.116.26]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p5KKmDZP015001; Mon, 20 Jun 2011 15:48:14 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 20 Jun 2011 13:48:13 -0700 From: "Drew Adams" To: "'Stefan Monnier'" , <8795-done@debbugs.gnu.org> References: <30D5A7793376489C883B10B9D1DFA392@us.oracle.com> Subject: RE: bug#8795: 24.0.50; `completion-try-completion' addition of METADATA arg Date: Mon, 20 Jun 2011 13:48:15 -0700 Message-ID: <07084D5D90994065B34FD0A11EE1ED00@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Acwvhz5Y1rsxtcVwSc6g2Z+fz75yzAABBQ5w In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: rtcsinet21.oracle.com [66.248.204.29] X-CT-RefId: str=0001.0A090201.4DFFB217.00E3:SCFSTAT5015188, ss=1, re=-4.000, fgs=0 X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 8795-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) > It's now optional, Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 20 18:28:46 2011 Received: (at 8795-done) by debbugs.gnu.org; 20 Jun 2011 22:28:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QYmxZ-0002B9-Fh for submit@debbugs.gnu.org; Mon, 20 Jun 2011 18:28:45 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QYmxY-0002Ay-4l for 8795-done@debbugs.gnu.org; Mon, 20 Jun 2011 18:28:44 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet10.oracle.com (Switch-3.4.4/Switch-3.4.2) with ESMTP id p5KMSZeh023612 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 20 Jun 2011 22:28:37 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p5KMSZnY029634 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 20 Jun 2011 22:28:35 GMT Received: from abhmt005.oracle.com (abhmt005.oracle.com [141.146.116.14]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p5KMSUpx029801; Mon, 20 Jun 2011 17:28:30 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 20 Jun 2011 15:28:29 -0700 From: "Drew Adams" To: "'Stefan Monnier'" , <8795-done@debbugs.gnu.org> References: <30D5A7793376489C883B10B9D1DFA392@us.oracle.com> Subject: RE: bug#8795: 24.0.50; `completion-try-completion' addition of METADATA arg Date: Mon, 20 Jun 2011 15:28:32 -0700 Message-ID: <83DF4618210A471BBD8E8446A69ACA71@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Acwvhz5Y1rsxtcVwSc6g2Z+fz75yzAAEZ69Q In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090208.4DFFC996.0070:SCFMA922111,ss=1,re=-4.000,fgs=0 X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 8795-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) > It's now optional, You closed the bug, but apparently you fixed only #1: make the METADATA parameter optional, not #2: describe the parameter. I still don't see METADATA described in the doc strings of these two functions. I looked here: http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/head:/lisp/minibuffer.el Thx. From unknown Tue Jun 24 22:34:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 19 Jul 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From unknown Tue Jun 24 22:34:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Wed, 12 Oct 2011 18:41:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 12 14:46:01 2011 Received: (at control) by debbugs.gnu.org; 12 Oct 2011 18:46:01 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RE3oX-00043H-1C for submit@debbugs.gnu.org; Wed, 12 Oct 2011 14:46:01 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RE3oW-000431-46 for control@debbugs.gnu.org; Wed, 12 Oct 2011 14:46:00 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p9CIjSqh011313 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Oct 2011 18:45:30 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p9CIjR8n020652 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 12 Oct 2011 18:45:28 GMT Received: from abhmt110.oracle.com (abhmt110.oracle.com [141.146.116.62]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p9CIjMLV021210 for ; Wed, 12 Oct 2011 13:45:22 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 12 Oct 2011 11:45:22 -0700 From: "Drew Adams" To: Subject: bug #8795: unarchive, reopen Date: Wed, 12 Oct 2011 11:45:18 -0700 Message-ID: <90EE3D127DC74620A04DAA2493D82A6A@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcyJDxbOv0fUmaibQ+Kd8bmOvipARQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090202.4E95E04A.0106:SCFMA922111,ss=1,re=-4.000,fgs=0 X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) unarchive 8795 reopen 8795 thanks From unknown Tue Jun 24 22:34:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Wed, 12 Oct 2011 18:46:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 12 17:28:57 2011 Received: (at 8795-done) by debbugs.gnu.org; 12 Oct 2011 21:28:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RE6MD-0000xM-IG for submit@debbugs.gnu.org; Wed, 12 Oct 2011 17:28:57 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RE6MC-0000xF-93 for 8795-done@debbugs.gnu.org; Wed, 12 Oct 2011 17:28:56 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id p9CLSRnj021103; Wed, 12 Oct 2011 17:28:27 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 979A9B41EC; Wed, 12 Oct 2011 17:28:30 -0400 (EDT) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#8795: 24.0.50; `completion-try-completion' addition of METADATA arg Message-ID: References: <30D5A7793376489C883B10B9D1DFA392@us.oracle.com> Date: Wed, 12 Oct 2011 17:28:30 -0400 In-Reply-To: (Drew Adams's message of "Wed, 12 Oct 2011 11:41:04 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV4008=0 X-NAI-Spam-Version: 2.2.0.9286 : core <4008> : streams <690817> : uri <981931> X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: 8795-done Cc: 8795-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.1 (----) > Still no doc for arg METADATA. Indeed. I have no intention to add any doc for it. It's obvious from context, and this is an internal function. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 12 18:09:42 2011 Received: (at 8795-done) by debbugs.gnu.org; 12 Oct 2011 22:09:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RE6ze-0001xK-53 for submit@debbugs.gnu.org; Wed, 12 Oct 2011 18:09:42 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RE6zb-0001x6-4Y for 8795-done@debbugs.gnu.org; Wed, 12 Oct 2011 18:09:40 -0400 Received: from ucsinet24.oracle.com (ucsinet24.oracle.com [156.151.31.67]) by acsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p9CM96xo006020 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 12 Oct 2011 22:09:08 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet24.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p9CM38uF013965 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 12 Oct 2011 22:03:09 GMT Received: from abhmt118.oracle.com (abhmt118.oracle.com [141.146.116.70]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p9CM90iS030374; Wed, 12 Oct 2011 17:09:00 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 12 Oct 2011 15:08:59 -0700 From: "Drew Adams" To: "'Stefan Monnier'" References: <30D5A7793376489C883B10B9D1DFA392@us.oracle.com> Subject: RE: bug#8795: 24.0.50; `completion-try-completion' addition of METADATA arg Date: Wed, 12 Oct 2011 15:09:02 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcyJJelusDVxLhGNR/6umsIuADhgegAAESxw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: ucsinet24.oracle.com [156.151.31.67] X-CT-RefId: str=0001.0A090203.4E961004.0096,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 8795-done Cc: 8795-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > > Still no doc for arg METADATA. > > Indeed. I have no intention to add any doc for it. > It's obvious from context, and this is an internal function. The bug should not be closed as fixed/done. "Wontfix" is what you are saying. And it is clearly not internal. If it were internal then you would not have needed to change METADATA to `&optional'. And I was not the only one to point out that its not being optional broke backward compatibility. http://lists.gnu.org/archive/html/emacs-devel/2011-06/msg00327.html http://lists.gnu.org/archive/html/emacs-devel/2011-06/msg00348.html I use it in my code, and obviously others do too. IIRC, it was you who suggested that I use it instead of `try-completion', at least in some contexts (or possibly it was c*-all-c* vs all-c*, or both - anyway, I use both). [*] Its parameters, including METADATA, should be documented. And no, it is not at all "obvious from context" what could or should be passed as METADATA, and when. The meaning and behavior should be described. Is that so hard to do? ---- [*] I use it in code such as this (similar, for c*-all-c*): (when (consp filtered-candidates) (let ((common-prefix (if (icicle-not-basic-prefix-completion-p) (icicle-completion-try-completion ; <========= input minibuffer-completion-table minibuffer-completion-predicate (length input) (and (fboundp 'completion--field-metadata) (completion--field-metadata ; Emacs 24 (field-beginning)))) (try-completion input minibuffer-completion-table minibuffer-completion-predicate)))) (setq icicle-common-match-string (if (eq t common-prefix) input common-prefix)))) `icicle-c*-try-c*' is nearly the same as `c*-try-c*', but with bug #4708 fixed (so it returns nil when there is no such file etc.) (defun icicle-completion-try-completion (string table pred point &optional metadata) "Icicles version of `completion-try-completion'. 1. Handle all Emacs versions. 2. Remove the last cdr, which might hold the base size. 3. METADATA is optional and defaults to `completion--field-metadata' at `field-beginning'." (let* ((mdata (and (fboundp 'completion--field-metadata) (or metadata (completion--field-metadata (field-beginning))))) (res (if (fboundp 'completion--field-metadata) (completion-try-completion ; <========= string table pred point mdata) (completion-try-completion ; <========= string table pred point)))) (when (consp res) (setq res (car res))) res)) If I can easily simplify some of this I would be glad to hear how. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 12 22:22:22 2011 Received: (at 8795-done) by debbugs.gnu.org; 13 Oct 2011 02:22:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1REAwA-0007hR-7F for submit@debbugs.gnu.org; Wed, 12 Oct 2011 22:22:22 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1REAw8-0007hE-3m for 8795-done@debbugs.gnu.org; Wed, 12 Oct 2011 22:22:21 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EABVKlk5FxJoX/2dsb2JhbABDqEGBBoFTAQEEAVYjBQsLNBIUGA0kiBG4RIdYBKEghEU X-IronPort-AV: E=Sophos;i="4.69,337,1315195200"; d="scan'208";a="141564541" Received: from 69-196-154-23.dsl.teksavvy.com (HELO pastel.home) ([69.196.154.23]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 12 Oct 2011 22:21:47 -0400 Received: by pastel.home (Postfix, from userid 20848) id E04B759346; Wed, 12 Oct 2011 22:21:41 -0400 (EDT) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#8795: 24.0.50; `completion-try-completion' addition of METADATA arg Message-ID: References: <30D5A7793376489C883B10B9D1DFA392@us.oracle.com> Date: Wed, 12 Oct 2011 22:21:41 -0400 In-Reply-To: (Drew Adams's message of "Wed, 12 Oct 2011 15:09:02 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8795-done Cc: 8795-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > And it is clearly not internal. It is. "Internal" reflects the intention behind this function. As the author of the code, I know better than you do whether it's internal or not. > If it were internal then you would not have needed to change METADATA > to `&optional'. And I was not the only one to point out that its not > being optional broke backward compatibility. Oh, so because I was nice enough to go through the trouble to preserve backward compatibility, I am now bound to additionally document the obvious because you don't find it obvious enough? Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 13 10:15:49 2011 Received: (at 8795-done) by debbugs.gnu.org; 13 Oct 2011 14:15:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1REM4a-0000Bm-Mk for submit@debbugs.gnu.org; Thu, 13 Oct 2011 10:15:49 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1REM4X-0000BX-LJ for 8795-done@debbugs.gnu.org; Thu, 13 Oct 2011 10:15:46 -0400 Received: from ucsinet23.oracle.com (ucsinet23.oracle.com [156.151.31.71]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p9DEF9Vp031813 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Thu, 13 Oct 2011 14:15:11 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet23.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p9DEF8fj009680 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 13 Oct 2011 14:15:09 GMT Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p9DEF3fX008813; Thu, 13 Oct 2011 09:15:03 -0500 Received: from dradamslap1 (/10.159.39.52) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 13 Oct 2011 07:15:02 -0700 From: "Drew Adams" To: "'Stefan Monnier'" References: <30D5A7793376489C883B10B9D1DFA392@us.oracle.com> Subject: RE: bug#8795: 24.0.50; `completion-try-completion' addition of METADATA arg Date: Thu, 13 Oct 2011 07:14:58 -0700 Message-ID: <731A5DEC538D448E962421309BF1B25E@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcyJTuDdahodUPj5Ts6/nFNGo2uzNQAYJwpA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: ucsinet23.oracle.com [156.151.31.71] X-CT-RefId: str=0001.0A090206.4E96F26F.01D5,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 8795-done Cc: 8795-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > > And it is clearly not internal. > > It is. "Internal" reflects the intention behind this > function. As the author of the code, I know better than > you do whether it's internal or not. Your intention is one thing. Reality (actual use) is apparently another. You already acknowledged that you didn't think anyone would ever use this - you were surprised that people do (have to?). What you intended as internal, not realizing the impact of your changes, is not internal - in practice. Do you think people jump through hoops like this just because they want to complicate things, with different code for different Emacs versions? ;; Recent Emacs (completion-try-completion input minibuffer-completion-table minibuffer-completion-predicate (length input) (completion--field-metadata (field-beginning))) instead of just ;; Older Emacs (try-completion input minibuffer-completion-table minibuffer-completion-predicate)) How much simpler it would be to just use `try-completion' here for all Emacs versions. As I said, "If I can easily simplify some of this I would be glad to hear how." No one _wants_ to use something you intended as internal, if they don't have to. > > If it were internal then you would not have needed to > > change METADATA to `&optional'. And I was not the only one > > to point out that its not being optional broke backward compatibility. > > Oh, so because I was nice enough to go through the trouble to preserve > backward compatibility, I am now bound to additionally document > the obvious because you don't find it obvious enough? Backward compatibility takes care of, well, backward compatibility. It does not take care of documenting how to use the new (more complex) paraphernalia. Again, why not? Is it so hard to explain the meaning and behavior of the METADATA parameter? What's wrong with describing even an "internal" function? If you so strongly resist putting the info in a doc string, then put it in a code comment, at least. Code comments are how we document "internal" functions, no? Whether something like this is obvious enough is not for you to determine, but for readers of the code. An author can vouch for the author's _intention_, but not for how well the meaning and behavior are communicated. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 13 16:37:27 2011 Received: (at 8795) by debbugs.gnu.org; 13 Oct 2011 20:37:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RES1v-0001qQ-5V for submit@debbugs.gnu.org; Thu, 13 Oct 2011 16:37:27 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RES1t-0001qB-OK; Thu, 13 Oct 2011 16:37:26 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by acsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p9DKalKf026498 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 13 Oct 2011 20:36:49 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p9DKalEb005295 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 13 Oct 2011 20:36:47 GMT Received: from abhmt101.oracle.com (abhmt101.oracle.com [141.146.116.53]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p9DKaeTr019606; Thu, 13 Oct 2011 15:36:41 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 13 Oct 2011 13:36:40 -0700 From: "Drew Adams" To: "'Stefan Monnier'" References: <30D5A7793376489C883B10B9D1DFA392@us.oracle.com> Subject: RE: bug#8795: 24.0.50; `completion-try-completion' addition of METADATA arg Date: Thu, 13 Oct 2011 13:36:41 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcyJTuDdahodUPj5Ts6/nFNGo2uzNQAYJwpAAA39KAA= In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090204.4E974BE1.0230:SCFMA922111,ss=1,re=-4.000,fgs=0 X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 8795 Cc: 8795-done@debbugs.gnu.org, 8795@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) And if it were really internal then you would not, yourself, need to use it also in other libraries, such as `icomplete.el'. And that's the other place where I (need to) use it too: `icomplete.el+', which tweaks the `icomplete.el' code. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 13 16:46:30 2011 Received: (at 8795) by debbugs.gnu.org; 13 Oct 2011 20:46:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RESAf-00025m-HI for submit@debbugs.gnu.org; Thu, 13 Oct 2011 16:46:30 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RESAY-00025L-HB for 8795@debbugs.gnu.org; Thu, 13 Oct 2011 16:46:24 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p9DKjihG027626 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <8795@debbugs.gnu.org>; Thu, 13 Oct 2011 20:45:46 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p9DKjiqI019234 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <8795@debbugs.gnu.org>; Thu, 13 Oct 2011 20:45:44 GMT Received: from abhmt101.oracle.com (abhmt101.oracle.com [141.146.116.53]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p9DKjd8R022428 for <8795@debbugs.gnu.org>; Thu, 13 Oct 2011 15:45:39 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 13 Oct 2011 13:45:38 -0700 From: "Drew Adams" To: <8795@debbugs.gnu.org> Subject: FW: bug#8795: 24.0.50; `completion-try-completion' addition of METADATA arg Date: Thu, 13 Oct 2011 13:45:39 -0700 Message-ID: <89D983C5D7CA43B7ABBCABB1AAA91910@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcyJTuDdahodUPj5Ts6/nFNGo2uzNQAYJwpAAA4jD0A= X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090203.4E974DFA.0154:SCFMA922111,ss=1,re=-4.000,fgs=0 X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 8795 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > > And it is clearly not internal. > > It is. "Internal" reflects the intention behind this > function. As the author of the code, I know better than > you do whether it's internal or not. Your intention is one thing. Reality (actual use) is apparently another. You already acknowledged that you didn't think anyone would ever use this - you were surprised that people do (have to?). What you intended as internal, not realizing the impact of your changes, is not internal - in practice. Do you think people jump through hoops like this just because they want to complicate things, with different code for different Emacs versions? ;; Recent Emacs (completion-try-completion input minibuffer-completion-table minibuffer-completion-predicate (length input) (completion--field-metadata (field-beginning))) instead of just ;; Older Emacs (try-completion input minibuffer-completion-table minibuffer-completion-predicate)) How much simpler it would be to just use `try-completion' here for all Emacs versions. As I said, "If I can easily simplify some of this I would be glad to hear how." No one _wants_ to use something you intended as internal, if they don't have to. > > If it were internal then you would not have needed to > > change METADATA to `&optional'. And I was not the only one > > to point out that its not being optional broke backward compatibility. > > Oh, so because I was nice enough to go through the trouble to preserve > backward compatibility, I am now bound to additionally document > the obvious because you don't find it obvious enough? Backward compatibility takes care of, well, backward compatibility. It does not take care of documenting how to use the new (more complex) paraphernalia. Again, why not? Is it so hard to explain the meaning and behavior of the METADATA parameter? What's wrong with describing even an "internal" function? If you so strongly resist putting the info in a doc string, then put it in a code comment, at least. Code comments are how we document "internal" functions, no? Whether something like this is obvious enough is not for you to determine, but for readers of the code. An author can vouch for the author's _intention_, but not for how well the meaning and behavior are communicated. From unknown Tue Jun 24 22:34:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 11 Nov 2011 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator