From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 02 06:08:52 2011 Received: (at submit) by debbugs.gnu.org; 2 Jun 2011 10:08:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QS4pg-0000J0-Kf for submit@debbugs.gnu.org; Thu, 02 Jun 2011 06:08:52 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QS4pf-0000Io-1O for submit@debbugs.gnu.org; Thu, 02 Jun 2011 06:08:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QS4pY-00068k-Ee for submit@debbugs.gnu.org; Thu, 02 Jun 2011 06:08:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RFC_ABUSE_POST, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:47367) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QS4pX-00068e-Sv for submit@debbugs.gnu.org; Thu, 02 Jun 2011 06:08:44 -0400 Received: from eggs.gnu.org ([140.186.70.92]:52027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QS4pW-0000I2-E3 for bug-automake@gnu.org; Thu, 02 Jun 2011 06:08:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QS4pU-00068D-TW for bug-automake@gnu.org; Thu, 02 Jun 2011 06:08:42 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:56093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QS4pU-000683-D2 for bug-automake@gnu.org; Thu, 02 Jun 2011 06:08:40 -0400 Received: by wyf19 with SMTP id 19so613290wyf.0 for ; Thu, 02 Jun 2011 03:08:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:mime-version :content-type:content-transfer-encoding:message-id; bh=h4CrW82zjIQ2YlE/kf3y2VBjMW6kSHh1yfPDJETPGqs=; b=LCYZ0epxMrbWfde6TxvLGc/rZdUDGXVZhXb8GULFrb9wMAoMNhLgDv71hJmR3h8bsu 1vM/fNvPPdrKlfLrj11WeavP345WDwrk7KgYA6DPJ7MPE/nZbAmXoJxVdSh1Nu8umV27 BRkLPHs+TFPERrGdxJed+t8CuEI5CgrAsFy0w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:mime-version:content-type :content-transfer-encoding:message-id; b=jp3WJuFQ+z2L5cuKzsW2TfV8WV3pXryhGJ0VtZzex++0cgODFcIWpT5uSFlGrp4vpa H0g6oTxrrRO/MxC9niXqS3qombdUzM9dmk9ek/jxxld818E3d/hUNhPzo/fAR5I5hNhz WsI+VRUYjiezeslfPloCxtTQv5SorX+CPG+oQ= Received: by 10.216.142.165 with SMTP id i37mr514435wej.106.1307009319459; Thu, 02 Jun 2011 03:08:39 -0700 (PDT) Received: from bigio.localnet (host139-49-dynamic.58-82-r.retail.telecomitalia.it [82.58.49.139]) by mx.google.com with ESMTPS id k70sm228715weq.6.2011.06.02.03.08.37 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 02 Jun 2011 03:08:38 -0700 (PDT) From: Stefano Lattarini To: bug-automake@gnu.org Subject: Support developer-reserved AM_DISTCHECK_CONFIGURE_FLAGS Date: Thu, 2 Jun 2011 12:08:20 +0200 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201106021208.20631.stefano.lattarini@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.8 (----) Severity: wishlist Hello automakers. Continuing with the good trend of avoiding to impinge on the user namespace, we should start supporting AM_DISTCHECK_CONFIGURE_FLAGS in addition to DISTCHECK_CONFIGURE_FLAGS, so that the former can be reserved for the developer to be set in the 'Makefile.am's, and the latter left for the user, packager or tester to use freely. Sorry for the curtness of this message, but it is thought more as a "note to self" than a bug report proper. Regards, Stefano From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 10 11:34:04 2011 Received: (at 8784) by debbugs.gnu.org; 10 Jun 2011 15:34:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QV3ik-0004Hl-Gs for submit@debbugs.gnu.org; Fri, 10 Jun 2011 11:34:03 -0400 Received: from mail-ww0-f46.google.com ([74.125.82.46]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QV3ih-0004HG-1p for 8784@debbugs.gnu.org; Fri, 10 Jun 2011 11:34:01 -0400 Received: by wwb28 with SMTP id 28so2730156wwb.15 for <8784@debbugs.gnu.org>; Fri, 10 Jun 2011 08:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:message-id; bh=gmEtqHBQ89a42q0ZFh/jg+ywDAjfRqK7DT+IXJJvU0I=; b=xv4Fb9XjfCO+bUGb76zhQrsRLaGek9eVnLYbhwranVhBiD5/GCV2g3t5DY3KU8W8Tf +gPrcFM6teuONzytbwRtlVJr6Ji7qSNLk6Mv9DZV3iVWbqI4XAm0BnHqfnIqfIPRE27V OfgPCSSDLMaJFpbxm0iI2zFqZRnTDCsJ/M9Os= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:message-id; b=HUS+ox6S7b0OGo3lYH0VbOnGKHSFeU4N4Zqh8C5GytHbL827QKtadJzaxDWYORRjEX g75ZE96PWysyEqwtRFz1hk9Xoi/nuSmMqBTXs9cbXn8UaaKv7TUmRnz5usewafF4txB2 d9/8PdPOBx7LWKAfyozPmreZ6HWjWuGoXgb4E= Received: by 10.216.237.131 with SMTP id y3mr6605weq.87.1307720033124; Fri, 10 Jun 2011 08:33:53 -0700 (PDT) Received: from bigio.localnet (host52-49-dynamic.58-82-r.retail.telecomitalia.it [82.58.49.52]) by mx.google.com with ESMTPS id h43sm1466468wes.35.2011.06.10.08.33.50 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 10 Jun 2011 08:33:51 -0700 (PDT) From: Stefano Lattarini To: automake-patches@gnu.org Subject: [PATCH] {maint} distcheck: add support for AM_DISTCHECK_CONFIGURE_FLAGS (was: Re: bug#8784: Support developer-reserved AM_DISTCHECK_CONFIGURE_FLAGS) Date: Fri, 10 Jun 2011 17:33:39 +0200 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: <201106021208.20631.stefano.lattarini@gmail.com> In-Reply-To: <201106021208.20631.stefano.lattarini@gmail.com> MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_Ulj8N/NkkpuPxwg" Message-Id: <201106101733.40520.stefano.lattarini@gmail.com> X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: 8784 Cc: 8784@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.8 (---) --Boundary-00=_Ulj8N/NkkpuPxwg Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Reference: On Thursday 02 June 2011, Stefano Lattarini wrote: > Severity: wishlist > > Hello automakers. > > Continuing with the good trend of avoiding to impinge on the user > namespace, we should start supporting AM_DISTCHECK_CONFIGURE_FLAGS > in addition to DISTCHECK_CONFIGURE_FLAGS, so that the former can be > reserved for the developer to be set in the 'Makefile.am's, and the > latter left for the user, packager or tester to use freely. > > Sorry for the curtness of this message, but it is thought more as > a "note to self" than a bug report proper. > > Regards, > Stefano > > Implemented in the first one of the attached patches. The second patch is a follow-up updating the "maintainer-check" rules accordingly. OK for maint? This should be quite uncontroversial, so I'll push in 72 hours if there is no review by then. Regards, Stefano --Boundary-00=_Ulj8N/NkkpuPxwg Content-Type: text/x-patch; charset="utf-8"; name="0001-distcheck-add-support-for-AM_DISTCHECK_CONFIGURE_FLA.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="0001-distcheck-add-support-for-AM_DISTCHECK_CONFIGURE_FLA.patch" =46rom 976003923e43d17985a776f82cf8168e8741f7de Mon Sep 17 00:00:00 2001 Message-Id: <976003923e43d17985a776f82cf8168e8741f7de.1307718833.git.stefan= o.lattarini@gmail.com> =46rom: Stefano Lattarini Date: Fri, 10 Jun 2011 12:26:42 +0200 Subject: [PATCH 1/2] distcheck: add support for AM_DISTCHECK_CONFIGURE_FLAGS * doc/automake.texi (Checking the Distribution): Suggest to use AM_DISTCHECK_CONFIGURE_FLAGS, not DISTCHECK_CONFIGURE_FLAGS, to define (in the top-level Makefile.am) extra flags to be passed to configure at "make distcheck" time; DISTCHECK_CONFIGURE_FLAGS should be reserved for the user. Add proper `@vindex' directive. Document that AM_DISTCHECK_CONFIGURE_FLAGS is not honoured in a subpackage Makefile.am, but the flags in it are passed down to the configure script of the subpackage. * lib/am/distdir.am (distcheck): Also pass the flags in $(AM_DISTCHECK_CONFIGURE_FLAGS) to the configure invocation. Update comments. * tests/defs.in.test (AM_DISTCHECK_CONFIGURE_FLAGS, DISTCHECK_CONFIGURE_FLAGS): Unset in case they are exported in the environment, they might improperly influence our testsuite. * tests/distcheck-configure-flags.test: New test. * tests/distcheck-configure-flags-am.test: Likewise. * tests/distcheck-configure-flags-subpkg.test: Likewise. * distcheck-hook.test: Likewise. * distcheck-hook2.test: Likewise. * tests/Makefile.am (TESTS): Update. Closes automake bug#8487. =2D-- ChangeLog | 25 ++++++++ Makefile.in | 1 + doc/automake.texi | 14 +++-- lib/am/distdir.am | 4 +- tests/Makefile.am | 5 ++ tests/Makefile.in | 5 ++ tests/defs.in | 2 + tests/distcheck-configure-flags-am.test | 68 ++++++++++++++++++++++ tests/distcheck-configure-flags-subpkg.test | 83 +++++++++++++++++++++++= ++++ tests/distcheck-configure-flags.test | 56 ++++++++++++++++++ tests/distcheck-hook.test | 53 +++++++++++++++++ tests/distcheck-hook2.test | 81 +++++++++++++++++++++++= +++ 12 files changed, 391 insertions(+), 6 deletions(-) create mode 100755 tests/distcheck-configure-flags-am.test create mode 100755 tests/distcheck-configure-flags-subpkg.test create mode 100755 tests/distcheck-configure-flags.test create mode 100755 tests/distcheck-hook.test create mode 100755 tests/distcheck-hook2.test diff --git a/ChangeLog b/ChangeLog index cb9918f..1a11eb2 100644 =2D-- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,28 @@ +2011-06-10 Stefano Lattarini + + distcheck: add support for AM_DISTCHECK_CONFIGURE_FLAGS + * doc/automake.texi (Checking the Distribution): Suggest to use + AM_DISTCHECK_CONFIGURE_FLAGS, not DISTCHECK_CONFIGURE_FLAGS, to + define (in the top-level Makefile.am) extra flags to be passed + to configure at "make distcheck" time; DISTCHECK_CONFIGURE_FLAGS + should be reserved for the user. Add proper `@vindex' directive. + Document that AM_DISTCHECK_CONFIGURE_FLAGS is not honoured in a + subpackage Makefile.am, but the flags in it are passed down to + the configure script of the subpackage. + * lib/am/distdir.am (distcheck): Also pass the flags in + $(AM_DISTCHECK_CONFIGURE_FLAGS) to the configure invocation. + Update comments. + * tests/defs.in.test (AM_DISTCHECK_CONFIGURE_FLAGS, + DISTCHECK_CONFIGURE_FLAGS): Unset in case they are exported in + the environment, they might improperly influence our testsuite. + * tests/distcheck-configure-flags.test: New test. + * tests/distcheck-configure-flags-am.test: Likewise. + * tests/distcheck-configure-flags-subpkg.test: Likewise. + * distcheck-hook.test: Likewise. + * distcheck-hook2.test: Likewise. + * tests/Makefile.am (TESTS): Update. + Closes automake bug#8784. + 2011-06-02 Stefano Lattarini =20 maintcheck: fix some failures, extend some checks diff --git a/Makefile.in b/Makefile.in index d0951e0..d6743e4 100644 =2D-- a/Makefile.in +++ b/Makefile.in @@ -721,6 +721,7 @@ distcheck: dist && am__cwd=3D`pwd` \ && $(am__cd) $(distdir)/_build \ && ../configure --srcdir=3D.. --prefix=3D"$$dc_install_base" \ + $(AM_DISTCHECK_CONFIGURE_FLAGS) \ $(DISTCHECK_CONFIGURE_FLAGS) \ && $(MAKE) $(AM_MAKEFLAGS) \ && $(MAKE) $(AM_MAKEFLAGS) dvi \ diff --git a/doc/automake.texi b/doc/automake.texi index 3846e0d..b3aecfc 100644 =2D-- a/doc/automake.texi +++ b/doc/automake.texi @@ -8417,11 +8417,14 @@ makes a distribution, then tries to do a @code{VPAT= H} build (@pxref{VPATH Builds}), run the test suite, and finally make another tarball to ensure the distribution is self-contained. =20 +@vindex AM_DISTCHECK_CONFIGURE_FLAGS @vindex DISTCHECK_CONFIGURE_FLAGS Building the package involves running @samp{./configure}. If you need to supply additional flags to @command{configure}, define them in the =2D@code{DISTCHECK_CONFIGURE_FLAGS} variable, either in your top-level =2D@file{Makefile.am}, or on the command line when invoking @command{make}. +@code{AM_DISTCHECK_CONFIGURE_FLAGS} variable in your top-level +@file{Makefile.am}. The user can still extend or override the flags +provided there by defining the @code{DISTCHECK_CONFIGURE_FLAGS} variable, +on the command line when invoking @command{make}. =20 @trindex distcheck-hook If the @code{distcheck-hook} rule is defined in your top-level @@ -8431,9 +8434,10 @@ is configured and built. Your @code{distcheck-hook}= can do almost anything, though as always caution is advised. Generally this hook is used to check for potential distribution errors not caught by the standard mechanism. Note that @code{distcheck-hook} as well as =2D@code{DISTCHECK_CONFIGURE_FLAGS} are not honored in a subpackage =2D@file{Makefile.am}, but the @code{DISTCHECK_CONFIGURE_FLAGS} are =2Dpassed down to the @command{configure} script of the subpackage. +@code{AM_DISTCHECK_CONFIGURE_FLAGS} and @code{DISTCHECK_CONFIGURE_FLAGS} +are not honored in a subpackage @file{Makefile.am}, but the flags from +@code{AM_DISTCHECK_CONFIGURE_FLAGS} and @code{DISTCHECK_CONFIGURE_FLAGS} +are passed down to the @command{configure} script of the subpackage. =20 @trindex distcleancheck @vindex DISTCLEANFILES diff --git a/lib/am/distdir.am b/lib/am/distdir.am index e0f3bce..c2dd7c5 100644 =2D-- a/lib/am/distdir.am +++ b/lib/am/distdir.am @@ -468,7 +468,9 @@ distcheck: dist && ../configure --srcdir=3D.. --prefix=3D"$$dc_install_base" \ ?GETTEXT? --with-included-gettext \ ## Additional flags for configure. Keep this last in the configure =2D## invocation so the user can override previous options. +## invocation so the developer and user can override previous options, +## and let the user's flags take precedence over the developer's ones. + $(AM_DISTCHECK_CONFIGURE_FLAGS) \ $(DISTCHECK_CONFIGURE_FLAGS) \ && $(MAKE) $(AM_MAKEFLAGS) \ && $(MAKE) $(AM_MAKEFLAGS) dvi \ diff --git a/tests/Makefile.am b/tests/Makefile.am index 33ae8bc..42a8813 100644 =2D-- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -313,6 +313,11 @@ distdir.test \ distlinks.test \ distlinksbrk.test \ distname.test \ +distcheck-configure-flags.test \ +distcheck-configure-flags-am.test \ +distcheck-configure-flags-subpkg.test \ +distcheck-hook.test \ +distcheck-hook2.test \ dmalloc.test \ dollar.test \ dollarvar.test \ diff --git a/tests/Makefile.in b/tests/Makefile.in index d7a1761..664ecaa 100644 =2D-- a/tests/Makefile.in +++ b/tests/Makefile.in @@ -584,6 +584,11 @@ distdir.test \ distlinks.test \ distlinksbrk.test \ distname.test \ +distcheck-configure-flags.test \ +distcheck-configure-flags-am.test \ +distcheck-configure-flags-subpkg.test \ +distcheck-hook.test \ +distcheck-hook2.test \ dmalloc.test \ dollar.test \ dollarvar.test \ diff --git a/tests/defs.in b/tests/defs.in index 87a350d..32fba30 100644 =2D-- a/tests/defs.in +++ b/tests/defs.in @@ -425,6 +425,8 @@ unset DESTDIR unset prefix exec_prefix bindir datarootdir datadir docdir dvidir unset htmldir includedir infodir libdir libexecdir localedir mandir unset oldincludedir pdfdir psdir sbindir sharedstatedir sysconfdir +# Unset variables that might change the "make distcheck" behaviour. +unset DISTCHECK_CONFIGURE_FLAGS AM_DISTCHECK_CONFIGURE_FLAGS # Also unset variables that control our test driver. While not # conceptually independent, they cause some changed semantics we # need to control (and test for) in some of the tests to ensure diff --git a/tests/distcheck-configure-flags-am.test b/tests/distcheck-conf= igure-flags-am.test new file mode 100755 index 0000000..a5cab6a =2D-- /dev/null +++ b/tests/distcheck-configure-flags-am.test @@ -0,0 +1,68 @@ +#! /bin/sh +# Copyright (C) 2011 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Check support for AM_DISTCHECK_CONFIGURE_FLAGS at "make distcheck" +# time, and its interactions with DISTCHECK_CONFIGURE_FLAGS. + +. ./defs || Exit 1 + +set -e + +cat >> configure.in << 'END' +AC_ARG_ENABLE([success], [], [success=3D$enableval], [success=3Dno]) +AS_IF([test $success =3D yes && test "$sentence" =3D 'it works :-)'], + [:], + [AC_MSG_ERROR([success=3D'$success', sentence=3D'$sentence'])]) +AC_OUTPUT +END + +unset sentence || : + +cat > Makefile.am << 'END' +AM_DISTCHECK_CONFIGURE_FLAGS =3D --enable-success sentence=3D'it works :-)' +END + +$ACLOCAL +$AUTOMAKE +$FGREP '$(DISTCHECK_CONFIGURE_FLAGS)' Makefile.in +$FGREP '$(AM_DISTCHECK_CONFIGURE_FLAGS)' Makefile.in +grep 'DISTCHECK_CONFIGURE_FLAGS.*AM_DISTCHECK_CONFIGURE_FLAGS' Makefile.in= \ + && Exit 1 + +$AUTOCONF +./configure --enable-success sentence=3D'it works :-)' + +# The configure call in "make distcheck" should honour +# $(AM_DISTCHECK_CONFIGURE_FLAGS). + +$MAKE distcheck + +# $(DISTCHECK_CONFIGURE_FLAGS) takes precedence over +# $(AM_DISTCHECK_CONFIGURE_FLAGS) + +cat >> Makefile.am << 'END' +AM_DISTCHECK_CONFIGURE_FLAGS +=3D --disable-success +END +$AUTOMAKE Makefile +./config.status Makefile + +$MAKE distcheck >output 2>&1 && { cat output; Exit 1; } +cat output +grep "^configure:.* success=3D'no', sentence=3D'it works :-)'" output + +$MAKE distcheck DISTCHECK_CONFIGURE_FLAGS=3D"--enable-success=3Dyes" + +: diff --git a/tests/distcheck-configure-flags-subpkg.test b/tests/distcheck-= configure-flags-subpkg.test new file mode 100755 index 0000000..695b47c =2D-- /dev/null +++ b/tests/distcheck-configure-flags-subpkg.test @@ -0,0 +1,83 @@ +#! /bin/sh +# Copyright (C) 2011 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Check AM_DISTCHECK_CONFIGURE_FLAGS and DISTCHECK_CONFIGURE_FLAGS +# are not honored in a subpackage Makefile.am, but the flags from +# AM_DISTCHECK_CONFIGURE_FLAGS and DISTCHECK_CONFIGURE_FLAGS are +# passed down to the configure script of the subpackage. This is +# explicitly documented in the manual. + +. ./defs || Exit 1 + +set -e + +cat >> configure.in << 'END' +AC_CONFIG_SUBDIRS([subpkg]) +if test $dc !=3D ok || test $am_dc !=3D ok; then + AC_MSG_ERROR([dc=3D$dc am_dc=3D$dc]) +fi +AC_OUTPUT +END + +mkdir subpkg + +sed subpkg/configure.in \ + -e 's/^AC_INIT.*/AC_INIT([subpkg], [2.0])/' \ + -e '/^AC_CONFIG_SUBDIRS/d' \ + +cat configure.in +cat subpkg/configure.in + +dc=3DKO am_dc=3DKO; export dc am_dc + +cat > Makefile.am << 'END' +AM_DISTCHECK_CONFIGURE_FLAGS =3D am_dc=3Dok +DISTCHECK_CONFIGURE_FLAGS =3D dc=3Dok +END + +: > subpkg/Makefile.am + +$ACLOCAL +$AUTOMAKE +$AUTOCONF + +cd subpkg +$ACLOCAL +$AUTOMAKE +$AUTOCONF +cd .. + +# For debugging. +$FGREP 'DISTCHECK_CONFIGURE_FLAGS' Makefile.in subpkg/Makefile.in + +grep '^AM_DISTCHECK_CONFIGURE_FLAGS =3D' Makefile.in +grep '^DISTCHECK_CONFIGURE_FLAGS =3D' Makefile.in +$EGREP '^(AM_)?DISTCHECK_CONFIGURE_FLAGS' subpkg/Makefile.in && Exit 1 + +./configure dc=3Dok am_dc=3Dok + +# Flags in $(DISTCHECK_CONFIGURE_FLAGS) and $(AM_DISTCHECK_CONFIGURE_FLAGS) +# should be passed down to the subpackage configure when "make distcheck" +# is run from the top-level package ... +$MAKE distcheck + +# ... but not when "make distcheck" is run from the subpackage. +cd subpkg +$MAKE distcheck >output 2>&1 && { cat output; Exit 1; } +cat output +grep '^configure:.* dc=3DKO am_dc=3DKO' output + +: diff --git a/tests/distcheck-configure-flags.test b/tests/distcheck-configu= re-flags.test new file mode 100755 index 0000000..117d83c =2D-- /dev/null +++ b/tests/distcheck-configure-flags.test @@ -0,0 +1,56 @@ +#! /bin/sh +# Copyright (C) 2011 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Check support for DISTCHECK_CONFIGURE_FLAGS at "make distcheck" time. + +. ./defs || Exit 1 + +set -e + +cat >> configure.in << 'END' +AC_ARG_ENABLE([success], [], [success=3D$enableval], [success=3Dno]) +AS_IF([test $success =3D yes && test "$sentence" =3D 'it works :-)'], + [:], + [AC_MSG_ERROR([success=3D'$success', sentence=3D'$sentence'])]) +AC_OUTPUT +END + +unset sentence || : + +: > Makefile.am + +$ACLOCAL +$AUTOMAKE +$FGREP '$(DISTCHECK_CONFIGURE_FLAGS)' Makefile.in + +$AUTOCONF +./configure --enable-success sentence=3D'it works :-)' + +# It should be ok to define DISTCHECK_CONFIGURE_FLAGS either on the +# make command line or in the environment. + +env DISTCHECK_CONFIGURE_FLAGS=3D'--enable-success sentence=3Dit\ works\ :-= \)' \ + $MAKE distcheck # Not `make -e' here, deliberately. + +$MAKE distcheck \ + DISTCHECK_CONFIGURE_FLAGS=3D"--enable-success=3Dyes sentence=3D'it works= :-)'" + +# Sanity check. +$MAKE distcheck >output 2>&1 && { cat output; Exit 1; } +cat output +grep "^configure:.* success=3D'no', sentence=3D''" output + +: diff --git a/tests/distcheck-hook.test b/tests/distcheck-hook.test new file mode 100755 index 0000000..9a2c384 =2D-- /dev/null +++ b/tests/distcheck-hook.test @@ -0,0 +1,53 @@ +#! /bin/sh +# Copyright (C) 2011 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Check basic support for distcheck-hook. + +. ./defs || Exit 1 + +set -e + +cat >> configure.in << 'END' +AC_OUTPUT +END + +cat > Makefile.am <<'END' +distcheck-hook: + ls -l $(distdir) + chmod u+w $(distdir) + : > $(distdir)/dc-hook-has-run + chmod a-w $(distdir) +check-local: + ls -l $(srcdir) + test -f $(srcdir)/dc-hook-has-run +END + +$ACLOCAL +$AUTOMAKE +$FGREP 'distcheck-hook' Makefile.in +$FGREP '$(MAKE) $(AM_MAKEFLAGS) distcheck-hook' Makefile.in +grep '^distcheck-hook:' Makefile.in + +$AUTOCONF +./configure + +$MAKE +$MAKE check && Exit 1 +$MAKE distdir +test -f $distdir/dc-hook-has-run && Exit 1 +$MAKE distcheck + +: diff --git a/tests/distcheck-hook2.test b/tests/distcheck-hook2.test new file mode 100755 index 0000000..befc1d6 =2D-- /dev/null +++ b/tests/distcheck-hook2.test @@ -0,0 +1,81 @@ +#! /bin/sh +# Copyright (C) 2011 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Check that no 'distcheck-hook' target is created automatically by +# Automake, and that a used-defined 'distcheck-hook' is *not* honored +# in a subpackage Makefile.am. + +. ./defs || Exit 1 + +set -e + +cat >> configure.in << 'END' +AC_CONFIG_SUBDIRS([subpkg]) +AC_OUTPUT +END + +mkdir subpkg + +cat > subpkg/configure.in << 'END' +AC_INIT([subpkg], [1.0]) +AM_INIT_AUTOMAKE +AC_CONFIG_FILES([Makefile]) +AC_OUTPUT +END + +cat > Makefile.am <<'END' +distcheck-hook: + ls -l $(distdir) + chmod u+w $(distdir) + : > $(distdir)/dc-hook-has-run + chmod a-w $(distdir) +check-local: + ls -l $(srcdir) + test -f $(srcdir)/dc-hook-has-run +END + +cat > subpkg/Makefile.am <<'END' +check-local: + ls -l $(srcdir) + test ! -r $(srcdir)/dc-hook-has-run +END + +$ACLOCAL +$AUTOMAKE +$AUTOCONF +cd subpkg +$ACLOCAL +$AUTOMAKE +$AUTOCONF +cd .. + +# For debugging. +$FGREP 'distcheck-hook' Makefile.in subpkg/Makefile.in + +$FGREP 'distcheck-hook' subpkg/Makefile.in && Exit 1 +$FGREP '$(MAKE) $(AM_MAKEFLAGS) distcheck-hook' Makefile.in +grep '^distcheck-hook:' Makefile.in + +./configure + +$MAKE +$MAKE check && Exit 1 +cd subpkg +$MAKE check +cd .. +$MAKE distcheck + +: =2D-=20 1.7.2.3 --Boundary-00=_Ulj8N/NkkpuPxwg Content-Type: text/x-patch; charset="utf-8"; name="0002-maintcheck-DISTCHECK_CONFIGURE_FLAGS-can-be-defined-.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="0002-maintcheck-DISTCHECK_CONFIGURE_FLAGS-can-be-defined-.patch" =46rom f84f54f530c8aa0fd3dcd7a31506eef169958a0a Mon Sep 17 00:00:00 2001 Message-Id: In-Reply-To: <976003923e43d17985a776f82cf8168e8741f7de.1307718833.git.stefa= no.lattarini@gmail.com> References: <976003923e43d17985a776f82cf8168e8741f7de.1307718833.git.stefan= o.lattarini@gmail.com> =46rom: Stefano Lattarini Date: Fri, 10 Jun 2011 17:13:17 +0200 Subject: [PATCH 2/2] maintcheck: DISTCHECK_CONFIGURE_FLAGS can be defined o= n make cmdline * Makefile.am (sc_tests_overriding_macros_on_cmdline): It's now acceptable that the test scripts override DISTCHECK_CONFIGURE_FLAGS on the make command line. Update comments accordingly. Since we are at it, make the relevant grepping rules slightly tighter. =2D-- ChangeLog | 8 ++++++++ Makefile.am | 17 ++++++++++++----- Makefile.in | 8 ++++++-- 3 files changed, 26 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index 1a11eb2..6d8233e 100644 =2D-- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,13 @@ 2011-06-10 Stefano Lattarini =20 + maintcheck: DISTCHECK_CONFIGURE_FLAGS can be defined on make cmdline + * Makefile.am (sc_tests_overriding_macros_on_cmdline): It's now + acceptable that the test scripts override DISTCHECK_CONFIGURE_FLAGS + on the make command line. Update comments accordingly. Since we + are at it, make the relevant grepping rules slightly tighter. + +2011-06-10 Stefano Lattarini + distcheck: add support for AM_DISTCHECK_CONFIGURE_FLAGS * doc/automake.texi (Checking the Distribution): Suggest to use AM_DISTCHECK_CONFIGURE_FLAGS, not DISTCHECK_CONFIGURE_FLAGS, to diff --git a/Makefile.am b/Makefile.am index f0cc95e..b25a30a 100644 =2D-- a/Makefile.am +++ b/Makefile.am @@ -442,17 +442,24 @@ sc_tests_required_after_defs: done =20 ## Overriding a Makefile macro on the command line is not portable when =2D## recursive targets are used. Better use an envvar. SHELL is an excep= tion, =2D## POSIX says it can't come from the environment. V and DESTDIRS are ex= ceptions, =2D## too, as package authors are urged not to initialize them anywhere. +## recursive targets are used. Better use an envvar. SHELL is an +## exception, POSIX says it can't come from the environment. DESTDIR and +## DISTCHECK_CONFIGURE_FLAGS and V are exceptions, too, as package authors +## are urged not to initialize them anywhere. sc_tests_overriding_macros_on_cmdline: @if grep -E '\$$MAKE .*(SHELL=3D.*=3D|=3D.*SHELL=3D)' $(srcdir)/tests/*.t= est; then \ echo 'Rewrite "$$MAKE foo=3Dbar SHELL=3D$$SHELL" as "foo=3Dbar $$MAKE -= e SHELL=3D$$SHELL"' 1>&2; \ echo ' in the above lines, it is more portable.' 1>&2; \ exit 1; \ fi =2D @if sed 's/DESTDIR=3D[^ ]*//; s/SHELL=3D[^ ]*//; s/V=3D[^ ]*//' $(srcdi= r)/tests/*.test | \ =2D grep '\$$MAKE .*=3D' ; then \ + @if sed -e 's/ DESTDIR=3D[^ ]*/ /' -e 's/ SHELL=3D[^ ]*/ /' \ + -e 's/ V=3D[^ ]*/ /' -e 's///' \ +## DISTCHECK_CONFIGURE_FLAGS is allowed to contain whitespace in its +## definition, so the more complex substitutions below. + -e "s/ DISTCHECK_CONFIGURE_FLAGS=3D'[^']*'/ /" \ + -e 's/ DISTCHECK_CONFIGURE_FLAGS=3D"[^"]*"/ /' \ + -e 's/ DISTCHECK_CONFIGURE_FLAGS=3D[^ ]/ /' \ + $(srcdir)/tests/*.test | grep '\$$MAKE .*=3D'; then \ echo 'Rewrite "$$MAKE foo=3Dbar" as "foo=3Dbar $$MAKE -e" in the above = lines,' 1>&2; \ echo 'it is more portable.' 1>&2; \ exit 1; \ diff --git a/Makefile.in b/Makefile.in index d6743e4..6539f3c 100644 =2D-- a/Makefile.in +++ b/Makefile.in @@ -1141,8 +1141,12 @@ sc_tests_overriding_macros_on_cmdline: echo ' in the above lines, it is more portable.' 1>&2; \ exit 1; \ fi =2D @if sed 's/DESTDIR=3D[^ ]*//; s/SHELL=3D[^ ]*//; s/V=3D[^ ]*//' $(srcdi= r)/tests/*.test | \ =2D grep '\$$MAKE .*=3D' ; then \ + @if sed -e 's/ DESTDIR=3D[^ ]*/ /' -e 's/ SHELL=3D[^ ]*/ /' \ + -e 's/ V=3D[^ ]*/ /' -e 's///' \ + -e "s/ DISTCHECK_CONFIGURE_FLAGS=3D'[^']*'/ /" \ + -e 's/ DISTCHECK_CONFIGURE_FLAGS=3D"[^"]*"/ /' \ + -e 's/ DISTCHECK_CONFIGURE_FLAGS=3D[^ ]/ /' \ + $(srcdir)/tests/*.test | grep '\$$MAKE .*=3D'; then \ echo 'Rewrite "$$MAKE foo=3Dbar" as "foo=3Dbar $$MAKE -e" in the above = lines,' 1>&2; \ echo 'it is more portable.' 1>&2; \ exit 1; \ =2D-=20 1.7.2.3 --Boundary-00=_Ulj8N/NkkpuPxwg-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 11 07:01:51 2011 Received: (at control) by debbugs.gnu.org; 11 Jun 2011 11:01:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QVLwt-0007QB-IN for submit@debbugs.gnu.org; Sat, 11 Jun 2011 07:01:51 -0400 Received: from mail-ww0-f46.google.com ([74.125.82.46]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QVLwr-0007Q0-5V for control@debbugs.gnu.org; Sat, 11 Jun 2011 07:01:49 -0400 Received: by wwb28 with SMTP id 28so3321290wwb.15 for ; Sat, 11 Jun 2011 04:01:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:mime-version :content-type:content-transfer-encoding:message-id; bh=KsB4XifUKIvmSfpt0jfF80Fn5+BTnjiT6YcuI0nGrCY=; b=TDot3lJTj+NYhqwQyghMaa/9KHRj+fCx6qjv4lKkF/mBKgoY/Y4M6p5m8qPPJtoshT AeK9DxSChDH/yReyXhEVmlPdxTfvUV1I1T3rK75wHqmdo5sMQ+/M5E5OojpnGlBk9wwR tOi++uLegnIdEZZqoeXON3rku3zYnrnlkgVEg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:mime-version:content-type :content-transfer-encoding:message-id; b=bCXudv9/P+VwQg0l+JwtfomnQjor6USbBuaq5Ex+uILZx+wKnlEFkyMCivESOZduOJ S3TWETCXwCMLo4S7dk8qQ0dE6clNAVyLKHxghFY/pXPOuaE0ekPij5hPeolfH4Z35yG5 Ko5ksmY2nrkF68Vl8xL18Sbq3RixCWXlETQLM= Received: by 10.216.64.145 with SMTP id c17mr3102421wed.56.1307790103221; Sat, 11 Jun 2011 04:01:43 -0700 (PDT) Received: from bigio.localnet (host17-92-dynamic.4-87-r.retail.telecomitalia.it [87.4.92.17]) by mx.google.com with ESMTPS id z66sm1850323weq.24.2011.06.11.04.01.40 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 11 Jun 2011 04:01:41 -0700 (PDT) From: Stefano Lattarini To: control@debbugs.gnu.org Subject: automake bug#8784 has a patch Date: Sat, 11 Jun 2011 13:01:31 +0200 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201106111301.32143.stefano.lattarini@gmail.com> X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) tags 8784 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 13 14:34:02 2011 Received: (at 8784-done) by debbugs.gnu.org; 13 Jun 2011 18:34:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QWBxa-0001LS-6H for submit@debbugs.gnu.org; Mon, 13 Jun 2011 14:34:02 -0400 Received: from mail-wy0-f172.google.com ([74.125.82.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QWBxX-0001L9-W1 for 8784-done@debbugs.gnu.org; Mon, 13 Jun 2011 14:34:00 -0400 Received: by wyb29 with SMTP id 29so3669255wyb.3 for <8784-done@debbugs.gnu.org>; Mon, 13 Jun 2011 11:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; bh=SCBPd+Wm8Kwt6NSO7inG5C9rDGyo8alqPMM0LfxwJj4=; b=mbfhPElPoK7aKn5z8N2PoTO2BThbPJNa2Kb+8YmkcYapi+gT7WE/0lplrNeUZJOq7I QzGi6QM33ERfJ1UtInWji8etkj/Ars5RtpO2GgayZdKrAh9H7gwegl1Dq8l+27gpC1QC gS/Tz2UTeufmclZpLGe5AGVu136DA2iBMFrV4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; b=IgG5vMIScVKc7Qcw0VAMXxr9ywfFEIIaM4iga1q07ctvlX8+BxGkwvB15umWFpUEBH VjITxtYm6cDB1Jyf7mS2zuak3nZ5zf/cjuWIVL4ghwdSkV0w4QptJOWSmL40wIU5Owxy YYFu+HYdo6NT66in1omCTdjBCMhPncwUprr84= Received: by 10.216.229.3 with SMTP id g3mr2963921weq.91.1307990032536; Mon, 13 Jun 2011 11:33:52 -0700 (PDT) Received: from bigio.localnet (host24-93-dynamic.7-79-r.retail.telecomitalia.it [79.7.93.24]) by mx.google.com with ESMTPS id h22sm3070719wes.8.2011.06.13.11.33.50 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 13 Jun 2011 11:33:51 -0700 (PDT) From: Stefano Lattarini To: automake-patches@gnu.org Subject: Re: [PATCH] {maint} distcheck: add support for AM_DISTCHECK_CONFIGURE_FLAGS (was: Re: bug#8784: Support developer-reserved AM_DISTCHECK_CONFIGURE_FLAGS) Date: Mon, 13 Jun 2011 20:33:39 +0200 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: <201106021208.20631.stefano.lattarini@gmail.com> <201106101733.40520.stefano.lattarini@gmail.com> In-Reply-To: <201106101733.40520.stefano.lattarini@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201106132033.40565.stefano.lattarini@gmail.com> X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: 8784-done Cc: 8784-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.8 (---) On Friday 10 June 2011, Stefano Lattarini wrote: > Reference: > > > On Thursday 02 June 2011, Stefano Lattarini wrote: > > Severity: wishlist > > > > Hello automakers. > > > > Continuing with the good trend of avoiding to impinge on the user > > namespace, we should start supporting AM_DISTCHECK_CONFIGURE_FLAGS > > in addition to DISTCHECK_CONFIGURE_FLAGS, so that the former can be > > reserved for the developer to be set in the 'Makefile.am's, and the > > latter left for the user, packager or tester to use freely. > > > > Sorry for the curtness of this message, but it is thought more as > > a "note to self" than a bug report proper. > > > > Regards, > > Stefano > > > > > Implemented in the first one of the attached patches. The second patch > is a follow-up updating the "maintainer-check" rules accordingly. > > OK for maint? This should be quite uncontroversial, so I'll push in 72 > hours if there is no review by then. > > Regards, > Stefano > I've pushed these patches to maint now. Regards, Stefano From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 14 17:24:37 2011 Received: (at 8784) by debbugs.gnu.org; 14 Jun 2011 21:24:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QWb6C-0007Pz-Dx for submit@debbugs.gnu.org; Tue, 14 Jun 2011 17:24:36 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1QWb67-0007Ph-EH for 8784@debbugs.gnu.org; Tue, 14 Jun 2011 17:24:35 -0400 Received: (qmail 16629 invoked by uid 0); 14 Jun 2011 21:24:25 -0000 Received: from 77.58.247.232 by www025.gmx.net with HTTP; Tue, 14 Jun 2011 23:24:22 +0200 (CEST) Content-Type: text/plain; charset="utf-8" Date: Tue, 14 Jun 2011 23:24:22 +0200 From: "Ralf Wildenhues" In-Reply-To: <201106101733.40520.stefano.lattarini@gmail.com> Message-ID: <20110614212422.76800@gmx.net> MIME-Version: 1.0 References: <201106021208.20631.stefano.lattarini@gmail.com> <201106101733.40520.stefano.lattarini@gmail.com> Subject: Re: [PATCH] {maint} distcheck: add support for AM_DISTCHECK_CONFIGURE_FLAGS To: Stefano Lattarini X-Authenticated: #13673931 X-Flags: 0001 X-Mailer: WWW-Mail 6100 (Global Message Exchange) X-Mutt-Fcc: ~/Mail/outbox X-Mutt-References: <201106101733.40520.stefano.lattarini@gmail.com> X-Priority: 3 X-Provags-ID: V01U2FsdGVkX1+HX/V/nbOHExKgIGu85bVyMBswil1HyZADRaZscx 8zzsYN1EAcHhcEK0Ib6JMkyfI6KfB2hoe1Wg== Content-Transfer-Encoding: 8bit X-GMX-UID: v+bEeUJsf2IsZZzMvGxogCB4dWxlc1ZK X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8784 Cc: 8784@debbugs.gnu.org, automake-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) * Stefano Lattarini wrote on Fri, Jun 10, 2011 at 05:33:39PM CEST: > > On Thursday 02 June 2011, Stefano Lattarini wrote: > > Continuing with the good trend of avoiding to impinge on the user > > namespace, we should start supporting AM_DISTCHECK_CONFIGURE_FLAGS > > in addition to DISTCHECK_CONFIGURE_FLAGS, so that the former can be > > reserved for the developer to be set in the 'Makefile.am's, and the > > latter left for the user, packager or tester to use freely. Sure, but: the previous lack of AM_DISTCHECK_CONFIGURE_FLAGS was due to the motivation that developers should make their code buildable without any special configure options. I would suggest to at least discourage using this in the documentation. Other than that, the patch looks OK to me, thanks. Cheers, Ralf From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 15 03:40:30 2011 Received: (at 8784) by debbugs.gnu.org; 15 Jun 2011 07:40:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QWkiD-000430-L1 for submit@debbugs.gnu.org; Wed, 15 Jun 2011 03:40:30 -0400 Received: from mail-wy0-f172.google.com ([74.125.82.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QWkiB-00042o-JI for 8784@debbugs.gnu.org; Wed, 15 Jun 2011 03:40:28 -0400 Received: by wyb29 with SMTP id 29so101593wyb.3 for <8784@debbugs.gnu.org>; Wed, 15 Jun 2011 00:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; bh=PvYBij2VYYoxxWCO2R8huir0w1iu2oeCV6tuiSjXFa0=; b=p2cNwG1jFAG6HEZMxs2qGxtLb9XDxXFymS9sDMOvL7dx4SkJNTDBxlL3sFvMAxOa/4 SQHnMu7K2NU4zZouYwMTZ0PNBXKUYOsR9wDoEnbpokYdba4pou6LyLdbhwM8kqjgwyWb Gpkjn4qOGkWeyFNoZAAyljfyWnjqQzMcPl4Wo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; b=oUsGcNxa5Yr7U9PpXjnxf2EJk4fnHE7ysq+ihMuvZCHEX1ljXUKH0rNJ1SV+kQJCOI MJZnGD9hM7AKMXWj2uUFddyYxg2DIgDptkWiqQN0LvX5ks9oclz7L5Dd0RncGZiCWgnG 1CANk1AwJLvgIvAaYYxQuCGAjof5DzZoy6sZk= Received: by 10.227.177.12 with SMTP id bg12mr205281wbb.59.1308123621656; Wed, 15 Jun 2011 00:40:21 -0700 (PDT) Received: from bigio.localnet (host251-31-dynamic.56-82-r.retail.telecomitalia.it [82.56.31.251]) by mx.google.com with ESMTPS id o38sm128882wba.20.2011.06.15.00.40.19 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 15 Jun 2011 00:40:20 -0700 (PDT) From: Stefano Lattarini To: "Ralf Wildenhues" Subject: Re: [PATCH] {maint} distcheck: add support for AM_DISTCHECK_CONFIGURE_FLAGS Date: Wed, 15 Jun 2011 09:40:07 +0200 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: <201106021208.20631.stefano.lattarini@gmail.com> <201106101733.40520.stefano.lattarini@gmail.com> <20110614212422.76800@gmx.net> In-Reply-To: <20110614212422.76800@gmx.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201106150940.08042.stefano.lattarini@gmail.com> X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: 8784 Cc: 8784@debbugs.gnu.org, automake-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) On Tuesday 14 June 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Fri, Jun 10, 2011 at 05:33:39PM CEST: > > > > On Thursday 02 June 2011, Stefano Lattarini wrote: > > > Continuing with the good trend of avoiding to impinge on the user > > > namespace, we should start supporting AM_DISTCHECK_CONFIGURE_FLAGS > > > in addition to DISTCHECK_CONFIGURE_FLAGS, so that the former can be > > > reserved for the developer to be set in the 'Makefile.am's, and the > > > latter left for the user, packager or tester to use freely. > > Sure, but: the previous lack of AM_DISTCHECK_CONFIGURE_FLAGS was due to > the motivation that developers should make their code buildable > without any special configure options. > Sure, but: the documentation wasn't aligned with this positions, as it suggested to define DISTCHECK_CONFIGURE_FLAGS in Makefile.am without giving any warning :-). However ... > I would suggest to at least discourage using this in the documentation. > ... I agree, and I will make the change soon. Maybe I can find a couple of examples of where the AM_DISTCHECK_CONFIGURE_FLAGS could be useful *and* legitimate; which would make my change more meaningful. > Other than that, the patch looks OK to me, thanks. > > Cheers, > Ralf > Thanks, Stefano From unknown Thu Sep 25 07:59:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 13 Jul 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator