GNU bug report logs - #8744
23.3.50; rcirc prints gibberish

Previous Next

Full log

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#8744: 23.3.50; rcirc prints gibberish
Date: Sun, 29 May 2011 22:26:22 +0800

On 2011-05-29 22:04 +0800, Leo wrote:
> The culprit is this line in rcirc-print:
>
>   ;; only decode text from other senders, not ours
>   (setq text (decode-coding-string text rcirc-decode-coding-system))
>
> Any idea why not also decode message to ourselves?

OK, found the reason. Will install the following patch soonish.

commit 0cd01fb856ec13223446cb77adf65a6b9867a455 (HEAD, refs/heads/leo-lisp-reader)
Date:   Sun May 29 22:17:23 2011 +0800

    Fix decoding issue for text to self in rcirc.el (#8744)
    
    Decoding is required due to change on 2006-04-08 by Eli Zaretskii.
---
 lisp/net/rcirc.el |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

	Modified lisp/net/rcirc.el
diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
index cbcac886..8fb5a98a 100644
--- a/lisp/net/rcirc.el
+++ b/lisp/net/rcirc.el
@@ -1428,9 +1428,8 @@ (defun rcirc-print (process sender response target text &optional activity)
 	      (old-point (point-marker))
 	      (fill-start (marker-position rcirc-prompt-start-marker)))
 
+	  (setq text (decode-coding-string text rcirc-decode-coding-system))
 	  (unless (string= sender (rcirc-nick process))
-	    ;; only decode text from other senders, not ours
-	    (setq text (decode-coding-string text rcirc-decode-coding-system))
 	    ;; mark the line with overlay arrow
 	    (unless (or (marker-position overlay-arrow-position)
 			(get-buffer-window (current-buffer))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.